Modified OColorButton to pass color to color dialog. Impacts appearance, launcher settings and liquid settings.

5 files changed, 61 insertions, 64 deletions

diff --git a/core/settings/launcher/tabdialog.cpp b/core/settings/launcher/tabdialog.cpp
index 5981d0b..4c9942f 100644
--- a/core/settings/launcher/tabdialog.cpp
+++ b/core/settings/launcher/tabdialog.cpp
@@ -105,3 +105,3 @@ public:
 		viewport ( )-> setUpdatesEnabled ( false );
-		
+
 		switch ( m ) {
@@ -184,3 +184,3 @@ public:
 	}
-	
+
 	void setItemTextPos ( ItemTextPos pos )
@@ -245,3 +245,3 @@ public:
 	}
-	
+
 	void drawBackground ( QPainter *p, const QRect &r )
@@ -265,3 +265,3 @@ private:
 
-TabDialog::TabDialog ( const QPixmap *tabicon, const QString &tabname, TabConfig &tc, QWidget *parent, const char *dname, bool modal, WFlags fl ) 
+TabDialog::TabDialog ( const QPixmap *tabicon, const QString &tabname, TabConfig &tc, QWidget *parent, const char *dname, bool modal, WFlags fl )
 	: QDialog ( parent, dname, modal, fl | WStyle_ContextHelp ), m_tc ( tc )
@@ -269,31 +269,31 @@ TabDialog::TabDialog ( const QPixmap *tabicon, const QString &tabname, TabConfig
 	setCaption ( tr( "Edit Tab" ));
-	
+
 	QVBoxLayout *lay = new QVBoxLayout ( this, 3, 3 );
-	
+
 	OTabWidget *tw = new OTabWidget ( this, "tabwidget", OTabWidget::Global, OTabWidget::Bottom );
 	QWidget *bgtab;
-	       
+
 	tw-> addTab ( bgtab = createBgTab ( tw ), "appearance/backgroundtabicon.png", tr( "Background" ));
 	tw-> addTab ( createFontTab ( tw ), "appearance/fonttabicon.png", tr( "Font" ));
-	tw-> addTab ( createIconTab ( tw ), "appearance/colorstabicon.png", tr( "Icons" ) );	                           
-	
-	tw-> setCurrentTab ( bgtab );                                       
-	
-	QWidget *sample = new QVBox ( this );	
+	tw-> addTab ( createIconTab ( tw ), "appearance/colorstabicon.png", tr( "Icons" ) );
+
+	tw-> setCurrentTab ( bgtab );
+
+	QWidget *sample = new QVBox ( this );
 	QTabBar *tb = new QTabBar ( sample );
 	QString name ( tr( "Previewing %1" ). arg ( tabname ));
-	
+
 	tb-> addTab ( tabicon ? new QTab ( *tabicon, name ) : new QTab ( name ));
-	
+
 	m_sample = new SampleView ( sample );
-			
+
 	lay-> addWidget ( tw, 10 );
 	lay-> addWidget ( sample, 1 );
-	
+
 	m_iconsize-> setButton ( tc. m_view );
 	iconSizeClicked ( tc. m_view );
-	m_iconcolor-> setColor ( QColor ( m_tc. m_text_color ));
+	//m_iconcolor-> setColor ( QColor ( m_tc. m_text_color ));
 	iconColorClicked ( m_iconcolor-> color ( ));
 	m_bgtype-> setButton ( tc. m_bg_type );
-	m_solidcolor-> setColor ( QColor ( tc. m_bg_color ));
+	//m_solidcolor-> setColor ( QColor ( tc. m_bg_color ));
 	m_bgimage = tc. m_bg_image;
@@ -321,5 +321,5 @@ QWidget *TabDialog::createFontTab ( QWidget *parent )
 
-    m_fontselect = new OFontSelector ( false, tab, "fontsel" );    
+    m_fontselect = new OFontSelector ( false, tab, "fontsel" );
     vertLayout-> addWidget ( m_fontselect );
-    
+
 	connect ( m_fontuse, SIGNAL( toggled ( bool )), m_fontselect, SLOT( setEnabled ( bool )));
@@ -328,3 +328,3 @@ QWidget *TabDialog::createFontTab ( QWidget *parent )
 
-    return tab; 
+    return tab;
 }
@@ -335,3 +335,3 @@ QWidget *TabDialog::createBgTab ( QWidget *parent )
     QVBoxLayout *vertLayout = new QVBoxLayout( tab, 3, 3 );
-        
+
     QGridLayout* gridLayout = new QGridLayout ( vertLayout );
@@ -354,7 +354,7 @@ QWidget *TabDialog::createBgTab ( QWidget *parent )
     rb = new QRadioButton( tr( "Solid color" ), tab, "solid" );
-    m_bgtype-> insert ( rb, TabConfig::SolidColor ); 
+    m_bgtype-> insert ( rb, TabConfig::SolidColor );
     hb-> addWidget ( rb );
 	hb-> addSpacing ( 10 );
-    
-	m_solidcolor = new OColorButton ( tab );
+
+	m_solidcolor = new OColorButton ( tab, QColor ( m_tc. m_bg_color ) );
 	connect ( m_solidcolor, SIGNAL( colorSelected ( const QColor & )), this, SLOT( bgColorClicked ( const QColor & )));
@@ -367,3 +367,3 @@ QWidget *TabDialog::createBgTab ( QWidget *parent )
 	hb-> setSpacing ( 3 );
-	
+
 	rb = new QRadioButton( tr( "Image" ), tab, "image" );
@@ -372,3 +372,3 @@ QWidget *TabDialog::createBgTab ( QWidget *parent )
     hb-> addSpacing ( 10 );
-    
+
 	m_imagebrowse = new QPushButton ( tr( "Select..." ), tab );
@@ -409,3 +409,3 @@ QWidget *TabDialog::createIconTab ( QWidget *parent )
     gridLayout-> addWidget( rb, 0, 1 );
-    
+
     rb = new QRadioButton( tr( "Large" ), tab, "iconlarge" );
@@ -420,9 +420,9 @@ QWidget *TabDialog::createIconTab ( QWidget *parent )
 	gridLayout-> addRowSpacing ( 2, 8 );
-	
+
 	label = new QLabel ( tr( "Color:" ), tab );
 	gridLayout-> addWidget ( label, 3, 0 );
-	
-	m_iconcolor = new OColorButton ( tab );
+
+	m_iconcolor = new OColorButton ( tab, QColor ( m_tc. m_text_color ) );
 	connect ( m_iconcolor, SIGNAL( colorSelected ( const QColor & )), this, SLOT( iconColorClicked ( const QColor & )));
-	gridLayout-> addWidget ( m_iconcolor, 3, 1, AlignLeft );        	
+	gridLayout-> addWidget ( m_iconcolor, 3, 1, AlignLeft );
 
diff --git a/libopie/ocolorbutton.cpp b/libopie/ocolorbutton.cpp
index 4734c0c..ddb6c4f 100644
--- a/libopie/ocolorbutton.cpp
+++ b/libopie/ocolorbutton.cpp
@@ -33,5 +33,5 @@
 #include <qimage.h>
-	
-#include <qpe/resource.h>	
-	
+
+#include <qpe/resource.h>
+
 class OColorButtonPrivate {
@@ -42,3 +42,3 @@ public:
 
-OColorButton::OColorButton ( QWidget *parent, const char *name ) 
+OColorButton::OColorButton ( QWidget *parent, const QColor &color, const char *name )
 	: QPushButton ( parent, name )
@@ -46,4 +46,4 @@ OColorButton::OColorButton ( QWidget *parent, const char *name )
 	d = new OColorButtonPrivate;
-	
-	d-> m_menu = new ColorPopupMenu ( black, 0, 0 );
+
+	d-> m_menu = new ColorPopupMenu ( color, 0, 0 );
 	setPopup ( d-> m_menu );
@@ -51,8 +51,8 @@ OColorButton::OColorButton ( QWidget *parent, const char *name )
 	connect ( d-> m_menu, SIGNAL( colorSelected ( const QColor & )), this, SLOT( updateColor ( const QColor & )));
-	
-	updateColor ( black );
-	
+
+	updateColor ( color );
+
 	QSize s = sizeHint ( ) + QSize ( 12, 0 );
 	setMinimumSize ( s );
-	setMaximumSize ( s. width ( ) * 2, s. height ( )); 
+	setMaximumSize ( s. width ( ) * 2, s. height ( ));
 }
diff --git a/libopie/ocolorbutton.h b/libopie/ocolorbutton.h
index ec04833..fe40fae 100644
--- a/libopie/ocolorbutton.h
+++ b/libopie/ocolorbutton.h
@@ -29,4 +29,4 @@
 #ifndef __OPIE_OCOLORBUTTON_H__
-#define __OPIE_OCOLORBUTTON_H__	
-	
+#define __OPIE_OCOLORBUTTON_H__
+
 #include <qpushbutton.h>
@@ -39,10 +39,10 @@ class OColorButton : public QPushButton {
 public:
-	OColorButton ( QWidget *parent = 0, const char *name = 0 );
+	OColorButton ( QWidget *parent = 0, const QColor & = black, const char *name = 0 );
 	virtual ~OColorButton ( );
-	
+
 	QColor color ( ) const;
-	
+
 signals:
-	void colorSelected ( const QColor & );	
-	
+	void colorSelected ( const QColor & );
+
 public slots:
diff --git a/noncore/settings/appearance2/editScheme.cpp b/noncore/settings/appearance2/editScheme.cpp
index c2e5355..eefeccc 100644
--- a/noncore/settings/appearance2/editScheme.cpp
+++ b/noncore/settings/appearance2/editScheme.cpp
@@ -48,3 +48,3 @@ EditScheme::EditScheme ( int cnt, const QString *labels, QColor *colors, QWidget
     m_colors = colors;
-        
+
     for ( int i = 0; i < cnt; i++ )
@@ -53,5 +53,4 @@ EditScheme::EditScheme ( int cnt, const QString *labels, QColor *colors, QWidget
         layout-> addWidget ( l, i, 0 );
-        
-        m_buttons [i] = new OColorButton ( this );
-        m_buttons [i]-> setColor ( colors [i] );
+
+        m_buttons [i] = new OColorButton ( this, colors [i] );
         layout-> addWidget ( m_buttons [i], i, 1 );
diff --git a/noncore/styles/liquid/liquidset.cpp b/noncore/styles/liquid/liquidset.cpp
index 255456c..7747da7 100644
--- a/noncore/styles/liquid/liquidset.cpp
+++ b/noncore/styles/liquid/liquidset.cpp
@@ -44,3 +44,3 @@ LiquidSettings::LiquidSettings ( QWidget* parent, const char *name, WFlags fl )
 	setCaption ( tr( "Liquid Style" ) );
-	
+
 	Config config ( "qpe" );
@@ -67,7 +67,7 @@ LiquidSettings::LiquidSettings ( QWidget* parent, const char *name, WFlags fl )
 	cb-> insertItem ( tr( "Custom translucency" ), Custom );
-	
+
 	cb-> setCurrentItem ( m_type );
 	vbox-> addWidget ( cb );
-	
-	
+
+
 	QGridLayout *grid = new QGridLayout ( vbox );
@@ -75,3 +75,3 @@ LiquidSettings::LiquidSettings ( QWidget* parent, const char *name, WFlags fl )
 	grid-> addColSpacing ( 3, 8 );
-	
+
 	grid-> addWidget ( m_menulbl = new QLabel ( tr( "Menu color" ), this ), 0, 1 );
@@ -80,8 +80,6 @@ LiquidSettings::LiquidSettings ( QWidget* parent, const char *name, WFlags fl )
 
-	m_menubtn = new OColorButton ( this );
-	m_menubtn-> setColor ( mcol );
+	m_menubtn = new OColorButton ( this, mcol );
 	grid-> addWidget ( m_menubtn, 0, 2 );
 
-	m_textbtn = new OColorButton ( this );
-	m_textbtn-> setColor ( tcol );
+	m_textbtn = new OColorButton ( this, tcol );
 	grid-> addWidget ( m_textbtn, 0, 5 );
@@ -94,5 +92,5 @@ LiquidSettings::LiquidSettings ( QWidget* parent, const char *name, WFlags fl )
 	grid-> addMultiCellWidget ( m_opacsld, 1, 1, 2, 5 );
-	
+
 	vbox-> addSpacing ( 4 );
-	
+
 	QCheckBox *shadow = new QCheckBox ( tr( "Use shadowed menu text" ), this );