summaryrefslogtreecommitdiff
authoreilers <eilers>2004-10-25 10:02:52 (UTC)
committer eilers <eilers>2004-10-25 10:02:52 (UTC)
commitaf0556afccb9df439bd826bb6028e05560d2910a (patch) (side-by-side diff)
tree39a8f735e0d8d13da9c073e0407bae8431dbf138
parented6b09bab91bf21d33ebef1ea49fdb049e10453b (diff)
downloadopie-af0556afccb9df439bd826bb6028e05560d2910a.zip
opie-af0556afccb9df439bd826bb6028e05560d2910a.tar.gz
opie-af0556afccb9df439bd826bb6028e05560d2910a.tar.bz2
Fixing some problems..
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--noncore/tools/pimconverter/converter.cpp98
-rwxr-xr-xnoncore/tools/pimconverter/converter.h2
2 files changed, 54 insertions, 46 deletions
diff --git a/noncore/tools/pimconverter/converter.cpp b/noncore/tools/pimconverter/converter.cpp
index fa3e714..e8bd475 100644
--- a/noncore/tools/pimconverter/converter.cpp
+++ b/noncore/tools/pimconverter/converter.cpp
@@ -76,3 +76,3 @@ void Converter::start_conversion(){
sourceDB = OPimAccessFactory<OPimContactAccess>::create( OPimGlobal::CONTACTLIST, OPimGlobal::XML, "converter" );
- }
+ }
break;
@@ -229,7 +229,14 @@ void Converter::closeEvent( QCloseEvent *e )
-bool Converter::sqliteCopyAndConvert(const QString& src, const QString &dest, QString &cmd)
+bool Converter::sqliteMoveAndConvert( const QString& name, const QString& src, const QString &dest )
{
+
+ QMessageBox::information( this, tr( "Pim-Converter" ),
+ tr( "<qt>Starting to convert the database for %1</qt>" ).arg( name ) );
+
+
+ bool error = false;
+ QString cmd;
if (!QFile::exists( src ) ) {
- cmd = tr("No SQLite2 database exists");
- return false;
+ cmd = tr( "No SQLite2 database could be found!" );
+ error = true;
}
@@ -237,19 +244,23 @@ bool Converter::sqliteCopyAndConvert(const QString& src, const QString &dest, QS
if( QFile::exists( dest ) ) {
- cmd = tr("A copy of the SQLite2 exists");
- return false;
+ cmd = tr( "The database is already converted!" );
+ error = true;
}
- /*
- * Copy it over
- */
- cmd = "cp " + Global::shellQuote(src) + " " + Global::shellQuote(dest);
- if( ::system( cmd ) != 0 )
- return false;
+
+ if ( error ){
+ QMessageBox::critical( this, tr("Pim-Converter"),
+ tr("<qt>Conversion not possible: \n"
+ "Problem: %1</qt>").arg(cmd) );
+ return error;
+ }
+
/*
- * Delete it to make place for the new file
+ * Move it over
*/
- cmd = "rm " + Global::shellQuote(src);
- if( ::system( cmd ) != 0 )
- return false;
+ cmd = "mv " + Global::shellQuote(src) + " " + Global::shellQuote(dest);
+ if( ::system( cmd ) != 0 ){
+ error = true;
+ }
+
@@ -258,4 +269,16 @@ bool Converter::sqliteCopyAndConvert(const QString& src, const QString &dest, QS
*/
- cmd = "sqlite " + Global::shellQuote(dest) + " .dump | sqlite3 " + Global::shellQuote(src);
- return ::system( cmd ) == 0;
+ if ( !error ){
+ cmd = "sqlite " + Global::shellQuote(dest) + " .dump | sqlite3 " + Global::shellQuote(src);
+ if ( ::system( cmd ) != 0 ){
+ error = true;
+ }
+ }
+
+ if ( error ){
+ QMessageBox::critical( this, tr("Pim-Converter"),
+ tr("<qt>An internal error occurred: "
+ "Converting the database was impossible! "
+ "Command: '%1' </qt>").arg(cmd) );
+
+ }
}
@@ -297,13 +320,8 @@ void Converter::start_upgrade()
- QString src, dest, cmd;
+ QString src, dest;
+ bool error = false;
+
src = Global::applicationFileName("addressbook", "addressbook.db" );
dest = Global::applicationFileName("addressbook", "addressbook.db_v2" );
-
- if(!sqliteCopyAndConvert(src, dest, cmd)) {
- QMessageBox::critical( this, tr("Pim-Converter"),
- tr("<qt>An internal error occurred: "
- "Converting the addressbook command was impossible! "
- "Executed the following command: %1</qt>").arg(cmd) );
- return;
- }
+ error = sqliteMoveAndConvert( "Addressbook", src, dest );
@@ -311,10 +329,4 @@ void Converter::start_upgrade()
dest = Global::applicationFileName("datebook", "datebook.db_v2" );
- if(!sqliteCopyAndConvert(src, dest, cmd)) {
- QMessageBox::critical( this, tr("Pim-Converter"),
- tr("<qt>An internal error occurred: "
- "Converting the datebook command was impossible! "
- "Executed the following command: '%1' </qt>").arg(cmd)
- );
- return;
- }
+ error = sqliteMoveAndConvert( "Datebook", src, dest );
+
@@ -322,13 +334,9 @@ void Converter::start_upgrade()
dest = Global::applicationFileName("todolist", "todolist.db_v2" );
- if(!sqliteCopyAndConvert(src, dest, cmd)) {
- QMessageBox::critical( this, tr("Pim-Converter"),
- tr("<qt>An internal error occurred: "
- "Converting the todolist command was impossible! "
- "Executed the following command: '%1' </qt>").arg(cmd) );
- return;
- }
+ error = sqliteMoveAndConvert( "TodoList", src, dest );
- QMessageBox::information( this, tr("Pim-Converter"),
- tr("Conversion is finished!"),
- QMessageBox::Ok );
+ if ( !error ){
+ QMessageBox::information( this, tr("Pim-Converter"),
+ tr("Conversion is finished!"),
+ QMessageBox::Ok );
+ }
}
diff --git a/noncore/tools/pimconverter/converter.h b/noncore/tools/pimconverter/converter.h
index e9035e7..cfd315c 100755
--- a/noncore/tools/pimconverter/converter.h
+++ b/noncore/tools/pimconverter/converter.h
@@ -44,3 +44,3 @@ private:
private:
- static bool sqliteCopyAndConvert( const QString &src, const QString &destination, QString &lastCommand );
+ bool sqliteMoveAndConvert( const QString& name, const QString &src, const QString &destination );
};