some cleanup regarding config:

replaced all the foo/foo_Interval configs with a single foo config (a 0
value means off)

1 files changed, 20 insertions, 66 deletions

diff --git a/core/settings/light-and-power/light.cpp b/core/settings/light-and-power/light.cpp
index bf94a21..c021ad4 100644
--- a/core/settings/light-and-power/light.cpp
+++ b/core/settings/light-and-power/light.cpp
@@ -76,29 +76,9 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
 
-    int interval;
     // battery spinboxes
-    interval = config.readNumEntry( "Interval_Dim", 20 );
-    if ( config.readNumEntry("Dim",1) == 0 ) {
-        interval_dim->setValue( 0 );
-    } else {
-        interval_dim->setValue( interval );
-    }
-
-    interval = config.readNumEntry( "Interval_LightOff", 30 );
-    if ( config.readNumEntry("LightOff",1) == 0 ) {
-        interval_lightoff->setValue( 0 );
-    } else {
-        interval_lightoff->setValue( interval );
-    }
-
-    interval = config.readNumEntry( "Interval", 60 );
-    if ( interval > 3600 ) interval /= 1000; // compatibility (was millisecs)
-
-    if ( config.readNumEntry("NoApm", 0 ) == 1 ) {
-        interval_suspend->setValue( 0 );
-    } else {
-        interval_suspend->setValue( interval );
-    }
+    interval_dim->setValue( config.readNumEntry( "Dim", 20 ));
+    interval_lightoff->setValue( config.readNumEntry( "LightOff", 30 ));
+    interval_suspend->setValue( config.readNumEntry( "Suspend", 60 ));
 
     // battery check and slider
-    LcdOffOnly->setChecked( config.readNumEntry("LcdOffOnly",0) != 0 );
+    LcdOffOnly->setChecked( config.readBoolEntry("LcdOffOnly",false));
     int maxbright = ODevice::inst ( )-> displayBrightnessResolution ( );
@@ -118,28 +98,8 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
     // ac spinboxes
-    interval = config.readNumEntry( "Interval_Dim", 20 );
-    if ( config.readNumEntry("Dim",1) == 0 ) {
-        interval_dim_ac_3->setValue( 0 );
-    } else {
-    interval_dim_ac_3->setValue( interval );
-    }
-
-    interval = config.readNumEntry( "Interval_LightOff", 30 );
-    if ( config.readNumEntry("LightOff",1) == 0 ) {
-        interval_lightoff_ac_3->setValue( 0 );
-    } else {
-        interval_lightoff_ac_3->setValue( interval );
-    }
-
-    interval = config.readNumEntry( "Interval", 60 );
-    if ( interval > 3600 ) {
-        interval /= 1000; // compatibility (was millisecs)
-    }
-    if ( config.readNumEntry("NoApm", 1) == 1 ) {
-        interval_suspend_ac_3->setValue( 0 );
-    } else {
-        interval_suspend_ac_3->setValue( interval );
-    }
+    interval_dim_ac_3->setValue( config.readNumEntry( "Dim", 20 ));
+    interval_lightoff_ac_3->setValue( config.readNumEntry( "LightOff", 30 ));
+    interval_suspend_ac_3->setValue( config.readNumEntry( "Suspend", 60 ));
 
     // ac check and slider
-    LcdOffOnly_2_3->setChecked( config.readNumEntry("LcdOffOnly",0) != 0 );
+    LcdOffOnly_2_3->setChecked( config.readBoolEntry("LcdOffOnly",false));
     int maxbright_ac = ODevice::inst ( )-> displayBrightnessResolution ( );
@@ -200,4 +160,4 @@ void LightSettings::accept()
     // bat
-    int i_dim =      ( !( interval_dim->specialValueText() == tr("never") ) ? interval_dim->value() : 0);
-    int i_lightoff = ( !( interval_lightoff->specialValueText() == tr("never") )  ? interval_lightoff->value() : 0);
+    int i_dim =      interval_dim->value();
+    int i_lightoff = interval_lightoff->value();
     int i_suspend =  interval_suspend->value();
@@ -207,4 +167,4 @@ void LightSettings::accept()
     // ac
-    int i_dim_ac =      ( !( interval_dim_ac_3->specialValueText() == tr("never") ) ? interval_dim_ac_3->value() : 0);
-    int i_lightoff_ac = ( !( interval_lightoff_ac_3->specialValueText() == tr("never") ) ? interval_lightoff_ac_3->value() : 0);
+    int i_dim_ac =      interval_dim_ac_3->value();
+    int i_lightoff_ac = interval_lightoff_ac_3->value();
     int i_suspend_ac =  interval_suspend_ac_3->value();
@@ -218,9 +178,6 @@ void LightSettings::accept()
     // bat
-    config.writeEntry( "Dim", interval_dim->specialValueText() == tr("never") );
-    config.writeEntry( "LightOff", interval_lightoff->specialValueText() == tr("never") );
-    config.writeEntry( "LcdOffOnly", (int)LcdOffOnly->isChecked() );
-    config.writeEntry( "NoAPm", interval_suspend->specialValueText() == tr("never") );
-    config.writeEntry( "Interval_Dim", interval_dim->value() );
-    config.writeEntry( "Interval_LightOff", interval_lightoff->value() );
-    config.writeEntry( "Interval", interval_suspend->value() );
+    config.writeEntry( "LcdOffOnly", LcdOffOnly->isChecked() );
+    config.writeEntry( "Dim", interval_dim->value() );
+    config.writeEntry( "LightOff", interval_lightoff->value() );
+    config.writeEntry( "Suspend", interval_suspend->value() );
     config.writeEntry( "Brightness",
@@ -230,9 +187,6 @@ void LightSettings::accept()
     config.setGroup( "AC" );
-    config.writeEntry( "Dim", interval_dim_ac_3->specialValueText() == tr("never") );
-    config.writeEntry( "LightOff", interval_lightoff_ac_3->specialValueText() == tr("never") );
-    config.writeEntry( "LcdOffOnly", (int)LcdOffOnly_2_3->isChecked() );
-    config.writeEntry( "NoAPm", interval_suspend_ac_3->specialValueText() == tr("never") );
-    config.writeEntry( "Interval_Dim", interval_dim_ac_3->value() );
-    config.writeEntry( "Interval_LightOff", interval_lightoff_ac_3->value() );
-    config.writeEntry( "Interval", interval_suspend_ac_3->value() );
+    config.writeEntry( "LcdOffOnly", LcdOffOnly_2_3->isChecked() );
+    config.writeEntry( "Dim", interval_dim_ac_3->value() );
+    config.writeEntry( "LightOff", interval_lightoff_ac_3->value() );
+    config.writeEntry( "Suspend", interval_suspend_ac_3->value() );
     config.writeEntry( "Brightness",