Fix some oddities regarding AM/PM and alarms at 00:xx in 24H mode

2 files changed, 8 insertions, 2 deletions

diff --git a/noncore/tools/clock/clock.cpp b/noncore/tools/clock/clock.cpp
index 9b9e644..a47793b 100644
--- a/noncore/tools/clock/clock.cpp
+++ b/noncore/tools/clock/clock.cpp
@@ -116,384 +116,387 @@ Clock::Clock( QWidget * parent, const char * name, WFlags f )
     set = new QPushButton ( controls );
     set->setMaximumSize(50,30);
     gl->addWidget( set, 0, 1 );
     set->setText( tr( "Start" ) );
     set->setEnabled( FALSE );
     grp->insert( set );
 
     reset = new QPushButton ( controls );
     gl->addWidget( reset, 1, 1 );
     reset->setText( tr( "Reset" ) );
     reset->setEnabled( FALSE );
     grp->insert( reset );
 
     alarmOffBtn = new QPushButton ( controls );
 //    alarmOffBtn->setMaximumSize(60,30);
     gl->addWidget( alarmOffBtn, 0, 2 );
 
     alarmBtn = new QPushButton ( controls );
       //  alarmBtn->setMaximumSize(60,30);
     gl->addWidget( alarmBtn, 1, 2 );
     alarmBtn->setText( tr( "Set Alarm" ) );
 
     OClickableLabel *click = new OClickableLabel(controls, "label" );
     click->setText(tr("Set date and time." ) );
     gl->addMultiCellWidget( click,  3,  3,  0, 2,  AlignHCenter);
     connect( click, SIGNAL(clicked() ), this, SLOT(slotAdjustTime() ) );
 
     connect( set, SIGNAL( pressed() ), SLOT( slotSet() ) );
     connect( reset, SIGNAL( clicked() ), SLOT( slotReset() ) );
 
     connect( alarmBtn, SIGNAL( clicked() ), SLOT( slotSetAlarm() ) );
     connect( snoozeBtn, SIGNAL( clicked() ), SLOT( slotSnooze() ) );
     connect( alarmOffBtn, SIGNAL( clicked() ), SLOT( slotToggleAlarm() ) );
 
     connect( qApp, SIGNAL(appMessage(const QCString&, const QByteArray&)),
        this, SLOT(appMessage(const QCString&, const QByteArray&)) );
 
     t = new QTimer( this );
     connect( t, SIGNAL( timeout() ), SLOT( updateClock() ) );
     t->start( 1000 );
 
     connect( qApp, SIGNAL( timeChanged() ), SLOT( updateClock() ) );
 
     swatch_running = FALSE;
     swatch_totalms = 0;
 
     connect( qApp, SIGNAL(clockChanged(bool)), this, SLOT(changeClock(bool)) );
 
     QString tmp = config.readEntry("clockAlarmHour", "");
     bool ok;
     hour = tmp.toInt(&ok,10);
     tmp = config.readEntry("clockAlarmMinute","");
     minute = tmp.toInt(&ok,10);
 
     if( config.readEntry("clockAlarmSet","FALSE") == "TRUE") {
         alarmOffBtn->setText( tr( "Alarm Is On" ) );
         alarmBool=TRUE;
         snoozeBtn->show();
     } else {
         alarmOffBtn->setText( tr( "Alarm Is Off" ) );
         alarmBool=FALSE;
         snoozeBtn->hide();
     }
 
     QTimer::singleShot( 0, this, SLOT(updateClock()) );
     modeSelect(0);
 }
 
 Clock::~Clock()
 {
     toggleScreenSaver( true );
 }
 
 void Clock::updateClock()
 {
     if ( clockRB->isChecked() ) {
   QTime tm = QDateTime::currentDateTime().time();
   QString s;
   if ( ampm ) {
       int hour = tm.hour();
       if (hour == 0)
     hour = 12;
       if (hour > 12)
     hour -= 12;
       s.sprintf( "%2d%c%02d", hour, ':', tm.minute() );
       ampmLabel->setText( (tm.hour() >= 12) ? "PM" : "AM" );
       ampmLabel->show();
   } else {
       s.sprintf( "%2d%c%02d", tm.hour(), ':', tm.minute() );
       ampmLabel->hide();
   }
   lcd->display( s );
   lcd->repaint( FALSE );
   aclock->display( QTime::currentTime() );
   date->setText( TimeString::longDateString( QDate::currentDate() ) );
     } else {
   QTime swatch_time;
   QString lcdtext;
   int totalms = swatch_totalms;
   if ( swatch_running )
       totalms += swatch_start.elapsed();
   swatch_time = QTime(0,0,0).addMSecs(totalms);
   QString d = swatch_running ? QString("    ")
         : QString::number(totalms%1000+1000);
   lcdtext = swatch_time.toString() + "." + d.right(3).left(sw_prec);
   lcd->display( lcdtext );
   lcd->repaint( FALSE );
   aclock->display( swatch_time );
   date->setText( TimeString::longDateString( QDate::currentDate() ) );
     }
 }
 
 void Clock::changeClock( bool a )
 {
     ampm = a;
     updateClock();
 }
 
 void Clock::clearClock( void )
 {
     lcd->display( QTime( 0,0,0 ).toString() );
     aclock->display( QTime( 0,0,0 ) );
 }
 
 void Clock::slotSet()
 {
     if  ( t->isActive() ) {
   swatch_totalms += swatch_start.elapsed();
   set->setText( tr( "Start" ) );
   t->stop();
   swatch_running = FALSE;
   toggleScreenSaver( TRUE );
   updateClock();
     } else {
   swatch_start.start();
   set->setText( tr( "Stop" ) );
         t->start( 1000 );
   swatch_running = TRUE;
   // disable screensaver while stop watch is running
   toggleScreenSaver( FALSE );
     }
 }
 
 void Clock::slotReset()
 {
     t->stop();
     swatch_start.start();
     swatch_totalms = 0;
 
     if (swatch_running )
   t->start(1000);
 
     updateClock();
 }
 
 void Clock::modeSelect( int m )
 {
     if ( m ) {
   lcd->setNumDigits( 8+1+sw_prec );
   lcd->setMinimumWidth( lcd->sizeHint().width() );
   set->setEnabled( TRUE );
   reset->setEnabled( TRUE );
   ampmLabel->hide();
 
   if ( !swatch_running )
       t->stop();
     } else {
   lcd->setNumDigits( 5 );
   lcd->setMinimumWidth( lcd->sizeHint().width() );
   set->setEnabled( FALSE );
   reset->setEnabled( FALSE );
   t->start(1000);
     }
     updateClock();
 }
 
 //this sets the alarm time
 void Clock::slotSetAlarm()
 {
     if( !snoozeBtn->isHidden())
         slotToggleAlarm();
     Set_Alarm *setAlarmDlg;
     setAlarmDlg = new Set_Alarm(this,"SetAlarm", TRUE);
     int result = setAlarmDlg->exec();
     if(result == 1) {
         Config config( "qpe" );
         config.setGroup("Time");
         QString tmp;
         hour =  setAlarmDlg->Hour_Slider->value();
         minute = setAlarmDlg->Minute_Slider->value();
         snoozeTime=setAlarmDlg->SnoozeSlider->value();
         if(ampm) {
+        	if ( hour == 12 )
+        		hour = 0;
+        
             if(setAlarmDlg->Pm_RadioButton->isChecked() && hour < 12 )
                 hour+=12;
         }
         config.writeEntry("clockAlarmHour", tmp.setNum( hour ),10);
         config.writeEntry("clockAlarmMinute",tmp.setNum( minute ),10);
         config.writeEntry("clockAlarmSnooze",tmp.setNum( snoozeTime ),10);
         config.write();
     }
 }
 
 void Clock::slotSnooze()
 {
     bSound=FALSE;
     int warn = 0;
     QTime t = QTime::currentTime();
     QDateTime whenl( when.date(), t.addSecs( snoozeTime*60));
     when=whenl;
     AlarmServer::addAlarm( when,
                              "QPE/Application/clock",
                              "alarm(QDateTime,int)", warn );
 
 }
 
 //toggles alarm on/off
 void Clock::slotToggleAlarm()
 {
     Config config( "qpe" );
     config.setGroup("Time");
     if(alarmBool) {
         config.writeEntry("clockAlarmSet","FALSE");
         alarmOffBtn->setText( tr( "Alarm Is Off" ) );
         snoozeBtn->hide();
         alarmBool=FALSE;
         alarmOff();
     } else {
         config.writeEntry("clockAlarmSet","TRUE");
         alarmOffBtn->setText( tr( "Alarm Is On" ) );
         snoozeBtn->show();
         alarmBool=TRUE;
         alarmOn();
     }
     config.write();
 }
 
 void Clock::alarmOn()
 {
     QDate d = QDate::currentDate();
     QTime tm((int)hour,(int)minute,0);
     qDebug("Time set "+tm.toString());
     QTime t = QTime::currentTime();
     if( t > tm)
         d = d.addDays(1);
     int warn = 0;
     QDateTime whenl(d,tm);
     when=whenl;
       AlarmServer::addAlarm( when,
                              "QPE/Application/clock",
                              "alarm(QDateTime,int)", warn );
     setCaption("Alarm set: "+ whenl.toString());
 }
 
 void Clock::alarmOff()
 {
     int warn = 0;
     bSound=FALSE;
         AlarmServer::deleteAlarm( when,
                                "QPE/Application/clock",
                                "alarm(QDateTime,int)", warn );
       qDebug("Alarm Off "+ when.toString());
       setCaption("Clock");
 }
 
 void Clock::appMessage(const QCString& msg, const QByteArray& data)
 {
     int stopTimer = 0;
     int timerStay = 5000;
     bSound=TRUE;
     qDebug("Message received in clock");
    if ( msg == "alarm(QDateTime,int)" ) {
        Sound::soundAlarm();
        stopTimer = startTimer( timerStay);
    }
    show();
    raise();
    QPEApplication::setKeepRunning();
    setActiveWindow();
 }
 
 void Clock::timerEvent( QTimerEvent *e )
 {
     static int stop = 0;
     if ( stop < 120 && bSound) {
         Sound::soundAlarm();
         stop++;
     } else {
         stop = 0;
         killTimer( e->timerId() );
         alarmOffBtn->setText( tr( "Alarm Is Off" ) );
         alarmBool=FALSE;
         snoozeBtn->hide();
         setCaption("Clock: Alarm was missed.");
     }
 }
 
 
 QSizePolicy AnalogClock::sizePolicy() const
 {
     return QSizePolicy( QSizePolicy::Expanding, QSizePolicy::Expanding );
 }
 
 void AnalogClock::drawContents( QPainter *p )
 {
     QRect r = contentsRect();
     QPoint center( r.x() + r.width() / 2, r.y() + r.height() / 2 );
 
     QPoint l1( r.x() + r.width() / 2, r.y() + 2 );
     QPoint l2( r.x() + r.width() / 2, r.y() + 8 );
 
     QPoint h1( r.x() + r.width() / 2, r.y() + r.height() / 4 );
     QPoint h2( r.x() + r.width() / 2, r.y() + r.height() / 2 );
 
     QPoint m1( r.x() + r.width() / 2, r.y() + r.height() / 8 );
     QPoint m2( r.x() + r.width() / 2, r.y() + r.height() / 2 );
 
     QPoint s1( r.x() + r.width() / 2, r.y() + 8 );
     QPoint s2( r.x() + r.width() / 2, r.y() + r.height() / 2 );
 
     QColor color( clear ? backgroundColor() : black );
     QTime time = clear ? prevTime : currTime;
 
     if ( clear && prevTime.secsTo(currTime) > 1 ) {
   p->eraseRect( rect() );
   return;
     }
 
     if ( !clear ) {
   // draw ticks
   p->setPen( QPen( color, 1 ) );
   for ( int i = 0; i < 12; i++ )
       p->drawLine( rotate( center, l1, i * 30 ), rotate( center, l2, i * 30 ) );
     }
 
     if ( !clear || prevTime.minute() != currTime.minute() ||
       prevTime.hour() != currTime.hour() ) {
   // draw hour pointer
   h1 = rotate( center, h1, 30 * ( time.hour() % 12 ) + time.minute() / 2 );
   h2 = rotate( center, h2, 30 * ( time.hour() % 12 ) + time.minute() / 2 );
   p->setPen( QPen( color, 3 ) );
   p->drawLine( h1, h2 );
     }
 
     if ( !clear || prevTime.minute() != currTime.minute() ) {
   // draw minute pointer
   m1 = rotate( center, m1, time.minute() * 6 );
   m2 = rotate( center, m2, time.minute() * 6 );
   p->setPen( QPen( color, 2 ) );
   p->drawLine( m1, m2 );
     }
 
     // draw second pointer
     s1 = rotate( center, s1, time.second() * 6 );
     s2 = rotate( center, s2, time.second() * 6 );
     p->setPen( QPen( color, 1 ) );
     p->drawLine( s1, s2 );
 
     if ( !clear )
   prevTime = currTime;
 }
 
 void AnalogClock::display( const QTime& t )
 {
     currTime = t;
     clear = true;
     repaint( false );
     clear = false;
     repaint( false );
 }
 
 QPoint AnalogClock::rotate( QPoint c, QPoint p, int a )
 {
     double angle = deg2rad * ( - a + 180 );
     double nx = c.x() - ( p.x() - c.x() ) * cos( angle ) -
     ( p.y() - c.y() ) * sin( angle );
     double ny = c.y() - ( p.y() - c.y() ) * cos( angle ) +
     ( p.x() - c.x() ) * sin( angle );
     return QPoint( nx, ny );
 }
 
 void Clock::slotAdjustTime() {
     QCopEnvelope e("QPE/System", "execute(QString)");
     e << QString("systemtime");
 }
diff --git a/noncore/tools/clock/setAlarm.cpp b/noncore/tools/clock/setAlarm.cpp
index 6b95e6a..bd964e0 100644
--- a/noncore/tools/clock/setAlarm.cpp
+++ b/noncore/tools/clock/setAlarm.cpp
@@ -1,184 +1,187 @@
  /***************************************************************************
 //                            setAlarm.cpp  -  description
 //                               -------------------
 //       Created: Wed Mar 13 19:47:24 2002
 //      copyright            : (C) 2002 by ljp
 //      email                : ljp@llornkcor.com
 // 
 ***************************************************************************
    *   This program is free software; you can redistribute it and/or modify  *
    *   it under the terms of the GNU General Public License as published by  *
    *   the Free Software Foundation; either version 2 of the License, or     *
    *   (at your option) any later version.                                   *
    ***************************************************************************/
 
 #include "setAlarm.h"
 
 #include <qpe/config.h>
 
 #include <qpe/qpeapplication.h>
 #include <qstring.h>
 #include <qlabel.h>
 #include <qlcdnumber.h>
 #include <qpushbutton.h>
 #include <qradiobutton.h>
 #include <qslider.h>
 #include <qlayout.h>
 #include <qvariant.h>
 #include <qtooltip.h>
 #include <qwhatsthis.h>
 #include <qbuttongroup.h>
 
 Set_Alarm::Set_Alarm( QWidget* parent,  const char* name, bool modal, WFlags fl )
     : QDialog( parent, name, modal, fl )
 {
     if ( !name )
   setName( "Set_Alarm" );
     resize( 240, 101 ); 
     setMaximumSize( QSize( 240, 320 ) );
     setCaption( tr( "Set Alarm" ) );
     connect( qApp,SIGNAL( aboutToQuit()),SLOT( cleanUp()) );
 
     Set_AlarmLayout = new QGridLayout( this ); 
     Set_AlarmLayout->setSpacing( 6 );
     Set_AlarmLayout->setMargin( 11 );
 
     TextLabel1 = new QLabel( this, "TextLabel1" );
     TextLabel1->setText( tr( "Hour" ) );
 
     Set_AlarmLayout->addWidget( TextLabel1, 0, 0 );
 
     TextLabel2 = new QLabel( this, "TextLabel2" );
     TextLabel2->setText( tr( "Minute" ) );
 
     Set_AlarmLayout->addMultiCellWidget( TextLabel2, 0, 0, 1, 2 );
 
     Hour_Slider = new QSlider( this, "Hour_Slider" );
     Hour_Slider->setPageStep( 1);
     Hour_Slider->setOrientation( QSlider::Horizontal );
     connect(Hour_Slider, SIGNAL( valueChanged(int)),this,SLOT(slotChangeHour(int)));
 
     Set_AlarmLayout->addWidget( Hour_Slider, 2, 0 );
 
     Hour_LCDNumber = new QLCDNumber( this, "Hour_LCDNumber" );
     Hour_LCDNumber->setFrameShape( QLCDNumber::Box );
     Hour_LCDNumber->setFrameShadow( QLCDNumber::Plain );
     Hour_LCDNumber->setSegmentStyle( QLCDNumber::Flat );
 
     Set_AlarmLayout->addWidget( Hour_LCDNumber, 1, 0 );
 
     Minute_Slider = new QSlider( this, "Minute_Slider" );
     Minute_Slider->setMaxValue( 59);
     Minute_Slider->setPageStep( 1);
     Minute_Slider->setOrientation( QSlider::Horizontal );
     connect(Minute_Slider, SIGNAL(  valueChanged(int)),this,SLOT(slotChangeMinute(int)));
     
     Set_AlarmLayout->addMultiCellWidget( Minute_Slider, 2, 2, 1, 2 );
 
     Minute_LCDNumber = new QLCDNumber( this, "Minute_LCDNumber" );
     Minute_LCDNumber->setFrameShape( QLCDNumber::Box );
     Minute_LCDNumber->setFrameShadow( QLCDNumber::Plain );
     Minute_LCDNumber->setSegmentStyle( QLCDNumber::Flat );
 
     Set_AlarmLayout->addMultiCellWidget( Minute_LCDNumber, 1, 1, 1, 2 );
 
     Am_RadioButton = new QRadioButton( this, "Am_RadioButton" );
     Am_RadioButton->setText( tr( "AM" ) );
     Am_RadioButton->setChecked(TRUE);
     connect( Am_RadioButton, SIGNAL(toggled(bool)),this,SLOT( amButtonToggled(bool)));
     
     Set_AlarmLayout->addMultiCellWidget( Am_RadioButton, 0, 1, 3, 4 );
 
 
     Pm_RadioButton = new QRadioButton( this, "Pm_RadioButton" );
     Pm_RadioButton->setText( tr( "PM" ) );
     connect( Pm_RadioButton, SIGNAL(toggled(bool)),this,SLOT( pmButtonToggled(bool)));
     
     Set_AlarmLayout->addMultiCellWidget(Pm_RadioButton, 1, 2, 3, 4 );
 
     TextLabel3 = new QLabel( this, "TextLabel3" );
     TextLabel3->setText( tr( "Snooze Delay\n(minutes)" ) );
 
     Set_AlarmLayout->addMultiCellWidget( TextLabel3, 3, 3, 0, 1 );
 
     Snooze_LCDNumber = new QLCDNumber( this, "Snooze_LCDNumber" );
     Snooze_LCDNumber->setFrameShape( QLCDNumber::Box );
     Snooze_LCDNumber->setFrameShadow( QLCDNumber::Plain );
     Snooze_LCDNumber->setSegmentStyle( QLCDNumber::Flat );
 
     Set_AlarmLayout->addMultiCellWidget( Snooze_LCDNumber, 3, 3, 1, 2 );
 
     SnoozeSlider = new QSlider( this, "SnoozeSlider" );
     SnoozeSlider->setMaxValue( 60 );
     SnoozeSlider->setOrientation( QSlider::Horizontal );
     connect(SnoozeSlider, SIGNAL(  valueChanged(int)),this,SLOT(slotChangeSnooze(int)));
 
     Set_AlarmLayout->addMultiCellWidget( SnoozeSlider, 3, 3, 3, 4 );
 
     Config config( "qpe" );
     config.setGroup("Time");
 
     bool ok;
     bool ampm = config.readBoolEntry( "AMPM", TRUE );
     QString alarmHour=config.readEntry("clockAlarmHour","8");
     int i_alarmHour = alarmHour.toInt(&ok,10);
     QString alarmMinute=config.readEntry("clockAlarmMinute","0");
     QString snoozeTime=config.readEntry("clockAlarmSnooze","0");
     if(ampm) {
         Hour_Slider->setMaxValue( 12);
         Hour_Slider->setMinValue( 1);
         
         if( i_alarmHour > 12) {
             i_alarmHour = i_alarmHour - 12;
             Pm_RadioButton->setChecked(TRUE);
         }
-        Hour_Slider->setValue( i_alarmHour);
+        else if ( i_alarmHour == 0 ) {
+        	i_alarmHour = 12; 
+        }	
+        Hour_Slider->setValue( i_alarmHour );
         Minute_Slider->setValue( alarmMinute.toInt(&ok,10) );
         SnoozeSlider->setValue( snoozeTime.toInt(&ok,10) );
     } else {
         Hour_Slider->setMaxValue( 23);
-        Hour_Slider->setMinValue( 1);
+        Hour_Slider->setMinValue( 0);
         Hour_Slider->setValue( i_alarmHour);
         Minute_Slider->setValue( alarmMinute.toInt(&ok,10) );
         SnoozeSlider->setValue( snoozeTime.toInt(&ok,10) );
         Am_RadioButton->hide();
         Pm_RadioButton->hide();
     }
     // signals and slots connections
 }
 
 Set_Alarm::~Set_Alarm()
 {
 
 }
 
 void Set_Alarm::slotChangeHour(int hour)
 {
     Hour_LCDNumber->display(hour);
 }
 
 void Set_Alarm::slotChangeMinute(int minute)
 {
     Minute_LCDNumber->display(minute);
 }
 
 void Set_Alarm::slotChangeSnooze(int minute)
 {
     Snooze_LCDNumber->display(minute);
 }
 
 void Set_Alarm::amButtonToggled(bool b)
 {
     if ( b)
         Pm_RadioButton->setChecked(FALSE);
 }
 
 void Set_Alarm::pmButtonToggled(bool b)
 {
     if (b)
         Am_RadioButton->setChecked(FALSE);
 }
 
 void Set_Alarm::cleanUp()
 {
 }