summaryrefslogtreecommitdiff
authorzecke <zecke>2003-04-13 16:25:24 (UTC)
committer zecke <zecke>2003-04-13 16:25:24 (UTC)
commitc27d6327b9be5792fa507557f03997a46f32cc26 (patch) (side-by-side diff)
tree3332ed2d1c673a898ba1862276d8688918618d7f
parent3e1f225ed1e515c3425361fdc90ac4d5b6d86941 (diff)
downloadopie-c27d6327b9be5792fa507557f03997a46f32cc26.zip
opie-c27d6327b9be5792fa507557f03997a46f32cc26.tar.gz
opie-c27d6327b9be5792fa507557f03997a46f32cc26.tar.bz2
Add apie comments
QString -> const QString& fix
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--libopie2/opiecore/oapplication.cpp2
-rw-r--r--libopie2/opiecore/oapplication.h6
-rw-r--r--libopie2/opiecore/oglobal.h3
-rw-r--r--libopie2/opiecore/oglobalsettings.h7
-rw-r--r--libopie2/opienet/omanufacturerdb.h1
-rw-r--r--libopie2/opienet/onetutils.h3
-rw-r--r--libopie2/opienet/onetwork.cpp2
-rw-r--r--libopie2/opienet/onetwork.h4
-rw-r--r--libopie2/opienet/opcap.h28
-rw-r--r--libopie2/opieui/odialog.h5
-rw-r--r--libopie2/opieui/oimageeffect.h1
-rw-r--r--libopie2/opieui/olistview.h4
-rw-r--r--libopie2/opieui/opopupmenu.h3
-rw-r--r--libopie2/qt3/opiecore/opair.h1
14 files changed, 51 insertions, 19 deletions
diff --git a/libopie2/opiecore/oapplication.cpp b/libopie2/opiecore/oapplication.cpp
index d3e04ba..ce26420 100644
--- a/libopie2/opiecore/oapplication.cpp
+++ b/libopie2/opiecore/oapplication.cpp
@@ -112,5 +112,5 @@ void OApplication::showMainWidget( QWidget* widget, bool nomax )
-void OApplication::setTitle( QString title ) const
+void OApplication::setTitle( const QString& title ) const
{
if ( mainWidget() )
diff --git a/libopie2/opiecore/oapplication.h b/libopie2/opiecore/oapplication.h
index 4d25202..8326847 100644
--- a/libopie2/opiecore/oapplication.h
+++ b/libopie2/opiecore/oapplication.h
@@ -34,4 +34,7 @@
#define oApp OApplication::oApplication()
+// the below stuff will fail with moc because moc does not pre process headers
+// This will make usage of signal and slots hard inside QPEApplication -zecke
+
#ifdef QWS
#include <qpe/qpeapplication.h>
@@ -47,4 +50,5 @@ class OConfig;
class OApplication: public OApplicationBaseClass
{
+// Q_OBJECT would fail -zecke
public:
@@ -115,5 +119,5 @@ class OApplication: public OApplicationBaseClass
* @param title the title. If not given, resets caption to appname
*/
- virtual void setTitle( QString title = QString::null ) const;
+ virtual void setTitle( const QString& title = QString::null ) const;
//virtual void setTitle() const;
diff --git a/libopie2/opiecore/oglobal.h b/libopie2/opiecore/oglobal.h
index 8345c6a..34f211e 100644
--- a/libopie2/opiecore/oglobal.h
+++ b/libopie2/opiecore/oglobal.h
@@ -38,9 +38,10 @@ static OConfig globalconfig = OConfig( "global" );
//FIXME: Is it wise or even necessary to inherit OGlobal from Global?
+// once we totally skip libqpe it should ideally swallow Global -zecke
class OGlobal : public Global
{
public:
-
+ // do we want to put that into OApplication as in KApplication -zecke
static OConfig* config();
};
diff --git a/libopie2/opiecore/oglobalsettings.h b/libopie2/opiecore/oglobalsettings.h
index 6481251..d3f357e 100644
--- a/libopie2/opiecore/oglobalsettings.h
+++ b/libopie2/opiecore/oglobalsettings.h
@@ -48,4 +48,5 @@
//FIXME: before public usage... lack of time to do it at once - so it will
//FIXME: happen step-by-step. ML.
+// we should not habe too much configure options!!!!!! -zecke
/**
@@ -100,4 +101,5 @@ class OGlobalSettings
*/
+ // we do not support DND at the momemt -zecke
static int dndEventDelay();
@@ -115,4 +117,5 @@ class OGlobalSettings
* Returns whether tear-off handles are inserted in OPopupMenus.
**/
+ // would clutter the small screen -zecke
static bool insertTearOffHandle();
@@ -252,4 +255,5 @@ class OGlobalSettings
* The path to the desktop directory of the current user.
*/
+ // below handled by Global stuff and QPEApplication
static QString desktopPath() { initStatic(); return *s_desktopPath; }
@@ -260,6 +264,7 @@ class OGlobalSettings
/**
- * The path to the trash directory of the current user.
+ * The path to the trash directory of the current user.
*/
+ // we do not have that concept -zecke
static QString trashPath() { initStatic(); return *s_trashPath; }
diff --git a/libopie2/opienet/omanufacturerdb.h b/libopie2/opienet/omanufacturerdb.h
index 5e66c37..cb0b6c8 100644
--- a/libopie2/opienet/omanufacturerdb.h
+++ b/libopie2/opienet/omanufacturerdb.h
@@ -22,4 +22,5 @@ class OManufacturerDB
{
public:
+ //FIXME make us consistent -zecke I use self(), sandman inst() you use instance() so we need to chose one!
static OManufacturerDB* instance();
const QString& lookup( const QString& macaddr ) const;
diff --git a/libopie2/opienet/onetutils.h b/libopie2/opienet/onetutils.h
index bedea63..9611518 100644
--- a/libopie2/opienet/onetutils.h
+++ b/libopie2/opienet/onetutils.h
@@ -51,4 +51,5 @@ class OMacAddress
{
public:
+ // QString c'tor? -zecke
OMacAddress( unsigned char* );
OMacAddress( const unsigned char* );
@@ -60,4 +61,5 @@ class OMacAddress
const unsigned char* native() const;
+ // no c'tor but this one why not make it a c'tor. it could also replace the others or is this the problem?
static OMacAddress fromString( const QString& );
@@ -103,4 +105,5 @@ class OPrivateIOCTL : public QObject
int typeSetArgs() const;
+ // FIXME return int? as ::ioctl does? -zecke
void invoke() const;
void setParameter( int, u_int32_t );
diff --git a/libopie2/opienet/onetwork.cpp b/libopie2/opienet/onetwork.cpp
index 73b543b..f0094c7 100644
--- a/libopie2/opienet/onetwork.cpp
+++ b/libopie2/opienet/onetwork.cpp
@@ -109,5 +109,5 @@ void ONetwork::synchronize()
-ONetworkInterface* ONetwork::interface( QString iface ) const
+ONetworkInterface* ONetwork::interface( const QString& iface ) const
{
return _interfaces[iface];
diff --git a/libopie2/opienet/onetwork.h b/libopie2/opienet/onetwork.h
index d2cc25d..db8e702 100644
--- a/libopie2/opienet/onetwork.h
+++ b/libopie2/opienet/onetwork.h
@@ -99,4 +99,5 @@ class ONetwork : public QObject
* @returns true, if the @p interface supports the wireless extension protocol.
*/
+ // FIXME QString? -zecke
bool isWirelessInterface( const char* interface ) const;
/**
@@ -104,5 +105,6 @@ class ONetwork : public QObject
* @see ONetworkInterface
*/
- ONetworkInterface* interface( QString interface ) const;
+ // FIXME: const QString& is prefered over QString!!! -zecke
+ ONetworkInterface* interface( const QString& interface ) const;
protected:
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h
index 99631ba..6bf7416 100644
--- a/libopie2/opienet/opcap.h
+++ b/libopie2/opienet/opcap.h
@@ -69,5 +69,5 @@ class QSocketNotifier;
* OPacket - A frame on the wire
*======================================================================================*/
-
+// FIXME how many OPackets do we've at a time? QObject seams to be a big for that usage
class OPacket : public QObject
{
@@ -96,4 +96,5 @@ class OPacket : public QObject
*======================================================================================*/
+//FIXME same critic as above -zecke
class OEthernetPacket : public QObject
{
@@ -116,5 +117,5 @@ class OEthernetPacket : public QObject
* OWaveLanPacket - DLT_IEEE802_11 frame
*======================================================================================*/
-
+//FIXME same
class OWaveLanPacket : public QObject
{
@@ -146,5 +147,5 @@ class OWaveLanPacket : public QObject
* OWaveLanManagementPacket - type: management (T_MGMT)
*======================================================================================*/
-
+//FIXME same as above -zecke
class OWaveLanManagementPacket : public QObject
{
@@ -175,5 +176,5 @@ class OWaveLanManagementPacket : public QObject
* OWaveLanManagementSSID
*======================================================================================*/
-
+//FIXME is QObject necessary? -zecke
class OWaveLanManagementSSID : public QObject
{
@@ -193,5 +194,5 @@ class OWaveLanManagementSSID : public QObject
* OWaveLanManagementRates
*======================================================================================*/
-
+// FIXME same as above -zecke
class OWaveLanManagementRates : public QObject
{
@@ -210,4 +211,5 @@ class OWaveLanManagementRates : public QObject
*======================================================================================*/
+//FIXME same....
class OWaveLanManagementCF : public QObject
{
@@ -226,4 +228,5 @@ class OWaveLanManagementCF : public QObject
*======================================================================================*/
+//FIXME same
class OWaveLanManagementFH : public QObject
{
@@ -241,5 +244,5 @@ class OWaveLanManagementFH : public QObject
* OWaveLanManagementDS
*======================================================================================*/
-
+//FIXME same
class OWaveLanManagementDS : public QObject
{
@@ -260,4 +263,5 @@ class OWaveLanManagementDS : public QObject
*======================================================================================*/
+//FIXME guess what?
class OWaveLanManagementTim : public QObject
{
@@ -276,4 +280,5 @@ class OWaveLanManagementTim : public QObject
*======================================================================================*/
+//FIXME same as above ( Qobject )
class OWaveLanManagementIBSS : public QObject
{
@@ -292,4 +297,5 @@ class OWaveLanManagementIBSS : public QObject
*======================================================================================*/
+// Qobject do we need that??
class OWaveLanManagementChallenge : public QObject
{
@@ -307,5 +313,5 @@ class OWaveLanManagementChallenge : public QObject
* OWaveLanDataPacket - type: data (T_DATA)
*======================================================================================*/
-
+// Qobject?
class OWaveLanDataPacket : public QObject
{
@@ -323,5 +329,5 @@ class OWaveLanDataPacket : public QObject
* OWaveLanControlPacket - type: control (T_CTRL)
*======================================================================================*/
-
+// Qobject needed?
class OWaveLanControlPacket : public QObject
{
@@ -340,4 +346,5 @@ class OWaveLanControlPacket : public QObject
*======================================================================================*/
+// QObject needed?
class OLLCPacket : public QObject
{
@@ -349,4 +356,5 @@ class OLLCPacket : public QObject
private:
+ //FIXME how to get that header?
const struct ieee_802_11_802_2_header* _header;
};
@@ -356,4 +364,5 @@ class OLLCPacket : public QObject
*======================================================================================*/
+// Qobject as baseclass?
class OIPPacket : public QObject
{
@@ -382,5 +391,5 @@ class OIPPacket : public QObject
* OUDPPacket
*======================================================================================*/
-
+// QObject?
class OUDPPacket : public QObject
{
@@ -402,4 +411,5 @@ class OUDPPacket : public QObject
*======================================================================================*/
+// Qobect needed?
class OTCPPacket : public QObject
{
diff --git a/libopie2/opieui/odialog.h b/libopie2/opieui/odialog.h
index 7947dfb..4116ed7 100644
--- a/libopie2/opieui/odialog.h
+++ b/libopie2/opieui/odialog.h
@@ -52,4 +52,5 @@ class QLayoutItem;
* @author Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de>
*/
+ // lets fix up Qt instead! Size does matter. -zecke
class ODialog : public QDialog
@@ -82,6 +83,6 @@ class ODialog : public QDialog
static int mSpacingSize;
- //class ODialogPrivate;
- //ODialogPrivate *d;
+ class ODialogPrivate;
+ ODialogPrivate *d; // d pointer always needed! -zecke
};
diff --git a/libopie2/opieui/oimageeffect.h b/libopie2/opieui/oimageeffect.h
index 313ea50..fb4d22d 100644
--- a/libopie2/opieui/oimageeffect.h
+++ b/libopie2/opieui/oimageeffect.h
@@ -1,4 +1,5 @@
//FIXME: Revise for Opie - do we really need such fancy stuff on PDA's?
//FIXME: Maybe not on SL5xxx, but surely on C700 :))
+//FIXME: I think we don#t need that -zecke
/* This file is part of the KDE libraries
diff --git a/libopie2/opieui/olistview.h b/libopie2/opieui/olistview.h
index bafc67c..b62e278 100644
--- a/libopie2/opieui/olistview.h
+++ b/libopie2/opieui/olistview.h
@@ -120,5 +120,5 @@ class OListViewItem;
virtual OListViewItem* childFactory();
- #ifndef QT_NO_DATASTREAM
+#ifndef QT_NO_DATASTREAM
/**
* serialize this object to a @ref QDataStream
@@ -132,5 +132,5 @@ class OListViewItem;
*/
virtual void serializeFrom( QDataStream& s );
- #endif
+#endif
private:
diff --git a/libopie2/opieui/opopupmenu.h b/libopie2/opieui/opopupmenu.h
index 94f05f4..54e4301 100644
--- a/libopie2/opieui/opopupmenu.h
+++ b/libopie2/opieui/opopupmenu.h
@@ -1,2 +1,5 @@
+//FIXME what is ODE? ODE Desktop Environemt? -zecke
+//FIXME do we need titles? space is limited that is only eyecandy? -zecke
+//FIXME keyboard navigation is also not that popular on a PDA might be with a keyboard (tuxphone) -zecke
/* This file is part of the ODE libraries
Copyright (C) 2000 Daniel M. Duley <mosfet@kde.org>
diff --git a/libopie2/qt3/opiecore/opair.h b/libopie2/qt3/opiecore/opair.h
index 26f617d..a151127 100644
--- a/libopie2/qt3/opiecore/opair.h
+++ b/libopie2/qt3/opiecore/opair.h
@@ -1,4 +1,5 @@
// QPair minus QT_INLINE_TEMPLATE (instead directly using 'inline' directive)
//FIXME: remove and use qpair.h as soon as we're on Qt3
+// name file qpair -zecke
/****************************************************************************