Rule of Thumb: If it is 3:00am and you've suddenly something that compiles it is a

step in the right direction but wrong...

Now the question is where to get the brown paperbacks again?! Maybe we get a discount...

Anyway:
  adding a break in switch/case is most likely a good idea. Before we only used return

1 files changed, 3 insertions, 0 deletions

diff --git a/libopie2/opiepim/core/opimaccessfactory.h b/libopie2/opiepim/core/opimaccessfactory.h
index a80e67c..ee55ba5 100644
--- a/libopie2/opiepim/core/opimaccessfactory.h
+++ b/libopie2/opiepim/core/opimaccessfactory.h
@@ -61,52 +61,55 @@ namespace Opie {
 template<class T>
 class OPimAccessFactory
 {
  public:
 
 	// Maybe we should introduce a global class for storing such global enums
 	// (something like opimglobal.h) ? (eilers)
 
 	OPimAccessFactory() {};
 
 	/**
 	 * Returns the selected PIM access-object.
 	 * @param type Type of the selected database (addressbook, todolist or datebook)
 	 * @param dbStyle Which database style should be used (xml, sql, vcard)
 	 * @param appName "Name" of your application. This should be any constant string which is used
 	 *                by some backends for creating special files (i.e.journal files). Please keep the
 	 *                string unique for your application !
 	 * @see OPimGlobal
 	 */
 	static T* create( OPimGlobal::PimType type, OPimGlobal::DatabaseStyle dbStyle, const QString& appName ){
             OPimBase *base;
 		switch ( type ){
 		case OPimGlobal::TODOLIST:
 		        base = new OPimTodoAccess( OBackendFactory<OPimTodoAccessBackend>::create( type, dbStyle, appName ) );
+                        break;
 		case OPimGlobal::CONTACTLIST:
 		        base = new OPimContactAccess( QString::null, QString::null, OBackendFactory<OPimContactAccessBackend>::create( type, dbStyle, appName ) );
+                        break;
 		case OPimGlobal::DATEBOOK:
 		        base = new ODateBookAccess( OBackendFactory<ODateBookAccessBackend>::create( type, dbStyle, appName ) );
+                        break;
 		default:
 			return 0l;
 		}
                 return static_cast<T*>( base );
 	}
 
 
 	/**
 	 * Returns the selected PIM access-object, using the default database style
 	 * Which style is selected is defined in the configfile "pimaccess.conf" in
 	 * the directory "Settings"
 	 * @param type Type of the selected database (addressbook, todolist or datebook)
 	 * @param appName "Name" of your application. This should be any constant string which is used
 	 *                by some backends for creating special files (i.e.journal files). Please keep the
 	 *                string unique for your application !
 	 * @see OPimGlobal
 	 *
 	 */
 	static T* defaultAccess( typename OPimGlobal::PimType type, const QString& appName ){
 
 		return create( type, OPimGlobal::DEFAULT, appName );
 
 	}
 };