Each file in this commit exhibits a problem where a variable is made in

some way but never used. This is a tricky problem with Qt since almost all
UI forms are made but not used (like QLabel). But I am pretty confident that
these changes are correct and do not have any aspect of a change to the UI.

In most cases, there are just variables that are made and then copied over
(like in iteration over lists or assignment of pointers based on
conditionals).

4 files changed, 7 insertions, 14 deletions

diff --git a/libqtaux/qsplitter.cpp b/libqtaux/qsplitter.cpp
index 39321f8..959d5e1 100644
--- a/libqtaux/qsplitter.cpp
+++ b/libqtaux/qsplitter.cpp
@@ -682,97 +682,97 @@ void QSplitter::doResize()
 	} else if ( s->mode == KeepSize ) {
 	    a[i].stretch = 0;
 	    a[i].minimumSize = pick( minSize(s->wid) );
 	    a[i].sizeHint = s->sizer;
 	    a[i].maximumSize = pick( s->wid->maximumSize() );
 	    a[i].empty = FALSE;
 	} else if ( s->mode == FollowSizeHint ) {
 	    a[i].stretch = 0;
 	    a[i].minimumSize = a[i].sizeHint = pick( s->wid->sizeHint() );
 	    a[i].maximumSize = pick( s->wid->maximumSize() );
 	    a[i].empty = FALSE;
 	} else { //proportional
 	    a[i].stretch = s->sizer;
 	    a[i].maximumSize = pick( s->wid->maximumSize() );
 	    a[i].sizeHint = a[i].minimumSize = pick( minSize(s->wid) );
 	    a[i].empty = FALSE;
 	}
     }
 
     qGeomCalc( a, 0, n, pick( r.topLeft() ), pick( r.size() ), 0 );
     for ( i = 0; i< n; i++ ) {
 	QSplitterLayoutStruct *s = data->list.at(i);
 	if ( orient == Horizontal )
 	    s->wid->setGeometry( a[i].pos, r.top(), a[i].size, r.height() );
 	else
 	    s->wid->setGeometry( r.left(), a[i].pos, r.width(), a[i].size );
     }
 
 }
 
 
 void QSplitter::recalc( bool update )
 {
     int fi = 2*frameWidth();
     int maxl = fi;
     int minl = fi;
     int maxt = QWIDGETSIZE_MAX;
     int mint = fi;
     int n = data->list.count();
     bool first = TRUE;
     /*
       The splitter before a hidden widget is always hidden.
       The splitter before the first visible widget is hidden.
       The splitter before any other visible widget is visible.
     */
     for ( int i = 0; i< n; i++ ) {
 	QSplitterLayoutStruct *s = data->list.at(i);
 	if ( !s->isSplitter ) {
-	    QSplitterLayoutStruct *p = (i > 0) ? p = data->list.at( i-1 ) : 0;
+	    QSplitterLayoutStruct *p = (i > 0) ? data->list.at( i-1 ) : 0;
 	    if ( p && p->isSplitter )
 		if ( first || s->wid->isHidden() )
 		    p->wid->hide(); //may trigger new recalc
 		else
 		    p->wid->show(); //may trigger new recalc
 	    if ( !s->wid->isHidden() )
 		first = FALSE;
 	}
     }
 
     bool empty=TRUE;
     for ( int j = 0; j< n; j++ ) {
 	QSplitterLayoutStruct *s = data->list.at(j);
 	if ( !s->wid->isHidden() ) {
 	    empty = FALSE;
 	    if ( s->isSplitter ) {
 		minl += s->sizer;
 		maxl += s->sizer;
 	    } else {
 		QSize minS = minSize(s->wid);
 		minl += pick( minS );
 		maxl += pick( s->wid->maximumSize() );
 		mint = QMAX( mint, trans( minS ));
 		int tm = trans( s->wid->maximumSize() );
 		if ( tm > 0 )
 		    maxt = QMIN( maxt, tm );
 	    }
 	}
     }
     if ( empty )
 	maxl = maxt = 0;
     else
 	maxl = QMIN( maxl, QWIDGETSIZE_MAX );
     if ( maxt < mint )
 	maxt = mint;
 
     if ( orient == Horizontal ) {
 	setMaximumSize( maxl, maxt );
 	setMinimumSize( minl, mint );
     } else {
 	setMaximumSize( maxt, maxl );
 	setMinimumSize( mint, minl );
     }
     if ( update )
 	doResize();
 }
 
 /*! \enum QSplitter::ResizeMode
diff --git a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
index 9fa4452..d8f5aa7 100644
--- a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
+++ b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
@@ -12,99 +12,97 @@
  *   it under the terms of the GNU General Public License as published by  *
  *   the Free Software Foundation; either version 2 of the License, or     *
  *   (at your option) any later version.                                   *
  *                                                                         *
  ***************************************************************************/
 
 #include "katesyntaxdocument.h"
 #include "kateconfig.h"
 #include "kdebug.h"
 #include "kstddirs.h"
 #include "klocale.h"
 #include "kmessagebox.h"
 #include "kglobal.h"
 
 /* OPIE */
 #include <opie2/odebug.h>
 #include <qpe/qpeapplication.h>
 
 /* QT */
 #include <qfile.h>
 #include <qstringlist.h>
 #include <qdir.h>
 
 SyntaxDocument::SyntaxDocument()
 {
   m_root=0;
   currentFile="";
   setupModeList();
 }
 
 void SyntaxDocument::setIdentifier(const QString& identifier)
 {
 #warning FIXME  delete m_root;
   m_root=Opie::Core::XMLElement::load(identifier);
   if (!m_root)    KMessageBox::error( 0L, i18n("Can't open %1").arg(identifier) );
 
 }
 
 SyntaxDocument::~SyntaxDocument()
 {
 }
 
 void SyntaxDocument::setupModeList(bool force)
 {
 
   if (myModeList.count() > 0) return;
 
   KateConfig *config=KGlobal::config();
-  KStandardDirs *dirs = KGlobal::dirs();
 
-//  QStringList list=dirs->findAllResources("data","kate/syntax/*.xml",false,true);
   QString path=QPEApplication::qpeDir() +"share/tinykate/syntax/";
 
   QDir dir(path);
   QStringList list=dir.entryList("*.xml");
 
   for ( QStringList::Iterator it = list.begin(); it != list.end(); ++it )
   {
     QString Group="Highlighting_Cache"+path+*it;
     if ((config->hasGroup(Group)) && (!force))
     {
       config->setGroup(Group);
       syntaxModeListItem *mli=new syntaxModeListItem;
       mli->name = config->readEntry("name","");
       mli->section = config->readEntry("section","");
       mli->mimetype = config->readEntry("mimetype","");
       mli->extension = config->readEntry("extension","");
       mli->identifier = path+*it;
       myModeList.append(mli);
     }
     else
     {
     odebug << "Found a description file:"+path+(*it) << oendl;
         setIdentifier(path+(*it));
         Opie::Core::XMLElement *e=m_root;
         if (e)
         {
       e=e->firstChild();
       odebug << e->tagName() << oendl;
           if (e->tagName()=="language")
           {
             syntaxModeListItem *mli=new syntaxModeListItem;
             mli->name = e->attribute("name");
             mli->section = e->attribute("section");
             mli->mimetype = e->attribute("mimetype");
             mli->extension = e->attribute("extensions");
         odebug << QString("valid description for: %1/%2").arg(mli->section).arg(mli->name) << oendl;
             if (mli->section.isEmpty())
               mli->section=i18n("Other");
 
             mli->identifier = path+(*it);
             config->setGroup(Group);
             config->writeEntry("name",mli->name);
             config->writeEntry("section",mli->section);
             config->writeEntry("mimetype",mli->mimetype);
             config->writeEntry("extension",mli->extension);
             myModeList.append(mli);
           }
         }
diff --git a/noncore/apps/tinykate/mainwindow/tinykate.cpp b/noncore/apps/tinykate/mainwindow/tinykate.cpp
index e87464e..e920d5b 100644
--- a/noncore/apps/tinykate/mainwindow/tinykate.cpp
+++ b/noncore/apps/tinykate/mainwindow/tinykate.cpp
@@ -158,176 +158,174 @@ TinyKate::TinyKate( QWidget *parent, const char *name, WFlags f) :
     mb->insertItem( editUndo );
     mb->insertItem(  editRedo );
 
 
     //Highlight management
     hlmenu=new QPopupMenu(this);
     HlManager *hlm=HlManager::self();
     for (int i=0;i<hlm->highlights();i++)
     {
         hlmenu->insertItem(hlm->hlName(i),i);
     }
     popup->insertItem(tr("Highlighting"),hlmenu);
 
 
     utilSettings = new QAction( tr( "Settings" ),
                                 Opie::Core::OResource::loadPixmap( "SettingsIcon", Opie::Core::OResource::SmallIcon ),
                                 QString::null, 0, this, 0 );
     utilSettings->addTo( popup);
 
     if( qApp->argc() > 1) open(qApp->argv()[1]);
     else slotNew();
 
 }
 
 TinyKate::~TinyKate( )
 {
     owarn << "TinyKate destructor\n" << oendl;
 
     if( KGlobal::config() != 0 )
     {
         owarn << "deleting KateConfig object..\n" << oendl;
         delete KGlobal::config();
     }
 }
 
 void TinyKate::slotOpen( )
 {
     QString filename = OFileDialog::getOpenFileName( OFileSelector::EXTENDED_ALL,
                        QString::null);
     if (!filename.isEmpty())
     {
         open(filename);
     }
 }
 
 void TinyKate::open(const QString & filename)
 {
     KateDocument *kd= new KateDocument(false, false, this,0,this);
-    KTextEditor::View *kv;
     QString realFileName;
     //check if filename is a .desktop file
     if ( filename.find( ".desktop", 0, true ) != -1 ) {
         switch ( QMessageBox::warning( this, tr( "TinyKATE" ),
                                        tr("TinyKATE has detected<BR>you selected a <B>.desktop</B> file.<BR>Open <B>.desktop</B> file or <B>linked</B> file?" ),
                                        tr(".desktop File"),
                                        tr("Linked Document"), 0, 1, 1 ) )
         {
         case 0: //desktop
             realFileName = filename;
             break;
         case 1: //linked
             DocLnk docLnk( filename );
             realFileName = docLnk.file();
             break;
         };
     } else {
 	    realFileName = filename;
     }
 
     QFileInfo fileInfo( realFileName );
     QString filenamed = fileInfo.fileName();
-    tabwidget->addTab(kv=kd->createView(tabwidget,"bLAH"),"tinykate/tinykate", filenamed );
+    tabwidget->addTab(kd->createView(tabwidget,"Unnamed kateview"),"tinykate/tinykate", filenamed );
     odebug << realFileName << oendl;
 
     kd->setDocName( filenamed);
     kd->open( realFileName );
     viewCount++;
 }
 
 void TinyKate::setDocument(const QString& fileref)
 {
     open( fileref );
 }
 
 void TinyKate::slotCurrentChanged( QWidget * view)
 {
     if (currentView)
     {
 
         disconnect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy()));
         disconnect(editCut,SIGNAL(clicked()),currentView,SLOT(cut()));
         disconnect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste()));
         disconnect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo()));
         disconnect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo()));
         disconnect(editFind,SIGNAL(activated()),currentView,SLOT(find()));
         disconnect(editReplace,SIGNAL(activated()),currentView,SLOT(replace()));
         disconnect(editGotoLine,SIGNAL(activated()),currentView,SLOT(gotoLine()));
         disconnect(viewIncFontSizes,SIGNAL(activated()), currentView,SLOT(slotIncFontSizes()));
         disconnect(viewDecFontSizes,SIGNAL(activated()), currentView,SLOT(slotDecFontSizes()));
         disconnect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int)));
         disconnect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog()));
     }
 
     currentView=(KTextEditor::View*)view;
 
     connect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy()));
     connect(editCut,SIGNAL(clicked()),currentView,SLOT(cut()));
     connect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste()));
     connect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo()));
     connect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo()));
     connect(editFind,SIGNAL(activated()),currentView,SLOT(find()));
     connect(editReplace,SIGNAL(activated()),currentView,SLOT(replace()));
     connect(editGotoLine,SIGNAL(activated()),currentView,SLOT(gotoLine()));
     connect(viewIncFontSizes,SIGNAL(activated()), currentView,SLOT(slotIncFontSizes()));
     connect(viewDecFontSizes,SIGNAL(activated()), currentView,SLOT(slotDecFontSizes()));
     connect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int)));
     connect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog()));
 
 }
 
 void TinyKate::slotNew( )
 {
     KateDocument *kd= new KateDocument(false, false, this,0,this);
-    KTextEditor::View *kv;
     
     kd->setDocName(tr("Unnamed %1").arg(nextUnnamed++));
     kd->setNewDoc(true);
-    tabwidget->addTab(kv=kd->createView(tabwidget,"BLAH"),
+    tabwidget->addTab(kd->createView(tabwidget,"Unnamed"),
                       "tinykate/tinykate",
                       kd->docName());
     viewCount++;
 }
 
 bool TinyKate::checkSave() {
     if (currentView==0) return true;
 
     KateView *kv = (KateView*) currentView;
     if(kv->isModified()) {
         KateDocument *kd = (KateDocument*) kv->document();
         switch( QMessageBox::information( 0, (tr("TinyKATE")),
                                         (tr("Do you want to save\n"
                                             "changes to the document\n"
                                             "%1?\n").arg(kd->docName())),
                                         (tr("Save")), (tr("Don't Save")), (tr("&Cancel")), 2, 2 ) )
         {
             case 0:
             {
                 return saveDocument();
             }
             break;
     
             case 1:
             {
                 return true;
             }
             break;
     
             default:
             {
                 return false;
             }
             break;
         };
     }
     else {
         return true;
     }
 }
 
 bool TinyKate::closeDocument()
 {
     if (currentView==0) return true;
     KTextEditor::View *dv=currentView;
     if(checkSave()) {
         currentView=0;
         tabwidget->removePage(dv);
diff --git a/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp b/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
index 147eb9c..d4f9943 100644
--- a/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
+++ b/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
@@ -73,104 +73,101 @@ QStringList DCIM_DirLister::folders()const {
         lst = findAlbums();
         break;
     case ListingFiles:
     default:
         break;
     }
 
     return lst;
 }
 
 QStringList DCIM_DirLister::files()const {
     if ( m_mode != ListingFiles )
         return QStringList();
     else
         return findImages();
 }
 
 QString DCIM_DirLister::dirUp( const QString& p )const {
     QString str;
 
     switch( m_mode ) {
     case ListingFiles:
         m_mode = ListingReFolder;
         str = PDirLister::dirUp( p );
         break;
     case ListingFolder:
         m_mode = ListingStart;
         break;
     case ListingUnknown:
     case ListingStart:
     default:
         break;
     }
 
     /* down cases */
     owarn << " New String " << str << " old path " << m_mode << oendl;
     m_path = str;
     return str;
 }
 
 
 QStringList DCIM_DirLister::findCameras()const {
     QStringList lst;
     StorageInfo inf;
 
     m_map.clear();
 
     const QList<FileSystem> &list = inf.fileSystems();
-    QListIterator<FileSystem> it( list );
 
-
-    FileSystem *sys;
-    for ( sys = it.current(); (sys=it.current())!=0  ; ++it )
-        if ( QFileInfo( sys->path() + "/dcim/" ).exists() ) {
-            lst << sys->name();
-            m_map.insert( sys->name(), sys->path() );
+    for ( QListIterator<FileSystem> it( list ); it.current()!=0  ; ++it )
+        if ( QFileInfo( it.current()->path() + "/dcim/" ).exists() ) {
+            lst << it.current()->name();
+            m_map.insert( it.current()->name(), it.current()->path() );
         }
 
     if ( lst.isEmpty() ) {
         m_mode = ListingUnknown;
         lst << QObject::tr("Error no Camera Dir found");
     }else
         m_mode = ListingStart;
 
     return lst;
 }
 
 QStringList DCIM_DirLister::findAlbums()const {
     QStringList lst = QDir( m_path ).entryList( QDir::Dirs );
     lst.remove( "."  );
     lst.remove( ".." );
 
     return lst;
 }
 
 QStringList DCIM_DirLister::findImages()const {
     return QDir( m_path ).entryList("*.jpg *.jpeg *.png", QDir::Files );
 }
 
 void DCIM_DirLister::deleteImage( const QString& fl ) {
     QFileInfo inf( fl );
     QFile::remove( fl );
     QFile::remove( inf.dirPath ()+"/preview/"+
                    inf.fileName() );
 }
 
 void DCIM_DirLister::thumbNail( const QString& _str, int w, int h ) {
     QFileInfo inf( _str );
     QString str = QFileInfo( inf.dirPath()+"/preview"+ inf.fileName() ).exists() ?
                   inf.dirPath()+"/preview"+ inf.fileName() : _str;
 
     SlaveMaster::self()->thumbNail( str, w, h );
 }
 
 QImage DCIM_DirLister::image( const QString& str,  Factor f,  int m ) {
     return SlaveMaster::self()->image( str, f, m );
 }
 
 void DCIM_DirLister::imageInfo( const QString& str ) {
     SlaveMaster::self()->thumbInfo( str );
 }
 
 void DCIM_DirLister::fullImageInfo( const QString& str ) {
     SlaveMaster::self()->imageInfo( str );