Resolved a feature request:

unique display of date-time of a mail
maillist now sorted for mail-date as default, user can switch sort order
to all other items (subject, author, size)

10 files changed, 81 insertions, 46 deletions

diff --git a/noncore/net/mail/libmailwrapper/genericwrapper.cpp b/noncore/net/mail/libmailwrapper/genericwrapper.cpp
index 703235d..0ac842d 100644
--- a/noncore/net/mail/libmailwrapper/genericwrapper.cpp
+++ b/noncore/net/mail/libmailwrapper/genericwrapper.cpp
@@ -381,13 +381,13 @@ QStringList Genericwrapper::parseInreplies(mailimf_in_reply_to * in_replies)
     }
     return res;
 }
 
 void Genericwrapper::parseList(QValueList<Opie::Core::OSmartPointer<RecMail> > &target,mailsession*session,const QString&mailbox,bool mbox_as_to)
 {
-    int r;
+    int r,toffset;
     mailmessage_list * env_list = 0;
     r = mailsession_get_messages_list(session,&env_list);
     if (r != MAIL_NO_ERROR) {
         odebug << "Error message list" << oendl;
         return;
     }
@@ -434,19 +434,19 @@ void Genericwrapper::parseList(QValueList<Opie::Core::OSmartPointer<RecMail> > &
             mail->setTo(mailbox);
         }
         if (single_fields.fld_cc)
             mail->setCC( parseAddressList( single_fields.fld_cc->cc_addr_list ) );
         if (single_fields.fld_bcc)
             mail->setBcc( parseAddressList( single_fields.fld_bcc->bcc_addr_list ) );
-        if (single_fields.fld_orig_date)
-            mail->setDate( parseDateTime( single_fields.fld_orig_date->dt_date_time ) );
-        // crashes when accessing pop3 account?
+        if (single_fields.fld_orig_date) {
+            QDateTime d = parseDateTime( single_fields.fld_orig_date->dt_date_time,toffset);
+            mail->setDate( d,toffset );
+        }
         if (single_fields.fld_message_id && single_fields.fld_message_id->mid_value) {
             mail->setMsgid(QString(single_fields.fld_message_id->mid_value));
         }
-
         if (single_fields.fld_reply_to) {
             QStringList t = parseAddressList(single_fields.fld_reply_to->rt_addr_list);
             if (t.count()>0) {
                 mail->setReplyto(t[0]);
             }
         }
diff --git a/noncore/net/mail/libmailwrapper/imapwrapper.cpp b/noncore/net/mail/libmailwrapper/imapwrapper.cpp
index 56efa0b..8e5212b 100644
--- a/noncore/net/mail/libmailwrapper/imapwrapper.cpp
+++ b/noncore/net/mail/libmailwrapper/imapwrapper.cpp
@@ -369,13 +369,13 @@ RecMail*IMAPwrapper::parse_list_result(mailimap_msg_att* m_att)
 {
     RecMail * m = 0;
     mailimap_msg_att_item *item=0;
     clistcell *current,*c,*cf;
     mailimap_msg_att_dynamic*flist;
     mailimap_flag_fetch*cflag;
-    int size;
+    int size,toffset;
     QBitArray mFlags(7);
     QStringList addresslist;
 
     if (!m_att) {
         return m;
     }
@@ -421,13 +421,14 @@ RecMail*IMAPwrapper::parse_list_result(mailimap_msg_att* m_att)
                 }
             }
             continue;
         }
         if (item->att_data.att_static->att_type==MAILIMAP_MSG_ATT_ENVELOPE) {
             mailimap_envelope * head = item->att_data.att_static->att_data.att_env;
-            m->setDate(parseDateTime(head->env_date));
+            QDateTime d = parseDateTime(head->env_date,toffset);
+            m->setDate(d,toffset);
             m->setSubject(convert_String((const char*)head->env_subject));
             if (head->env_from!=NULL) {
                 addresslist = address_list_to_stringlist(head->env_from->frm_list);
                 if (addresslist.count()) {
                     m->setFrom(addresslist.first());
                 }
diff --git a/noncore/net/mail/libmailwrapper/mailstatics.cpp b/noncore/net/mail/libmailwrapper/mailstatics.cpp
index 4878dc9..033ec28 100644
--- a/noncore/net/mail/libmailwrapper/mailstatics.cpp
+++ b/noncore/net/mail/libmailwrapper/mailstatics.cpp
@@ -1,29 +1,30 @@
 #include "mailstatics.h"
 #include <libetpan/libetpan.h>
-#include <qpe/timestring.h>
+//#include <qpe/timestring.h>
 
-QString MailStatics::parseDateTime(const mailimf_date_time *date )
+QDateTime MailStatics::parseDateTime(const mailimf_date_time *date,int&offset )
 {
-    if (!date) return "";
+    offset = 0;
+    if (!date) {
+        return QDateTime();
+    }
     QDateTime da(QDate(date->dt_year,date->dt_month,date->dt_day),QTime(date->dt_hour,date->dt_min,date->dt_sec));
-    QString timestring = TimeString::numberDateString(QDate(date->dt_year,date->dt_month,date->dt_day))+" ";
-    timestring+=TimeString::timeString(QTime(date->dt_hour,date->dt_min,date->dt_sec))+" ";
-    timestring.sprintf(timestring+" %+05i",date->dt_zone);
-    return timestring;
+    offset = date->dt_zone;
+    return da;
 }
 
-QString MailStatics::parseDateTime(const char*date)
+QDateTime MailStatics::parseDateTime(const char*date,int&offset)
 {
-    mailimf_date_time * date_time;
-    QString d = "";
+    mailimf_date_time * date_time=0;
+    QDateTime d;
     size_t cur_tok = 0;
     if (!date) return d;
     int r = mailimf_date_time_parse(date,strlen(date),&cur_tok,&date_time);
     if (r==MAILIMF_NO_ERROR) {
-        d = parseDateTime(date_time);
+        d = parseDateTime(date_time,offset);
     }
     if (date_time) {
         mailimf_date_time_free(date_time);
     }
     return d;
-}
\ No newline at end of file
+}
diff --git a/noncore/net/mail/libmailwrapper/mailstatics.h b/noncore/net/mail/libmailwrapper/mailstatics.h
index 841d14d..c714ead 100644
--- a/noncore/net/mail/libmailwrapper/mailstatics.h
+++ b/noncore/net/mail/libmailwrapper/mailstatics.h
@@ -6,14 +6,14 @@
 
 struct mailimf_date_time;
 
 class MailStatics
 {
 protected:
-    static QString parseDateTime(const mailimf_date_time * date);
-    static QString parseDateTime(const char*date);
+    static QDateTime parseDateTime(const mailimf_date_time * date,int&offset);
+    static QDateTime parseDateTime(const char*date,int&offset);
     MailStatics(){};
     virtual ~MailStatics(){};
 public:
 };
 
 #endif
diff --git a/noncore/net/mail/libmailwrapper/mailtypes.cpp b/noncore/net/mail/libmailwrapper/mailtypes.cpp
index d4395a2..b009b75 100644
--- a/noncore/net/mail/libmailwrapper/mailtypes.cpp
+++ b/noncore/net/mail/libmailwrapper/mailtypes.cpp
@@ -1,35 +1,37 @@
 #include "mailtypes.h"
 
 #include <opie2/odebug.h>
+#include <qpe/timestring.h>
 
 #include <stdlib.h>
 
 using namespace Opie::Core;
 RecMail::RecMail()
-    :Opie::Core::ORefCount(),subject(""),date(""),from(""),mbox(""),msg_id(""),msg_number(0),msg_size(0),msg_flags(7)
+    :Opie::Core::ORefCount(),subject(""),from(""),mbox(""),msg_id(""),msg_number(0),msg_size(0),msg_flags(7),maildate(),date("")
 {
     init();
 }
 
 RecMail::RecMail(const RecMail&old)
-    :Opie::Core::ORefCount(),subject(""),date(""),from(""),mbox(""),msg_id(""),msg_number(0),msg_flags(7)
+    :Opie::Core::ORefCount(),subject(""),from(""),mbox(""),msg_id(""),msg_number(0),msg_flags(7),maildate(),date("")
 {
     init();
     copy_old(old);
-    odebug << "Copy constructor RecMail" << oendl; 
+    odebug << "Copy constructor RecMail" << oendl;
 }
 
 RecMail::~RecMail()
 {
     wrapper = 0;
 }
 
 void RecMail::copy_old(const RecMail&old)
 {
     subject = old.subject;
+    maildate = old.maildate;
     date = old.date;
     mbox = old.mbox;
     msg_id = old.msg_id;
     msg_size = old.msg_size;
     msg_number = old.msg_number;
     from = old.from;
@@ -50,12 +52,23 @@ void RecMail::init()
     bcc.clear();
     in_reply_to.clear();
     references.clear();
     wrapper = 0;
 }
 
+void RecMail::setDate( const QDateTime&a,int offset)
+{
+    QString timestring = TimeString::numberDateString(a.date())+" ";
+    timestring+=TimeString::timeString(a.time());
+    if (offset > 0) {
+        timestring.sprintf(timestring+" %+05i",offset);
+    }
+    date = timestring;
+    maildate = a;
+}
+
 void RecMail::setWrapper(AbstractMail*awrapper)
 {
     wrapper = awrapper;
 }
 
 AbstractMail* RecMail::Wrapper()
@@ -131,13 +144,13 @@ RecPart::RecPart(const RecPart&old)
     m_encoding = old.m_encoding;
     m_description = old.m_description;
     m_lines = old.m_lines;
     m_size = old.m_size;
     m_Parameters = old.m_Parameters;
     m_poslist = old.m_poslist;
-    odebug << "RecPart copy constructor" << oendl; 
+    odebug << "RecPart copy constructor" << oendl;
 }
 
 RecPart::~RecPart()
 {
 }
 
@@ -255,13 +268,13 @@ RecBody::RecBody()
 RecBody::RecBody(const RecBody&old)
     :Opie::Core::ORefCount(),m_BodyText(),m_PartsList(),m_description(new RecPart())
 {
     m_BodyText = old.m_BodyText;
     m_PartsList = old.m_PartsList;
     m_description = old.m_description;
-    odebug << "Recbody copy constructor" << oendl; 
+    odebug << "Recbody copy constructor" << oendl;
 }
 
 RecBody::~RecBody()
 {
 }
 
@@ -320,20 +333,20 @@ encodedString::encodedString(char*nContent,unsigned int nSize)
 }
 
 encodedString::encodedString(const encodedString&old)
 {
     init();
     copy_old(old);
-    odebug << "encodedeString: copy constructor!" << oendl; 
+    odebug << "encodedeString: copy constructor!" << oendl;
 }
 
 encodedString& encodedString::operator=(const encodedString&old)
 {
     init();
     copy_old(old);
-    odebug << "encodedString: assign operator!" << oendl; 
+    odebug << "encodedString: assign operator!" << oendl;
     return *this;
 }
 
 encodedString::~encodedString()
 {
     clean();
@@ -393,7 +406,6 @@ folderStat&folderStat::operator=(const folderStat&old)
 {
     message_count = old.message_count;
     message_unseen = old.message_unseen;
     message_recent = old.message_recent;
     return *this;
 }
-
diff --git a/noncore/net/mail/libmailwrapper/mailtypes.h b/noncore/net/mail/libmailwrapper/mailtypes.h
index c317880..272514c 100644
--- a/noncore/net/mail/libmailwrapper/mailtypes.h
+++ b/noncore/net/mail/libmailwrapper/mailtypes.h
@@ -12,12 +12,13 @@
 
 #include <qbitarray.h>
 #include <qstring.h>
 #include <qstringlist.h>
 #include <qmap.h>
 #include <qvaluelist.h>
+#include <qdatetime.h>
 
 class AbstractMail;
 /* a class to describe mails in a mailbox */
 /* Attention!
    From programmers point of view it would make sense to
    store the mail body into this class, too.
@@ -35,14 +36,12 @@ public:
     RecMail();
     RecMail(const RecMail&old);
     virtual ~RecMail();
 
     const unsigned int getNumber()const{return msg_number;}
     void setNumber(unsigned int number){msg_number=number;}
-    const QString&getDate()const{ return date; }
-    void setDate( const QString&a ) { date = a; }
     const QString&getFrom()const{ return from; }
     void setFrom( const QString&a ) { from = a; }
     const QString&getSubject()const { return subject; }
     void setSubject( const QString&s ) { subject = s; }
     const QString&getMbox()const{return mbox;}
     void setMbox(const QString&box){mbox = box;}
@@ -68,20 +67,26 @@ public:
     const QBitArray&getFlags()const{return msg_flags;}
     void setFlags(const QBitArray&flags){msg_flags = flags;}
 
     void setWrapper(AbstractMail*wrapper);
     AbstractMail* Wrapper();
 
+    const QDateTime&getDate()const{ return maildate; }
+    const QString&getStringDate()const{return date;}
+    void setDate( const QDateTime&a,int offset=0 );
+
 protected:
-    QString subject,date,from,mbox,msg_id,replyto;
+    QString subject,from,mbox,msg_id,replyto;
     unsigned int msg_number,msg_size;
     QBitArray msg_flags;
     QStringList to,cc,bcc,in_reply_to,references;
     AbstractMail*wrapper;
     void init();
     void copy_old(const RecMail&old);
+    QDateTime maildate;
+    QString date;
 };
 
 typedef Opie::Core::OSmartPointer<RecMail> RecMailP;
 typedef QMap<QString,QString> part_plist_t;
 
 class RecPart:public Opie::Core::ORefCount
diff --git a/noncore/net/mail/mailistviewitem.cpp b/noncore/net/mail/mailistviewitem.cpp
index 0b926da..d3a0723 100644
--- a/noncore/net/mail/mailistviewitem.cpp
+++ b/noncore/net/mail/mailistviewitem.cpp
@@ -1,22 +1,23 @@
 #include "mailistviewitem.h"
 #include <libmailwrapper/abstractmail.h>
 #include <qtextstream.h>
 #include <qpe/resource.h>
+#include <qpe/timestring.h>
 
 MailListViewItem::MailListViewItem(QListView * parent, MailListViewItem * item )
         :QListViewItem(parent,item),mail_data()
 {
 }
 
 void MailListViewItem::showEntry()
 {
     if ( mail_data->getFlags().testBit( FLAG_ANSWERED ) == true) {
         setPixmap( 0, Resource::loadPixmap( "mail/kmmsgreplied") );
     } else if ( mail_data->getFlags().testBit( FLAG_SEEN ) == true )  {
-        /* I think it looks nicer if there are not such a log of icons but only on mails
+        /* I think it looks nicer if there are not such a lot of icons but only on mails
            replied or new - Alwin*/
         //setPixmap( 0, Resource::loadPixmap( "mail/kmmsgunseen") );
     } else  {
         setPixmap( 0, Resource::loadPixmap( "mail/kmmsgnew") );
     }
     double s = mail_data->Msgsize();
@@ -45,17 +46,30 @@ void MailListViewItem::showEntry()
     {
         QTextOStream o(&fsize);
         if (w>0) o.precision(2); else o.precision(0);
         o.setf(QTextStream::fixed);
         o << s << " " << q << "Byte";
     }
-
     setText(1,mail_data->getSubject());
     setText(2,mail_data->getFrom());
     setText(3,fsize);
-    setText(4,mail_data->getDate());
+    setText(4,mail_data->getStringDate());
+}
+
+QString MailListViewItem::key(int col,bool) const
+{
+    QString temp;
+    if (col == 4) {
+        temp.sprintf( "%08d",QDateTime().secsTo(mail_data->getDate()));
+        return temp;
+    }
+    if (col == 3) {
+        temp.sprintf( "%020d",mail_data->Msgsize());
+        return temp;
+    }
+    return text(col);
 }
 
 void MailListViewItem::storeData(const RecMailP&data)
 {
     mail_data = data;
 }
diff --git a/noncore/net/mail/mailistviewitem.h b/noncore/net/mail/mailistviewitem.h
index d953d83..ce64ca9 100644
--- a/noncore/net/mail/mailistviewitem.h
+++ b/noncore/net/mail/mailistviewitem.h
@@ -13,11 +13,12 @@ public:
 
     void storeData(const RecMailP&data);
     const RecMailP&data()const;
     void showEntry();
     MAILLIB::ATYPE wrapperType();
 
+    virtual QString key(int col,bool) const;
 protected:
     RecMailP mail_data;
 };
 
 #endif
diff --git a/noncore/net/mail/mainwindow.cpp b/noncore/net/mail/mainwindow.cpp
index 6252fc2..c115b32 100644
--- a/noncore/net/mail/mainwindow.cpp
+++ b/noncore/net/mail/mainwindow.cpp
@@ -100,13 +100,14 @@ MainWindow::MainWindow( QWidget *parent, const char *name, WFlags flags )
     mailView->addColumn( "" );
     mailView->addColumn( tr( "Subject" ),QListView::Manual );
     mailView->addColumn( tr( "Sender" ),QListView::Manual );
     mailView->addColumn( tr( "Size" ),QListView::Manual);
     mailView->addColumn( tr( "Date" ));
     mailView->setAllColumnsShowFocus(true);
-    mailView->setSorting(-1);
+    mailView->setShowSortIndicator(true);
+    mailView->setSorting(4,false);
 
     statusWidget = new StatusWidget( wrapperBox );
     statusWidget->hide();
 
     layout->addWidget( mailView );
     layout->setStretchFactor( folderView, 1 );
@@ -140,13 +141,13 @@ MainWindow::MainWindow( QWidget *parent, const char *name, WFlags flags )
 MainWindow::~MainWindow()
 {
 }
 
 void MainWindow::appMessage(const QCString &, const QByteArray &)
 {
-    odebug << "appMessage not reached" << oendl; 
+    odebug << "appMessage not reached" << oendl;
 }
 
 void MainWindow::slotAdjustLayout() {
 
   QWidget *d = QApplication::desktop();
 
@@ -174,38 +175,38 @@ void MainWindow::slotAdjustColumns()
 void MainWindow::slotEditSettings()
 {
 }
 
 void MainWindow::slotShowFolders( bool )
 {
-   odebug << "slotShowFolders not reached" << oendl; 
+   odebug << "slotShowFolders not reached" << oendl;
 }
 
 void MainWindow::refreshMailView(const QValueList<RecMailP>&)
 {
-   odebug << "refreshMailView not reached" << oendl; 
+   odebug << "refreshMailView not reached" << oendl;
 }
 
 void MainWindow::mailLeftClicked(int, QListViewItem *,const QPoint&,int )
 {
-    odebug << "mailLeftClicked not reached" << oendl; 
+    odebug << "mailLeftClicked not reached" << oendl;
 }
 
 void MainWindow::displayMail()
 {
-    odebug << "displayMail not reached" << oendl; 
+    odebug << "displayMail not reached" << oendl;
 }
 
 void MainWindow::slotDeleteMail()
 {
-    odebug << "deleteMail not reached" << oendl; 
+    odebug << "deleteMail not reached" << oendl;
 }
 
 void MainWindow::mailHold(int, QListViewItem *,const QPoint&,int  )
 {
-    odebug << "mailHold not reached" << oendl; 
+    odebug << "mailHold not reached" << oendl;
 }
 
 void MainWindow::slotSendQueued()
 {
 }
 
diff --git a/noncore/net/mail/viewmail.cpp b/noncore/net/mail/viewmail.cpp
index ce694d5..d5f9b7f 100644
--- a/noncore/net/mail/viewmail.cpp
+++ b/noncore/net/mail/viewmail.cpp
@@ -141,13 +141,13 @@ void ViewMail::setBody(const RecBodyP&body )
     {
         filename = "";
         type = body->Parts()[i]->Type()+"/"+body->Parts()[i]->Subtype();
         part_plist_t::ConstIterator it = body->Parts()[i]->Parameters().begin();
         for (;it!=body->Parts()[i]->Parameters().end();++it)
         {
-            odebug << it.key() << oendl; 
+            odebug << it.key() << oendl;
             if (it.key().lower()=="name")
             {
                 filename=it.data();
             }
         }
         s = body->Parts()[i]->Size();
@@ -244,13 +244,13 @@ void ViewMail::slotItemClicked( QListViewItem * item , const QPoint & point, int
                     delete content;
                 }
             }
         }
         break ;
 
-    case 2: 
+    case 2:
         {
             QString tmpfile = "/tmp/opiemail-image";
             encodedString*content = m_recMail->Wrapper()->fetchDecodedPart( m_recMail, m_body->Parts()[ ( ( AttachItem* )item )->Partnumber() ] );
             if (content) {
                 QFile output(tmpfile);
                 output.open(IO_WriteOnly);
@@ -286,13 +286,13 @@ void ViewMail::setMail(const RecMailP&mail )
 {
 
     m_recMail = mail;
 
     m_mail[0] = mail->getFrom();
     m_mail[1] = mail->getSubject();
-    m_mail[3] = mail->getDate();
+    m_mail[3] = mail->getStringDate();
     m_mail[4] = mail->Msgid();
 
     m_mail2[0] = mail->To();
     m_mail2[1] = mail->CC();
     m_mail2[2] = mail->Bcc();