author | simon <simon> | 2002-04-30 14:33:42 (UTC) |
---|---|---|
committer | simon <simon> | 2002-04-30 14:33:42 (UTC) |
commit | 85b6723c707949f5689bfca6f442d9cbb73f2ee9 (patch) (side-by-side diff) | |
tree | 20afdd73f737c35560eff022a61f9b1f3c6497e1 | |
parent | b7b0040f0a8069d36e3f5ad0bed0ce992dd30780 (diff) | |
download | opie-85b6723c707949f5689bfca6f442d9cbb73f2ee9.zip opie-85b6723c707949f5689bfca6f442d9cbb73f2ee9.tar.gz opie-85b6723c707949f5689bfca6f442d9cbb73f2ee9.tar.bz2 |
- no default args in method impls
- don't return void in non-void functions
-rw-r--r-- | noncore/apps/tableviewer/db/common.cpp | 2 | ||||
-rw-r--r-- | noncore/apps/tableviewer/db/csvsource.cpp | 1 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/commonwidgets.cpp | 6 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/tvbrowseview.cpp | 4 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/tveditview.cpp | 4 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/tvfilterview.cpp | 4 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/tvkeyedit.cpp | 4 | ||||
-rw-r--r-- | noncore/apps/tableviewer/ui/tvlistview.cpp | 4 |
8 files changed, 15 insertions, 14 deletions
diff --git a/noncore/apps/tableviewer/db/common.cpp b/noncore/apps/tableviewer/db/common.cpp index 71844a5..dbf9370 100644 --- a/noncore/apps/tableviewer/db/common.cpp +++ b/noncore/apps/tableviewer/db/common.cpp @@ -674,17 +674,17 @@ bool TVVariant::close(TVVariant n) \class Key \brief document me! document me! */ Key::Key() : kname(), kexample(), kflags(0) { } -Key::Key(QString name, TVVariant example, int flags = 0) : +Key::Key(QString name, TVVariant example, int flags) : kname(name), kexample(example), kflags(flags) { } Key::Key(const Key &other) { kname = other.kname; kexample = other.kexample; kflags = other.kflags; } diff --git a/noncore/apps/tableviewer/db/csvsource.cpp b/noncore/apps/tableviewer/db/csvsource.cpp index 2561b4b..ea36300 100644 --- a/noncore/apps/tableviewer/db/csvsource.cpp +++ b/noncore/apps/tableviewer/db/csvsource.cpp @@ -93,16 +93,17 @@ QStringList readElem(QString in) quotedElem = FALSE; /* skip till a , or end of line */ while (index < in.length() && in[index] != ',') index++; if(index == in.length()) return out; else index++; } + return out; } bool DBCsv::openSource(QIODevice *inDev) { QTextStream tsIn(inDev); QString in = tsIn.readLine().stripWhiteSpace(); QStringList keys; diff --git a/noncore/apps/tableviewer/ui/commonwidgets.cpp b/noncore/apps/tableviewer/ui/commonwidgets.cpp index bf4c36f..4c47951 100644 --- a/noncore/apps/tableviewer/ui/commonwidgets.cpp +++ b/noncore/apps/tableviewer/ui/commonwidgets.cpp @@ -23,17 +23,17 @@ #include <qlabel.h> #include <qcombobox.h> #include <qpe/datebookmonth.h> #include <qpopupmenu.h> #include <qspinbox.h> #include "commonwidgets.h" -DateEdit::DateEdit( QWidget *parent = 0, const char *name = 0, WFlags f = 0 ) +DateEdit::DateEdit( QWidget *parent, const char *name, WFlags f ) : QToolButton(parent, name) { QPopupMenu *m1 = new QPopupMenu(this); dateSelector = new DateBookMonth(m1, 0, TRUE); m1->insertItem(dateSelector); setPopup(m1); setPopupDelay(0); @@ -77,17 +77,17 @@ void DateEdit::clear() void DateEdit::subValueChanged() { QDate current = dateSelector->selectedDate(); setText(current.toString()); emit valueChanged(current); } -TimeEdit::TimeEdit( QWidget *parent = 0, const char *name = 0, WFlags f = 0 ) +TimeEdit::TimeEdit( QWidget *parent, const char *name, WFlags f ) : QWidget(parent, name, f) { QHBoxLayout *layout = new QHBoxLayout(this, 0); layout->addWidget(hourKey = new QSpinBox(1, 12, 1, this)); hourKey->setWrapping(true); hourKey->setMinimumWidth(30); hourKey->setMaximumWidth(35); @@ -185,17 +185,17 @@ void TimeEdit::clear() ampm->setCurrentItem(0); } void TimeEdit::subValueChanged() { emit valueChanged(time()); } -IntEdit::IntEdit( QWidget *parent = 0, const char *name = 0, WFlags f = 0 ) +IntEdit::IntEdit( QWidget *parent, const char *name, WFlags f ) : QSpinBox(INT_MIN, INT_MAX, 1, parent, name) { setValue(0); } IntEdit::~IntEdit() {} diff --git a/noncore/apps/tableviewer/ui/tvbrowseview.cpp b/noncore/apps/tableviewer/ui/tvbrowseview.cpp index 9bfc791..f5f2555 100644 --- a/noncore/apps/tableviewer/ui/tvbrowseview.cpp +++ b/noncore/apps/tableviewer/ui/tvbrowseview.cpp @@ -32,18 +32,18 @@ at a time, or search on a single key. Its main goal is to show a single element in a readable format and make it easy for the user to rapidly find specific elements in the table. */ /*! Constructs a new TVBrowseView widget */ -TVBrowseView::TVBrowseView(TableState *t, QWidget* parent = 0, const char *name = 0, - WFlags fl =0) +TVBrowseView::TVBrowseView(TableState *t, QWidget* parent, const char *name, + WFlags fl ) { if (!name) setName("BrowseView"); // setSizePolicy(QSizePolicy( QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding, 0, 0, sizePolicy().hasHeightForWidth() ) ); QVBoxLayout *vlayout = new QVBoxLayout(this); textViewDisplay = new QTextBrowser(this, "textViewDisplay"); vlayout->addWidget( textViewDisplay ); diff --git a/noncore/apps/tableviewer/ui/tveditview.cpp b/noncore/apps/tableviewer/ui/tveditview.cpp index ba2bd06..23e2b42 100644 --- a/noncore/apps/tableviewer/ui/tveditview.cpp +++ b/noncore/apps/tableviewer/ui/tveditview.cpp @@ -35,18 +35,18 @@ #include <qvbox.h> #include <qlineedit.h> #include <qcheckbox.h> #include <qlist.h> #include <qlabel.h> #include <qscrollview.h> #include <qsignalmapper.h> -TVEditView::TVEditView(TableState *s, DataElem *d, QWidget* parent = 0, - const char *name = 0, WFlags fl =0) : QDialog(parent, name, true, fl) +TVEditView::TVEditView(TableState *s, DataElem *d, QWidget* parent, + const char *name, WFlags fl ) : QDialog(parent, name, true, fl) { if (!name) setName("TVEditView"); QVBoxLayout *layout = new QVBoxLayout(this, 0); /* only so that will resize correctly in other widgets */ diff --git a/noncore/apps/tableviewer/ui/tvfilterview.cpp b/noncore/apps/tableviewer/ui/tvfilterview.cpp index 72d39d6..0182127 100644 --- a/noncore/apps/tableviewer/ui/tvfilterview.cpp +++ b/noncore/apps/tableviewer/ui/tvfilterview.cpp @@ -21,18 +21,18 @@ #include <qtoolbutton.h> #include <qcombobox.h> #include <qlistview.h> #include <qlayout.h> #include <qheader.h> #include <qpushbutton.h> #include <qlabel.h> -TVFilterView::TVFilterView(TableState *t, QWidget* parent = 0, - const char *name = 0, WFlags fl =0) : QDialog(parent, name, TRUE, fl) +TVFilterView::TVFilterView(TableState *t, QWidget* parent, + const char *name, WFlags fl ) : QDialog(parent, name, TRUE, fl) { if ( !name ) setName( "Filter View" ); QVBoxLayout *vlayout = new QVBoxLayout(this); display = new QListView(this, "display"); display->addColumn("Key"); diff --git a/noncore/apps/tableviewer/ui/tvkeyedit.cpp b/noncore/apps/tableviewer/ui/tvkeyedit.cpp index fb7b7fe..4849e87 100644 --- a/noncore/apps/tableviewer/ui/tvkeyedit.cpp +++ b/noncore/apps/tableviewer/ui/tvkeyedit.cpp @@ -87,18 +87,18 @@ public: } private: QString name; TVVariant::KeyType keyType; int position; }; -TVKeyEdit::TVKeyEdit(TableState *t, QWidget* parent = 0, const char *name = 0, - WFlags fl = 0) : TVKeyEdit_gen(parent, name, true, fl) +TVKeyEdit::TVKeyEdit(TableState *t, QWidget* parent, const char *name, + WFlags fl) : TVKeyEdit_gen(parent, name, true, fl) { int i; ts = t; if(!ts) return; if(!ts->kRep) return; working_state = *ts->kRep; diff --git a/noncore/apps/tableviewer/ui/tvlistview.cpp b/noncore/apps/tableviewer/ui/tvlistview.cpp index 82d67c6..b25e813 100644 --- a/noncore/apps/tableviewer/ui/tvlistview.cpp +++ b/noncore/apps/tableviewer/ui/tvlistview.cpp @@ -80,18 +80,18 @@ TVListViewItem::TVListViewItem(QListView *parent, DataElem *d) data_reference = d; } TVListViewItem::~TVListViewItem() { data_reference = 0; } -TVListView::TVListView(TableState *t, QWidget* parent = 0, - const char *name = 0, WFlags fl =0) : QWidget(parent, name, fl) +TVListView::TVListView(TableState *t, QWidget* parent, + const char *name, WFlags fl ) : QWidget(parent, name, fl) { if (!name) setName("TVListView"); // the next two lines need to be rationalized. resize(318,457); setSizePolicy(QSizePolicy((QSizePolicy::SizeType)7, (QSizePolicy::SizeType)7, sizePolicy().hasHeightForWidth())); |