A couple more return values that need to be checked.

1 files changed, 5 insertions, 1 deletions

diff --git a/core/opie-login/passworddialogimpl.cpp b/core/opie-login/passworddialogimpl.cpp
index d9132e2..3c1b474 100644
--- a/core/opie-login/passworddialogimpl.cpp
+++ b/core/opie-login/passworddialogimpl.cpp
@@ -143,49 +143,53 @@ void PasswordDialogImpl::writePassword() {
      * Now crypt the password so we can write it later
      */
     char* password = ::crypt( m_pass->text().latin1(), crypt_make_salt() );
 
     if ( !password )
         return error( tr("Password not legal" ),
                       tr("<qt>The entered password is not a valid password."
                          "Please try entering a valid password.</qt>" ) );
 
     /* rewind and rewrite the password file */
     ::setpwent();
 
     FILE* file = ::fopen( "/etc/passwd.new", "w" );
     struct passwd* pass;
     while ( (pass = ::getpwent()) != 0l ) {
         /* no  shadow password support */
         if ( pass->pw_uid == 0  )
             pass->pw_passwd = password;
 
         ::putpwent( pass, file );
     }
 
     ::fclose( file );
     ::endpwent();
-    ::rename("/etc/passwd.new","/etc/passwd" );
+    if (::rename("/etc/passwd.new","/etc/passwd" ) == -1)
+        return error( tr("Rename /etc/passwd failed"),
+                      tr("<qt>Renaming /etc/passwd.new to /etc/passwd failed."
+                         "Please check your /etc/passed file, your /etc directory "
+                         "or your filesystem.</qt>") );
 
     /* should be done now */
 #ifdef  OPIE_LOGIN_SHADOW_PW
     #error "Can't write Shadow Passwords fixme"
 #endif
 }
 
 /**
  * Raise an error. Delete input and set the focus after showing
  * the error to the user
  */
 void PasswordDialogImpl::error( const QString& caption, const QString& text ) {
     m_isSet = false;
     QMessageBox::critical(this,caption, text,
                           QMessageBox::Ok, QMessageBox::NoButton );
 
     m_pass->setText("");
     m_pass->setFocus();
 
     m_confirm->setText("");
 }
 
 void PasswordDialogImpl::slotToggleEcho( bool b ) {
     m_pass->   setEchoMode( b ? QLineEdit::Normal : QLineEdit::Password );