summaryrefslogtreecommitdiff
path: root/core/pim/todo
authoralwin <alwin>2004-03-02 14:00:39 (UTC)
committer alwin <alwin>2004-03-02 14:00:39 (UTC)
commit12dd57c04b42d4517061ed847b1aa041dd8af841 (patch) (unidiff)
treeafbd18d5b439138256d27aecec7ef993d74a0bd7 /core/pim/todo
parentac3e7c0a1ccbb984f06917ebe6156b1681b7de7f (diff)
downloadopie-12dd57c04b42d4517061ed847b1aa041dd8af841.zip
opie-12dd57c04b42d4517061ed847b1aa041dd8af841.tar.gz
opie-12dd57c04b42d4517061ed847b1aa041dd8af841.tar.bz2
fixed up todlist to work again. The segfault resulted due a real ugly code-style:
Never, realy never, use "using namespace <...>" inside a include file. Ever use "Opie::<class>" or such inside include files. Think twice, before using a "use namespace <...>" inside a c++ file. If you're using it just 3,4 times, write "Opie::<class>::<variable>" or such. If you just simple write a using namespace all the time it makes the idea of namespaces obsolete. Mostly: just integrate your OWN namespace (in that case use namespace Todo;) - but try to use all other namespaces the explicit way - so you will sure that the compiler inherits the right methods. ToDo: write this statement into the developer wiki
Diffstat (limited to 'core/pim/todo') (more/less context) (ignore whitespace changes)
-rw-r--r--core/pim/todo/mainwindow.cpp2
-rw-r--r--core/pim/todo/mainwindow.h8
-rw-r--r--core/pim/todo/quickeditimpl.cpp2
3 files changed, 5 insertions, 7 deletions
diff --git a/core/pim/todo/mainwindow.cpp b/core/pim/todo/mainwindow.cpp
index a244e58..c2f422d 100644
--- a/core/pim/todo/mainwindow.cpp
+++ b/core/pim/todo/mainwindow.cpp
@@ -61,13 +61,13 @@
61OPIE_EXPORT_APP( OApplicationFactory<Todo::MainWindow> ) 61OPIE_EXPORT_APP( OApplicationFactory<Todo::MainWindow> )
62 62
63using namespace Todo; 63using namespace Todo;
64 64
65MainWindow::MainWindow( QWidget* parent, 65MainWindow::MainWindow( QWidget* parent,
66 const char* name, WFlags ) 66 const char* name, WFlags )
67 : OPimMainWindow( "Todolist", parent, name, WType_TopLevel | WStyle_ContextHelp ) 67 : Opie::OPimMainWindow( "Todolist", parent, name, WType_TopLevel | WStyle_ContextHelp )
68{ 68{
69 if (!name) 69 if (!name)
70 setName("todo window"); 70 setName("todo window");
71 71
72 m_syncing = false; 72 m_syncing = false;
73 m_showing = false; 73 m_showing = false;
diff --git a/core/pim/todo/mainwindow.h b/core/pim/todo/mainwindow.h
index 6a7296b..b35a42b 100644
--- a/core/pim/todo/mainwindow.h
+++ b/core/pim/todo/mainwindow.h
@@ -46,23 +46,21 @@ class QMenuBar;
46class QToolBar; 46class QToolBar;
47class QAction; 47class QAction;
48class Ir; 48class Ir;
49class QVBox; 49class QVBox;
50class QLineEdit; 50class QLineEdit;
51 51
52using namespace Opie;
53
54namespace Todo { 52namespace Todo {
55 typedef TodoView View; 53 typedef TodoView View;
56 class TemplateManager; 54 class TemplateManager;
57 class Editor; 55 class Editor;
58 class TodoShow; 56 class TodoShow;
59 class TemplateEditor; 57 class TemplateEditor;
60 struct QuickEditBase; 58 struct QuickEditBase;
61 59
62 class MainWindow : public OPimMainWindow { 60 class MainWindow : public Opie::OPimMainWindow {
63 Q_OBJECT 61 Q_OBJECT
64 friend class TodoView; // avoid QObject here.... 62 friend class TodoView; // avoid QObject here....
65 friend class TodoShow; // avoid QObject 63 friend class TodoShow; // avoid QObject
66 public: 64 public:
67 /* OApplicationFactory application Name */ 65 /* OApplicationFactory application Name */
68 static QString appName() { return QString::fromLatin1("todolist"); } 66 static QString appName() { return QString::fromLatin1("todolist"); }
@@ -141,13 +139,13 @@ private slots:
141 *m_deleteAllAction, 139 *m_deleteAllAction,
142 *m_deleteCompleteAction, 140 *m_deleteCompleteAction,
143 *m_duplicateAction, 141 *m_duplicateAction,
144 *m_showOverDueAction, 142 *m_showOverDueAction,
145 *m_showQuickTaskAction, 143 *m_showQuickTaskAction,
146 *m_effectiveAction; 144 *m_effectiveAction;
147 OWidgetStack *m_stack; 145 Opie::OWidgetStack *m_stack;
148 QPopupMenu* m_catMenu, 146 QPopupMenu* m_catMenu,
149 *m_edit, 147 *m_edit,
150 *m_options, 148 *m_options,
151 *m_template; 149 *m_template;
152 150
153 bool m_syncing:1; 151 bool m_syncing:1;
@@ -202,12 +200,12 @@ private slots:
202 void reload(); 200 void reload();
203 int create(); 201 int create();
204 bool remove( int uid ); 202 bool remove( int uid );
205 void beam(int uid); 203 void beam(int uid);
206 void show( int uid ); 204 void show( int uid );
207 void edit( int uid ); 205 void edit( int uid );
208 void add( const OPimRecord& ); 206 void add( const Opie::OPimRecord& );
209 void doAlarm( const QDateTime& dt, int uid ); 207 void doAlarm( const QDateTime& dt, int uid );
210 }; 208 };
211} 209}
212 210
213#endif 211#endif
diff --git a/core/pim/todo/quickeditimpl.cpp b/core/pim/todo/quickeditimpl.cpp
index cd0684f..94ae97e 100644
--- a/core/pim/todo/quickeditimpl.cpp
+++ b/core/pim/todo/quickeditimpl.cpp
@@ -18,13 +18,13 @@ QuickEditImpl::QuickEditImpl( QWidget* parent, bool visible )
18 // TODO - probably should be done globally somewhere else, 18 // TODO - probably should be done globally somewhere else,
19 // see also tableview.cpp/h, taskeditoroverview.cpp/h 19 // see also tableview.cpp/h, taskeditoroverview.cpp/h
20 priority1 = Resource::loadPixmap( "todo/priority1" ); 20 priority1 = Resource::loadPixmap( "todo/priority1" );
21 priority3 = Resource::loadPixmap( "todo/priority3" ); 21 priority3 = Resource::loadPixmap( "todo/priority3" );
22 priority5 = Resource::loadPixmap( "todo/priority5" ); 22 priority5 = Resource::loadPixmap( "todo/priority5" );
23 23
24 m_lbl = new OClickableLabel( this ); 24 m_lbl = new Opie::OClickableLabel( this );
25 m_lbl->setMinimumWidth( 15 ); 25 m_lbl->setMinimumWidth( 15 );
26 m_lbl->setPixmap( priority3 ); 26 m_lbl->setPixmap( priority3 );
27 connect(m_lbl, SIGNAL(clicked() ), this, SLOT(slotPrio()) ); 27 connect(m_lbl, SIGNAL(clicked() ), this, SLOT(slotPrio()) );
28 QWhatsThis::add( m_lbl, QWidget::tr( "Click here to set the priority of new task.\n\nThis area is called the quick task bar.\n\nIt allows you to quickly add a new task to your list. This area can be shown or hidden by selecting Options->'Show quick task bar' from the menu above." ) ); 28 QWhatsThis::add( m_lbl, QWidget::tr( "Click here to set the priority of new task.\n\nThis area is called the quick task bar.\n\nIt allows you to quickly add a new task to your list. This area can be shown or hidden by selecting Options->'Show quick task bar' from the menu above." ) );
29 29
30 m_edit = new QLineEdit( this ); 30 m_edit = new QLineEdit( this );