author | zecke <zecke> | 2002-04-13 19:58:17 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-04-13 19:58:17 (UTC) |
commit | 244495af9bd629fe565b5c753d066cc4fde684ae (patch) (unidiff) | |
tree | 8f20084c688b627223a431f02875703418e6d999 /core/pim | |
parent | 84f5e0817231fa3721c781b0538659f5a7149349 (diff) | |
download | opie-244495af9bd629fe565b5c753d066cc4fde684ae.zip opie-244495af9bd629fe565b5c753d066cc4fde684ae.tar.gz opie-244495af9bd629fe565b5c753d066cc4fde684ae.tar.bz2 |
Fix Stefan Eilers patch
Extend the due column
better sorting
and colors ;)
-rw-r--r-- | core/pim/todo/mainwindow.cpp | 4 | ||||
-rw-r--r-- | core/pim/todo/todotable.cpp | 96 | ||||
-rw-r--r-- | core/pim/todo/todotable.h | 39 |
3 files changed, 84 insertions, 55 deletions
diff --git a/core/pim/todo/mainwindow.cpp b/core/pim/todo/mainwindow.cpp index 33f13aa..a34bcf2 100644 --- a/core/pim/todo/mainwindow.cpp +++ b/core/pim/todo/mainwindow.cpp | |||
@@ -110,7 +110,6 @@ TodoWindow::TodoWindow( QWidget *parent, const char *name, WFlags f = 0 ) : | |||
110 | bool complete = config.readBoolEntry( "ShowComplete", true ); | 110 | bool complete = config.readBoolEntry( "ShowComplete", true ); |
111 | table->setShowCompleted( complete ); | 111 | table->setShowCompleted( complete ); |
112 | 112 | ||
113 | /* added 20.01.2k2 by se */ | ||
114 | bool showdeadline = config.readBoolEntry("ShowDeadLine", true); | 113 | bool showdeadline = config.readBoolEntry("ShowDeadLine", true); |
115 | table->setShowDeadline (showdeadline); | 114 | table->setShowDeadline (showdeadline); |
116 | 115 | ||
@@ -181,7 +180,6 @@ TodoWindow::TodoWindow( QWidget *parent, const char *name, WFlags f = 0 ) : | |||
181 | 180 | ||
182 | completedAction = new QAction( QString::null, tr("Completed tasks"), 0, this, 0, TRUE ); | 181 | completedAction = new QAction( QString::null, tr("Completed tasks"), 0, this, 0, TRUE ); |
183 | 182 | ||
184 | /* added 20.01.2k2 by se */ | ||
185 | showdeadlineAction = new QAction( QString::null, tr( "Show Deadline" ), 0, this, 0, TRUE ); | 183 | showdeadlineAction = new QAction( QString::null, tr( "Show Deadline" ), 0, this, 0, TRUE ); |
186 | 184 | ||
187 | catMenu->setCheckable( true ); | 185 | catMenu->setCheckable( true ); |
@@ -364,7 +362,7 @@ void TodoWindow::populateCategories() | |||
364 | completedAction->setOn( table->showCompleted() ); | 362 | completedAction->setOn( table->showCompleted() ); |
365 | showdeadlineAction->addTo( catMenu ); | 363 | showdeadlineAction->addTo( catMenu ); |
366 | showdeadlineAction->setOn( table->showDeadline() ); | 364 | showdeadlineAction->setOn( table->showDeadline() ); |
367 | 365 | catMenu->insertSeparator(); | |
368 | int id, rememberId; | 366 | int id, rememberId; |
369 | id = 1; | 367 | id = 1; |
370 | catMenu->insertItem( tr( "All Categories" ), id++ ); | 368 | catMenu->insertItem( tr( "All Categories" ), id++ ); |
diff --git a/core/pim/todo/todotable.cpp b/core/pim/todo/todotable.cpp index 3cd0c0e..2acd03c 100644 --- a/core/pim/todo/todotable.cpp +++ b/core/pim/todo/todotable.cpp | |||
@@ -160,9 +160,57 @@ QString ComboItem::text() const | |||
160 | return cb->currentText(); | 160 | return cb->currentText(); |
161 | return QTableItem::text(); | 161 | return QTableItem::text(); |
162 | } | 162 | } |
163 | 163 | DueTextItem::DueTextItem( QTable *t, ToDoEvent *ev ) | |
164 | 164 | : QTableItem(t, Never, QString::null ) | |
165 | 165 | { | |
166 | setToDoEvent( ev ); | ||
167 | } | ||
168 | QString DueTextItem::key() const | ||
169 | { | ||
170 | QString key; | ||
171 | if( m_hasDate ){ | ||
172 | if(m_off == 0 ){ | ||
173 | key.append("b"); | ||
174 | }else if( m_off > 0 ){ | ||
175 | key.append("c"); | ||
176 | }else if( m_off < 0 ){ | ||
177 | key.append("a"); | ||
178 | } | ||
179 | key.append(QString::number(m_off ) ); | ||
180 | }else{ | ||
181 | key.append("d"); | ||
182 | } | ||
183 | return key; | ||
184 | } | ||
185 | void DueTextItem::setToDoEvent( const ToDoEvent *ev ) | ||
186 | { | ||
187 | m_hasDate = ev->hasDate(); | ||
188 | m_completed = ev->isCompleted(); | ||
189 | if( ev->hasDate() ){ | ||
190 | QDate today = QDate::currentDate(); | ||
191 | m_off = today.daysTo(ev->date() ); | ||
192 | setText( QString::number(m_off) + " day(s) " ); | ||
193 | }else{ | ||
194 | setText("n.d." ); | ||
195 | m_off = 0; | ||
196 | } | ||
197 | } | ||
198 | void DueTextItem::paint( QPainter *p, const QColorGroup &cg, const QRect &cr, bool selected ) | ||
199 | { | ||
200 | QColorGroup cg2(cg); | ||
201 | QColor text = cg.text(); | ||
202 | if( m_hasDate && !m_completed ){ | ||
203 | if( m_off < 0 ){ | ||
204 | cg2.setColor(QColorGroup::Text, QColor(red ) ); | ||
205 | }else if( m_off == 0 ){ | ||
206 | cg2.setColor(QColorGroup::Text, QColor(yellow) ); // orange isn't predefined | ||
207 | }else if( m_off > 0){ | ||
208 | cg2.setColor(QColorGroup::Text, QColor(green ) ); | ||
209 | } | ||
210 | } | ||
211 | QTableItem::paint(p, cg2, cr, selected ); | ||
212 | cg2.setColor(QColorGroup::Text, text ); | ||
213 | } | ||
166 | TodoTable::TodoTable( QWidget *parent, const char *name ) | 214 | TodoTable::TodoTable( QWidget *parent, const char *name ) |
167 | // #ifdef QT_QTABLE_NOHEADER_CONSTRUCTOR | 215 | // #ifdef QT_QTABLE_NOHEADER_CONSTRUCTOR |
168 | // : QTable( 0, 3, parent, name, TRUE ), | 216 | // : QTable( 0, 3, parent, name, TRUE ), |
@@ -247,13 +295,13 @@ void TodoTable::slotClicked( int row, int col, int, const QPoint &pos ) | |||
247 | break; | 295 | break; |
248 | case 2: | 296 | case 2: |
249 | // may as well edit it... | 297 | // may as well edit it... |
250 | menuTimer->stop(); | 298 | // menuTimer->stop(); |
251 | // emit signalEdit(); | 299 | // emit signalEdit(); |
252 | break; | 300 | // fall through |
253 | case 3: /* added 20.01.2k2 by se */ | 301 | case 3: |
254 | // may as well edit it... | 302 | // may as well edit it... |
255 | menuTimer->stop(); | 303 | menuTimer->stop(); |
256 | emit signalEdit(); | 304 | // emit signalEdit(); |
257 | break; | 305 | break; |
258 | } | 306 | } |
259 | } | 307 | } |
@@ -368,6 +416,7 @@ void TodoTable::load( const QString &fn ) | |||
368 | // QTable::sortColumn(1,TRUE,TRUE); | 416 | // QTable::sortColumn(1,TRUE,TRUE); |
369 | QTable::sortColumn(0,TRUE,TRUE); | 417 | QTable::sortColumn(0,TRUE,TRUE); |
370 | setCurrentCell( 0, 2 ); | 418 | setCurrentCell( 0, 2 ); |
419 | setSorting(true ); | ||
371 | } | 420 | } |
372 | 421 | ||
373 | void TodoTable::updateVisible() | 422 | void TodoTable::updateVisible() |
@@ -375,9 +424,6 @@ void TodoTable::updateVisible() | |||
375 | if ( !isUpdatesEnabled() ) | 424 | if ( !isUpdatesEnabled() ) |
376 | return; | 425 | return; |
377 | 426 | ||
378 | // qDebug("--> updateVisible!"); | ||
379 | |||
380 | /* added 20.01.2k2 by se */ | ||
381 | if (showDeadl){ | 427 | if (showDeadl){ |
382 | showColumn (3); | 428 | showColumn (3); |
383 | adjustColumn(3); | 429 | adjustColumn(3); |
@@ -400,7 +446,7 @@ void TodoTable::updateVisible() | |||
400 | if ( vlCats.count() > 0 ) | 446 | if ( vlCats.count() > 0 ) |
401 | hide = true; | 447 | hide = true; |
402 | } else { | 448 | } else { |
403 | // do some comparing, we have to reverse our idea here... | 449 | // do some comparing, we have to reverse our idea here... which idea - zecke |
404 | if ( !hide ) { | 450 | if ( !hide ) { |
405 | hide = true; | 451 | hide = true; |
406 | for ( uint it = 0; it < vlCats.count(); ++it ) { | 452 | for ( uint it = 0; it < vlCats.count(); ++it ) { |
@@ -466,13 +512,13 @@ void TodoTable::clear() | |||
466 | setNumRows( 0 ); | 512 | setNumRows( 0 ); |
467 | } | 513 | } |
468 | 514 | ||
469 | void TodoTable::sortColumn( int col, bool /*ascending*/, bool /*wholeRows*/ ) | 515 | void TodoTable::sortColumn( int col, bool ascending, bool /*wholeRows*/ ) |
470 | { | 516 | { |
471 | // The default for wholeRows is false, however | 517 | // The default for wholeRows is false, however |
472 | // for this todo table we want to exchange complete | 518 | // for this todo table we want to exchange complete |
473 | // rows when sorting. Also, we always want ascending, since | 519 | // rows when sorting. Also, we always want ascending, since |
474 | // the values have a logical order. | 520 | // the values have a logical order. |
475 | QTable::sortColumn( col, TRUE, TRUE ); | 521 | QTable::sortColumn( col, ascending, TRUE ); |
476 | updateVisible(); | 522 | updateVisible(); |
477 | } | 523 | } |
478 | 524 | ||
@@ -497,7 +543,7 @@ void TodoTable::updateJournal( const ToDoEvent &/*todo*/, journal_action action, | |||
497 | buf = "<Task"; | 543 | buf = "<Task"; |
498 | // todo.save( buf ); | 544 | // todo.save( buf ); |
499 | buf += " Action=\"" + QString::number( int(action) ) + "\""; | 545 | buf += " Action=\"" + QString::number( int(action) ) + "\""; |
500 | buf += " Row=\"" + QString::number( row ) + "\""; | 546 | buf += " Row=\"" + QString::number( row ) + "\""; // better write the id |
501 | buf += "/>\n"; | 547 | buf += "/>\n"; |
502 | str = buf.utf8(); | 548 | str = buf.utf8(); |
503 | f.writeBlock( str.data(), str.length() ); | 549 | f.writeBlock( str.data(), str.length() ); |
@@ -541,17 +587,8 @@ void TodoTable::journalFreeReplaceEntry( const ToDoEvent &todo, int row ) | |||
541 | static_cast<ComboItem*>(item(row, 1))->setText( QString::number(todo.priority()) ); | 587 | static_cast<ComboItem*>(item(row, 1))->setText( QString::number(todo.priority()) ); |
542 | item( row, 2 )->setText( strTodo ); | 588 | item( row, 2 )->setText( strTodo ); |
543 | 589 | ||
544 | /* added 20.01.2k2 by se */ | ||
545 | if (showDeadl){ | 590 | if (showDeadl){ |
546 | if (todo.hasDate()){ | 591 | static_cast<DueTextItem*>(item(row,3))->setToDoEvent(&todo ); |
547 | QDate *today = new QDate (QDate::currentDate()); | ||
548 | if (today){ | ||
549 | item (row, 3)->setText (tr ("%1").arg(today->daysTo(todo.date()))); | ||
550 | delete (today); | ||
551 | } | ||
552 | }else{ | ||
553 | item (row, 3)->setText ("n.d."); | ||
554 | } | ||
555 | } | 592 | } |
556 | 593 | ||
557 | *(*it) = todo; | 594 | *(*it) = todo; |
@@ -565,17 +602,8 @@ void TodoTable::journalFreeReplaceEntry( const ToDoEvent &todo, int row ) | |||
565 | static_cast<ComboItem*>(item(row, 1))->setText( QString::number(todo.priority()) ); | 602 | static_cast<ComboItem*>(item(row, 1))->setText( QString::number(todo.priority()) ); |
566 | item( row, 2 )->setText( strTodo ); | 603 | item( row, 2 )->setText( strTodo ); |
567 | 604 | ||
568 | /* added 20.01.2k2 by se */ | ||
569 | if (showDeadl){ | 605 | if (showDeadl){ |
570 | if (todo.hasDate()){ | 606 | static_cast<DueTextItem*>(item(row,3))->setToDoEvent(&todo ); |
571 | QDate *today = new QDate (QDate::currentDate()); | ||
572 | if (today){ | ||
573 | item (row, 3)->setText (tr ("%1").arg(today->daysTo(todo.date()))); | ||
574 | delete (today); | ||
575 | } | ||
576 | }else{ | ||
577 | item (row, 3)->setText ("n.d."); | ||
578 | } | ||
579 | } | 607 | } |
580 | 608 | ||
581 | todoList.insert( static_cast<CheckItem*>(item(row,0)), new ToDoEvent(todo) ); | 609 | todoList.insert( static_cast<CheckItem*>(item(row,0)), new ToDoEvent(todo) ); |
diff --git a/core/pim/todo/todotable.h b/core/pim/todo/todotable.h index 288ff90..32df514 100644 --- a/core/pim/todo/todotable.h +++ b/core/pim/todo/todotable.h | |||
@@ -77,6 +77,19 @@ public: | |||
77 | QString key () const { return Qtopia::buildSortKey( text() ); } | 77 | QString key () const { return Qtopia::buildSortKey( text() ); } |
78 | }; | 78 | }; |
79 | 79 | ||
80 | class DueTextItem : public QTableItem | ||
81 | { | ||
82 | public: | ||
83 | DueTextItem( QTable *t, ToDoEvent *ev ); | ||
84 | QString key() const; | ||
85 | void setToDoEvent( const ToDoEvent *ev ); | ||
86 | void paint( QPainter *p, const QColorGroup &cg, const QRect &cr, bool selected ); | ||
87 | private: | ||
88 | int m_off; | ||
89 | bool m_hasDate:1; | ||
90 | bool m_completed:1; | ||
91 | |||
92 | }; | ||
80 | 93 | ||
81 | 94 | ||
82 | enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; | 95 | enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; |
@@ -98,7 +111,6 @@ public: | |||
98 | void setShowCompleted( bool sc ) { showComp = sc; updateVisible(); } | 111 | void setShowCompleted( bool sc ) { showComp = sc; updateVisible(); } |
99 | bool showCompleted() const { return showComp; } | 112 | bool showCompleted() const { return showComp; } |
100 | 113 | ||
101 | /* added 20.01.2k2 by se */ | ||
102 | void setShowDeadline (bool sd) {showDeadl = sd; updateVisible();} | 114 | void setShowDeadline (bool sd) {showDeadl = sd; updateVisible();} |
103 | bool showDeadline() const { return showDeadl;} | 115 | bool showDeadline() const { return showDeadl;} |
104 | 116 | ||
@@ -163,9 +175,7 @@ private: | |||
163 | bool enablePainting; | 175 | bool enablePainting; |
164 | Categories mCat; | 176 | Categories mCat; |
165 | int currFindRow; | 177 | int currFindRow; |
166 | 178 | bool showDeadl:1; | |
167 | /* added 20.01.2k2 by se */ | ||
168 | bool showDeadl; | ||
169 | }; | 179 | }; |
170 | 180 | ||
171 | 181 | ||
@@ -181,19 +191,8 @@ inline void TodoTable::insertIntoTable( ToDoEvent *todo, int row ) | |||
181 | QTableItem *ti = new TodoTextItem( this, todo->description().left(40).simplifyWhiteSpace() ); | 191 | QTableItem *ti = new TodoTextItem( this, todo->description().left(40).simplifyWhiteSpace() ); |
182 | ti->setReplaceable( false ); | 192 | ti->setReplaceable( false ); |
183 | 193 | ||
184 | /* added 20.01.2k2 by se */ | 194 | DueTextItem *due = new DueTextItem(this, todo ); |
185 | QTableItem *dl = NULL; | 195 | setItem( row, 3, due); |
186 | if (todo->hasDate()){ | ||
187 | QDate *today = new QDate (QDate::currentDate()); | ||
188 | if (today){ | ||
189 | dl = new TodoTextItem (this, tr ("%1"). | ||
190 | arg(today->daysTo(todo->date()))); | ||
191 | delete (today); | ||
192 | } | ||
193 | }else{ | ||
194 | dl = new TodoTextItem (this,"n.d."); | ||
195 | } | ||
196 | setItem( row, 3, dl); | ||
197 | 196 | ||
198 | setItem( row, 0, chk ); | 197 | setItem( row, 0, chk ); |
199 | setItem( row, 1, cmb ); | 198 | setItem( row, 1, cmb ); |
@@ -207,7 +206,8 @@ inline void TodoTable::realignTable( int row ) | |||
207 | { | 206 | { |
208 | QTableItem *ti1, | 207 | QTableItem *ti1, |
209 | *ti2, | 208 | *ti2, |
210 | *ti3; | 209 | *ti3, |
210 | *ti4; | ||
211 | int totalRows = numRows(); | 211 | int totalRows = numRows(); |
212 | for ( int curr = row; curr < totalRows - 1; curr++ ) { | 212 | for ( int curr = row; curr < totalRows - 1; curr++ ) { |
213 | // this is bad, we must take the item out and then | 213 | // this is bad, we must take the item out and then |
@@ -217,12 +217,15 @@ inline void TodoTable::realignTable( int row ) | |||
217 | ti1 = item( curr + 1, 0 ); | 217 | ti1 = item( curr + 1, 0 ); |
218 | ti2 = item( curr + 1, 1 ); | 218 | ti2 = item( curr + 1, 1 ); |
219 | ti3 = item( curr + 1, 2 ); | 219 | ti3 = item( curr + 1, 2 ); |
220 | ti4 = item( curr + 1, 3 ); | ||
220 | takeItem( ti1 ); | 221 | takeItem( ti1 ); |
221 | takeItem( ti2 ); | 222 | takeItem( ti2 ); |
222 | takeItem( ti3 ); | 223 | takeItem( ti3 ); |
224 | takeItem( ti4 ); | ||
223 | setItem( curr, 0, ti1 ); | 225 | setItem( curr, 0, ti1 ); |
224 | setItem( curr, 1, ti2 ); | 226 | setItem( curr, 1, ti2 ); |
225 | setItem( curr, 2, ti3 ); | 227 | setItem( curr, 2, ti3 ); |
228 | setItem( curr, 3, ti4 ); | ||
226 | } | 229 | } |
227 | setNumRows( totalRows - 1 ); | 230 | setNumRows( totalRows - 1 ); |
228 | } | 231 | } |