- Completly reworked the backlight "preview":

every slider/control that relates to backlight levels, is now switching the
lcd to this level for 2 seconds - after that the backlight switches back to
the standard level (or light sensor control)

- Many bugfixes and usability improvements in light sensor calibration

1 files changed, 31 insertions, 24 deletions

diff --git a/core/settings/light-and-power/light.cpp b/core/settings/light-and-power/light.cpp
index c0ba60b..21377b7 100644
--- a/core/settings/light-and-power/light.cpp
+++ b/core/settings/light-and-power/light.cpp
@@ -27,5 +27,5 @@
 */
 
-#include "settings.h"
+#include "light.h"
 
 #include <qpe/config.h>
@@ -39,4 +39,5 @@
 #include <qtabwidget.h>
 #include <qslider.h>
+#include <qtimer.h>
 #include <qspinbox.h>
 #include <qpushbutton.h>
@@ -49,5 +50,5 @@ using namespace Opie;
 
 LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
-        : LightSettingsBase( parent, name, true, WStyle_ContextHelp )
+        : LightSettingsBase( parent, name, false, WStyle_ContextHelp )
 {
         m_res = ODevice::inst ( )-> displayBrightnessResolution ( );
@@ -64,6 +65,6 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
 
         // battery spinboxes
-        interval_dim->      setValue ( config. readNumEntry ( "Dim", 20 ));
-        interval_lightoff-> setValue ( config. readNumEntry ( "LightOff", 30 ));
+        interval_dim->      setValue ( config. readNumEntry ( "Dim", 30 ));
+        interval_lightoff-> setValue ( config. readNumEntry ( "LightOff", 20 ));
         interval_suspend->  setValue ( config. readNumEntry ( "Suspend", 60 ));
 
@@ -71,5 +72,5 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
         LcdOffOnly-> setChecked ( config. readBoolEntry ( "LcdOffOnly", false ));
 
-        int bright = config. readNumEntry ( "Brightness", 255 );
+        int bright = config. readNumEntry ( "Brightness", 127 );
         brightness-> setMaxValue ( m_res - 1 );
         brightness-> setTickInterval ( QMAX( 1, m_res / 16 ));
@@ -85,7 +86,7 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
         
         // ac spinboxes
-        interval_dim_ac_3->      setValue ( config. readNumEntry ( "Dim", 20 ));
-        interval_lightoff_ac_3-> setValue ( config. readNumEntry ( "LightOff", 30 ));
-        interval_suspend_ac_3->  setValue ( config. readNumEntry ( "Suspend", 60 ));
+        interval_dim_ac_3->      setValue ( config. readNumEntry ( "Dim", 60 ));
+        interval_lightoff_ac_3-> setValue ( config. readNumEntry ( "LightOff", 120 ));
+        interval_suspend_ac_3->  setValue ( config. readNumEntry ( "Suspend", 0 ));
 
         // ac check and slider
@@ -109,12 +110,16 @@ LightSettings::LightSettings( QWidget* parent,  const char* name, WFlags )
         criticalSpinBox-> setValue ( config. readNumEntry ( "powercritical", 5 ) );
 
+        m_resettimer = new QTimer ( this );
+        connect ( m_resettimer, SIGNAL( timeout ( )), this, SLOT( resetBacklight ( )));
+
         if ( PowerStatusManager::readStatus ( ). acStatus ( ) != PowerStatus::Online ) {
-                connect ( brightness, SIGNAL( valueChanged ( int )), this, SLOT( setBacklight ( int )));
                         tabs-> setCurrentPage ( 0 );    
         }
         else {
-                connect ( brightness_ac_3, SIGNAL( valueChanged ( int )), this, SLOT( setBacklight ( int )));
                 tabs-> setCurrentPage ( 1 );
         }
+        
+        connect ( brightness, SIGNAL( valueChanged ( int )), this, SLOT( setBacklight ( int )));
+        connect ( brightness_ac_3, SIGNAL( valueChanged ( int )), this, SLOT( setBacklight ( int )));
 }
 
@@ -123,8 +128,8 @@ LightSettings::~LightSettings ( )
 }
 
-
 void LightSettings::calibrateSensor ( )
 {
         Sensor *s = new Sensor ( m_sensordata, this );
+        connect ( s, SIGNAL( viewBacklight ( int )), this, SLOT( setBacklight ( int )));
         s-> showMaximized ( );
         s-> exec ( );
@@ -135,4 +140,5 @@ void LightSettings::calibrateSensorAC ( )
 {
         Sensor *s = new Sensor ( m_sensordata_ac, this );
+        connect ( s, SIGNAL( viewBacklight ( int )), this, SLOT( setBacklight ( int )));
         s-> showMaximized ( );
         s-> exec ( );
@@ -142,16 +148,19 @@ void LightSettings::calibrateSensorAC ( )
 void LightSettings::setBacklight ( int bright )
 {
+        if ( bright >= 0 )
         bright = bright * 255 / ( m_res - 1 );
+        
         QCopEnvelope e ( "QPE/System", "setBacklight(int)" );
         e << bright;
+        
+        if ( bright != -1 ) {
+                m_resettimer-> stop ( );
+                m_resettimer-> start ( 2000, true );
+                }
 }
 
-void LightSettings::reject ( )
+void LightSettings::resetBacklight ( )
 {
-        {
-                QCopEnvelope e ( "QPE/System", "setBacklight(int)" );
-                e << -1;
-        }
-        QDialog::reject ( );
+        setBacklight ( -1 );
 }
 
@@ -201,15 +210,13 @@ void LightSettings::accept ( )
                 e << -1;
         }
-        {
-                QCopEnvelope e ( "QPE/System", "setBacklight(int)" );
-                e << -1;
-        }
-        
-        QDialog::accept ( );
+        LightSettingsBase::accept ( );
 }
 
 void LightSettings::done ( int r )
 {
-        QDialog::done ( r );
+        m_resettimer-> stop ( );
+        resetBacklight ( );
+        
+        LightSettingsBase::done ( r );
         close ( );
 }