- no default arguments in method implementations

- don't return void in non-void functions

1 files changed, 4 insertions, 3 deletions

diff --git a/core/pim/addressbook/contacteditor.cpp b/core/pim/addressbook/contacteditor.cpp
index adea1a1..e74da87 100644
--- a/core/pim/addressbook/contacteditor.cpp
+++ b/core/pim/addressbook/contacteditor.cpp
@@ -49,15 +49,15 @@ void parseEmailFrom( const QString &txt, QString &strDefaultEmail,
 void parseEmailTo( const QString &strDefaultEmail,
                    const QString &strOtherEmail, QString &strBack );
 
         ContactEditor::ContactEditor(const Contact &entry,
                                 const QValueList<int> *newOrderedValues,
                                 QStringList *slNewOrdered,
-                                QWidget *parent = 0,
-                                const char *name = 0,
-                                WFlags fl = 0 )
+                                QWidget *parent,
+                                const char *name,
+                                WFlags fl )
         : QDialog( parent, name, TRUE, fl ),
           orderedValues( newOrderedValues ),
           slOrdered( slNewOrdered )
 {
         
         init();
@@ -1122,12 +1122,13 @@ QString ContactEditor::parseName( const QString fullName, int type ) {
                         return strLastName;
 
                 case NAME_S:
                         return strSuffix;
 
         }
+        return QString::null;
 }
 
 void ContactEditor::cleanupFields() {
 
         QStringList::Iterator it = slChooserValues->begin();
         for ( int i = 0; it != slChooserValues->end(); i++, ++it ) {