Merging all changes from BRANCH_1_0.

1 files changed, 39 insertions, 17 deletions

diff --git a/libopie/orecurrancewidget.cpp b/libopie/orecurrancewidget.cpp
index 471249d..be8ec30 100644
--- a/libopie/orecurrancewidget.cpp
+++ b/libopie/orecurrancewidget.cpp
@@ -10,15 +10,32 @@
 // Global Templates for use in setting up the repeat label...
-const QString strDayTemplate = QObject::tr("Every");
-const QString strYearTemplate = QObject::tr("%1 %2 every ");
-const QString strMonthDateTemplate = QObject::tr("The %1 every ");
-const QString strMonthDayTemplate = QObject::tr("The %1 %1 of every");
-const QString strWeekTemplate = QObject::tr("Every ");
-const QString dayLabel[] = { QObject::tr("Monday"),
-                             QObject::tr("Tuesday"),
-                             QObject::tr("Wednesday"),
-                             QObject::tr("Thursday"),
-                             QObject::tr("Friday"),
-                             QObject::tr("Saturday"),
-                             QObject::tr("Sunday") };
+// the problem is these strings get initialized before QPEApplication can install the translator -zecke
+namespace {
+QString strDayTemplate;
+QString strYearTemplate;
+QString strMonthDateTemplate;
+QString strMonthDayTemplate;
+QString strWeekTemplate;
+QString dayLabel[7];
+}
 
+/*
+ * static linkage to not polute the symbol table...
+ * The problem is that const and static linkage are resolved prior to installing a translator
+ * leading to that the above strings are translted but to the original we delay the init of these strings...
+ * -zecke
+ */
+static void fillStrings() {
+    strDayTemplate = QObject::tr("Every");
+    strYearTemplate = QObject::tr("%1 %2 every ");
+    strMonthDateTemplate = QObject::tr("The %1 every ");
+    strMonthDayTemplate = QObject::tr("The %1 %2 of every");
+    strWeekTemplate = QObject::tr("Every ");
+    dayLabel[0] = QObject::tr("Monday");
+    dayLabel[1] = QObject::tr("Tuesday");
+    dayLabel[2] = QObject::tr("Wednesday");
+    dayLabel[3] = QObject::tr("Thursday");
+    dayLabel[4] = QObject::tr("Friday");
+    dayLabel[5] = QObject::tr("Saturday");
+    dayLabel[6] = QObject::tr("Sunday");
+}
 
@@ -48,2 +65,5 @@ ORecurranceWidget::ORecurranceWidget( bool startOnMonday,
 {
+     if (strDayTemplate.isEmpty() )
+        fillStrings();
+
     init();
@@ -73,2 +93,4 @@ ORecurranceWidget::ORecurranceWidget( bool startOnMonday,
 {
+     if (strDayTemplate.isEmpty() )
+        fillStrings();
     // do some stuff with the repeat pattern
@@ -86,3 +108,2 @@ ORecurranceWidget::~ORecurranceWidget() {
 void ORecurranceWidget::setStartDate( const QDate& date ) {
-    qWarning("ORecurranceWidget::setStartDate");
     setRecurrence( recurrence(), date );
@@ -369,3 +390,4 @@ void ORecurranceWidget::slotWeekLabel() {
     }
-    str = str.prepend( "on " );
+    str = str.prepend( tr("on ") );
+
     lblWeekVar->setText( str );
@@ -377,6 +399,6 @@ void ORecurranceWidget::slotMonthLabel(int type) {
     if ( type == 1 )
-        str = strMonthDateTemplate.arg( numberPlacing(start.day()) );
+                str = strMonthDateTemplate.arg( numberPlacing(start.day()) );
     else
-        str = strMonthDayTemplate.arg( numberPlacing(week(start)))
-              .arg( dayLabel[start.dayOfWeek() - 1] );
+                str = strMonthDayTemplate.arg( numberPlacing(week(start)))
+                          .arg( dayLabel[start.dayOfWeek() - 1] );
     lblRepeat->setText( str );