author | zecke <zecke> | 2002-09-28 13:30:31 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-09-28 13:30:31 (UTC) |
commit | 93f90487bf9d2b8937a4933aef2ee472b5cdc89c (patch) (side-by-side diff) | |
tree | e9bf4c608df27ab241c4ad293111cd291bd485b8 /libopie/pim/otodoaccessxml.cpp | |
parent | 8a95ca149ff5eedc9215bb012c8d7d09cdcaf96c (diff) | |
download | opie-93f90487bf9d2b8937a4933aef2ee472b5cdc89c.zip opie-93f90487bf9d2b8937a4933aef2ee472b5cdc89c.tar.gz opie-93f90487bf9d2b8937a4933aef2ee472b5cdc89c.tar.bz2 |
remove debug output
move from Opie::XMLElement to custom parser
this cuts down loading 10.000 items from 22 seconds
to 4 seconds
Diffstat (limited to 'libopie/pim/otodoaccessxml.cpp') (more/less context) (show whitespace changes)
-rw-r--r-- | libopie/pim/otodoaccessxml.cpp | 138 |
1 files changed, 87 insertions, 51 deletions
diff --git a/libopie/pim/otodoaccessxml.cpp b/libopie/pim/otodoaccessxml.cpp index 692483e..31822d4 100644 --- a/libopie/pim/otodoaccessxml.cpp +++ b/libopie/pim/otodoaccessxml.cpp @@ -43,42 +43,85 @@ bool OTodoAccessXML::load() { dict.insert("Progress" , new int(OTodo::Progress) ); dict.insert("Completed", new int(OTodo::Completed) ); dict.insert("CrossReference", new int(OTodo::CrossReference) ); dict.insert("HasAlarmDateTime",new int(OTodo::HasAlarmDateTime) ); dict.insert("AlarmDateTime", new int(OTodo::AlarmDateTime) ); - Opie::XMLElement *root = Opie::XMLElement::load( m_file ); - int day, year, month; - day = year = month = -1; - - /* if opened */ - if ( root != 0l ) { - Opie::XMLElement *element = root->firstChild(); - if ( element == 0l ) + // here the custom XML parser from TT it's GPL + // but we want to push that to TT..... + QFile f(m_file ); + if (!f.open(IO_ReadOnly) ) return false; - element = element->firstChild(); + QByteArray ba = f.readAll(); + f.close(); + char* dt = ba.data(); + int len = ba.size(); + int i = 0; + char *point; + const char* collectionString = "<Task "; + while ( dt+i != 0 && ( point = strstr( dt+i, collectionString ) ) != 0l ) { + i = point -dt; + i+= strlen(collectionString); + OTodo ev; + m_year = m_month = m_day = 0; + + while ( TRUE ) { + while ( i < len && (dt[i] == ' ' || dt[i] == '\n' || dt[i] == '\r') ) + ++i; + if ( i >= len-2 || (dt[i] == '/' && dt[i+1] == '>') ) + break; - while ( element ) { - if ( element->tagName() != QString::fromLatin1("Task") ) { - element = element->nextChild(); + // we have another attribute, read it. + int j = i; + while ( j < len && dt[j] != '=' ) + ++j; + QCString attr( dt+i, j-i+1); + + i = ++j; // skip = + + // find the start of quotes + while ( i < len && dt[i] != '"' ) + ++i; + j = ++i; + + bool haveUtf = FALSE; + bool haveEnt = FALSE; + while ( j < len && dt[j] != '"' ) { + if ( ((unsigned char)dt[j]) > 0x7f ) + haveUtf = TRUE; + if ( dt[j] == '&' ) + haveEnt = TRUE; + ++j; + } + if ( i == j ) { + // empty value + i = j + 1; continue; } - /* here is the right element for a task */ - OTodo ev = todo( &dict, element ); - m_events.insert( ev.uid(), ev ); - element = element->nextChild(); + QCString value( dt+i, j-i+1 ); + i = j + 1; + + QString str = (haveUtf ? QString::fromUtf8( value ) + : QString::fromLatin1( value ) ); + if ( haveEnt ) + str = Qtopia::plainString( str ); + + /* + * add key + value + */ + todo( &dict, ev, attr, str ); + } - }else { -// qWarning("could not parse"); - return false;; + /* + * now add it + */ + m_events.insert(ev.uid(), ev ); } - delete root; -// qWarning("Access %d" + m_events.count() ); return true; } bool OTodoAccessXML::reload() { return load(); } bool OTodoAccessXML::save() { @@ -217,99 +260,92 @@ QArray<int> OTodoAccessXML::overDue() { ids.resize( i ); return ids; } /* private */ -OTodo OTodoAccessXML::todo( QAsciiDict<int>* dict, Opie::XMLElement* element)const { +void OTodoAccessXML::todo( QAsciiDict<int>* dict, OTodo& ev, + const QCString& attr, const QString& val) { // qWarning("parse to do from XMLElement" ); - OTodo ev; - QMap<QString, QString> attributes = element->attributes(); - QMap<QString, QString>::Iterator it; int *find=0; - int day, month, year; - day = month = year = -1; - for ( it = attributes.begin(); it != attributes.end(); ++it ) { - find = (*dict)[ it.key() ]; + + find = (*dict)[ attr.data() ]; if (!find ) { // qWarning("Unknown option" + it.key() ); - ev.setCustomField( it.key(), it.data() ); - continue; + ev.setCustomField( attr, val ); + return; } switch( *find ) { case OTodo::Uid: - ev.setUid( it.data().toInt() ); + ev.setUid( val.toInt() ); break; case OTodo::Category: - ev.setCategories( ev.idsFromString( it.data() ) ); + ev.setCategories( ev.idsFromString( val ) ); break; case OTodo::HasDate: - ev.setHasDueDate( it.data().toInt() ); + ev.setHasDueDate( val.toInt() ); break; case OTodo::Completed: - ev.setCompleted( it.data().toInt() ); + ev.setCompleted( val.toInt() ); break; case OTodo::Description: - ev.setDescription( it.data() ); + ev.setDescription( val ); break; case OTodo::Summary: - ev.setSummary( it.data() ); + ev.setSummary( val ); break; case OTodo::Priority: - qWarning("ParsePriority " + it.data() ); - ev.setPriority( it.data().toInt() ); + ev.setPriority( val.toInt() ); break; case OTodo::DateDay: - day = it.data().toInt(); + m_day = val.toInt(); break; case OTodo::DateMonth: - month = it.data().toInt(); + m_month = val.toInt(); break; case OTodo::DateYear: - year = it.data().toInt(); + m_year = val.toInt(); break; case OTodo::Progress: - ev.setProgress( it.data().toInt() ); + ev.setProgress( val.toInt() ); break; case OTodo::CrossReference: { /* * A cross refernce looks like * appname,id;appname,id * we need to split it up */ - QStringList refs = QStringList::split(';', it.data() ); + QStringList refs = QStringList::split(';', val ); QStringList::Iterator strIt; for (strIt = refs.begin(); strIt != refs.end(); ++strIt ) { int pos = (*strIt).find(','); if ( pos > -1 ) ev.addRelation( (*strIt).left(pos), (*strIt).mid(pos+1).toInt() ); } break; } case OTodo::HasAlarmDateTime: - ev.setHasAlarmDateTime( it.data().toInt() ); + ev.setHasAlarmDateTime( val.toInt() ); break; case OTodo::AlarmDateTime: { /* this sounds better ;) zecke */ - ev.setAlarmDateTime( TimeConversion::fromISO8601( it.data().local8Bit() ) ); + ev.setAlarmDateTime( TimeConversion::fromISO8601( val.local8Bit() ) ); break; } default: break; } - } + if ( ev.hasDueDate() ) { - QDate date( year, month, day ); + QDate date( m_year, m_month, m_day ); ev.setDueDate( date ); } - - return ev; } QString OTodoAccessXML::toString( const OTodo& ev )const { QString str; str += "Completed=\"" + QString::number( ev.isCompleted() ) + "\" "; str += "HasDate=\"" + QString::number( ev.hasDueDate() ) + "\" "; @@ -477,13 +513,13 @@ QArray<int> OTodoAccessXML::sorted( bool asc, int sortOrder, OTodoXMLVector vector(m_events.count(), asc,sortOrder ); QMap<int, OTodo>::Iterator it; int item = 0; bool bCat = sortFilter & 1 ? true : false; bool bOver = sortFilter & 0 ? true : false; - bool bOnly = split & 2 ? true : false; + bool bOnly = sortFilter & 2 ? true : false; for ( it = m_events.begin(); it != m_events.end(); ++it ) { /* show category */ if ( bCat ) if (!(*it).categories().contains( cat ) ) continue; |