author | zecke <zecke> | 2003-04-13 16:25:24 (UTC) |
---|---|---|
committer | zecke <zecke> | 2003-04-13 16:25:24 (UTC) |
commit | c27d6327b9be5792fa507557f03997a46f32cc26 (patch) (side-by-side diff) | |
tree | 3332ed2d1c673a898ba1862276d8688918618d7f /libopie2/opiecore | |
parent | 3e1f225ed1e515c3425361fdc90ac4d5b6d86941 (diff) | |
download | opie-c27d6327b9be5792fa507557f03997a46f32cc26.zip opie-c27d6327b9be5792fa507557f03997a46f32cc26.tar.gz opie-c27d6327b9be5792fa507557f03997a46f32cc26.tar.bz2 |
Add apie comments
QString -> const QString& fix
-rw-r--r-- | libopie2/opiecore/oapplication.cpp | 2 | ||||
-rw-r--r-- | libopie2/opiecore/oapplication.h | 6 | ||||
-rw-r--r-- | libopie2/opiecore/oglobal.h | 3 | ||||
-rw-r--r-- | libopie2/opiecore/oglobalsettings.h | 5 |
4 files changed, 13 insertions, 3 deletions
diff --git a/libopie2/opiecore/oapplication.cpp b/libopie2/opiecore/oapplication.cpp index d3e04ba..ce26420 100644 --- a/libopie2/opiecore/oapplication.cpp +++ b/libopie2/opiecore/oapplication.cpp @@ -113,3 +113,3 @@ void OApplication::showMainWidget( QWidget* widget, bool nomax ) -void OApplication::setTitle( QString title ) const +void OApplication::setTitle( const QString& title ) const { diff --git a/libopie2/opiecore/oapplication.h b/libopie2/opiecore/oapplication.h index 4d25202..8326847 100644 --- a/libopie2/opiecore/oapplication.h +++ b/libopie2/opiecore/oapplication.h @@ -35,2 +35,5 @@ +// the below stuff will fail with moc because moc does not pre process headers +// This will make usage of signal and slots hard inside QPEApplication -zecke + #ifdef QWS @@ -48,2 +51,3 @@ class OApplication: public OApplicationBaseClass { +// Q_OBJECT would fail -zecke public: @@ -116,3 +120,3 @@ class OApplication: public OApplicationBaseClass */ - virtual void setTitle( QString title = QString::null ) const; + virtual void setTitle( const QString& title = QString::null ) const; //virtual void setTitle() const; diff --git a/libopie2/opiecore/oglobal.h b/libopie2/opiecore/oglobal.h index 8345c6a..34f211e 100644 --- a/libopie2/opiecore/oglobal.h +++ b/libopie2/opiecore/oglobal.h @@ -39,2 +39,3 @@ static OConfig globalconfig = OConfig( "global" ); //FIXME: Is it wise or even necessary to inherit OGlobal from Global? +// once we totally skip libqpe it should ideally swallow Global -zecke @@ -43,3 +44,3 @@ class OGlobal : public Global public: - + // do we want to put that into OApplication as in KApplication -zecke static OConfig* config(); diff --git a/libopie2/opiecore/oglobalsettings.h b/libopie2/opiecore/oglobalsettings.h index 6481251..d3f357e 100644 --- a/libopie2/opiecore/oglobalsettings.h +++ b/libopie2/opiecore/oglobalsettings.h @@ -49,2 +49,3 @@ //FIXME: happen step-by-step. ML. +// we should not habe too much configure options!!!!!! -zecke @@ -101,2 +102,3 @@ class OGlobalSettings + // we do not support DND at the momemt -zecke static int dndEventDelay(); @@ -116,2 +118,3 @@ class OGlobalSettings **/ + // would clutter the small screen -zecke static bool insertTearOffHandle(); @@ -253,2 +256,3 @@ class OGlobalSettings */ + // below handled by Global stuff and QPEApplication static QString desktopPath() { initStatic(); return *s_desktopPath; } @@ -263,2 +267,3 @@ class OGlobalSettings */ + // we do not have that concept -zecke static QString trashPath() { initStatic(); return *s_trashPath; } |