| author | erik <erik> | 2007-01-22 22:56:12 (UTC) |
|---|---|---|
| committer | erik <erik> | 2007-01-22 22:56:12 (UTC) |
| commit | 9b4871054d01a47b4c546952a0948553413840d6 (patch) (side-by-side diff) | |
| tree | 4e0248489c2790cf4225a116cfb903b637d4cdf0 /libopie2/opiemm | |
| parent | f60301bab1f8aa3693089036a3791a01ae6f9db8 (diff) | |
| download | opie-9b4871054d01a47b4c546952a0948553413840d6.zip opie-9b4871054d01a47b4c546952a0948553413840d6.tar.gz opie-9b4871054d01a47b4c546952a0948553413840d6.tar.bz2 | |
Every file in this commit makes a call to a function which returns a value.
Each file also didn't check the return value.
This commit changes it so that every single non-checked call in these files
is checked.
| -rw-r--r-- | libopie2/opiemm/opieexif.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/libopie2/opiemm/opieexif.cpp b/libopie2/opiemm/opieexif.cpp index de49937..653216c 100644 --- a/libopie2/opiemm/opieexif.cpp +++ b/libopie2/opiemm/opieexif.cpp @@ -206,5 +206,5 @@ int ExifData::ReadJpegSections (QFile & infile, ReadMode_t ReadMode) unsigned long size; - size = QMAX( 0ul, infile.size()-infile.at() ); + size = infile.size()-infile.at(); Data = (uchar *)malloc(size); if (Data == NULL){ @@ -810,5 +810,9 @@ bool ExifData::scan(const QString & path) QFile f(path); - f.open(IO_ReadOnly); + if ( !f.open(IO_ReadOnly) ) { + owarn << "Unable to open file " << f.name() << " readonly" << oendl; + DiscardData(); + return false; + } // Scan the JPEG headers. |