Add apie comments

QString -> const QString& fix

5 files changed, 27 insertions, 11 deletions

diff --git a/libopie2/opienet/omanufacturerdb.h b/libopie2/opienet/omanufacturerdb.h
index 5e66c37..cb0b6c8 100644
--- a/libopie2/opienet/omanufacturerdb.h
+++ b/libopie2/opienet/omanufacturerdb.h
@@ -23,2 +23,3 @@ class OManufacturerDB
   public:
+    //FIXME make us consistent -zecke I use self(), sandman inst() you use instance() so we need to chose one!
     static OManufacturerDB* instance();
diff --git a/libopie2/opienet/onetutils.h b/libopie2/opienet/onetutils.h
index bedea63..9611518 100644
--- a/libopie2/opienet/onetutils.h
+++ b/libopie2/opienet/onetutils.h
@@ -52,2 +52,3 @@ class OMacAddress
   public:
+    // QString c'tor? -zecke
     OMacAddress( unsigned char* );
@@ -61,2 +62,3 @@ class OMacAddress
 
+    // no c'tor but this one why not make it a c'tor. it could also replace the others or is this the problem?
     static OMacAddress fromString( const QString& );
@@ -104,2 +106,3 @@ class OPrivateIOCTL : public QObject
 
+    // FIXME return int? as ::ioctl does? -zecke
     void invoke() const;
diff --git a/libopie2/opienet/onetwork.cpp b/libopie2/opienet/onetwork.cpp
index 73b543b..f0094c7 100644
--- a/libopie2/opienet/onetwork.cpp
+++ b/libopie2/opienet/onetwork.cpp
@@ -110,3 +110,3 @@ void ONetwork::synchronize()
 
-ONetworkInterface* ONetwork::interface( QString iface ) const
+ONetworkInterface* ONetwork::interface( const QString& iface ) const
 {
diff --git a/libopie2/opienet/onetwork.h b/libopie2/opienet/onetwork.h
index d2cc25d..db8e702 100644
--- a/libopie2/opienet/onetwork.h
+++ b/libopie2/opienet/onetwork.h
@@ -100,2 +100,3 @@ class ONetwork : public QObject
      */
+     // FIXME QString? -zecke
     bool isWirelessInterface( const char* interface ) const;
@@ -105,3 +106,4 @@ class ONetwork : public QObject
      */
-    ONetworkInterface* interface( QString interface ) const;
+     // FIXME: const QString& is prefered over QString!!! -zecke
+    ONetworkInterface* interface( const QString& interface ) const;
 
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h
index 99631ba..6bf7416 100644
--- a/libopie2/opienet/opcap.h
+++ b/libopie2/opienet/opcap.h
@@ -70,3 +70,3 @@ class QSocketNotifier;
  *======================================================================================*/
-
+// FIXME how many OPackets do we've at a time? QObject seams to be a big for that usage
 class OPacket : public QObject
@@ -97,2 +97,3 @@ class OPacket : public QObject
 
+//FIXME same critic as above -zecke
 class OEthernetPacket : public QObject
@@ -117,3 +118,3 @@ class OEthernetPacket : public QObject
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanPacket : public QObject
@@ -147,3 +148,3 @@ class OWaveLanPacket : public QObject
  *======================================================================================*/
-
+//FIXME same as above -zecke
 class OWaveLanManagementPacket : public QObject
@@ -176,3 +177,3 @@ class OWaveLanManagementPacket : public QObject
  *======================================================================================*/
-
+//FIXME is QObject necessary? -zecke
 class OWaveLanManagementSSID : public QObject
@@ -194,3 +195,3 @@ class OWaveLanManagementSSID : public QObject
  *======================================================================================*/
-
+// FIXME same as above -zecke
 class OWaveLanManagementRates : public QObject
@@ -211,2 +212,3 @@ class OWaveLanManagementRates : public QObject
 
+//FIXME same....
 class OWaveLanManagementCF : public QObject
@@ -227,2 +229,3 @@ class OWaveLanManagementCF : public QObject
 
+//FIXME same
 class OWaveLanManagementFH : public QObject
@@ -242,3 +245,3 @@ class OWaveLanManagementFH : public QObject
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanManagementDS : public QObject
@@ -261,2 +264,3 @@ class OWaveLanManagementDS : public QObject
 
+//FIXME guess what?
 class OWaveLanManagementTim : public QObject
@@ -277,2 +281,3 @@ class OWaveLanManagementTim : public QObject
 
+//FIXME same as above ( Qobject )
 class OWaveLanManagementIBSS : public QObject
@@ -293,2 +298,3 @@ class OWaveLanManagementIBSS : public QObject
 
+// Qobject do we need that??
 class OWaveLanManagementChallenge : public QObject
@@ -308,3 +314,3 @@ class OWaveLanManagementChallenge : public QObject
  *======================================================================================*/
-
+// Qobject?
 class OWaveLanDataPacket : public QObject
@@ -324,3 +330,3 @@ class OWaveLanDataPacket : public QObject
  *======================================================================================*/
-
+// Qobject needed?
 class OWaveLanControlPacket : public QObject
@@ -341,2 +347,3 @@ class OWaveLanControlPacket : public QObject
 
+// QObject needed?
 class OLLCPacket : public QObject
@@ -350,2 +357,3 @@ class OLLCPacket : public QObject
   private:
+  //FIXME how to get that header?
     const struct ieee_802_11_802_2_header* _header;
@@ -357,2 +365,3 @@ class OLLCPacket : public QObject
 
+// Qobject as baseclass?
 class OIPPacket : public QObject
@@ -383,3 +392,3 @@ class OIPPacket : public QObject
  *======================================================================================*/
-
+// QObject?
 class OUDPPacket : public QObject
@@ -403,2 +412,3 @@ class OUDPPacket : public QObject
 
+// Qobect needed?
 class OTCPPacket : public QObject