Add apie comments

QString -> const QString& fix

5 files changed, 27 insertions, 11 deletions

diff --git a/libopie2/opienet/omanufacturerdb.h b/libopie2/opienet/omanufacturerdb.h
index 5e66c37..cb0b6c8 100644
--- a/libopie2/opienet/omanufacturerdb.h
+++ b/libopie2/opienet/omanufacturerdb.h
@@ -22,4 +22,5 @@ class OManufacturerDB
 {
   public:
+    //FIXME make us consistent -zecke I use self(), sandman inst() you use instance() so we need to chose one!
     static OManufacturerDB* instance();
     const QString& lookup( const QString& macaddr ) const;
diff --git a/libopie2/opienet/onetutils.h b/libopie2/opienet/onetutils.h
index bedea63..9611518 100644
--- a/libopie2/opienet/onetutils.h
+++ b/libopie2/opienet/onetutils.h
@@ -51,4 +51,5 @@ class OMacAddress
 {
   public:
+    // QString c'tor? -zecke
     OMacAddress( unsigned char* );
     OMacAddress( const unsigned char* );
@@ -60,4 +61,5 @@ class OMacAddress
     const unsigned char* native() const;
 
+    // no c'tor but this one why not make it a c'tor. it could also replace the others or is this the problem?
     static OMacAddress fromString( const QString& );
 
@@ -103,4 +105,5 @@ class OPrivateIOCTL : public QObject
     int typeSetArgs() const;
 
+    // FIXME return int? as ::ioctl does? -zecke
     void invoke() const;
     void setParameter( int, u_int32_t );
diff --git a/libopie2/opienet/onetwork.cpp b/libopie2/opienet/onetwork.cpp
index 73b543b..f0094c7 100644
--- a/libopie2/opienet/onetwork.cpp
+++ b/libopie2/opienet/onetwork.cpp
@@ -109,5 +109,5 @@ void ONetwork::synchronize()
 
 
-ONetworkInterface* ONetwork::interface( QString iface ) const
+ONetworkInterface* ONetwork::interface( const QString& iface ) const
 {
     return _interfaces[iface];
diff --git a/libopie2/opienet/onetwork.h b/libopie2/opienet/onetwork.h
index d2cc25d..db8e702 100644
--- a/libopie2/opienet/onetwork.h
+++ b/libopie2/opienet/onetwork.h
@@ -99,4 +99,5 @@ class ONetwork : public QObject
      * @returns true, if the @p interface supports the wireless extension protocol.
      */
+     // FIXME QString? -zecke
     bool isWirelessInterface( const char* interface ) const;
     /**
@@ -104,5 +105,6 @@ class ONetwork : public QObject
      * @see ONetworkInterface
      */
-    ONetworkInterface* interface( QString interface ) const;
+     // FIXME: const QString& is prefered over QString!!! -zecke
+    ONetworkInterface* interface( const QString& interface ) const;
 
   protected:
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h
index 99631ba..6bf7416 100644
--- a/libopie2/opienet/opcap.h
+++ b/libopie2/opienet/opcap.h
@@ -69,5 +69,5 @@ class QSocketNotifier;
  * OPacket - A frame on the wire
  *======================================================================================*/
-
+// FIXME how many OPackets do we've at a time? QObject seams to be a big for that usage
 class OPacket : public QObject
 {
@@ -96,4 +96,5 @@ class OPacket : public QObject
  *======================================================================================*/
 
+//FIXME same critic as above -zecke
 class OEthernetPacket : public QObject
 {
@@ -116,5 +117,5 @@ class OEthernetPacket : public QObject
  * OWaveLanPacket - DLT_IEEE802_11 frame
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanPacket : public QObject
 {
@@ -146,5 +147,5 @@ class OWaveLanPacket : public QObject
  * OWaveLanManagementPacket - type: management (T_MGMT)
  *======================================================================================*/
-
+//FIXME same as above -zecke
 class OWaveLanManagementPacket : public QObject
 {
@@ -175,5 +176,5 @@ class OWaveLanManagementPacket : public QObject
  * OWaveLanManagementSSID
  *======================================================================================*/
-
+//FIXME is QObject necessary? -zecke
 class OWaveLanManagementSSID : public QObject
 {
@@ -193,5 +194,5 @@ class OWaveLanManagementSSID : public QObject
  * OWaveLanManagementRates
  *======================================================================================*/
-
+// FIXME same as above -zecke
 class OWaveLanManagementRates : public QObject
 {
@@ -210,4 +211,5 @@ class OWaveLanManagementRates : public QObject
  *======================================================================================*/
 
+//FIXME same....
 class OWaveLanManagementCF : public QObject
 {
@@ -226,4 +228,5 @@ class OWaveLanManagementCF : public QObject
  *======================================================================================*/
 
+//FIXME same
 class OWaveLanManagementFH : public QObject
 {
@@ -241,5 +244,5 @@ class OWaveLanManagementFH : public QObject
  * OWaveLanManagementDS
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanManagementDS : public QObject
 {
@@ -260,4 +263,5 @@ class OWaveLanManagementDS : public QObject
  *======================================================================================*/
 
+//FIXME guess what?
 class OWaveLanManagementTim : public QObject
 {
@@ -276,4 +280,5 @@ class OWaveLanManagementTim : public QObject
  *======================================================================================*/
 
+//FIXME same as above ( Qobject )
 class OWaveLanManagementIBSS : public QObject
 {
@@ -292,4 +297,5 @@ class OWaveLanManagementIBSS : public QObject
  *======================================================================================*/
 
+// Qobject do we need that??
 class OWaveLanManagementChallenge : public QObject
 {
@@ -307,5 +313,5 @@ class OWaveLanManagementChallenge : public QObject
  * OWaveLanDataPacket - type: data (T_DATA)
  *======================================================================================*/
-
+// Qobject?
 class OWaveLanDataPacket : public QObject
 {
@@ -323,5 +329,5 @@ class OWaveLanDataPacket : public QObject
  * OWaveLanControlPacket - type: control (T_CTRL)
  *======================================================================================*/
-
+// Qobject needed?
 class OWaveLanControlPacket : public QObject
 {
@@ -340,4 +346,5 @@ class OWaveLanControlPacket : public QObject
  *======================================================================================*/
 
+// QObject needed?
 class OLLCPacket : public QObject
 {
@@ -349,4 +356,5 @@ class OLLCPacket : public QObject
 
   private:
+  //FIXME how to get that header?
     const struct ieee_802_11_802_2_header* _header;
 };
@@ -356,4 +364,5 @@ class OLLCPacket : public QObject
  *======================================================================================*/
 
+// Qobject as baseclass?
 class OIPPacket : public QObject
 {
@@ -382,5 +391,5 @@ class OIPPacket : public QObject
  * OUDPPacket
  *======================================================================================*/
-
+// QObject?
 class OUDPPacket : public QObject
 {
@@ -402,4 +411,5 @@ class OUDPPacket : public QObject
  *======================================================================================*/
 
+// Qobect needed?
 class OTCPPacket : public QObject
 {