author | zecke <zecke> | 2002-11-15 10:53:42 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-11-15 10:53:42 (UTC) |
commit | dc68676392f6ac7cced3a9b004fe72a8b408812f (patch) (side-by-side diff) | |
tree | d74a42aef53b57edb9d452806b34695c591f8252 /libopie2/opiepim | |
parent | 5fac1f8271dc037d8d3a3a765bccc44c4734e544 (diff) | |
download | opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.zip opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.gz opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.bz2 |
API REVIEW added
Simon if you read that feel free to do an API REVIEW
on libopie but leave out OFileSelector for now...
Stefan: added an explanation for you
-rw-r--r-- | libopie2/opiepim/ocontact.h | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/libopie2/opiepim/ocontact.h b/libopie2/opiepim/ocontact.h index 81ac1c1..9643e8b 100644 --- a/libopie2/opiepim/ocontact.h +++ b/libopie2/opiepim/ocontact.h @@ -30,30 +30,45 @@ #if defined(QPC_TEMPLATEDLL) // MOC_SKIP_BEGIN QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>; // MOC_SKIP_END #endif class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se) + /* Stefan das ist eine forward declaration + * dann machst du in der private section + * ContactPrivate *d; + * + * und wenn du bei Opie1.1 was hinzufuegen moechtest + * packst du es in ContactPrivate damit Opie + * binaer kompatibel bleibt + * -zecke + */ class QPC_EXPORT OContact : public OPimRecord { friend class DataSet; public: OContact(); OContact( const QMap<int, QString> &fromMap ); virtual ~OContact(); + /* VCARD stuff should vanish! -zecke */ static void writeVCard( const QString &filename, const QValueList<OContact> &contacts); static void writeVCard( const QString &filename, const OContact &c ); static QValueList<OContact> readVCard( const QString &filename ); enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; + /* + * do we need to inline them + * if yes do we need to inline them this way? + * -zecke + */ void setTitle( const QString &v ) { replace( Qtopia::Title, v ); } void setFirstName( const QString &v ) { replace( Qtopia::FirstName, v ); } void setMiddleName( const QString &v ) { replace( Qtopia::MiddleName, v ); } void setLastName( const QString &v ) { replace( Qtopia::LastName, v ); } void setSuffix( const QString &v ) { replace( Qtopia::Suffix, v ); } void setFileAs( const QString &v ) { replace( Qtopia::FileAs, v ); } void setFileAs(); @@ -122,16 +137,21 @@ public: QString suffix() const { return find( Qtopia::Suffix ); } QString fileAs() const { return find( Qtopia::FileAs ); } // email QString defaultEmail() const { return find( Qtopia::DefaultEmail ); } QStringList emailList() const; // home + /* + * OPimAddress address(enum Location)const; + * would be some how nicer... + * -zecke + */ QString homeStreet() const { return find( Qtopia::HomeStreet ); } QString homeCity() const { return find( Qtopia::HomeCity ); } QString homeState() const { return find( Qtopia::HomeState ); } QString homeZip() const { return find( Qtopia::HomeZip ); } QString homeCountry() const { return find( Qtopia::HomeCountry ); } QString homePhone() const { return find( Qtopia::HomePhone ); } QString homeFax() const { return find( Qtopia::HomeFax ); } QString homeMobile() const { return find( Qtopia::HomeMobile ); } @@ -191,35 +211,41 @@ public: static QStringList untrfields(); QString toRichText() const; QMap<int, QString> toMap() const; QString field( int key ) const { return find( key ); } // journaling... + /* do we still need them? Stefan your backend takes care of these -zecke */ void saveJournal( journal_action action, const QString &key = QString::null ); void save( QString &buf ) const; + /* we shouldn't inline this one -zecke */ void setUid( int i ) { OPimRecord::setUid(i); replace( Qtopia::AddressUid , QString::number(i)); } QString toShortText()const; QString OContact::type()const; QMap<QString,QString> OContact::toExtraMap() const; class QString OContact::recordField(int) const; // Why private ? (eilers,se) QString emailSeparator() const { return " "; } // the emails should be seperated by a comma void setEmails( const QString &v ); QString emails() const { return find( Qtopia::Emails ); } private: + /* I do not like friends ;) + * besides that I think we do not need them + * anymore -zecke + */ friend class AbEditor; friend class AbTable; friend class AddressBookAccessPrivate; friend class XMLIO; void insert( int key, const QString &value ); void replace( int key, const QString &value ); QString find( int key ) const; |