author | zecke <zecke> | 2002-11-15 10:53:42 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-11-15 10:53:42 (UTC) |
commit | dc68676392f6ac7cced3a9b004fe72a8b408812f (patch) (unidiff) | |
tree | d74a42aef53b57edb9d452806b34695c591f8252 /libopie2 | |
parent | 5fac1f8271dc037d8d3a3a765bccc44c4734e544 (diff) | |
download | opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.zip opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.gz opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.bz2 |
API REVIEW added
Simon if you read that feel free to do an API REVIEW
on libopie but leave out OFileSelector for now...
Stefan: added an explanation for you
-rw-r--r-- | libopie2/opiepim/ocontact.h | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/libopie2/opiepim/ocontact.h b/libopie2/opiepim/ocontact.h index 81ac1c1..9643e8b 100644 --- a/libopie2/opiepim/ocontact.h +++ b/libopie2/opiepim/ocontact.h | |||
@@ -36,4 +36,13 @@ QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>; | |||
36 | 36 | ||
37 | class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se) | 37 | class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se) |
38 | /* Stefan das ist eine forward declaration | ||
39 | * dann machst du in der private section | ||
40 | * ContactPrivate *d; | ||
41 | * | ||
42 | * und wenn du bei Opie1.1 was hinzufuegen moechtest | ||
43 | * packst du es in ContactPrivate damit Opie | ||
44 | * binaer kompatibel bleibt | ||
45 | * -zecke | ||
46 | */ | ||
38 | class QPC_EXPORT OContact : public OPimRecord | 47 | class QPC_EXPORT OContact : public OPimRecord |
39 | { | 48 | { |
@@ -44,4 +53,5 @@ public: | |||
44 | virtual ~OContact(); | 53 | virtual ~OContact(); |
45 | 54 | ||
55 | /* VCARD stuff should vanish! -zecke */ | ||
46 | static void writeVCard( const QString &filename, const QValueList<OContact> &contacts); | 56 | static void writeVCard( const QString &filename, const QValueList<OContact> &contacts); |
47 | static void writeVCard( const QString &filename, const OContact &c ); | 57 | static void writeVCard( const QString &filename, const OContact &c ); |
@@ -50,4 +60,9 @@ public: | |||
50 | enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; | 60 | enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; |
51 | 61 | ||
62 | /* | ||
63 | * do we need to inline them | ||
64 | * if yes do we need to inline them this way? | ||
65 | * -zecke | ||
66 | */ | ||
52 | void setTitle( const QString &v ) { replace( Qtopia::Title, v ); } | 67 | void setTitle( const QString &v ) { replace( Qtopia::Title, v ); } |
53 | void setFirstName( const QString &v ) { replace( Qtopia::FirstName, v ); } | 68 | void setFirstName( const QString &v ) { replace( Qtopia::FirstName, v ); } |
@@ -128,4 +143,9 @@ public: | |||
128 | 143 | ||
129 | // home | 144 | // home |
145 | /* | ||
146 | * OPimAddress address(enum Location)const; | ||
147 | * would be some how nicer... | ||
148 | * -zecke | ||
149 | */ | ||
130 | QString homeStreet() const { return find( Qtopia::HomeStreet ); } | 150 | QString homeStreet() const { return find( Qtopia::HomeStreet ); } |
131 | QString homeCity() const { return find( Qtopia::HomeCity ); } | 151 | QString homeCity() const { return find( Qtopia::HomeCity ); } |
@@ -197,7 +217,9 @@ public: | |||
197 | 217 | ||
198 | // journaling... | 218 | // journaling... |
219 | /* do we still need them? Stefan your backend takes care of these -zecke */ | ||
199 | void saveJournal( journal_action action, const QString &key = QString::null ); | 220 | void saveJournal( journal_action action, const QString &key = QString::null ); |
200 | void save( QString &buf ) const; | 221 | void save( QString &buf ) const; |
201 | 222 | ||
223 | /* we shouldn't inline this one -zecke */ | ||
202 | void setUid( int i ) | 224 | void setUid( int i ) |
203 | { OPimRecord::setUid(i); replace( Qtopia::AddressUid , QString::number(i)); } | 225 | { OPimRecord::setUid(i); replace( Qtopia::AddressUid , QString::number(i)); } |
@@ -216,4 +238,8 @@ public: | |||
216 | 238 | ||
217 | private: | 239 | private: |
240 | /* I do not like friends ;) | ||
241 | * besides that I think we do not need them | ||
242 | * anymore -zecke | ||
243 | */ | ||
218 | friend class AbEditor; | 244 | friend class AbEditor; |
219 | friend class AbTable; | 245 | friend class AbTable; |