Fix icon sizing for light and qpe styles

1 files changed, 17 insertions, 13 deletions

diff --git a/library/lightstyle.cpp b/library/lightstyle.cpp
index 3bd1623..c5073ca 100644
--- a/library/lightstyle.cpp
+++ b/library/lightstyle.cpp
@@ -522,216 +522,216 @@ void LightStyle::drawIndicator(QPainter *p, int x, int y ,int w, int h,
         p->drawLine(x + 3, y + h - 5, x + w - 5, y + 3);
         p->drawLine(x + 3, y + h - 4, x + w - 4, y + 3);
         p->drawLine(x + 4, y + h - 4, x + w - 4, y + 4);
     }
 
     p->restore();
 }
 
 
 void LightStyle::drawExclusiveIndicator(QPainter *p, int x, int y, int w, int h,
                                         const QColorGroup &g, bool on,
                                         bool down, bool)
 {
     p->save();
 
     p->fillRect(x, y, w, h, g.brush(QColorGroup::Background));
 
     p->setPen(g.dark());
     p->drawArc(x, y, w, h, 0, 16*360);
     p->setPen(g.mid());
     p->drawArc(x + 1, y + 1, w - 2, h - 2, 45*16, 180*16);
     p->setPen(g.light());
     p->drawArc(x + 1, y + 1, w - 2, h - 2, 235*16, 180*16);
 
     p->setPen(down ? g.mid() : g.base());
     p->setBrush(down ? g.mid() : g.base());
     p->drawEllipse(x + 2, y + 2, w - 4, h - 4);
 
     if (on) {
         p->setBrush(g.foreground());
         p->drawEllipse(x + 3, y + 3, w - x - 6, h - y - 6);
     }
 
     p->restore();
 }
 
 
 
 #if 1
 //copied from QPE style
 void LightStyle::drawTab( QPainter *p, const QTabBar *tb, QTab *t, bool selected )
 {
 #if 0
     //We can't do this, because QTabBar::focusInEvent redraws the
     // tab label with the default font.
         QFont f = tb->font();
         f.setBold( selected );
         p->setFont( f );
-#endif    
+#endif
     QRect r( t->rect() );
     if ( tb->shape()  == QTabBar::RoundedAbove ) {
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.bottom(), r.right(), r.bottom() );
         if ( r.left() == 0 )
             p->drawPoint( tb->rect().bottomLeft() );
         else {
             p->setPen( tb->colorGroup().light() );
             p->drawLine( r.left(), r.bottom(), r.right(), r.bottom() );
         }
 
         if ( selected ) {
             p->setPen( tb->colorGroup().background() );
             p->drawLine( r.left()+2, r.top()+1, r.right()-2, r.top()+1 );
             p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-2),
                          tb->colorGroup().brush( QColorGroup::Background ));
 
         } else {
             r.setRect( r.left() + 2, r.top() + 2,
                        r.width() - 4, r.height() - 2 );
             p->setPen( tb->colorGroup().button() );
             p->drawLine( r.left()+2, r.top()+1, r.right()-2, r.top()+1 );
             p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-3),
                          tb->colorGroup().brush( QColorGroup::Button ));
             //do shading; will not work for pixmap brushes
-            QColor bg = tb->colorGroup().button(); 
+            QColor bg = tb->colorGroup().button();
                     //    int h,s,v;
                     //    bg.hsv( &h, &s, &v );
             int n = r.height()/2;
             int dark = 100;
             for ( int i = 1; i < n; i++ ) {
                 dark = (dark * (100+(i*15)/n) )/100;
                 p->setPen( bg.dark( dark ) );
                 int y = r.bottom()-n+i;
                 int x1 = r.left()+1;
                 int x2 = r.right()-1;
                 p->drawLine( x1, y, x2, y );
             }
-            
+
         }
 
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.bottom()-1, r.left(), r.top() + 2 );
         p->drawPoint( r.left()+1, r.top() + 1 );
         p->drawLine( r.left()+2, r.top(),
                      r.right() - 2, r.top() );
 
         p->setPen( tb->colorGroup().dark() );
         p->drawPoint( r.right() - 1, r.top() + 1 );
         p->drawLine( r.right(), r.top() + 2, r.right(), r.bottom() - 1);
     } else if ( tb->shape() == QTabBar::RoundedBelow ) {
         if ( selected ) {
             p->setPen( tb->colorGroup().background() );
             p->drawLine( r.left()+2, r.bottom()-1, r.right()-2, r.bottom()-1 );
             p->fillRect( QRect( r.left()+1, r.top(), r.width()-2, r.height()-2),
                          tb->palette().normal().brush( QColorGroup::Background ));
         } else {
             p->setPen( tb->colorGroup().dark() );
             p->drawLine( r.left(), r.top(),
                          r.right(), r.top() );
             r.setRect( r.left() + 2, r.top(),
                        r.width() - 4, r.height() - 2 );
             p->setPen( tb->colorGroup().button() );
             p->drawLine( r.left()+2, r.bottom()-1, r.right()-2, r.bottom()-1 );
             p->fillRect( QRect( r.left()+1, r.top()+1, r.width()-2, r.height()-3),
                          tb->palette().normal().brush( QColorGroup::Button ));
         }
 
         p->setPen( tb->colorGroup().dark() );
         p->drawLine( r.right(), r.top(),
                      r.right(), r.bottom() - 2 );
         p->drawPoint( r.right() - 1, r.bottom() - 1 );
         p->drawLine( r.right() - 2, r.bottom(),
                      r.left() + 2, r.bottom() );
 
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.top()+1,
                      r.left(), r.bottom() - 2 );
         p->drawPoint( r.left() + 1, r.bottom() - 1 );
         if ( r.left() == 0 )
             p->drawPoint( tb->rect().topLeft() );
 
     } else {
         QCommonStyle::drawTab( p, tb, t, selected );
     }
 }
 
 #else
 
 void LightStyle::drawTab(QPainter *p, const QTabBar *tabbar, QTab *tab,
                               bool selected)
 {
     p->save();
 
     QColorGroup g = tabbar->colorGroup();
     QRect fr(tab->r);
     fr.setLeft(fr.left() + 2);
 
     if (! selected) {
         if (tabbar->shape() == QTabBar::RoundedAbove ||
             tabbar->shape() == QTabBar::TriangularAbove) {
 
             fr.setTop(fr.top() + 2);
         } else {
             fr.setBottom(fr.bottom() - 2);
         }
     }
 
     QRegion tabr(tab->r);
 
     QPointArray cliptri(4);
     cliptri.setPoint(0, fr.left(), fr.top());
     cliptri.setPoint(1, fr.left(), fr.top() + 5);
     cliptri.setPoint(2, fr.left() + 5, fr.top());
     cliptri.setPoint(3, fr.left(), fr.top());
     QRegion trir(cliptri);
     p->setClipRegion(tabr - trir);
 
-    p->setPen( NoPen ); 
+    p->setPen( NoPen );
     p->setBrush(g.brush(selected ? QColorGroup::Background : QColorGroup::Mid));
 
     fr.setWidth(fr.width() - 1);
     p->drawRect(fr.left() + 1, fr.top() + 1, fr.width() - 2, fr.height() - 2);
 
     if (tabbar->shape() == QTabBar::RoundedAbove) {
         // "rounded" tabs on top
         fr.setBottom(fr.bottom() - 1);
 
         p->setPen(g.dark());
         p->drawLine(fr.left(), fr.top() + 5, fr.left(), fr.bottom() - 1);
         p->drawLine(fr.left(), fr.top() + 5, fr.left() + 5, fr.top());
         p->drawLine(fr.left() + 5, fr.top(), fr.right() - 1, fr.top());
         p->drawLine(fr.right(), fr.top() + 1, fr.right(), fr.bottom() - 1);
 
         if (selected) {
             p->drawLine(fr.right(), fr.bottom(), fr.right() + 2, fr.bottom());
             p->drawPoint(fr.left(), fr.bottom());
         } else
             p->drawLine(fr.left(), fr.bottom(), fr.right() + 2, fr.bottom());
 
         if (fr.left() == 2) {
             p->drawPoint(fr.left() - 1, fr.bottom() + 1);
             p->drawPoint(fr.left() - 2, fr.bottom() + 2);
         }
 
         if (selected) {
             p->setPen(g.mid());
             p->drawLine(fr.right() - 1, fr.top() + 1, fr.right() - 1, fr.bottom() - 2);
         }
 
         p->setPen(g.light()); p->setPen(red);
         p->drawLine(fr.left() + 1, fr.top() + 6, fr.left() + 1,
                     fr.bottom() - (selected ? 0 : 1));
         p->drawLine(fr.left() + 1, fr.top() + 5, fr.left() + 5, fr.top() + 1);
         p->drawLine(fr.left() + 6, fr.top() + 1, fr.right() - 3, fr.top() + 1);
         if (selected) {
             p->drawLine(fr.right() + 1, fr.bottom() + 1,
                         fr.right() + 2, fr.bottom() + 1);
             p->drawLine(fr.left(), fr.bottom() + 1, fr.left() + 1, fr.bottom() + 1);
         } else
             p->drawLine(fr.left(), fr.bottom() + 1,
                         fr.right() + 2, fr.bottom() + 1);
     } else if (tabbar->shape() == QTabBar::RoundedBelow) {
         // "rounded" tabs on bottom
         fr.setTop(fr.top() + 1);
 
         p->setPen(g.dark());
@@ -837,189 +837,189 @@ void LightStyle::scrollBarMetrics(const QScrollBar *scrollbar,
 QStyle::ScrollControl LightStyle::scrollBarPointOver(const QScrollBar *scrollbar,
                                                    int sliderStart, const QPoint &p)
 {
     if (! scrollbar->rect().contains(p))
         return NoScroll;
 
     int sliderMin, sliderMax, sliderLength, buttonDim, pos;
     scrollBarMetrics( scrollbar, sliderMin, sliderMax, sliderLength, buttonDim );
 
     if (scrollbar->orientation() == Horizontal)
         pos = p.x();
     else
         pos = p.y();
 
     if (pos < buttonDim)
         return SubLine;
     if (pos < sliderStart)
         return SubPage;
     if (pos < sliderStart + sliderLength)
         return Slider;
     if (pos < sliderMax + sliderLength)
         return AddPage;
     if (pos < sliderMax + sliderLength + buttonDim)
         return SubLine;
     return AddLine;
 }
 
 
 
 void LightStyle::drawScrollBarControls( QPainter* p, const QScrollBar* scrollbar,
                                              int sliderStart, uint controls,
                                              uint activeControl )
 {
     QColorGroup g  = scrollbar->colorGroup();
 
     int sliderMin, sliderMax, sliderLength, buttonDim;
     scrollBarMetrics( scrollbar, sliderMin, sliderMax, sliderLength, buttonDim );
 
     if (sliderStart > sliderMax) { // sanity check
         sliderStart = sliderMax;
     }
 
     QRect addR, subR, subR2, addPageR, subPageR, sliderR;
     int length =  ((scrollbar->orientation() == Horizontal) ?
                    scrollbar->width()  : scrollbar->height());
     int extent =  ((scrollbar->orientation() == Horizontal) ?
                    scrollbar->height() : scrollbar->width());
 
-    
+
     int fudge = 3; //####disgusting hack
-    
+
     if (scrollbar->orientation() == Horizontal) {
         subR.setRect(0, defaultFrameWidth(),
                      buttonDim + fudge, buttonDim);
         subR2.setRect(length - (buttonDim * 2), defaultFrameWidth() ,
                       buttonDim, buttonDim);
         addR.setRect(length - buttonDim, defaultFrameWidth(),
                      buttonDim, buttonDim);
     } else {
         subR.setRect(defaultFrameWidth() + 1, 0,
                      buttonDim, buttonDim + fudge);
         subR2.setRect(defaultFrameWidth() + 1, length - (buttonDim * 2),
                       buttonDim, buttonDim);
         addR.setRect(defaultFrameWidth() + 1, length - buttonDim,
                      buttonDim, buttonDim);
     }
 
     int sliderEnd = sliderStart + sliderLength;
     int sliderW = extent - defaultFrameWidth() - 1;
     if (scrollbar->orientation() == Horizontal) {
         subPageR.setRect( subR.right() + 1, defaultFrameWidth(),
                           sliderStart - subR.right() - 1 , sliderW );
         addPageR.setRect( sliderEnd, defaultFrameWidth(),
                           subR2.left() - sliderEnd, sliderW );
         sliderR.setRect( sliderStart, defaultFrameWidth(), sliderLength, sliderW );
     } else {
         subPageR.setRect( defaultFrameWidth(), subR.bottom() + 1,
                           sliderW, sliderStart - subR.bottom() - 1 );
         addPageR.setRect( defaultFrameWidth(), sliderEnd,
                           sliderW, subR2.top() - sliderEnd );
         sliderR .setRect( defaultFrameWidth(), sliderStart,
                           sliderW, sliderLength );
     }
 
     if ( controls == ( AddLine | SubLine | AddPage | SubPage |
                        Slider | First | Last ) ) {
         if (scrollbar->orientation() == Horizontal)
             qDrawShadePanel(p, 0, 0, length, 2, g, TRUE, 1,
                             &g.brush(QColorGroup::Background));
         else
             qDrawShadePanel(p, 0, 0, 2, length, g, TRUE, 1,
                             &g.brush(QColorGroup::Background));
     }
 
     if ( controls & AddLine )
         drawArrow( p, (scrollbar->orientation() == Vertical) ? DownArrow : RightArrow,
                    FALSE, addR.x(), addR.y(),
                    addR.width(), addR.height(),
                    (( activeControl == AddLine ) ?
                     singleton->hoverPalette.active() : g),
                    TRUE, &g.brush(QColorGroup::Background));
     if ( controls & SubLine ) {
         drawArrow( p, (scrollbar->orientation() == Vertical) ? UpArrow : LeftArrow,
                    FALSE, subR.x(), subR.y(),
                    subR.width(), subR.height(),
                    (( activeControl == SubLine ) ?
                     singleton->hoverPalette.active() : g),
                    TRUE, &g.brush(QColorGroup::Background));
         drawArrow( p, (scrollbar->orientation() == Vertical) ? UpArrow : LeftArrow,
                    FALSE, subR2.x(), subR2.y(),
                    subR2.width(), subR2.height(),
                    (( activeControl == SubLine ) ?
                     singleton->hoverPalette.active() : g),
                    TRUE, &g.brush(QColorGroup::Background));
     }
 
     if ( controls & SubPage )
         p->fillRect( subPageR,
                      ((activeControl == SubPage) ?
                       g.brush( QColorGroup::Dark ) :
                       g.brush( QColorGroup::Mid )));
     if ( controls & AddPage )
         p->fillRect( addPageR,
                      ((activeControl == AddPage) ?
                       g.brush( QColorGroup::Dark ) :
                       g.brush( QColorGroup::Mid )));
 
     if ( controls & Slider ) {
 
         QPoint bo = p->brushOrigin();
         p->setBrushOrigin(sliderR.topLeft());
         if ( sliderR.isValid() ) {
             p->fillRect( sliderR.x(), sliderR.y(), 2, 2,
                       g.brush( QColorGroup::Mid ));
-            p->fillRect( sliderR.x() + sliderR.width() - 2, 
+            p->fillRect( sliderR.x() + sliderR.width() - 2,
                     sliderR.y(), 2, 2,
                       g.brush( QColorGroup::Mid ));
-            p->fillRect( sliderR.x() + sliderR.width() - 2, 
+            p->fillRect( sliderR.x() + sliderR.width() - 2,
                     sliderR.y() + sliderR.height() - 2, 2, 2,
                       g.brush( QColorGroup::Mid ));
-            p->fillRect( sliderR.x(), 
+            p->fillRect( sliderR.x(),
                     sliderR.y() + sliderR.height() - 2, 2, 2,
                       g.brush( QColorGroup::Mid ));
 
             QColorGroup cg( g );
             cg.setBrush( QColorGroup::Background, g.brush( QColorGroup::Mid ) );
             drawBevelButton( p, sliderR.x(), sliderR.y(),
                              sliderR.width(), sliderR.height(),
                              cg, FALSE, &g.brush( QColorGroup::Button ) );
         }
 
         p->setBrushOrigin(bo);
     }
 }
 
 
 void LightStyle::drawToolBarHandle(QPainter *p, const QRect &rect,
                                    Qt::Orientation orientation,
                                    bool, const QColorGroup &g, bool)
 {
     p->save();
     p->setPen(g.mid());
     p->setBrush(g.brush(QColorGroup::Mid));
 
     if (orientation == Qt::Horizontal) {
         QRect l, r;
         l.setRect(rect.x() + 1, rect.y() + 1, rect.width() - 5, rect.height() - 2);
         r.setRect(l.right() + 1, l.y(), 3, l.height());
 
         p->drawRect(l);
                qDrawShadePanel(p, r, g, FALSE);
     } else {
         QRect t, b;
         t.setRect(rect.x() + 1, rect.y() + 1, rect.width() - 2, rect.height() - 5);
         b.setRect(t.x(), t.bottom() + 1, t.width(), 3);
 
         p->drawRect(t);
                qDrawShadePanel(p, b, g, FALSE);
     }
 
     p->restore();
 }
 
 
 bool LightStyle::eventFilter(QObject *object, QEvent *event)
 {
     switch(event->type()) {
     case QEvent::Enter:
         {
@@ -1073,161 +1073,165 @@ static const int motifItemFrame		= 1;	// menu item frame width
         static const int motifSepHeight                 = 2;// separator item height
         static const int motifItemHMargin       = 1;// menu item hor text margin
         static const int motifItemVMargin       = 2;// menu item ver text margin
         static const int motifArrowHMargin      = 0;// arrow horizontal margin
         static const int motifTabSpacing        = 12;// space between text and tab
         static const int motifCheckMarkHMargin  = 1;// horiz. margins of check mark
         static const int windowsRightBorder= 8;    // right border on windows
 static const int windowsCheckMarkWidth  = 2;    // checkmarks width on windows
 
 /*! \reimp
 */
 int LightStyle::extraPopupMenuItemWidth( bool checkable, int maxpmw, QMenuItem* mi, const QFontMetrics& /*fm*/ )
 {
 #ifndef QT_NO_MENUDATA
     int w = 2*motifItemHMargin + 2*motifItemFrame; // a little bit of border can never harm
 
     if ( mi->isSeparator() )
         return 10; // arbitrary
     else if ( mi->pixmap() )
                 w += mi->pixmap()->width();// pixmap only
 
     if ( !mi->text().isNull() ) {
                 if ( mi->text().find('\t') >= 0 )// string contains tab
             w += motifTabSpacing;
     }
 
     if ( maxpmw ) { // we have iconsets
         w += maxpmw;
         w += 6; // add a little extra border around the iconset
     }
 
     if ( checkable && maxpmw < windowsCheckMarkWidth ) {
         w += windowsCheckMarkWidth - maxpmw; // space for the checkmarks
     }
 
     if ( maxpmw > 0 || checkable ) // we have a check-column ( iconsets or checkmarks)
         w += motifCheckMarkHMargin; // add space to separate the columns
 
     w += windowsRightBorder; // windows has a strange wide border on the right side
 
     return w;
 #endif
 }
 
 /*! \reimp
 */
 int LightStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QFontMetrics& fm )
 {
-#ifndef QT_NO_MENUDATA    
+#ifndef QT_NO_MENUDATA
     int h = 0;
             if ( mi->isSeparator() )            // separator height
         h = motifSepHeight;
             else if ( mi->pixmap() )    // pixmap height
         h = mi->pixmap()->height() + 2*motifItemFrame;
             else                                // text height
         h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame;
 
     if ( !mi->isSeparator() && mi->iconSet() != 0 ) {
-        h = QMAX( h, mi->iconSet()->pixmap( QIconSet::Small, QIconSet::Normal ).height() + 2*motifItemFrame );
+        h = QMAX( h, mi->iconSet()->pixmap().height() + 2*motifItemFrame );
     }
     if ( mi->custom() )
         h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1;
     return h;
 #endif
 }
 
 void LightStyle::drawPopupMenuItem( QPainter* p, bool checkable, int maxpmw, int tab, QMenuItem* mi,
                                        const QPalette& pal,
                                        bool act, bool enabled, int x, int y, int w, int h)
 {
-#ifndef QT_NO_MENUDATA    
+#ifndef QT_NO_MENUDATA
     const QColorGroup & g = pal.active();
             bool dis  = !enabled;
     QColorGroup itemg = dis ? pal.disabled() : pal.active();
 
     if ( checkable )
         maxpmw = QMAX( maxpmw, 8 ); // space for the checkmarks
 
             int checkcol  =     maxpmw;
 
             if ( mi && mi->isSeparator() ) {            // draw separator
         p->setPen( g.dark() );
         p->drawLine( x, y, x+w, y );
         p->setPen( g.light() );
         p->drawLine( x, y+1, x+w, y+1 );
         return;
     }
 
     QBrush fill = act? g.brush( QColorGroup::Highlight ) :
                             g.brush( QColorGroup::Button );
     p->fillRect( x, y, w, h, fill);
 
     if ( !mi )
         return;
 
     if ( mi->isChecked() ) {
         if ( act && !dis ) {
             qDrawShadePanel( p, x, y, checkcol, h,
                              g, TRUE, 1, &g.brush( QColorGroup::Button ) );
         } else {
             qDrawShadePanel( p, x, y, checkcol, h,
                              g, TRUE, 1, &g.brush( QColorGroup::Midlight ) );
         }
     } else if ( !act ) {
         p->fillRect(x, y, checkcol , h,
                     g.brush( QColorGroup::Button ));
     }
 
             if ( mi->iconSet() ) {      // draw iconset
         QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal;
         if (act && !dis )
             mode = QIconSet::Active;
-        QPixmap pixmap = mi->iconSet()->pixmap( QIconSet::Small, mode );
+    QPixmap pixmap;
+    if ( mode == QIconSet::Disabled )
+        pixmap = mi->iconSet()->pixmap( QIconSet::Automatic, mode );
+    else
+        pixmap = mi->iconSet()->pixmap();
         int pixw = pixmap.width();
         int pixh = pixmap.height();
         if ( act && !dis ) {
             if ( !mi->isChecked() )
                 qDrawShadePanel( p, x, y, checkcol, h, g, FALSE,  1, &g.brush( QColorGroup::Button ) );
         }
         QRect cr( x, y, checkcol, h );
         QRect pmr( 0, 0, pixw, pixh );
         pmr.moveCenter( cr.center() );
         p->setPen( itemg.text() );
         p->drawPixmap( pmr.topLeft(), pixmap );
 
         QBrush fill = act? g.brush( QColorGroup::Highlight ) :
                               g.brush( QColorGroup::Button );
         p->fillRect( x+checkcol + 1, y, w - checkcol - 1, h, fill);
             } else  if ( checkable ) {// just "checking"...
         int mw = checkcol + motifItemFrame;
         int mh = h - 2*motifItemFrame;
         if ( mi->isChecked() ) {
             drawCheckMark( p, x + motifItemFrame + 2,
                            y+motifItemFrame, mw, mh, itemg, act, dis );
         }
     }
 
     p->setPen( act ? g.highlightedText() : g.buttonText() );
 
     QColor discol;
     if ( dis ) {
         discol = itemg.text();
         p->setPen( discol );
     }
 
     int xm = motifItemFrame + checkcol + motifItemHMargin;
 
     if ( mi->custom() ) {
         int m = motifItemVMargin;
         p->save();
         if ( dis && !act ) {
             p->setPen( g.light() );
             mi->custom()->paint( p, itemg, act, enabled,
                                  x+xm+1, y+m+1, w-xm-tab+1, h-2*m );
             p->setPen( discol );
         }
         mi->custom()->paint( p, itemg, act, enabled,
                              x+xm, y+m, w-xm-tab+1, h-2*m );
         p->restore();
     }
     QString s = mi->text();