ich@opiezilla:~/programming/opie/head/opie$ nm lib/libopiecore2.so | grep polish

         U _ZN14QPEApplication6polishEP7QWidget


	 ich@opiezilla:~/programming/opie/head/opie$ nm lib/libopiecore2.so | grep polish
	          U _ZN12QApplication6polishEP7QWidget


        in qt_override we had to overwrite the Palette for some widgets for some styles (setting no
        background liquid and such) we overwrote the polish method.
        As we did not inherit from QPEApplication the 'polish' symbol was only internal to
        libqpe and this way Opie apps worked on Opies and Sharps libqpe, and Sharp apps work
        on our libqpe. Now with libopiecore the compiler tries to include different symbols as shown above.
        So for now we could disable the legacy palette polishing which shouldn't hurt anyway.
        OApplication is the source of all evil, we wouldn't 'pull' in the polish symbol... but having
	a 'shadow' weak symbol as backup isn't good as well.


	Chicken you may enable the option in config.in...

2 files changed, 10 insertions, 1 deletions

diff --git a/library/qpeapplication.h b/library/qpeapplication.h
index 8c85ad0..d2782e4 100644
--- a/library/qpeapplication.h
+++ b/library/qpeapplication.h
@@ -143,51 +143,53 @@ signals:
     void volumeChanged( bool muted );
     void appMessage( const QCString& msg, const QByteArray& data);
     void weekChanged( bool startOnMonday );
     void dateFormatChanged( DateFormat );
     void flush();
     void reload();
     /* linkChanged signal */
 
 private slots:
     void systemMessage( const QCString &msg, const QByteArray &data );
     void pidMessage( const QCString &msg, const QByteArray &data );
     void removeSenderFromStylusDict();
     void hideOrQuit();
 
 protected:
     bool qwsEventFilter( QWSEvent * );
     void internalSetStyle( const QString &style );
     void prepareForTermination(bool willrestart);
     virtual void restart();
     virtual void shutdown();
     bool eventFilter( QObject *, QEvent * );
     void timerEvent( QTimerEvent * );
     bool raiseAppropriateWindow();
     virtual void tryQuit();
+#ifndef OPIE_NO_ERASE_RECT_HACKFIX
 #if QT_VERSION > 233
     virtual void polish ( QWidget * ); // this is actually implemented in qt_override.cpp (!)
 #endif
+#endif
 private:
 #ifndef QT_NO_TRANSLATION
     void installTranslation( const QString& baseName );
 #endif
     void mapToDefaultAction( QWSKeyEvent *ke, int defKey );
     void processQCopFile();
 
 #if defined(Q_WS_QWS) && !defined(QT_NO_COP)
     QCopChannel *sysChannel;
     QCopChannel *pidChannel;
 #endif
     QPEApplicationData *d;
 
     bool reserved_sh;
 
 
 
 };
 
 inline void QPEApplication::showDialog( QDialog* d, bool nomax )
 {
     showWidget( d, nomax );
 }
 
diff --git a/library/qt_override.cpp b/library/qt_override.cpp
index 4d1f475..56f82d7 100644
--- a/library/qt_override.cpp
+++ b/library/qt_override.cpp
@@ -1,55 +1,60 @@
 
 #include <qpe/qpeapplication.h>
 #include <qfontdatabase.h>
 
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <limits.h>
 #include <sys/param.h> // for toolchains with old libc headers
 
 #include "qt_override_p.h"
 
 #if QT_VERSION > 233
 
+#ifndef OPIE_NO_ERASE_RECT_HACKFIX
 struct color_fix_t {
         char *m_app;
         char *m_class;
         char *m_name;
         QColorGroup::ColorRole m_set;
         QColorGroup::ColorRole m_get;
 };
 
-#ifndef OPIE_NO_OVERRIDE_QT
+
 
 static const color_fix_t apps_that_need_special_colors [] = {
         { "HancomMobileWord", "HTextEdit", 0, QColorGroup::Background, QColorGroup::Base },
         { "neocal", "Display", 0, QColorGroup::Background, QColorGroup::Base },
 
         { 0, 0, 0, QColorGroup::Base, QColorGroup::Base }
 };
 
+#endif
+
+#ifndef OPIE_NO_OVERRIDE_QT
+
 static const char * const apps_that_need_pointsizes_times_10 [] = {
         "HancomMobileWord",
         "hancomsheet",
         "HancomPresenterViewer",
 
         0
 };
 
 
 
 
 int Opie::force_appearance = 0;
 
 
 // Return the *real* name of the binary - not just a quick guess
 // by looking at argv [0] (which could be anything)
 
 static void binaryNameFree ( )
 {
         ::free ((void *) Opie::binaryName ( )); // we need to cast away the const here
 }
 
 const char *Opie::binaryName ( )
 {
@@ -68,69 +73,71 @@ const char *Opie::binaryName ( )
 
                 ::atexit ( binaryNameFree );
         }
         return appname;
 }
 
 #else
 int Opie::force_appearance = 0;
 #endif
 
 // Fix for a toolchain incompatibility (binaries compiled with
 // old tcs using shared libs compiled with newer tcs)
 
 extern "C" {
 
 extern void __gmon_start__ ( ) __attribute__(( weak ));
 
 extern void __gmon_start__ ( )
 {
 }
 
 }
 
 
+#ifndef OPIE_NO_ERASE_RECT_HACKFIX
 // Fix for apps, that use QPainter::eraseRect() which doesn't work with styles
 // that set a background pixmap (it would be easier to fix eraseRect(), but
 // TT made it an inline ...)
 
 void QPEApplication::polish ( QWidget *w )
 {
 #ifndef OPIE_NO_OVERRIDE_QT
         //qDebug ( "QPEApplication::polish()" );
 
         for ( const color_fix_t *ptr = apps_that_need_special_colors; ptr-> m_app; ptr++ ) {
                 if (( ::strcmp ( Opie::binaryName ( ), ptr-> m_app ) == 0 ) &&
                     ( ptr-> m_class ? w-> inherits ( ptr-> m_class ) : true ) &&
                     ( ptr-> m_name ? ( ::strcmp ( w-> name ( ), ptr-> m_name ) == 0 ) : true )) {
                         QPalette pal = w-> palette ( );
                         pal. setColor ( ptr-> m_set, pal. color ( QPalette::Active, ptr-> m_get ));
                         w-> setPalette ( pal );
                 }
         }
 #endif
         QApplication::polish ( w );
 }
+#endif
 
 
 #ifndef OPIE_NO_OVERRIDE_QT
 // Fix for the binary incompatibility that TT introduced in Qt/E 2.3.4 -- point sizes
 // were multiplied by 10 (which was incorrect)
 
 QValueList <int> QFontDatabase::pointSizes ( QString const &family, QString const &style, QString const &charset )
 {
         //qDebug ( "QFontDatabase::pointSizes()" );
 
         QValueList <int> sl = pointSizes_NonWeak ( family, style, charset );
 
         for ( const char * const *ptr = apps_that_need_pointsizes_times_10; *ptr; ptr++ ) {
                 if ( ::strcmp ( Opie::binaryName ( ), *ptr ) == 0 ) {
                         for ( QValueList <int>::Iterator it = sl. begin ( ); it != sl. end ( ); ++it )
                                 *it *= 10;
                 }
         }
         return sl;
 }
 
 
 // Various style/font/color related overrides for weak symbols in Qt/E,
 // which allows us to force the usage of the global Opie appearance.