SzModem:

Make it compile remove = 0 from sendFile
Add a Type to Sz
so it could cover SX,SY too

MetaFactory:
 take QCString name
 QString uiString
 so Carsten will be able to translate
 and users can switch Language without losing profiles

Default
 It's aware of all Default/BuiltIn Plugins and adds them to the factory
Common
 typedef bool BOOL TT is not using bool because it wasn't available at that time
 they use uint : 1...
 maybe we should change UINT_8 to Q_UINT8...

MainWindow:
 give the factory to the config widget
 use Default
IOLayer
 reload should take Profile not Config

ConfigDialog:
 make use of Factory and do not do new MetaFactory.. i should
 make the c'tor private and add MainWindow as friend

ProfileEditorDialog:
 Huge clean ups to the architecture. I still need to convert
 the widgets.
 Use the factory right

1 files changed, 6 insertions, 4 deletions

diff --git a/noncore/apps/opie-console/configdialog.cpp b/noncore/apps/opie-console/configdialog.cpp
index ee1ffb4..50512b6 100644
--- a/noncore/apps/opie-console/configdialog.cpp
+++ b/noncore/apps/opie-console/configdialog.cpp
@@ -8,105 +8,107 @@
 
 class ConfigListItem : public QListViewItem {
 public:
     ConfigListItem( QListView* item, const Profile& );
     ~ConfigListItem();
     Profile profile()const;
 
 private:
     Profile m_prof;
 };
 ConfigListItem::ConfigListItem( QListView* item, const Profile& prof )
     : QListViewItem( item ), m_prof( prof )
 {
     setText(0, prof.name() );
 }
 ConfigListItem::~ConfigListItem() {
 
 }
 Profile ConfigListItem::profile()const {
     return m_prof;
 }
 
 /* Dialog */
 
-ConfigDialog::ConfigDialog( const Profile::ValueList& lis, QWidget* parent )
-    : ConfigureBase( parent, 0, TRUE )
+ConfigDialog::ConfigDialog( const Profile::ValueList& lis, MetaFactory* fa,
+                            QWidget* parent )
+    : ConfigureBase( parent, 0, TRUE ), m_fact( fa )
 {
     //init();
     {
         Profile::ValueList::ConstIterator it;
         for (it = lis.begin(); it != lis.end(); ++it ) {
             new ConfigListItem( lstView, (*it) );
         }
     }
 }
 ConfigDialog::~ConfigDialog() {
 
 }
 Profile::ValueList ConfigDialog::list()const {
 /* iterate over the list */
     Profile::ValueList lst;
     QListViewItemIterator it(lstView);
     for ( ; it.current(); ++it ) {
         ConfigListItem* item = (ConfigListItem*)it.current();
         lst.append( item->profile() );
     }
     return lst;
 }
 /* our slots */
 void ConfigDialog::slotRemove() {
     ConfigListItem* item = (ConfigListItem*)lstView->currentItem();
     if (!item )
         return;
 
     lstView->takeItem( item );
     delete item;
 }
 
 void ConfigDialog::slotEdit() {
         Profile p;
 
         if(!lstView->currentItem()) return;
 
         // Load profile
         p = ((ConfigListItem*)lstView->currentItem())->profile();
 
-        ProfileEditorDialog dlg(new MetaFactory(), p);
+        ProfileEditorDialog dlg(m_fact, p);
 
         dlg.setCaption("Edit Connection Profile");
         dlg.showMaximized();
         int ret = dlg.exec();
 
         if(ret == QDialog::Accepted)
         {
                 if(lstView->currentItem()) delete lstView->currentItem();
 
                 // use dlg.terminal()!
                 Profile p = dlg.profile();
 
                 new ConfigListItem(lstView, p);
         }
 }
 
 
 void ConfigDialog::slotAdd() {
-        ProfileEditorDialog dlg(new MetaFactory());
+    qWarning("slotAdd");
+        ProfileEditorDialog dlg(m_fact);
 
         dlg.setCaption("New Connection");
         dlg.showMaximized();
         int ret = dlg.exec();
 
         if(ret == QDialog::Accepted)
         {
                 // TODO: Move into general profile save part
                 // assignments
                 //QString type = dlg.term_type();
                 //if(type == "VT102") profile = Profile::VT102;
 
                 // get profile from editor
                 Profile p = dlg.profile();
 
                 new ConfigListItem(lstView, p);
         }
 }