author | zecke <zecke> | 2002-10-15 01:14:17 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-10-15 01:14:17 (UTC) |
commit | e0efd37513192d9a17fa9a9f46bbaed0ca38029c (patch) (unidiff) | |
tree | 04163d93fc4c4185d322912e9430eff9b36b71cc /noncore/apps/opie-console | |
parent | b12b38a00c66ddc100f3fff75478539b8b797928 (diff) | |
download | opie-e0efd37513192d9a17fa9a9f46bbaed0ca38029c.zip opie-e0efd37513192d9a17fa9a9f46bbaed0ca38029c.tar.gz opie-e0efd37513192d9a17fa9a9f46bbaed0ca38029c.tar.bz2 |
The right way to deal with the pipe
-rw-r--r-- | noncore/apps/opie-console/MyPty.cpp | 10 | ||||
-rw-r--r-- | noncore/apps/opie-console/MyPty.h | 2 |
2 files changed, 9 insertions, 3 deletions
diff --git a/noncore/apps/opie-console/MyPty.cpp b/noncore/apps/opie-console/MyPty.cpp index cacb4ce..ae01392 100644 --- a/noncore/apps/opie-console/MyPty.cpp +++ b/noncore/apps/opie-console/MyPty.cpp | |||
@@ -116,7 +116,9 @@ void MyPty::donePty() | |||
116 | if (m_cpid) { | 116 | if (m_cpid) { |
117 | qWarning("killing!!!"); | 117 | qWarning("killing!!!"); |
118 | kill(m_cpid, SIGHUP); | 118 | kill(m_cpid, SIGHUP); |
119 | waitpid(m_cpid, &status, 0); | 119 | //waitpid(m_cpid, &status, 0); |
120 | delete m_sn_e; | ||
121 | m_sn_e = 0l; | ||
120 | } | 122 | } |
121 | 123 | ||
122 | m_cpid = 0; | 124 | m_cpid = 0; |
@@ -186,9 +188,10 @@ int MyPty::run(const char* cmd, QStrList &, const char*, int) | |||
186 | 188 | ||
187 | // parent - continue as a widget | 189 | // parent - continue as a widget |
188 | QSocketNotifier* sn_r = new QSocketNotifier(m_fd,QSocketNotifier::Read,this); | 190 | QSocketNotifier* sn_r = new QSocketNotifier(m_fd,QSocketNotifier::Read,this); |
189 | // QSocketNotifier* sn_e = new QSocketNotifier(m_fd,QSocketNotifier::Exception,this); | 191 | delete m_sn_e; |
192 | m_sn_e = new QSocketNotifier(m_fd,QSocketNotifier::Exception,this); | ||
190 | connect(sn_r,SIGNAL(activated(int)),this,SLOT(readPty())); | 193 | connect(sn_r,SIGNAL(activated(int)),this,SLOT(readPty())); |
191 | // connect(sn_e,SIGNAL(activated(int)),this,SLOT(error())); | 194 | connect(m_sn_e,SIGNAL(activated(int)),this,SLOT(error())); |
192 | 195 | ||
193 | return 0; | 196 | return 0; |
194 | } | 197 | } |
@@ -232,6 +235,7 @@ int MyPty::openPty() | |||
232 | */ | 235 | */ |
233 | MyPty::MyPty(const Profile&) : m_cpid(0) | 236 | MyPty::MyPty(const Profile&) : m_cpid(0) |
234 | { | 237 | { |
238 | m_sn_e = 0l; | ||
235 | m_fd = openPty(); | 239 | m_fd = openPty(); |
236 | ProcCtl* ctl = ProcCtl::self(); | 240 | ProcCtl* ctl = ProcCtl::self(); |
237 | } | 241 | } |
diff --git a/noncore/apps/opie-console/MyPty.h b/noncore/apps/opie-console/MyPty.h index 9231a8a..3166fa0 100644 --- a/noncore/apps/opie-console/MyPty.h +++ b/noncore/apps/opie-console/MyPty.h | |||
@@ -28,6 +28,7 @@ | |||
28 | #include "io_layer.h" | 28 | #include "io_layer.h" |
29 | 29 | ||
30 | class Profile; | 30 | class Profile; |
31 | class QSocketNotifier; | ||
31 | class MyPty : public IOLayer | 32 | class MyPty : public IOLayer |
32 | { | 33 | { |
33 | Q_OBJECT | 34 | Q_OBJECT |
@@ -90,6 +91,7 @@ private: | |||
90 | char m_ttynam[16]; // "/dev/ttyxx" | "/dev/pts/########..." | 91 | char m_ttynam[16]; // "/dev/ttyxx" | "/dev/pts/########..." |
91 | int m_fd; | 92 | int m_fd; |
92 | int m_cpid; | 93 | int m_cpid; |
94 | QSocketNotifier* m_sn_e; | ||
93 | }; | 95 | }; |
94 | 96 | ||
95 | #endif | 97 | #endif |