author | erik <erik> | 2007-01-29 22:00:04 (UTC) |
---|---|---|
committer | erik <erik> | 2007-01-29 22:00:04 (UTC) |
commit | 9a3875c32922a322d991e67b13e89242f71a862c (patch) (unidiff) | |
tree | 4f5c7c79f7e1ee70f19b5cc3d75131b8151ad9cd /noncore/apps | |
parent | 02ef45be75a3024df11365956e1cce6392d9103c (diff) | |
download | opie-9a3875c32922a322d991e67b13e89242f71a862c.zip opie-9a3875c32922a322d991e67b13e89242f71a862c.tar.gz opie-9a3875c32922a322d991e67b13e89242f71a862c.tar.bz2 |
Each file in this commit exhibits a problem where a variable is made in
some way but never used. This is a tricky problem with Qt since almost all
UI forms are made but not used (like QLabel). But I am pretty confident that
these changes are correct and do not have any aspect of a change to the UI.
In most cases, there are just variables that are made and then copied over
(like in iteration over lists or assignment of pointers based on
conditionals).
-rw-r--r-- | noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp | 2 | ||||
-rw-r--r-- | noncore/apps/tinykate/mainwindow/tinykate.cpp | 6 |
2 files changed, 2 insertions, 6 deletions
diff --git a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp index 9fa4452..d8f5aa7 100644 --- a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp +++ b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp | |||
@@ -36,51 +36,49 @@ SyntaxDocument::SyntaxDocument() | |||
36 | { | 36 | { |
37 | m_root=0; | 37 | m_root=0; |
38 | currentFile=""; | 38 | currentFile=""; |
39 | setupModeList(); | 39 | setupModeList(); |
40 | } | 40 | } |
41 | 41 | ||
42 | void SyntaxDocument::setIdentifier(const QString& identifier) | 42 | void SyntaxDocument::setIdentifier(const QString& identifier) |
43 | { | 43 | { |
44 | #warning FIXME delete m_root; | 44 | #warning FIXME delete m_root; |
45 | m_root=Opie::Core::XMLElement::load(identifier); | 45 | m_root=Opie::Core::XMLElement::load(identifier); |
46 | if (!m_root) KMessageBox::error( 0L, i18n("Can't open %1").arg(identifier) ); | 46 | if (!m_root) KMessageBox::error( 0L, i18n("Can't open %1").arg(identifier) ); |
47 | 47 | ||
48 | } | 48 | } |
49 | 49 | ||
50 | SyntaxDocument::~SyntaxDocument() | 50 | SyntaxDocument::~SyntaxDocument() |
51 | { | 51 | { |
52 | } | 52 | } |
53 | 53 | ||
54 | void SyntaxDocument::setupModeList(bool force) | 54 | void SyntaxDocument::setupModeList(bool force) |
55 | { | 55 | { |
56 | 56 | ||
57 | if (myModeList.count() > 0) return; | 57 | if (myModeList.count() > 0) return; |
58 | 58 | ||
59 | KateConfig *config=KGlobal::config(); | 59 | KateConfig *config=KGlobal::config(); |
60 | KStandardDirs *dirs = KGlobal::dirs(); | ||
61 | 60 | ||
62 | // QStringList list=dirs->findAllResources("data","kate/syntax/*.xml",false,true); | ||
63 | QString path=QPEApplication::qpeDir() +"share/tinykate/syntax/"; | 61 | QString path=QPEApplication::qpeDir() +"share/tinykate/syntax/"; |
64 | 62 | ||
65 | QDir dir(path); | 63 | QDir dir(path); |
66 | QStringList list=dir.entryList("*.xml"); | 64 | QStringList list=dir.entryList("*.xml"); |
67 | 65 | ||
68 | for ( QStringList::Iterator it = list.begin(); it != list.end(); ++it ) | 66 | for ( QStringList::Iterator it = list.begin(); it != list.end(); ++it ) |
69 | { | 67 | { |
70 | QString Group="Highlighting_Cache"+path+*it; | 68 | QString Group="Highlighting_Cache"+path+*it; |
71 | if ((config->hasGroup(Group)) && (!force)) | 69 | if ((config->hasGroup(Group)) && (!force)) |
72 | { | 70 | { |
73 | config->setGroup(Group); | 71 | config->setGroup(Group); |
74 | syntaxModeListItem *mli=new syntaxModeListItem; | 72 | syntaxModeListItem *mli=new syntaxModeListItem; |
75 | mli->name = config->readEntry("name",""); | 73 | mli->name = config->readEntry("name",""); |
76 | mli->section = config->readEntry("section",""); | 74 | mli->section = config->readEntry("section",""); |
77 | mli->mimetype = config->readEntry("mimetype",""); | 75 | mli->mimetype = config->readEntry("mimetype",""); |
78 | mli->extension = config->readEntry("extension",""); | 76 | mli->extension = config->readEntry("extension",""); |
79 | mli->identifier = path+*it; | 77 | mli->identifier = path+*it; |
80 | myModeList.append(mli); | 78 | myModeList.append(mli); |
81 | } | 79 | } |
82 | else | 80 | else |
83 | { | 81 | { |
84 | odebug << "Found a description file:"+path+(*it) << oendl; | 82 | odebug << "Found a description file:"+path+(*it) << oendl; |
85 | setIdentifier(path+(*it)); | 83 | setIdentifier(path+(*it)); |
86 | Opie::Core::XMLElement *e=m_root; | 84 | Opie::Core::XMLElement *e=m_root; |
diff --git a/noncore/apps/tinykate/mainwindow/tinykate.cpp b/noncore/apps/tinykate/mainwindow/tinykate.cpp index e87464e..e920d5b 100644 --- a/noncore/apps/tinykate/mainwindow/tinykate.cpp +++ b/noncore/apps/tinykate/mainwindow/tinykate.cpp | |||
@@ -182,72 +182,71 @@ TinyKate::TinyKate( QWidget *parent, const char *name, WFlags f) : | |||
182 | TinyKate::~TinyKate( ) | 182 | TinyKate::~TinyKate( ) |
183 | { | 183 | { |
184 | owarn << "TinyKate destructor\n" << oendl; | 184 | owarn << "TinyKate destructor\n" << oendl; |
185 | 185 | ||
186 | if( KGlobal::config() != 0 ) | 186 | if( KGlobal::config() != 0 ) |
187 | { | 187 | { |
188 | owarn << "deleting KateConfig object..\n" << oendl; | 188 | owarn << "deleting KateConfig object..\n" << oendl; |
189 | delete KGlobal::config(); | 189 | delete KGlobal::config(); |
190 | } | 190 | } |
191 | } | 191 | } |
192 | 192 | ||
193 | void TinyKate::slotOpen( ) | 193 | void TinyKate::slotOpen( ) |
194 | { | 194 | { |
195 | QString filename = OFileDialog::getOpenFileName( OFileSelector::EXTENDED_ALL, | 195 | QString filename = OFileDialog::getOpenFileName( OFileSelector::EXTENDED_ALL, |
196 | QString::null); | 196 | QString::null); |
197 | if (!filename.isEmpty()) | 197 | if (!filename.isEmpty()) |
198 | { | 198 | { |
199 | open(filename); | 199 | open(filename); |
200 | } | 200 | } |
201 | } | 201 | } |
202 | 202 | ||
203 | void TinyKate::open(const QString & filename) | 203 | void TinyKate::open(const QString & filename) |
204 | { | 204 | { |
205 | KateDocument *kd= new KateDocument(false, false, this,0,this); | 205 | KateDocument *kd= new KateDocument(false, false, this,0,this); |
206 | KTextEditor::View *kv; | ||
207 | QString realFileName; | 206 | QString realFileName; |
208 | //check if filename is a .desktop file | 207 | //check if filename is a .desktop file |
209 | if ( filename.find( ".desktop", 0, true ) != -1 ) { | 208 | if ( filename.find( ".desktop", 0, true ) != -1 ) { |
210 | switch ( QMessageBox::warning( this, tr( "TinyKATE" ), | 209 | switch ( QMessageBox::warning( this, tr( "TinyKATE" ), |
211 | tr("TinyKATE has detected<BR>you selected a <B>.desktop</B> file.<BR>Open <B>.desktop</B> file or <B>linked</B> file?" ), | 210 | tr("TinyKATE has detected<BR>you selected a <B>.desktop</B> file.<BR>Open <B>.desktop</B> file or <B>linked</B> file?" ), |
212 | tr(".desktop File"), | 211 | tr(".desktop File"), |
213 | tr("Linked Document"), 0, 1, 1 ) ) | 212 | tr("Linked Document"), 0, 1, 1 ) ) |
214 | { | 213 | { |
215 | case 0: //desktop | 214 | case 0: //desktop |
216 | realFileName = filename; | 215 | realFileName = filename; |
217 | break; | 216 | break; |
218 | case 1: //linked | 217 | case 1: //linked |
219 | DocLnk docLnk( filename ); | 218 | DocLnk docLnk( filename ); |
220 | realFileName = docLnk.file(); | 219 | realFileName = docLnk.file(); |
221 | break; | 220 | break; |
222 | }; | 221 | }; |
223 | } else { | 222 | } else { |
224 | realFileName = filename; | 223 | realFileName = filename; |
225 | } | 224 | } |
226 | 225 | ||
227 | QFileInfo fileInfo( realFileName ); | 226 | QFileInfo fileInfo( realFileName ); |
228 | QString filenamed = fileInfo.fileName(); | 227 | QString filenamed = fileInfo.fileName(); |
229 | tabwidget->addTab(kv=kd->createView(tabwidget,"bLAH"),"tinykate/tinykate", filenamed ); | 228 | tabwidget->addTab(kd->createView(tabwidget,"Unnamed kateview"),"tinykate/tinykate", filenamed ); |
230 | odebug << realFileName << oendl; | 229 | odebug << realFileName << oendl; |
231 | 230 | ||
232 | kd->setDocName( filenamed); | 231 | kd->setDocName( filenamed); |
233 | kd->open( realFileName ); | 232 | kd->open( realFileName ); |
234 | viewCount++; | 233 | viewCount++; |
235 | } | 234 | } |
236 | 235 | ||
237 | void TinyKate::setDocument(const QString& fileref) | 236 | void TinyKate::setDocument(const QString& fileref) |
238 | { | 237 | { |
239 | open( fileref ); | 238 | open( fileref ); |
240 | } | 239 | } |
241 | 240 | ||
242 | void TinyKate::slotCurrentChanged( QWidget * view) | 241 | void TinyKate::slotCurrentChanged( QWidget * view) |
243 | { | 242 | { |
244 | if (currentView) | 243 | if (currentView) |
245 | { | 244 | { |
246 | 245 | ||
247 | disconnect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy())); | 246 | disconnect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy())); |
248 | disconnect(editCut,SIGNAL(clicked()),currentView,SLOT(cut())); | 247 | disconnect(editCut,SIGNAL(clicked()),currentView,SLOT(cut())); |
249 | disconnect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste())); | 248 | disconnect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste())); |
250 | disconnect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo())); | 249 | disconnect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo())); |
251 | disconnect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo())); | 250 | disconnect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo())); |
252 | disconnect(editFind,SIGNAL(activated()),currentView,SLOT(find())); | 251 | disconnect(editFind,SIGNAL(activated()),currentView,SLOT(find())); |
253 | disconnect(editReplace,SIGNAL(activated()),currentView,SLOT(replace())); | 252 | disconnect(editReplace,SIGNAL(activated()),currentView,SLOT(replace())); |
@@ -257,53 +256,52 @@ void TinyKate::slotCurrentChanged( QWidget * view) | |||
257 | disconnect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int))); | 256 | disconnect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int))); |
258 | disconnect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog())); | 257 | disconnect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog())); |
259 | } | 258 | } |
260 | 259 | ||
261 | currentView=(KTextEditor::View*)view; | 260 | currentView=(KTextEditor::View*)view; |
262 | 261 | ||
263 | connect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy())); | 262 | connect(editCopy,SIGNAL(clicked()),currentView,SLOT(copy())); |
264 | connect(editCut,SIGNAL(clicked()),currentView,SLOT(cut())); | 263 | connect(editCut,SIGNAL(clicked()),currentView,SLOT(cut())); |
265 | connect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste())); | 264 | connect(editPaste,SIGNAL(clicked()),currentView,SLOT(paste())); |
266 | connect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo())); | 265 | connect(editUndo,SIGNAL(clicked()),currentView,SLOT(undo())); |
267 | connect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo())); | 266 | connect(editRedo,SIGNAL(clicked()),currentView,SLOT(redo())); |
268 | connect(editFind,SIGNAL(activated()),currentView,SLOT(find())); | 267 | connect(editFind,SIGNAL(activated()),currentView,SLOT(find())); |
269 | connect(editReplace,SIGNAL(activated()),currentView,SLOT(replace())); | 268 | connect(editReplace,SIGNAL(activated()),currentView,SLOT(replace())); |
270 | connect(editGotoLine,SIGNAL(activated()),currentView,SLOT(gotoLine())); | 269 | connect(editGotoLine,SIGNAL(activated()),currentView,SLOT(gotoLine())); |
271 | connect(viewIncFontSizes,SIGNAL(activated()), currentView,SLOT(slotIncFontSizes())); | 270 | connect(viewIncFontSizes,SIGNAL(activated()), currentView,SLOT(slotIncFontSizes())); |
272 | connect(viewDecFontSizes,SIGNAL(activated()), currentView,SLOT(slotDecFontSizes())); | 271 | connect(viewDecFontSizes,SIGNAL(activated()), currentView,SLOT(slotDecFontSizes())); |
273 | connect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int))); | 272 | connect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int))); |
274 | connect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog())); | 273 | connect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog())); |
275 | 274 | ||
276 | } | 275 | } |
277 | 276 | ||
278 | void TinyKate::slotNew( ) | 277 | void TinyKate::slotNew( ) |
279 | { | 278 | { |
280 | KateDocument *kd= new KateDocument(false, false, this,0,this); | 279 | KateDocument *kd= new KateDocument(false, false, this,0,this); |
281 | KTextEditor::View *kv; | ||
282 | 280 | ||
283 | kd->setDocName(tr("Unnamed %1").arg(nextUnnamed++)); | 281 | kd->setDocName(tr("Unnamed %1").arg(nextUnnamed++)); |
284 | kd->setNewDoc(true); | 282 | kd->setNewDoc(true); |
285 | tabwidget->addTab(kv=kd->createView(tabwidget,"BLAH"), | 283 | tabwidget->addTab(kd->createView(tabwidget,"Unnamed"), |
286 | "tinykate/tinykate", | 284 | "tinykate/tinykate", |
287 | kd->docName()); | 285 | kd->docName()); |
288 | viewCount++; | 286 | viewCount++; |
289 | } | 287 | } |
290 | 288 | ||
291 | bool TinyKate::checkSave() { | 289 | bool TinyKate::checkSave() { |
292 | if (currentView==0) return true; | 290 | if (currentView==0) return true; |
293 | 291 | ||
294 | KateView *kv = (KateView*) currentView; | 292 | KateView *kv = (KateView*) currentView; |
295 | if(kv->isModified()) { | 293 | if(kv->isModified()) { |
296 | KateDocument *kd = (KateDocument*) kv->document(); | 294 | KateDocument *kd = (KateDocument*) kv->document(); |
297 | switch( QMessageBox::information( 0, (tr("TinyKATE")), | 295 | switch( QMessageBox::information( 0, (tr("TinyKATE")), |
298 | (tr("Do you want to save\n" | 296 | (tr("Do you want to save\n" |
299 | "changes to the document\n" | 297 | "changes to the document\n" |
300 | "%1?\n").arg(kd->docName())), | 298 | "%1?\n").arg(kd->docName())), |
301 | (tr("Save")), (tr("Don't Save")), (tr("&Cancel")), 2, 2 ) ) | 299 | (tr("Save")), (tr("Don't Save")), (tr("&Cancel")), 2, 2 ) ) |
302 | { | 300 | { |
303 | case 0: | 301 | case 0: |
304 | { | 302 | { |
305 | return saveDocument(); | 303 | return saveDocument(); |
306 | } | 304 | } |
307 | break; | 305 | break; |
308 | 306 | ||
309 | case 1: | 307 | case 1: |