applied the patch generated by the optimize_connect script from

TT.

4 files changed, 13 insertions, 13 deletions

diff --git a/noncore/comm/keypebble/krfbcanvas.cpp b/noncore/comm/keypebble/krfbcanvas.cpp
index 75cba68..cd1fda0 100644
--- a/noncore/comm/keypebble/krfbcanvas.cpp
+++ b/noncore/comm/keypebble/krfbcanvas.cpp
@@ -1,200 +1,200 @@
 #include "krfbconnection.h"
 #include "krfbcanvas.h"
 #include "krfbbuffer.h"
 
 #include <qpe/qpeapplication.h>
 
 #include <qclipboard.h>
 
 KRFBCanvas::KRFBCanvas( QWidget *parent, const char *name )
   : QScrollView( parent, name )
 {
     connection_ = new KRFBConnection();
     connect( connection_, SIGNAL( loggedIn() ),
             this, SLOT( loggedIn() ) );
 
     loggedIn_ = false;
 
                 //QPEApplication::setStylusOperation(viewport(), QPEApplication::RightOnHold);
 
     viewport()->setFocusPolicy( QWidget::StrongFocus );
     viewport()->setFocus();
 
     nextRightClick=0;
     nextDoubleClick=0;
 }
 
 KRFBCanvas::~KRFBCanvas()
 {
 }
 
 
 void KRFBCanvas::openConnection(KRFBServer server)
 {
 
   
                 QCString host = server.hostname.latin1();
                 password=server.password;
                 connection_->connectTo( server);
 }
 
 
 void KRFBCanvas::openURL( const QUrl &url )
 {
   if ( loggedIn_ ) {
       qWarning( "openURL invoked when logged in\n" );
       return;
   }
 
   QCString host = url.host().latin1();
   int display = url.port();
 
 //  connection_->connectTo( host, display );
 }
 
 void KRFBCanvas::closeConnection()
 {
   loggedIn_ = false;
   connection_->disconnect();
 
   viewport()->setMouseTracking( false );
   viewport()->setBackgroundMode( PaletteDark );
   setBackgroundMode( PaletteDark );
   update();
 }
 
 
 void KRFBCanvas::bell()
 {
   if ( connection_->options()->deIconify ) {
     topLevelWidget()->raise();
     topLevelWidget()->show();
   }
 }
 
 void KRFBCanvas::loggedIn()
 {
   qWarning( "Ok, we're logged in" );
 
   //
   // Get ready for action
   //
   loggedIn_ = true;
   viewport()->setMouseTracking( true );
   viewport()->setBackgroundMode( NoBackground );
   setBackgroundMode( NoBackground );
 
   // Start using the buffer
-  connect( connection_->buffer(), SIGNAL( sizeChanged( int, int ) ),
+  connect( connection_->buffer(), SIGNAL( sizeChanged(int,int) ),
            this, SLOT( resizeContents(int,int) ) );
-  connect( connection_->buffer(), SIGNAL( updated( int, int, int, int ) ),
+  connect( connection_->buffer(), SIGNAL( updated(int,int,int,int) ),
            this, SLOT( viewportUpdate(int,int,int,int) ) );
   connect( connection_->buffer(), SIGNAL( bell() ),
            this, SLOT( bell() ) );
   connect( qApp->clipboard(), SIGNAL( dataChanged() ),
            this, SLOT( clipboardChanged() ) );
 }
 
 void KRFBCanvas::viewportPaintEvent( QPaintEvent *e )
 {
   QRect r = e->rect();
 
   if ( loggedIn_ ) {
                         QPixmap p;
 
     bitBlt( viewport(), r.x(), r.y(),
             connection_->buffer()->pixmap(),
             r.x() + contentsX(), r.y() + contentsY(),
             r.width(), r.height() );
   }
   else {
     QScrollView::viewportPaintEvent( e );
   }
 }
 
 void KRFBCanvas::viewportUpdate( int x, int y, int w, int h )
 {
   updateContents( x, y, w, h );
 }
 
 void KRFBCanvas::contentsMousePressEvent( QMouseEvent *e )
 {
 
   if (nextDoubleClick) {
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonPress, e->pos(),LeftButton,LeftButton));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonRelease, e->pos(),LeftButton,0));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonRelease, e->pos(),LeftButton,0));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonPress, e->pos(),NoButton,NoButton));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonRelease, e->pos(),NoButton,0));
   } if (nextRightClick) {
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonPress, e->pos(),RightButton,RightButton));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonRelease, e->pos(),RightButton,0));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonPress, e->pos(),NoButton,NoButton));
     connection_->buffer()->mouseEvent( &QMouseEvent(QEvent::MouseButtonRelease, e->pos(),NoButton,0));
   } else if ( loggedIn_ )
     connection_->buffer()->mouseEvent( e );
 
 }
 
 void KRFBCanvas::contentsMouseReleaseEvent( QMouseEvent *e )
 {
   if ( loggedIn_ && !nextRightClick && !nextDoubleClick) {
     connection_->buffer()->mouseEvent( e );
   }
 
   nextRightClick=0;
   nextDoubleClick=0;
 }
 
 void KRFBCanvas::contentsMouseMoveEvent( QMouseEvent *e )
 {
   if ( loggedIn_ )
     connection_->buffer()->mouseEvent( e );
 }
 
 void KRFBCanvas::keyPressEvent( QKeyEvent *e )
 {
   if ( loggedIn_ )
     connection_->buffer()->keyPressEvent( e );
 }
 
 void KRFBCanvas::keyReleaseEvent( QKeyEvent *e )
 {
   if ( loggedIn_ )
     connection_->buffer()->keyReleaseEvent( e );
 }
 
 void KRFBCanvas::refresh()
 {
   if ( loggedIn_ )
     connection_->refresh();
 }
 
 void KRFBCanvas::clipboardChanged()
 {
   if ( loggedIn_ ) {
       connection_->sendCutText( qApp->clipboard()->text() );
   }
 }
 void KRFBCanvas::sendCtlAltDel( void)
 {
 
   if ( loggedIn_ ) {
     connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyPress,Qt::Key_Control, 0,0));
     connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyPress,Qt::Key_Alt, 0,0));
                 connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyPress,Qt::Key_Delete, 0,0));
                 connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyRelease,Qt::Key_Control, 0,0));
                 connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyRelease,Qt::Key_Alt, 0,0));
     connection_->buffer()->keyPressEvent( &QKeyEvent(QEvent::KeyRelease,Qt::Key_Delete, 0,0));
         }
 }
 
 void KRFBCanvas::markDoubleClick( void)
 {
   nextRightClick=1;
 }
 
 void KRFBCanvas::markRightClick( void)
 {
   nextRightClick=1;
 }
diff --git a/noncore/comm/keypebble/krfbconnection.cpp b/noncore/comm/keypebble/krfbconnection.cpp
index e6c33c6..b447046 100644
--- a/noncore/comm/keypebble/krfbconnection.cpp
+++ b/noncore/comm/keypebble/krfbconnection.cpp
@@ -1,233 +1,233 @@
 #include <assert.h>
 #include <qsocket.h>
 #include <qtimer.h>
 #include <string.h>
 
 #include "krfbconnection.h"
 #include "krfblogin.h"
 #include "krfbdecoder.h"
 #include "krfbbuffer.h"
 
 KRFBConnection::KRFBConnection( QObject *parent )
                 : QObject( parent, "KRFBConnection" )
 {
                 portBase_ = 5900;
                 currentState_ = Disconnected;
                 sock = 0;
                 minData_ = 0;
                 options_ = new KRFBServer();
                 updater = 0;
                 decoder_ = 0;
                 buffer_ = 0;
 }
 
 KRFBConnection::~KRFBConnection()
 {
                 if ( ( currentState_ != Disconnected ) && ( currentState_ != Disconnecting ) && sock ) {
                                 disconnectDone();
                 }
                 delete options_;
 }
 
 void KRFBConnection::connectTo( KRFBServer server)
 {
                 if ( currentState_ != Disconnected )
                                 disconnect();
                 
     (*options_)=server;
 
                 sock = new QSocket( this, "rfbSocket" );
                 CHECK_PTR( sock );
 
                 // Connect to something to notice connection or error
-                connect( sock, SIGNAL( error( int ) ), SLOT( gotSocketError( int ) ) );
+                connect( sock, SIGNAL( error(int) ), SLOT( gotSocketError(int) ) );
                 connect( sock, SIGNAL( connected() ), SLOT( gotSocketConnection() ) );
 
                 qWarning( "Connecting..." );
 
                 currentState_ = Connecting;
                 sock->connectToHost( options_->hostname.latin1(), portBase_ + options_->display );
 }
 
 void KRFBConnection::disconnect()
 {
                 qWarning( "Disconnecting from server" );
 
                 if ( ( currentState_ != Disconnected )
                                                 && ( currentState_ != Disconnecting )
                                                 && sock ) {
                                 currentState_ = Disconnecting;
 
                                 connect( sock, SIGNAL( delayedCloseFinished() ), SLOT( disconnectDone() ) );
                                 sock->close();
 
                                 if ( sock->state() != QSocket::Closing )
                                                 disconnectDone();
                 }
 }
 
 void KRFBConnection::disconnectDone()
 {
                 currentState_ = Disconnected;
                 delete sock;
                 sock = 0;
                 minData_ = 0;
                 delete updater;
                 delete decoder_;
                 delete buffer_;
                 emit disconnected();
 }
 
 void KRFBConnection::gotSocketConnection()
 {
                 currentState_ = LoggingIn;
 
                 qWarning( "Connected, logging in..." );
 
                 static QString statusMsg = tr( "Connected" );
                 emit statusChanged( statusMsg );
 
                 // Do some login stuff
                 login = new KRFBLogin( this );
 }
 
 void KRFBConnection::gotRFBConnection()
 {
                 qWarning( "Logged into server" );
 
                 currentState_ = Connected;
                 emit connected();
 
                 // Create the decoder and start doing stuff
                 decoder_ = new KRFBDecoder( this );
                 CHECK_PTR( decoder_ );
 
                 buffer_ = new KRFBBuffer( decoder_, this, "RFB Buffer" );
                 CHECK_PTR( buffer_ );
                 decoder_->setBuffer( buffer_ );
 
-                connect( decoder_, SIGNAL( status( const QString & ) ),
-                                                this, SIGNAL( statusChanged( const QString & ) ) );
+                connect( decoder_, SIGNAL( status(const QString&) ),
+                                                this, SIGNAL( statusChanged(const QString&) ) );
                 emit loggedIn();
 
                 decoder_->start();
 
                 updater = new QTimer;
                 connect( updater, SIGNAL( timeout() ), SLOT( updateTimer() ) );
                 updater->start( options_->updateRate );
 }
 
 void KRFBConnection::gotSocketError( int err )
 {
                 currentState_ = Error;
 
                 // Do some error handling stuff
                 qWarning( "KRFBConnection: Socket error %d", err );
 
                 static QString refused = tr( "Connection Refused" );
                 static QString host = tr( "Host not found" );
                 static QString read = tr( "Read Error: QSocket reported an error reading\n"
                                                 "data, the remote host has probably dropped the\n"
                                                 "connection." );
                 static QString confused = tr( "QSocket reported an invalid error code" );
 
                 QString msg;
                 switch ( err ) {
                                 case QSocket::ErrConnectionRefused:
                                                 msg = refused;
                                                 break;
                                 case QSocket::ErrHostNotFound:
                                                 msg = host;
                                                 break;
                                 case QSocket::ErrSocketRead:
                                                 msg = read;
                                                 break;
                                 default:
                                                 msg = confused;
                 };
 
                 QObject::disconnect( sock, SIGNAL( readyRead() ), this, SLOT( gotMoreData() ) );
                 delete sock;
                 sock = 0;
                 currentState_ = Disconnected;
 
                 emit error( msg );
 }
 
 void KRFBConnection::gotMoreData()
 {
                 assert( minData_ > 0 );
 
                 if ( sock->size() >= minData_ ) {
                                 minData_ = 0;
                                 QObject::disconnect( sock, SIGNAL( readyRead() ), this, SLOT( gotMoreData() ) );
                                 emit gotEnoughData();
                 }
 }
 
 void KRFBConnection::waitForData( unsigned int sz )
 {
                 assert( minData_ == 0 );
                 assert( sz > 0 );
                 assert( currentState_ != Error );
 
                 if ( sock->size() >= sz ) {
                                 //    qWarning( "No need to wait for data" );
                                 emit gotEnoughData();
                 }
                 else {
                                 //    qWarning( "Waiting for %u bytes", sz );
                                 minData_ = sz;
                                 connect( sock, SIGNAL( readyRead() ), SLOT( gotMoreData() ) );
                 }
 }
 
 int KRFBConnection::read( void *buf, int sz )
 {
                 return sock->readBlock( (char *)  buf, sz );
 }
 
 int KRFBConnection::write( void *buf, int sz )
 {
                 return sock->writeBlock( (const char *) buf, sz );
 }
 
 KRFBConnection::State KRFBConnection::state() const
 {
                 return currentState_;
 }
 
 void KRFBConnection::setPortBase( int base )
 {
                 portBase_ = base;
 }
 
 int KRFBConnection::portBase() const
 {
                 return portBase_;
 }
 
 void KRFBConnection::updateTimer()
 {
                 decoder_->sendUpdateRequest( true );
 }
 
 void KRFBConnection::refresh()
 {
                 decoder_->sendUpdateRequest( false );
 }
 
 void KRFBConnection::sendCutText( const QString &text )
 {
                 decoder_->sendCutEvent( text );
 }
 
 const QUrl &KRFBConnection::url()
 {
                 url_.setProtocol( "vnc" );
                 url_.setPort( display() );
                 url_.setHost( host() );
                 url_.setPath( "/" );
 
                 return url_;
 }
diff --git a/noncore/comm/keypebble/krfblogin.cpp b/noncore/comm/keypebble/krfblogin.cpp
index 0b4a757..2bbd110 100644
--- a/noncore/comm/keypebble/krfblogin.cpp
+++ b/noncore/comm/keypebble/krfblogin.cpp
@@ -1,244 +1,244 @@
 #include <assert.h>
 
 
 extern "C" {
 #include "vncauth.h"
 }
 
 #include "krfblogin.h"
 #include "krfbconnection.h"
 #include <qtimer.h>
 
 // The length of the various messages (used to decide how many bytes to
 // wait for).
 const int ServerVersionLength = 12;
 const int ClientVersionLength = 12;
 const int AuthSchemeLength = 4;
 const int FailureReasonSizeLength = 4;
 const int ChallengeLength = 16;
 const int AuthResultLength = 4;
 
 // Authentication results
 enum AuthResult {
   AuthOk,
   AuthFailed,
   AuthTooMany
 };
 
 typedef unsigned char CARD8;
 typedef unsigned short CARD16;
 typedef unsigned long CARD32;
 
 const int endianTest = 1;
 
 // Endian stuff
 #define Swap16IfLE(s) \
     (*(char *)&endianTest ? ((((s) & 0xff) << 8) | (((s) >> 8) & 0xff)) : (s))
 
 #define Swap32IfLE(l) \
     (*(char *)&endianTest ? ((((l) & 0xff000000) >> 24) | \
                              (((l) & 0x00ff0000) >> 8)  | \
                              (((l) & 0x0000ff00) << 8)  | \
                              (((l) & 0x000000ff) << 24))  : (l))
 
 KRFBLogin::KRFBLogin( KRFBConnection *con )
   : QObject( con, "RFB login manager" )
 {
   assert( con );
   this->con = con;
   currentState = AwaitingServerVersion;
 
-  connect( this, SIGNAL( error( const QString & ) ),
-           con, SIGNAL( error( const QString & ) ) );
+  connect( this, SIGNAL( error(const QString&) ),
+           con, SIGNAL( error(const QString&) ) );
 
 
   qWarning( "Waiting for server version..." );
 
   static QString statusMsg = tr( "Waiting for server version..." );
   emit status( statusMsg );
 
   // Kick off the state machine
   connect( con, SIGNAL( gotEnoughData() ), SLOT( gotServerVersion() ) );
   con->waitForData( ServerVersionLength );
 }
 
 KRFBLogin::~KRFBLogin()
 {
 
 }
 
 KRFBLogin::State KRFBLogin::state() const
 {
   return currentState;
 }
 
 void KRFBLogin::gotServerVersion()
 {
   qWarning( "Got server version" );
 
   disconnect( con, SIGNAL( gotEnoughData() ), 
               this, SLOT( gotServerVersion() ) );
 
   // Read the server's version message
   char serverVersion[ ServerVersionLength + 1 ];
   con->read( serverVersion, ServerVersionLength );
   serverVersion[ ServerVersionLength ] = '\0';
 
   QCString rfbString( serverVersion, ServerVersionLength + 1 );
   versionString = rfbString;
 
   QRegExp regexp( "RFB [0-9][0-9][0-9]\\.[0-9][0-9][0-9]\n" );
 
   if ( rfbString.find( regexp ) == -1 ) {
     static QString msg = tr( "Error: Invalid server version, %1" ).arg( rfbString );
 
     qWarning( msg );
     emit error( msg );
     currentState = Error;
     return;
   }
 
   // Calculate the actual version number
   serverMajor = (serverVersion[4] - '0') * 100
     + (serverVersion[5] - '0') * 10
     + (serverVersion[6] - '0');
   serverMinor = (serverVersion[8] - '0') * 100
     + (serverVersion[9] - '0') * 10
     + (serverVersion[10] - '0');
 
   qWarning("Server Version: %03d.%03d", serverMajor, serverMinor );
 
   if ( serverMajor != 3 ) {
     QString msg = tr( "Error: Unsupported server version, %1" )
       .arg( rfbString );
 
     qWarning( msg );
     emit error( msg );
     currentState = Error;
     return;    
   }
   
   if ( serverMinor != 3 ) {
     qWarning( "Minor version mismatch: %d", serverMinor );
   }
 
   // Setup for the next state
   sendClientVersion();
 
   connect( con, SIGNAL( gotEnoughData() ), SLOT( gotAuthScheme() ) );
   con->waitForData( AuthSchemeLength );
 }
 
 void KRFBLogin::gotAuthScheme()
 {
   disconnect( con, SIGNAL( gotEnoughData() ), 
               this, SLOT( gotAuthScheme() ) );
 
   // Got data
   CARD32 scheme;
   con->read( &scheme, AuthSchemeLength );
   scheme = Swap32IfLE( scheme );
 
   static QString statusMsgOk = tr( "Logged in" );
 
   switch ( scheme ) {
   case 0:
     qWarning( "Failed" );
     // Handle failure
     connect( con, SIGNAL( gotEnoughData() ), SLOT( gotFailureReasonSize() ) );
     con->waitForData( FailureReasonSizeLength );
     break;
   case 1:
     // Handle no auth
     emit status( statusMsgOk );
     con->gotRFBConnection();
     break;
   case 2:
     // Handle VNC auth
     connect( con, SIGNAL( gotEnoughData() ), SLOT( gotChallenge() ) );
     con->waitForData( ChallengeLength );
     break;
   default:
     qWarning( "Unknown authentication scheme, 0x%08lx", scheme );
     currentState = Error;
     break;
   };
 }
 
 void KRFBLogin::gotChallenge()
 {
   disconnect( con, SIGNAL( gotEnoughData() ),
               this, SLOT( gotChallenge() ) );
 
   QTimer::singleShot( 0, this, SLOT(getPassword()) );
 }
 
 void KRFBLogin::getPassword()
 {
   // Got data
   CARD8 challenge[ ChallengeLength ];
   con->read( challenge, ChallengeLength );
 
   // Last chance to enter a password
   if ( con->options_->password.isNull() ) {
     qWarning( "krfblogin needs a password" );
     emit passwordRequired( con );
   }
 
   if ( con->options_->password.isNull() ) {
     QString msg = tr( "Error: This server requires a password, but none "
                         "has been specified.\n" );
     
     emit error( msg );
     return;
   }
 
   vncEncryptBytes( (unsigned char *) challenge, QCString(con->options_->password.latin1()).data() );
   con->write( challenge, ChallengeLength );
 
   connect( con, SIGNAL( gotEnoughData() ), SLOT( gotAuthResult() ) );
   con->waitForData( AuthResultLength );
 }
 
 void KRFBLogin::gotFailureReasonSize()
 {
   disconnect( con, SIGNAL( gotEnoughData() ), this,
               SLOT( gotFailureReasonSize() ) );
 }
 
 void KRFBLogin::gotAuthResult()
 {
   // Got data
   disconnect( con, SIGNAL( gotEnoughData() ), this,
               SLOT( gotAuthResult() ) );
 
   long result;
   con->read( &result, AuthResultLength );
   result = Swap32IfLE( result );
 
   qWarning( "Authentication Result is 0x%08lx", result );
 
   static QString failed = tr( "Error: The password you specified was incorrect." );
   static QString tooMany = tr( "Error: Too many invalid login attempts have been made\n"
                                  "to this account, please try later." );
 
   static QString statusMsgOk = tr( "Logged in" );
   static QString statusMsgFailed = tr( "Login Failed" );
   static QString statusMsgTooMany = tr( "Too many failures" );
 
   switch( result ) {
   case AuthOk:
     emit status( statusMsgOk );
     con->gotRFBConnection();
     break;
   case AuthFailed:
     qWarning( "Dammit" );
     emit status( statusMsgFailed );
     emit error( failed );
     break;
   case AuthTooMany:
     emit status( statusMsgTooMany );
     emit error( tooMany );    
     break;
   default:
     qWarning( "Invalid authentication result, %lx", result );
diff --git a/noncore/comm/keypebble/kvnc.cpp b/noncore/comm/keypebble/kvnc.cpp
index c678edf..88cb50b 100644
--- a/noncore/comm/keypebble/kvnc.cpp
+++ b/noncore/comm/keypebble/kvnc.cpp
@@ -1,260 +1,260 @@
 #include <qaction.h>
 #include <qpopupmenu.h>
 #include <qpushbutton.h>
 #include <qmessagebox.h>
 #include <qlistbox.h>
 #include <qpe/qpeapplication.h>
 #include <qpe/resource.h>
 
 #include <assert.h>
 
 #include "kvnc.h"
 #include "krfbcanvas.h"
 #include "krfbconnection.h"
 #include "kvncconndlg.h"
 
 static int u_id = 1;
 static int get_unique_id()
 {
                 return u_id++;
 }
 
 
 /* XPM */
 static char * menu_xpm[] = {
 "12 12 5 1",
         " c None",
         ".c #000000",
         "+c #FFFDAD",
         "@c #FFFF00",
         "#c #E5E100",
 "            ",
 "            ",
 "  ......... ",
 "  .+++++++. ",
 "  .+@@@@#.  ",
 "  .+@@@#.   ",
 "  .+@@#.    ",
 "  .+@#.     ",
 "  .+#.      ",
 "  .+.       ",
 "  ..        ",
 "            "};
 
 const int StatusTextId = 0;
 
 KVNC::KVNC(  QWidget *parent, const char *name, WFlags f) : QMainWindow( 0, name ,WStyle_ContextHelp)
 {
     setCaption( tr("VNC Viewer") );
     fullscreen = false;
 
                 stack = new QWidgetStack( this );
                 setCentralWidget( stack );
 
                 bookmarkSelector=new KVNCBookmarkDlg();
                 stack->addWidget(bookmarkSelector,get_unique_id());
                 stack->raiseWidget( bookmarkSelector );
 
                 canvas = new KRFBCanvas( stack, "canvas" );
                 stack->addWidget(canvas,get_unique_id());
     setCentralWidget( stack );
 
 
-    connect( bookmarkSelector->bookmarkList, SIGNAL(clicked(QListBoxItem *)),
-            this, SLOT(openConnection(QListBoxItem *)) );
-    connect( canvas->connection(), SIGNAL(statusChanged(const QString &)),
-            this, SLOT(statusMessage(const QString &)) );
-    connect( canvas->connection(), SIGNAL(error(const QString &)),
-            this, SLOT(error(const QString &)) );
+    connect( bookmarkSelector->bookmarkList, SIGNAL(clicked(QListBoxItem*)),
+            this, SLOT(openConnection(QListBoxItem*)) );
+    connect( canvas->connection(), SIGNAL(statusChanged(const QString&)),
+            this, SLOT(statusMessage(const QString&)) );
+    connect( canvas->connection(), SIGNAL(error(const QString&)),
+            this, SLOT(error(const QString&)) );
     connect( canvas->connection(), SIGNAL(connected()), this, SLOT(connected()) );
     connect( canvas->connection(), SIGNAL(loggedIn()), this, SLOT(loggedIn()) );
     connect( canvas->connection(), SIGNAL(disconnected()), this, SLOT(disconnected()) );
 
     setupActions();
 
     cornerButton = new QPushButton( this );
     cornerButton->setPixmap( QPixmap( (const char**)menu_xpm ) );
     connect( cornerButton, SIGNAL(pressed()), this, SLOT(showMenu()) );
     canvas->setCornerWidget( cornerButton );
 
                 stack->raiseWidget( bookmarkSelector );
 
 
                 bar= new QToolBar( this );
                 setToolBarsMovable( false );
                 setRightJustification(false);
 
 
                  QAction *n = new QAction( tr( "New Connection" ), Resource::loadPixmap( "new" ),
                                 QString::null, 0, this, 0 );
                  connect( n, SIGNAL( activated() ),
                                                 this, SLOT( newConnection() ) );
                 n->addTo( bar );
 
                  QAction *o = new QAction( tr( "Open Bookmark" ), Resource::loadPixmap( "fileopen" ),
                                 QString::null, 0, this, 0 );
                  connect( o, SIGNAL( activated() ),
                                                 this, SLOT( openConnection() ) );
                 o->addTo( bar );
 
                  QAction *d = new QAction( tr( "Delete Bookmark" ), Resource::loadPixmap( "trash" ),
                                 QString::null, 0, this, 0 );
                  connect( d, SIGNAL( activated() ),
                                                 this, SLOT( deleteBookmark() ) );
                 d->addTo( bar );
 }
 
 KVNC::~KVNC()
 {
 
 }
 
 void KVNC::newConnection()
 {
     curServer=new KRFBServer;
 
                 KVNCConnDlg dlg( curServer,this);
                 if ( QPEApplication::execDialog( &dlg )) {
                                 if (!curServer->name.isEmpty())
                                                 bookmarkSelector->addBookmark(curServer);
                                 canvas->openConnection(*curServer);
                 } else
                                 curServer=0;
 }
 
 void KVNC::openConnection( QString name)
 {
     curServer=bookmarkSelector->getServer(name);
 
                 if (curServer) {
                                 KVNCConnDlg dlg( curServer,this);
                         if ( QPEApplication::execDialog( &dlg ) ) {
                                         canvas->openConnection(*curServer);
                                         bookmarkSelector->writeBookmarks();
                         } else
                                         curServer=0;
                 }
 }
 
 void KVNC::openConnection( void )
 {
                 openConnection( bookmarkSelector->selectedBookmark());
 }
 
 void KVNC::openConnection( QListBoxItem * item)
 {
     if (item)
                 openConnection(item->text());
 }
 
 void KVNC::setupActions()
 {
     cornerMenu = new QPopupMenu( this );
 
     fullScreenAction = new QAction( tr("Full Screen"), QString::null, 0, 0 );
     connect( fullScreenAction, SIGNAL(activated()),
             this, SLOT( toggleFullScreen() ) );
     fullScreenAction->addTo( cornerMenu );
     fullScreenAction->setEnabled( false );
 
     ctlAltDelAction = new QAction( tr("Send Contrl-Alt-Delete"), QString::null, 0, 0 );
     connect( ctlAltDelAction, SIGNAL(activated()),
             canvas, SLOT( sendCtlAltDel() ) );
     ctlAltDelAction->addTo( cornerMenu );
     ctlAltDelAction->setEnabled( false );
 
     disconnectAction = new QAction( tr("Disconnect"), QString::null, 0, 0 );
     connect( disconnectAction, SIGNAL(activated()),
             this, SLOT( closeConnection() ) );
     disconnectAction->addTo( cornerMenu );
     disconnectAction->setEnabled( false );
 
     doubleClickAction = new QAction( tr("Next Click is Double Click"), QString::null, 0, 0 );
     connect( doubleClickAction, SIGNAL(activated()),
             canvas, SLOT( markDoubleClick() ) );
     doubleClickAction->addTo( cornerMenu );
     doubleClickAction->setEnabled( false );
 
     rightClickAction = new QAction( tr("Next Click is Right Click"), QString::null, 0, 0 );
     connect( rightClickAction, SIGNAL(activated()),
             canvas, SLOT( markRightClick() ) );
     rightClickAction->addTo( cornerMenu );
     rightClickAction->setEnabled( false );
 }
 
 void KVNC::toggleFullScreen()
 {
                 if ( fullscreen ) {
                         canvas->releaseKeyboard();
                         canvas->reparent( stack, 0, QPoint(0,0), false );
                         canvas->setFrameStyle( QFrame::Panel | QFrame::Sunken );
                         setCentralWidget( stack );
                         stack->addWidget(canvas,get_unique_id());
                         stack->raiseWidget(canvas);
                         canvas->show();
                         stack->show();
                         fullScreenAction->setText( tr("Full Screen") );
                 } else {
                         canvas->setFrameStyle( QFrame::NoFrame );
                         stack->removeWidget(canvas);
                                 canvas->reparent( 0,WStyle_Tool | WStyle_Customize | WStyle_StaysOnTop,
                         QPoint(0,0),false);
                         canvas->resize(qApp->desktop()->width(), qApp->desktop()->height());
                         canvas->raise();
                         canvas->setFocus();
                                 canvas->grabKeyboard();
                                 canvas->show();
 
                                 fullScreenAction->setText( tr("Stop Full Screen") );
                 }
 
 
     fullscreen = !fullscreen;
 }
 
 void KVNC::closeConnection()
 {
     if ( fullscreen )
         toggleFullScreen();
     canvas->closeConnection();
 }
 
 void KVNC::showMenu()
 {
     QPoint pt = mapToGlobal(cornerButton->pos());
     QSize s = cornerMenu->sizeHint();
     pt.ry() -= s.height();
     pt.rx() -= s.width();
     cornerMenu->popup( pt );
 }
 
 void KVNC::connected()
 {
     static QString msg = tr( "Connected to remote host" );
     statusMessage( msg );
     ctlAltDelAction->setEnabled(true);
     disconnectAction->setEnabled( true );
     fullScreenAction->setEnabled( true );
     doubleClickAction->setEnabled( false );
     rightClickAction->setEnabled( true );
                 stack->raiseWidget(canvas);
                  bar->hide();
 }
 
 void KVNC::loggedIn()
 {
     static QString msg = tr( "Logged in to remote host" );
     statusMessage( msg );
 }
 
 void KVNC::disconnected()
 {
 
                 if ( fullscreen )
                                 toggleFullScreen();
     static QString msg = tr( "Connection closed" );
     statusMessage( msg );
     ctlAltDelAction->setEnabled(false);
     disconnectAction->setEnabled( false );
     fullScreenAction->setEnabled( false );
     doubleClickAction->setEnabled( false );