I expanded my audit to include any app I could get to compile in i386.

In that expansion a whole new crop of unchecked returns has sprung up.
This commit fixes those weeds or should I say potential bugs.

3 files changed, 16 insertions, 16 deletions

diff --git a/noncore/multimedia/opieplayer2/lib.cpp b/noncore/multimedia/opieplayer2/lib.cpp
index 84d28ce..5f281b7 100644
--- a/noncore/multimedia/opieplayer2/lib.cpp
+++ b/noncore/multimedia/opieplayer2/lib.cpp
@@ -77,7 +77,7 @@ Lib::Lib( InitializationMode initMode, XineVideoWidget* widget )
     // not really OO, should be an extra class, later
     if ( !QFile::exists(configPath) ) {
         QFile f(configPath);
-        f.open(IO_WriteOnly);
+        if (f.open(IO_WriteOnly)) {
         QTextStream ts( &f );
         ts << "misc.memcpy_method:glibc\n";
         ts << "# uncomment if you experience double speed audio \n #audio.oss_sync_method:softsync\n";
@@ -91,6 +91,8 @@ Lib::Lib( InitializationMode initMode, XineVideoWidget* widget )
         ts << "audio.out_size_zero_buf:1024\n";
         ts << "audio.passthrough_offset:0\n";
         f.close();
+        } else
+            owarn << "Failed to open " f.name() << oendl;
     }
 
     if ( initMode == InitializeImmediately ) {
diff --git a/noncore/multimedia/opieplayer2/om3u.cpp b/noncore/multimedia/opieplayer2/om3u.cpp
index 790fa09..f2a01d3 100644
--- a/noncore/multimedia/opieplayer2/om3u.cpp
+++ b/noncore/multimedia/opieplayer2/om3u.cpp
@@ -38,10 +38,13 @@ using namespace Opie::Core;
 //extern PlayListWidget *playList;
 
 Om3u::Om3u( const QString &filePath, int mode)
-      : QStringList (){
+  : QStringList ()
+{
 odebug << "<<<<<<<new m3u "+filePath << oendl; 
   f.setName(filePath);
-  f.open(mode);
+    if (!f.open(mode)) {
+        owarn << "Unable to open file " << f.name() << oendl;
+    }
 }
 
 Om3u::~Om3u(){}
@@ -83,12 +86,6 @@ void Om3u::readPls() { //it's a pls file
                 s = s.stripWhiteSpace();
                 s.replace( QRegExp( "%20" )," ");
 //                odebug << "adding " + s + " to playlist" << oendl; 
-                // numberofentries=2
-                // File1=http
-                // Title
-                // Length
-                // Version
-                // File2=http
                 s = s.replace( QRegExp( "\\" ), "/" );
                 QFileInfo f( s );
                 QString name = f.baseName();
@@ -101,9 +98,6 @@ void Om3u::readPls() { //it's a pls file
                 if( s.at( s.length() - 4) == '.') // if this is probably a file
                 append(s);
                 else { //if its a url
-//                     if( name.right( 1 ).find( '/' ) == -1) {
-//                         s += "/";
-//                     }
                     append(s);
                 }
             }
@@ -120,7 +114,6 @@ void Om3u::write() { //writes list to m3u file
 				t << *it << "\n";
     }
   }
-//    f.close();
 }
 
 void Om3u::add(const QString &filePath) { //adds to m3u file
diff --git a/noncore/multimedia/opieplayer2/threadutil.cpp b/noncore/multimedia/opieplayer2/threadutil.cpp
index b5cac61..5fc8a0b 100644
--- a/noncore/multimedia/opieplayer2/threadutil.cpp
+++ b/noncore/multimedia/opieplayer2/threadutil.cpp
@@ -233,12 +233,17 @@ void Thread::exit()
     pthread_exit( 0 );
 }
 
-OnewayNotifier::OnewayNotifier()
+OnewayNotifier::OnewayNotifier() :
+  m_readFd(-1),
+  m_writeFd(-1)
 {
-    int fds[ 2 ];
-    pipe( fds );
+    int fds[ 2 ] = { -1, -1 };
+    if (pipe( fds ) == 0) {
     m_readFd = fds[ 0 ];
     m_writeFd = fds[ 1 ];
+    } else {
+        owarn << "Call to pipe() failed" << oendl;
+    }
 
     m_notifier = new QSocketNotifier( m_readFd, QSocketNotifier::Read );
     connect( m_notifier, SIGNAL( activated(int) ),