fixes:

- saving of ntpservers
- poping up of messagebox

2 files changed, 40 insertions, 19 deletions

diff --git a/noncore/settings/netsystemtime/ntp.cpp b/noncore/settings/netsystemtime/ntp.cpp
index 6e74e32..c7e3b52 100644
--- a/noncore/settings/netsystemtime/ntp.cpp
+++ b/noncore/settings/netsystemtime/ntp.cpp
@@ -27,12 +27,13 @@
 #include <stdlib.h>
 
 
 Ntp::Ntp( QWidget* parent,  const char* name, WFlags fl )
   : SetDateTime( parent, name, fl )
 {
+  _interactive = false;
   Config ntpSrvs(QPEApplication::qpeDir()+"etc/ntpservers",Config::File);
   ntpSrvs.setGroup("servers");
   int srvCount = ntpSrvs.readNumEntry("count", 0 );
   for (int i = 0; i < srvCount; i++)
     {
       ntpSrvs.setGroup(QString::number(i));
@@ -75,37 +76,44 @@ Ntp::Ntp( QWidget* parent,  const char* name, WFlags fl )
 
   ntpProcess = new OProcess( );
   connect( SpinBoxNtpDelay, SIGNAL( valueChanged(int) ),
 	   SLOT(slotNtpDelayChanged(int)) );
 
   ntpSock = new QSocket( this );
-  connect( ntpSock, SIGNAL( error(int) ),
-	   SLOT(slotCheckNtp(int)) );
+  connect( ntpSock, SIGNAL( error(int) ),SLOT(slotCheckNtp(int)) );
   slotProbeNtpServer();
 
   connect ( ntpProcess, SIGNAL(receivedStdout(OProcess*,char*,int)),
 	    this, SLOT(getNtpOutput(OProcess*,char*,int)));
   connect ( ntpProcess, SIGNAL(processExited(OProcess*)),
 	    this, SLOT(ntpFinished(OProcess*)));
-  connect(runNtp, SIGNAL(clicked()), this, SLOT(slotRunNtp()));
+  connect(runNtp, SIGNAL(clicked()), this, SLOT(slotButtonRunNtp()));
   connect(PushButtonPredict, SIGNAL(clicked()), this, SLOT(preditctTime()));
   connect(PushButtonSetPredTime, SIGNAL(clicked()), this, SLOT(setPredictTime()));
   slotCheckNtp(-1);
   readLookups();
 }
 
 Ntp::~Ntp()
 {
   delete ntpProcess;
-  Config ntpSrvs("/etc/ntpservers",Config::File);
-  ntpSrvs.setGroup("servers");
   int srvCount = ComboNtpSrv->count();
-  ntpSrvs.writeEntry("count", srvCount);
+  bool serversChanged = true;
+  QString edit = ComboNtpSrv->currentText();
   for (int i = 0; i < srvCount; i++){
-    ntpSrvs.setGroup(QString::number(i));
-    ntpSrvs.writeEntry( "name", ComboNtpSrv->text(i) );
+       if ( edit ==  ComboNtpSrv->text(i)) serversChanged = false;
+  }
+  if (serversChanged){
+    Config ntpSrvs("/etc/ntpservers",Config::File);
+    ntpSrvs.setGroup("servers");
+    ntpSrvs.writeEntry("count", srvCount);
+    for (int i = 0; i < srvCount; i++){
+      qDebug("ntpSrvs[%i/%i]=%s",i,srvCount,ComboNtpSrv->text(i).latin1());
+      ntpSrvs.setGroup(QString::number(i));
+      ntpSrvs.writeEntry( "name", ComboNtpSrv->text(i) );
+    }
   }
   Config cfg("ntp",Config::User);
   cfg.setGroup("settings");
   cfg.writeEntry("ntpServer", ComboNtpSrv->currentItem());
   cfg.writeEntry( "minLookupDiff", SpinBoxMinLookupDelay->value() );
   cfg.writeEntry( "ntpRefreshFreq", SpinBoxNtpDelay->value() );
@@ -124,12 +132,25 @@ bool Ntp::ntpDelayElapsed()
 
 QString Ntp::getNtpServer()
 {
   return ComboNtpSrv->currentText();
 }
 
+void Ntp::slotButtonRunNtp()
+{
+  _interactive = true;
+  slotRunNtp();
+}
+
+void Ntp::slotTimerRunNtp()
+{
+  _interactive = false;
+  slotRunNtp();
+}
+
+
 void Ntp::slotRunNtp()
 {
   if ( !ntpDelayElapsed() && CheckBoxAdvSettings->isChecked() )
     {
       switch (
 	      QMessageBox::warning(this, tr("Run NTP?"),
@@ -173,20 +194,17 @@ void  Ntp::getNtpOutput(OProcess *proc, char *buffer, int buflen)
 
 void  Ntp::ntpFinished(OProcess *p)
 {
   qDebug("p->exitStatus() %i",p->exitStatus());
   if (p->exitStatus()!=0 || !p->normalExit())
     {      
-      if ( isVisible() ) {
-	QMessageBox::critical(this, tr("ntp error"),
-			    tr("Error while getting time form\n server")+ 
-			    getNtpServer()+"\n"+
-			    _ntpOutput );
-	TabWidgetMain->showPage( tabManualSetTime );
+      if ( isVisible() && _interactive ){
+        QMessageBox::critical(this, tr("ntp error"),tr("Error while getting time form\n server")+getNtpServer()+"\n"+_ntpOutput );
+        TabWidgetMain->showPage( tabManualSetTime );
       }
-      
+
       return;
     }
 
   Global::writeHWClock();
   // since time has changed quickly load in the datebookdb
   // to allow the alarm server to get a better grip on itself
@@ -300,20 +318,20 @@ void Ntp::setPredictTime()
 void Ntp::slotCheckNtp(int i)
 {
   if (i == 0)
     {
       TextLabelMainPredTime->hide();
       ButtonSetTime->setText( tr("Get time from network") );
-      connect( ButtonSetTime, SIGNAL(clicked()), SLOT(slotRunNtp()) );
+      connect( ButtonSetTime, SIGNAL(clicked()), SLOT(slotButtonRunNtp()) );
       if ( ntpDelayElapsed() )
    	{
 	  slotRunNtp();
 	  disconnect(ntpTimer, SIGNAL( timeout() ), this, SLOT(slotProbeNtpServer()) );
-	  connect(ntpTimer, SIGNAL( timeout() ), SLOT(slotRunNtp()) );
+	  connect(ntpTimer, SIGNAL( timeout() ), SLOT(slotTimerRunNtp()) );
 	}else{
-	  disconnect(ntpTimer, SIGNAL( timeout() ), this, SLOT(slotRunNtp()) );
+	  disconnect(ntpTimer, SIGNAL( timeout() ), this, SLOT(slotTimerRunNtp()) );
 	  connect(ntpTimer, SIGNAL( timeout() ), SLOT(slotProbeNtpServer()) );
 	}
     }else{
       preditctTime();
       ButtonSetTime->setText( tr("Set predicted time: ")+predictedTime.toString() );
       if (i>0)ntpOutPut(tr("Could not connect to server ")+getNtpServer());
@@ -351,12 +369,13 @@ void Ntp::makeChannel()
 
 void Ntp::receive(const QCString &msg, const QByteArray &arg)
 {
   qDebug("QCop(Ntp) "+msg+" "+QCString(arg));
   if ( msg == "ntpLookup(QString)" )
     {
+      _interactive = false;
       slotRunNtp();
     }
   if ( msg == "setPredictedTime(QString)" )
     {
       setPredictTime();
     }else{
diff --git a/noncore/settings/netsystemtime/ntp.h b/noncore/settings/netsystemtime/ntp.h
index f6694c9..15cddbd 100644
--- a/noncore/settings/netsystemtime/ntp.h
+++ b/noncore/settings/netsystemtime/ntp.h
@@ -29,19 +29,21 @@ private:
   float _shiftPerSec;
   int _lookupDiff;
   OProcess *ntpProcess;
   QTimer *ntpTimer;
   QSocket *ntpSock;
   QCopChannel *channel;
-
+  bool _interactive;
   float getTimeShift();
   void readLookups();
   void ntpOutPut(QString);
   bool ntpDelayElapsed();
   QString getNtpServer();
 private slots:
+  void slotTimerRunNtp();
+  void slotButtonRunNtp();
   void slotRunNtp();
   void getNtpOutput(OProcess *proc, char *buffer, int buflen);
   void ntpFinished(OProcess*);
   void preditctTime();
   void slotCheckNtp(int);
   void setPredictTime();