Fix the issues the compilers bothers

remove unused parameters, give return values on return

6 files changed, 26 insertions, 24 deletions

diff --git a/noncore/settings/networksettings/ppp/connect.cpp b/noncore/settings/networksettings/ppp/connect.cpp
index 24d33f4..128877a 100644
--- a/noncore/settings/networksettings/ppp/connect.cpp
+++ b/noncore/settings/networksettings/ppp/connect.cpp
@@ -213,7 +213,8 @@ void ConnectWidget::init() {
 
     qApp->processEvents();
     QApplication::flushX();
-    pid_t id = execute_command(_ifaceppp->data()->command_before_connect());
+    (void)execute_command(_ifaceppp->data()->command_before_connect());
+
 //     int i, status;
 
 //     do {
@@ -473,7 +474,7 @@ void ConnectWidget::timerEvent(QTimerEvent *) {
         scriptCommand = *(comlist->at(scriptindex));
         scriptArgument = *(arglist->at(scriptindex));
       } else {
-       odebug << "End of script" << oendl; 
+       odebug << "End of script" << oendl;
         vmain = 10;
         return;
       }
@@ -839,7 +840,7 @@ void ConnectWidget::timerEvent(QTimerEvent *) {
       killTimer( main_timer_ID );
 
       if_timeout_timer->start(_ifaceppp->data()->pppdTimeout()*1000);
-      odebug << "started if timeout timer with " << _ifaceppp->data()->pppdTimeout()*1000 << "" << oendl; 
+      odebug << "started if timeout timer with " << _ifaceppp->data()->pppdTimeout()*1000 << "" << oendl;
 
       // find out PPP interface and notify the stats module
 //      stats->setUnit(pppInterfaceNumber());
@@ -849,7 +850,7 @@ void ConnectWidget::timerEvent(QTimerEvent *) {
       result = execppp();
 
       emit debugMessage(QObject::tr("Starting pppd..."));
-      odebug << "execppp() returned with return-code " << result << "" << oendl; 
+      odebug << "execppp() returned with return-code " << result << "" << oendl;
 
       if(result) {
         if(!_ifaceppp->data()->autoDNS())
@@ -1065,7 +1066,7 @@ void ConnectWidget::setExpect(const QString &n) {
 void ConnectWidget::if_waiting_timed_out() {
   if_timer->stop();
   if_timeout_timer->stop();
-  odebug << "if_waiting_timed_out()" << oendl; 
+  odebug << "if_waiting_timed_out()" << oendl;
 
   _ifaceppp->data()->setpppdError(E_IF_TIMEOUT);
 
@@ -1272,7 +1273,7 @@ bool ConnectWidget::execppp() {
     return false; // nonsensically long command which would bust my buffer buf.
   }
 
-  owarn << "Command IS: " << command.latin1() << "" << oendl; 
+  owarn << "Command IS: " << command.latin1() << "" << oendl;
 
   qApp->flushX();
 
diff --git a/noncore/settings/networksettings/ppp/devices.cpp b/noncore/settings/networksettings/ppp/devices.cpp
index 42de44c..e2c67d8 100644
--- a/noncore/settings/networksettings/ppp/devices.cpp
+++ b/noncore/settings/networksettings/ppp/devices.cpp
@@ -74,11 +74,11 @@ DevicesWidget::DevicesWidget( InterfacePPP* ip, QWidget *parent, const char *nam
 //  delete_b->setEnabled( false ); //FIXME
 
   QStringList tmp = _pppdata->getDevicesNamesList();
-  odebug << "DevicesWidget::DevicesWidget got devices " << tmp.join("--").latin1() << "" << oendl; 
+  odebug << "DevicesWidget::DevicesWidget got devices " << tmp.join("--").latin1() << "" << oendl;
   listListbox->insertStringList(tmp);
 
   for (uint i = 0; i < listListbox->count(); i++){
-      odebug << "listListbox->text(i) " << listListbox->text(i).latin1() << " == _pppdata->devname() " << _pppdata->devname().latin1() << "" << oendl; 
+      odebug << "listListbox->text(i) " << listListbox->text(i).latin1() << " == _pppdata->devname() " << _pppdata->devname().latin1() << "" << oendl;
       if ( listListbox->text(i) == _pppdata->devname() )
           listListbox->setCurrentItem( i );
   }
@@ -87,7 +87,7 @@ DevicesWidget::DevicesWidget( InterfacePPP* ip, QWidget *parent, const char *nam
 
 
 void DevicesWidget::slotListBoxSelect(int idx) {
-    bool ok = _pppdata->setDevice( listListbox->text(idx) );
+    _pppdata->setDevice( listListbox->text(idx) );
     delete_b->setEnabled((bool)(idx != -1));
     edit_b->setEnabled((bool)(idx != -1));
 //FIXME  copy_b->setEnabled((bool)(idx != -1));
diff --git a/noncore/settings/networksettings/ppp/edit.cpp b/noncore/settings/networksettings/ppp/edit.cpp
index 3b2393c..6c9735c 100644
--- a/noncore/settings/networksettings/ppp/edit.cpp
+++ b/noncore/settings/networksettings/ppp/edit.cpp
@@ -1202,7 +1202,7 @@ QString PhoneNumberDialog::phoneNumber()
 }
 
 
-void PhoneNumberDialog::textChanged(const QString &s)
+void PhoneNumberDialog::textChanged(const QString &)
 {
     //  enableButtonOK(s.length() > 0);
 }
diff --git a/noncore/settings/networksettings/ppp/interfaceinformationppp.cpp b/noncore/settings/networksettings/ppp/interfaceinformationppp.cpp
index 4755aed..56e1c1f 100644
--- a/noncore/settings/networksettings/ppp/interfaceinformationppp.cpp
+++ b/noncore/settings/networksettings/ppp/interfaceinformationppp.cpp
@@ -21,10 +21,10 @@ using namespace Opie::Core;
  * Constructor for the InterfaceInformationImp class.  This class pretty much
  * just display's information about the interface that is passed to it.
  */
-InterfaceInformationPPP::InterfaceInformationPPP(QWidget *parent, const char *name, Interface *i, WFlags f)
+InterfaceInformationPPP::InterfaceInformationPPP(QWidget *parent, const char *name, Interface *i, WFlags )
     :InterfaceInformationImp(parent, name, i, Qt::WStyle_ContextHelp)
 {
-    odebug << "InterfaceInformationPPP::InterfaceInformationPPP " << name << "" << oendl; 
+    odebug << "InterfaceInformationPPP::InterfaceInformationPPP " << name << "" << oendl;
     con = new ConnectWidget( (InterfacePPP*)i, this, "con" );
     con->setSizePolicy( QSizePolicy(QSizePolicy::MinimumExpanding,
                                     QSizePolicy::Fixed) );
diff --git a/noncore/settings/networksettings/ppp/pppmodule.cpp b/noncore/settings/networksettings/ppp/pppmodule.cpp
index fb279ee..dec0177 100644
--- a/noncore/settings/networksettings/ppp/pppmodule.cpp
+++ b/noncore/settings/networksettings/ppp/pppmodule.cpp
@@ -63,10 +63,10 @@ PPPModule::PPPModule() : Module()
     QMap<QString,QString> ifaces = PPPData::getConfiguredInterfaces();
     QMap<QString,QString>::Iterator it;
     InterfacePPP *iface;
-    odebug << "getting interfaces" << oendl; 
+    odebug << "getting interfaces" << oendl;
     for( it = ifaces.begin(); it != ifaces.end(); ++it )
     {
-        odebug << "ifaces " << it.key().latin1() << " " << it.data().latin1() << "" << oendl; 
+        odebug << "ifaces " << it.key().latin1() << " " << it.data().latin1() << "" << oendl;
         iface = new InterfacePPP( 0, it.key() );
         iface->setHardwareName( it.data() );
         list.append( (Interface*)iface );
@@ -74,7 +74,7 @@ PPPModule::PPPModule() : Module()
         // check if (*it) is one of the running ifaces
         if ( running.contains( it.data() ) )
         {
-            odebug << "iface is running " << it.key().latin1() << "" << oendl; 
+            odebug << "iface is running " << it.key().latin1() << "" << oendl;
             handledInterfaceNames << running[it.data()].device;
             iface->setStatus( true );
             iface->setPPPDpid( running[it.data()].pid );
@@ -91,7 +91,7 @@ PPPModule::PPPModule() : Module()
  */
 PPPModule::~PPPModule()
 {
-    odebug << "PPPModule::~PPPModule() " << oendl; 
+    odebug << "PPPModule::~PPPModule() " << oendl;
     QMap<QString,QString> ifaces;
     InterfaceKeeper keeper;
     Interface *i;
@@ -100,7 +100,7 @@ PPPModule::~PPPModule()
         /* if online save the state */
         if ( i->getStatus() )
         {
-            odebug << "Iface " << i->getHardwareName().latin1() << " is still up" << oendl; 
+            odebug << "Iface " << i->getHardwareName().latin1() << " is still up" << oendl;
             InterfacePPP* ppp = static_cast<InterfacePPP*>(i);
             keeper.addInterface( ppp->pppPID(), ppp->pppDev(), ppp->getHardwareName() );
         }
@@ -144,7 +144,7 @@ bool PPPModule::isOwner(Interface *i)
  */
 QWidget *PPPModule::configure(Interface *i)
 {
-    odebug << "return ModemWidget" << oendl; 
+    odebug << "return ModemWidget" << oendl;
     PPPConfigWidget *pppconfig = new PPPConfigWidget( (InterfacePPP*)i,
                                  0, "PPPConfig", false,
                                  ::Qt::WDestructiveClose | ::Qt::WStyle_ContextHelp);
@@ -171,18 +171,19 @@ QWidget *PPPModule::information(Interface *i)
 QList<Interface> PPPModule::getInterfaces()
 {
     // List all of the files in the peer directory
-    odebug << "PPPModule::getInterfaces" << oendl; 
+    odebug << "PPPModule::getInterfaces" << oendl;
     return list;
 }
 
 /**
  * Attempt to add a new interface as defined by name
- * @param name the name of the type of interface that should be created given
+ * @param newInterface the name of the type of interface that should be created given
  *  by possibleNewInterfaces();
  * @return Interface* NULL if it was unable to be created.
  */
 Interface *PPPModule::addNewInterface(const QString &newInterface)
 {
+    Q_CONST_UNUSED( newInterface )
 
     InterfacePPP *ifaceppp;
     Interface *iface;
@@ -264,7 +265,7 @@ namespace
             con.name = (*it);
             con.pid = cfg.readNumEntry("pid");
             con.device = cfg.readEntry("device");
-            odebug << " " << con.name.latin1() << " " << con.device.latin1() << " " << con.pid << "" << oendl; 
+            odebug << " " << con.name.latin1() << " " << con.device.latin1() << " " << con.pid << "" << oendl;
 
             if ( con.pid != -1 && isAvailable( con.pid ) )
                 ifaces.insert( con.name, con );
@@ -275,11 +276,11 @@ namespace
     {
         if (::kill(p, 0 ) == 0 || errno != ESRCH )
         {
-            odebug << "isAvailable " << p << "" << oendl; 
+            odebug << "isAvailable " << p << "" << oendl;
             return true;
         }
 
-        odebug << "notAvailable " << p << "" << oendl; 
+        odebug << "notAvailable " << p << "" << oendl;
         return false;
     }
 
diff --git a/noncore/settings/networksettings/ppp/pppmodule.h b/noncore/settings/networksettings/ppp/pppmodule.h
index de649e4..1ecbf7a 100644
--- a/noncore/settings/networksettings/ppp/pppmodule.h
+++ b/noncore/settings/networksettings/ppp/pppmodule.h
@@ -22,7 +22,7 @@ public:
   virtual Interface *addNewInterface(const QString &name);
   virtual bool remove(Interface* i);
   virtual QString getPixmapName(Interface* i);
-  virtual void receive(const QCString &msg, const QByteArray &arg) {};
+  virtual void receive(const QCString &, const QByteArray &) {};
 
 private:
   QList<Interface> list;