summaryrefslogtreecommitdiff
path: root/noncore
authortille <tille>2003-06-02 15:12:10 (UTC)
committer tille <tille>2003-06-02 15:12:10 (UTC)
commit2d9798f244078089a0305d26509e288bb4a4190e (patch) (side-by-side diff)
treefd1932ca218382dc607ee21dd754693e30ef74e9 /noncore
parent6f49eaa7cf9589bf1f3f4277dc6dbd4d35cb0462 (diff)
downloadopie-2d9798f244078089a0305d26509e288bb4a4190e.zip
opie-2d9798f244078089a0305d26509e288bb4a4190e.tar.gz
opie-2d9798f244078089a0305d26509e288bb4a4190e.tar.bz2
impl remove item
Diffstat (limited to 'noncore') (more/less context) (ignore whitespace changes)
-rw-r--r--noncore/settings/networksettings/ppp/TODO2
-rw-r--r--noncore/settings/networksettings/ppp/pppdata.cpp5
-rw-r--r--noncore/settings/networksettings/ppp/pppmodule.cpp11
3 files changed, 9 insertions, 9 deletions
diff --git a/noncore/settings/networksettings/ppp/TODO b/noncore/settings/networksettings/ppp/TODO
index 529d236..5635438 100644
--- a/noncore/settings/networksettings/ppp/TODO
+++ b/noncore/settings/networksettings/ppp/TODO
@@ -6,2 +6,2 @@
not quite shure why it does not work... IMHO it should work
-- remove interfaces
+
diff --git a/noncore/settings/networksettings/ppp/pppdata.cpp b/noncore/settings/networksettings/ppp/pppdata.cpp
index 517dd8b..23db409 100644
--- a/noncore/settings/networksettings/ppp/pppdata.cpp
+++ b/noncore/settings/networksettings/ppp/pppdata.cpp
@@ -1247,3 +1247,6 @@ QString PPPData::modemGroup()
{
- if (modemDeviceGroup<0)qFatal("wrong modem %i",modemDeviceGroup);
+ if (modemDeviceGroup<0){
+ qDebug("wrong modem %i\n using 0",modemDeviceGroup);
+ modemDeviceGroup = 0; //FIXME!
+ }
return QString("%1_%1").arg(MODEM_GRP).arg(modemDeviceGroup);
diff --git a/noncore/settings/networksettings/ppp/pppmodule.cpp b/noncore/settings/networksettings/ppp/pppmodule.cpp
index 95df068..8c401a9 100644
--- a/noncore/settings/networksettings/ppp/pppmodule.cpp
+++ b/noncore/settings/networksettings/ppp/pppmodule.cpp
@@ -107,4 +107,2 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){
- qDebug("try to add iface %s",newInterface.latin1());
-
InterfacePPP *ifaceppp;
@@ -115,4 +113,4 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){
if(imp.exec() == QDialog::Accepted ){
+ iface = (InterfacePPP*) ifaceppp;
iface->setModuleOwner( this );
- iface = ifaceppp;
list.append( iface );
@@ -120,3 +118,3 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){
}else {
- delete iface;
+ delete ifaceppp;
iface = NULL;
@@ -130,5 +128,4 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){
*/
-bool PPPModule::remove(Interface*){
- // Can't remove a hardware device, you can stop it though.
- return false;
+bool PPPModule::remove(Interface *i){
+ return list.remove(i);
}