author | zecke <zecke> | 2002-10-18 01:34:23 (UTC) |
---|---|---|
committer | zecke <zecke> | 2002-10-18 01:34:23 (UTC) |
commit | 0457c48c165abef8afa2ac73c8f66d20e289681a (patch) (side-by-side diff) | |
tree | 2c6baf363487d474df6ceeaf2ea17a351b38aa05 /x11/ipc/server/ocopserver.cpp | |
parent | e7e36afd3685c7fab146ebd0078d7f1a60f8c5e6 (diff) | |
download | opie-0457c48c165abef8afa2ac73c8f66d20e289681a.zip opie-0457c48c165abef8afa2ac73c8f66d20e289681a.tar.gz opie-0457c48c165abef8afa2ac73c8f66d20e289681a.tar.bz2 |
Fix OCOPServer bugs... when removing clients
Implement the Opie side for the OK button
now the awesome matchbox needs to get an update
I was too excited about X11 so i did not do any PIM work yet
-rw-r--r-- | x11/ipc/server/ocopserver.cpp | 51 |
1 files changed, 31 insertions, 20 deletions
diff --git a/x11/ipc/server/ocopserver.cpp b/x11/ipc/server/ocopserver.cpp index 4940cb8..0f818b7 100644 --- a/x11/ipc/server/ocopserver.cpp +++ b/x11/ipc/server/ocopserver.cpp @@ -163,25 +163,25 @@ void OCopServer::newOnClient( int fd ) { * and then send the OCOPPacket * */ if (head.magic == 47 ) { - qWarning("magic match"); +// qWarning("magic match"); QCString channel( head.chlen+1 ); QCString func( head.funclen+1 ); QByteArray data ( head.datalen ); /* * we do not check for errors */ - qWarning("read "); +// qWarning("read "); int s = read(fd, channel.data(), head.chlen ); s = read(fd, func.data(), head.funclen ); s = read(fd, data.data(), head.datalen ); - qWarning("read"); +// qWarning("read"); /* debug output */ - qWarning("channel %s %d", channel.data(), head.chlen ); - qWarning("func %s %d", func.data(), head.funclen ); +// qWarning("channel %s %d", channel.data(), head.chlen ); +// qWarning("func %s %d", func.data(), head.funclen ); /* debug end */ /* * now that we got the complete body @@ -213,12 +213,8 @@ void OCopServer::registerClient( int fd ) { }; void OCopServer::deregisterClient(int fd ) { QMap<int, OCOPClient>::Iterator it = m_clients.find( fd ); if (it != m_clients.end() ) { - OCOPClient client = it.data(); - delete client.notify; - m_clients.remove(fd ); - close(fd ); /* * TIME_ME * * now delete from all channels @@ -232,17 +228,17 @@ void OCopServer::deregisterClient(int fd ) { for ( it2 = m_channels.begin(); it2 != m_channels.end(); ++it2 ) { /* * The channel contains this fd */ - qWarning("Channel %s", it2.key().data() ); + qWarning("Channel %s %d", it2.key().data(), it2.data().count() ); if ( it2.data().contains( fd ) ) { qWarning("contains"); QValueList<int> array = it2.data(); /* * remove channel or just replace */ - if ( array.count() == 1 ) { + if ( array.count() == 1 || array.count() == 0) { qWarning("Invalidate!"); /* is the list now invalidatet? */ m_channels.remove( it2 ); /* That is the first go to of my life @@ -253,14 +249,20 @@ void OCopServer::deregisterClient(int fd ) { * so the only way is to reiterate :( */ goto repeatIt; }else{ - qWarning("removing"); - array.remove( fd ); - it2 = m_channels.replace( it2.key(), array ); + qWarning("removing count %d %d",fd, array.count() ); + QValueList<int>::Iterator it3 = array.find( fd ); + it3 = array.remove( it3 ); + QCString key = it2.key().copy(); + it2 = m_channels.replace( key, array ); } } } // off all channels + OCOPClient client = it.data(); + delete client.notify; + m_clients.remove(fd ); + close(fd ); } qWarning("clients are now at %d", m_clients.count() ); }; /** @@ -326,36 +328,45 @@ bool OCopServer::isChannelRegistered( const QCString& chan ) const{ void OCopServer::addChannel( const QCString& channel, int fd ) { QMap<QCString, QValueList<int> >::Iterator it; it = m_channels.find( channel ); - + if ( it != m_channels.end() ) { /* could be empty */ QValueList<int> list = it.data(); list.append( fd ); + qWarning("count is now in addChannel %d %s", list.count(), channel.data() ); it = m_channels.replace( channel, list ); + }else { + QValueList<int> ints; + ints.append( fd ); + m_channels.insert( channel, ints ); + } }; void OCopServer::delChannel( const QCString& channel, int fd ) { + qWarning("remove %s, %d", channel.data(), fd ); if (!m_channels.contains( channel ) ) return; QMap<QCString, QValueList<int> >::Iterator it; it = m_channels.find( channel ); if ( it.data().contains(fd) ) { - QValueList<int> ints = it.data(); if ( ints.count() == 1 ) - m_channels.remove( it ); + m_channels.remove( channel ); else{ QValueList<int> ints = it.data(); - ints.remove( fd ); - m_channels.replace( it.key(), ints ); + QValueList<int>::Iterator rem = ints.find( fd ); + rem = ints.remove( rem ); + QCString str = it.key().copy(); + m_channels.replace( str, ints ); } + qWarning(" channel count is now %d", ints.count() ); } } void OCopServer::isRegistered( const QCString& channel, int fd) { - qWarning("isRegistered"); +// qWarning("isRegistered"); OCOPHead head; QCString func(2); memset(&head, 0, sizeof(head ) ); |