summaryrefslogtreecommitdiff
Side-by-side diff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--noncore/net/opie-smb/qsmb.cpp198
-rw-r--r--noncore/net/opie-smb/qsmb.h22
-rw-r--r--noncore/net/opie-smb/qsmbbase.ui59
3 files changed, 170 insertions, 109 deletions
diff --git a/noncore/net/opie-smb/qsmb.cpp b/noncore/net/opie-smb/qsmb.cpp
index 422b9f3..b978b46 100644
--- a/noncore/net/opie-smb/qsmb.cpp
+++ b/noncore/net/opie-smb/qsmb.cpp
@@ -8,4 +8,5 @@
#include <qdir.h>
#include <qfileinfo.h>
+#include <qtabwidget.h>
#include <qpe/process.h>
@@ -27,10 +28,11 @@
#include <netinet/in.h>
#include <arpa/inet.h>
-
#include <rpc/clnt.h>
+#include <sys/vfs.h>
+#include <mntent.h>
-#include <opie2/odebug.h>
-using namespace Opie::Core;
+// #include <opie2/odebug.h>
+// using namespace Opie::Core;
@@ -40,11 +42,15 @@ Qsmb::Qsmb( QWidget* parent, const char* name, WFlags fl )
connect(CBHost, SIGNAL(activated(int)), this, SLOT(hostSelected(int)));
connect(DoItBtn, SIGNAL(clicked()), this, SLOT(DoItClicked()));
+ connect(UnmountBtn, SIGNAL(clicked()), this, SLOT(umountIt()));
connect(BtnScan, SIGNAL(clicked()), this, SLOT(scanClicked()));
connect(BtnClear, SIGNAL(clicked()), this, SLOT(clear()));
+ mountpt->setEditable(true);
mountpt->insertItem("/mnt/samba1",-1);
mountpt->insertItem("/mnt/samba2",-1);
mountpt->insertItem("/mnt/samba3",-1);
-
+
+// TextViewOutput
+
top_element = NULL;
scanning = false;
@@ -72,5 +78,5 @@ void Qsmb::DoItClicked()
{
- if(! ListViewScan->selectedItem()) {
+ if( !ListViewScan->selectedItem()) {
QMessageBox::warning(this, tr("Error"),tr("<p>No share selected!</p>"));
return;
@@ -96,6 +102,4 @@ void* runitm(void* arg)
void Qsmb::scan()
{
-// int i;
-
if (scanning) return;
scanning = true;
@@ -110,5 +114,5 @@ void Qsmb::scan()
QString ip = inet_ntoa( my_addr.sin_addr);
- owarn << "IP Address : " << ip<< oendl;
+ qWarning("IP Address : "+ip);
match = ip.left(5);
@@ -148,11 +152,11 @@ void Qsmb::scan()
}
-void Qsmb::hostSelected(int index)
+void Qsmb::hostSelected(int /*index*/ )
{
- owarn << "hostSelected" << oendl;
QListViewItem *element;
- QListViewItem *parent;
+// QListViewItem *parent;
QString text = CBHost->currentText();
+ ListViewScan->clear();
if (scanning) return;
@@ -187,5 +191,7 @@ void Qsmb::hostSelected(int index)
share = token[0];
comment = token[2];
- element = new QListViewItem(ListViewScan,share, comment);
+ share = share.stripWhiteSpace();
+ comment = comment.stripWhiteSpace();
+ element = new QListViewItem(ListViewScan, share, comment);
element->setOpen(true);
// top_element = element;
@@ -251,10 +257,11 @@ void Qsmb::hostSelected(int index)
}
+
void Qsmb::DoIt()
{
+
QListViewItem *element;
element = ListViewScan->selectedItem();
if(!element) {
- QMessageBox::warning(this, tr("Error!!"),tr("<p><b>No</b> share selected!!</p>"));
return;
}
@@ -263,112 +270,139 @@ void Qsmb::DoIt()
scanning = true;
- int i;
- bool err = false;
+ QString mount = mountpt->currentText();
+ if(isMounted(mount)) {
+ qWarning(mount +" is already mounted");
+ TextViewOutput->append(mount +" is already mounted");
+ return;
+ }
+
+ bool noerr = false;
- char share[512];
+ QString share;
QString cmd;
QString cmd2;
- char result[256];
-// QString result;
QString text = mountpt->currentText();
-
- FILE *pipe,*pipe2;
+ QStringList ccmd;
LScan->setText("Mounting...");
qApp->processEvents();
-
- if(! QFileInfo(text).exists()) {
- QStringList ccmd;
+ if( !QFileInfo(text).exists()) {
ccmd << "mkdir";
ccmd << "-p";
ccmd << text;
- owarn<<"cmd: "<< ccmd << oendl;
+ qWarning( "cmd: "+ ccmd.join(" "));
runCommand(ccmd);
}
+ share = element->text(0);
+ qWarning("selected share is "+share);
- strcpy(share,(const char *)element->text(0));
-
- for(i = 0; i < 256; i++) {
- if(isalpha( share[i])) {
- strcpy( share, share + i);
- break;
- }
- }
-
- cmd = "/usr/bin/smbmount //"+CBHost->currentText()+"/"+share+" "+mountpt->currentText()+" -o username="+username->text()+",password="+password->text();
-
- owarn << "cmd: " << cmd << oendl;
- TextViewOutput->append(cmd.latin1());
+ QString service = CBHost->currentText();
+ service = service.stripWhiteSpace();
+ if(mount.left(1) != "/")
+ mount = QDir::currentDirPath()+"/"+mount;
+ mount = mount.stripWhiteSpace();
+ ccmd.clear();
+
+ ccmd << "/usr/bin/smbmount";
+ ccmd << "//"+ service+"/"+share;
+ ccmd << mount;
+ ccmd << "-o";
+ ccmd << "username="+username->text()+",password="+password->text()+"";
+ TextViewOutput->append(ccmd.join(" ").latin1());
if(onbootBtn->isChecked()) {
- owarn << "Saving Setting permanently..." << oendl;
- cmd2 = "echo '" + cmd + "'>/opt/QtPalmtop/etc/samba.env";
- /* run command & read output */
- if ((pipe = popen(cmd2.latin1(), "r")) == NULL) {
- snprintf(result, 256, "Error: Can't run %s", cmd.latin1());
- return;
- }
- /* parse output and display in ListViewScan */
- while(fgets(result, 256, pipe) != NULL) {
- }
- }
-
-
- /* run command & read output */
- if ((pipe = popen(cmd.latin1(), "r")) == NULL) {
- snprintf(result, 256, "Error: Can't run %s", cmd.latin1());
- TextViewOutput->append(result);
- return;
- }
-
- /* parse output and display in ListViewScan */
- while(fgets(result, 256, pipe) != NULL) {
- /* put result into TextViewOutput */
- TextViewOutput->append(result);
+ qWarning("Saving Setting permanently...");
+ QFile sambenv("/opt/QtPalmtop/etc/samba.env");
+ QTextStream smbv(&sambenv);
+ sambenv.open(IO_WriteOnly);
+ smbv << ccmd.join(" ") ;
+ sambenv.close();
}
+ noerr = runCommand(ccmd);
- TextViewOutput->append("\n\n================CheckMounts==================\n");
LScan->setText("");
- cmd = "/bin/mount 2>&1";
- owarn << "cmd: " << cmd << oendl;
-
- if ((pipe2 = popen(cmd.latin1(), "r")) == NULL) {
+ if(noerr) {
+ element->setText(2, mount);
+ TextViewOutput->append("\n\n================CheckMounts==================\n");
+ ccmd = "/bin/mount";
+ runCommand(ccmd);
+ TextViewOutput->append("\n\n============================================\n");
+ qApp->processEvents();
+ } else {
+ //do nothing
+ }
- snprintf(result, 256, "Error: Can't run %s", cmd.latin1());
-// result = "Error: Can't run "+ cmd;
+ scanning = false;
+}
- TextViewOutput->append(result);
+void Qsmb::umountIt()
+{
+ QString mount = mountpt->currentText();
+ if(!isMounted(mount)) {
+ qWarning(mount +" is not mounted");
+ TextViewOutput->append(mount +" is not mounted");
return;
}
- /* parse output and display in ListViewScan */
- while(fgets(result, 256, pipe2) != NULL) {
- /* put result into TextViewOutput */
- TextViewOutput->append(result);
- }
- TextViewOutput->append("\n\n============================================\n");
- scanning = false;
+ QStringList ccmd;
+ QString share;
+ QListViewItem *element;
+ element = ListViewScan->selectedItem();
+ share = element->text(0);
+ qWarning("selected share is "+share);
+
+ if(mount.left(1) != "/")
+ mount = QDir::currentDirPath()+"/"+mount;
+ mount = mount.stripWhiteSpace();
+
+ ccmd << "/usr/bin/smbumount";
+ ccmd << mount;
+ runCommand(ccmd);
+
+ element->setText(2, "");
+
+ ccmd = "/bin/mount";
+ runCommand(ccmd);
}
bool Qsmb::runCommand(const QStringList & command) {
- owarn << "runCommand " << command.join(" ") << oendl;
+ qWarning( "runCommand " + command.join(" ") );
+ TextViewOutput->append(command.join(" "));
out = "";
Process ipkg_status( command);
bool r = ipkg_status.exec("",out);
- if(!r) {
- QMessageBox::warning(this, tr("Error!!"),tr("<p>"+out+"</p>"));
- }
+ qWarning("result is %d"+ r );
+ qWarning("Output " + out );
+ TextViewOutput->append(out);
- owarn << "Output " << out << oendl;
- TextViewOutput->append(out.latin1());
+//very hacky
+ if(out.find("failed") !=-1) {
+ r = false;
+ }
return r;
}
+bool Qsmb::isMounted(const QString &mountPoint) {
+ struct mntent *me;
+ bool mounted = false;
+ FILE *mntfp = setmntent( "/etc/mtab", "r" );
+ if ( mntfp ){
+ while ( (me = getmntent( mntfp )) != 0 ) {
+ QString deviceName = me->mnt_fsname;
+ QString mountDir = me->mnt_dir;
+ QString fsType = me->mnt_type;
+ if( fsType == "smbfs" && mountDir.find(mountPoint) !=-1)
+ mounted = true;
+ }
+ }
+ endmntent( mntfp );
+ return mounted;
+}
diff --git a/noncore/net/opie-smb/qsmb.h b/noncore/net/opie-smb/qsmb.h
index b406a1e..fba94d0 100644
--- a/noncore/net/opie-smb/qsmb.h
+++ b/noncore/net/opie-smb/qsmb.h
@@ -13,18 +13,19 @@
class Qsmb : public FormQPESMBBase
{
- Q_OBJECT
+ Q_OBJECT
public:
- static QString appName() { return QString::fromLatin1("opie-smb"); }
- Qsmb( QWidget* parent = 0, const char* name = 0, WFlags fl = 0 );
- ~Qsmb();
- void scan();
- void DoIt();
+ static QString appName() { return QString::fromLatin1("opie-smb"); }
+ Qsmb( QWidget* parent = 0, const char* name = 0, WFlags fl = 0 );
+ ~Qsmb();
+ void scan();
+ void DoIt();
private:
- QListViewItem *top_element;
- QComboBox *hosts;
- pthread_t tpid;
- bool scanning;
+ QListViewItem *top_element;
+ QComboBox *hosts;
+ pthread_t tpid;
+ bool scanning;
+ bool isMounted(const QString &);
public slots:
@@ -33,4 +34,5 @@ public slots:
void hostSelected(int);
void DoItClicked();
+ void umountIt();
QString out;
bool runCommand(const QStringList &);
diff --git a/noncore/net/opie-smb/qsmbbase.ui b/noncore/net/opie-smb/qsmbbase.ui
index 297eb2a..4692282 100644
--- a/noncore/net/opie-smb/qsmbbase.ui
+++ b/noncore/net/opie-smb/qsmbbase.ui
@@ -12,6 +12,6 @@
<x>0</x>
<y>0</y>
- <width>250</width>
- <height>352</height>
+ <width>259</width>
+ <height>395</height>
</rect>
</property>
@@ -69,5 +69,5 @@
<property stdset="1">
<name>spacing</name>
- <number>0</number>
+ <number>2</number>
</property>
<widget row="1" column="0" rowspan="1" colspan="4" >
@@ -137,4 +137,18 @@
</property>
</column>
+ <column>
+ <property>
+ <name>text</name>
+ <string>Mount</string>
+ </property>
+ <property>
+ <name>clickable</name>
+ <bool>true</bool>
+ </property>
+ <property>
+ <name>resizeable</name>
+ <bool>true</bool>
+ </property>
+ </column>
<property stdset="1">
<name>name</name>
@@ -179,16 +193,5 @@
</property>
</widget>
- <widget row="5" column="0" rowspan="1" colspan="2" >
- <class>QPushButton</class>
- <property stdset="1">
- <name>name</name>
- <cstring>DoItBtn</cstring>
- </property>
- <property stdset="1">
- <name>text</name>
- <string>&amp;Mount</string>
- </property>
- </widget>
- <widget row="5" column="2" rowspan="1" colspan="2" >
+ <widget row="5" column="2" rowspan="2" colspan="2" >
<class>QLayoutWidget</class>
<property stdset="1">
@@ -277,4 +280,26 @@
</grid>
</widget>
+ <widget row="6" column="0" rowspan="1" colspan="2" >
+ <class>QPushButton</class>
+ <property stdset="1">
+ <name>name</name>
+ <cstring>UnmountBtn</cstring>
+ </property>
+ <property stdset="1">
+ <name>text</name>
+ <string>&amp;Umount</string>
+ </property>
+ </widget>
+ <widget row="5" column="0" rowspan="1" colspan="2" >
+ <class>QPushButton</class>
+ <property stdset="1">
+ <name>name</name>
+ <cstring>DoItBtn</cstring>
+ </property>
+ <property stdset="1">
+ <name>text</name>
+ <string>&amp;Mount</string>
+ </property>
+ </widget>
</grid>
</widget>
@@ -292,9 +317,9 @@
<property stdset="1">
<name>margin</name>
- <number>11</number>
+ <number>2</number>
</property>
<property stdset="1">
<name>spacing</name>
- <number>6</number>
+ <number>2</number>
</property>
<widget row="0" column="0" >