summaryrefslogtreecommitdiff
Side-by-side diff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--noncore/settings/networksettings/ppp/TODO3
-rw-r--r--noncore/settings/networksettings/ppp/edit.cpp3
-rw-r--r--noncore/settings/networksettings/ppp/pppdargs.cpp31
-rw-r--r--noncore/settings/networksettings/ppp/pppdargs.h2
4 files changed, 11 insertions, 28 deletions
diff --git a/noncore/settings/networksettings/ppp/TODO b/noncore/settings/networksettings/ppp/TODO
index 9425628..529d236 100644
--- a/noncore/settings/networksettings/ppp/TODO
+++ b/noncore/settings/networksettings/ppp/TODO
@@ -2,6 +2,5 @@
- impl. PPPData::copyaccount & PPPData::deleteAccount
- update modem attribute inputs when modem has changed
-- fix layout of edit account
-- save pppd arguments in edit account
+- fix layout of edit account, i.e. get it shown maximised
- popup configure modem with the correct account prselected
not quite shure why it does not work... IMHO it should work
diff --git a/noncore/settings/networksettings/ppp/edit.cpp b/noncore/settings/networksettings/ppp/edit.cpp
index 10bc25c..45d6e4f 100644
--- a/noncore/settings/networksettings/ppp/edit.cpp
+++ b/noncore/settings/networksettings/ppp/edit.cpp
@@ -180,5 +180,4 @@ DialWidget::DialWidget( PPPData *pd, QWidget *parent, bool isnewaccount
}
-
bool DialWidget::save() {
//first check to make sure that the account name is unique!
@@ -261,5 +260,5 @@ void DialWidget::downNumber() {
void DialWidget::pppdargsbutton() {
PPPdArguments pa(_pppdata, this);
- pa.exec();
+ pa.exec();
}
diff --git a/noncore/settings/networksettings/ppp/pppdargs.cpp b/noncore/settings/networksettings/ppp/pppdargs.cpp
index d1143cf..66a4d82 100644
--- a/noncore/settings/networksettings/ppp/pppdargs.cpp
+++ b/noncore/settings/networksettings/ppp/pppdargs.cpp
@@ -28,15 +28,13 @@
#include <qlayout.h>
#include <qbuttongroup.h>
-//#include <kwin.h>
#include <qapplication.h>
#include "pppdargs.h"
#include "pppdata.h"
-//#include <klocale.h>
-#define i18n QObject::tr
+
PPPdArguments::PPPdArguments( PPPData *pd, QWidget *parent, const char *name)
: QDialog(parent, name, TRUE), _pppdata(pd)
{
- setCaption(i18n("Customize pppd Arguments"));
+ setCaption(tr("Customize pppd Arguments"));
// KWin::setIcons(winId(), kapp->icon(), kapp->miniIcon());
QVBoxLayout *l = new QVBoxLayout(this, 10, 10);
@@ -51,5 +49,5 @@ PPPdArguments::PPPdArguments( PPPData *pd, QWidget *parent, const char *name)
l1->addLayout(l11);
- argument_label = new QLabel(i18n("Argument:"), this);
+ argument_label = new QLabel(tr("Argument:"), this);
l11->addWidget(argument_label);
@@ -67,14 +65,14 @@ PPPdArguments::PPPdArguments( PPPData *pd, QWidget *parent, const char *name)
l1->addWidget(arguments, 1);
- add = new QPushButton(i18n("Add"), this);
+ add = new QPushButton(tr("Add"), this);
connect(add, SIGNAL(clicked()), SLOT(addbutton()));
l2->addWidget(add);
l2->addStretch(1);
- remove = new QPushButton(i18n("Remove"), this);
+ remove = new QPushButton(tr("Remove"), this);
connect(remove, SIGNAL(clicked()), SLOT(removebutton()));
l2->addWidget(remove);
- defaults = new QPushButton(i18n("Defaults"), this);
+ defaults = new QPushButton(tr("Defaults"), this);
connect(defaults, SIGNAL(clicked()), SLOT(defaultsbutton()));
l2->addWidget(defaults);
@@ -82,17 +80,4 @@ PPPdArguments::PPPdArguments( PPPData *pd, QWidget *parent, const char *name)
l->addSpacing(5);
-// QButtonGroup *bbox = new QButtonGroup(this);
-// // bbox->addStretch(1);
-// closebtn = new QPushButton( bbox, i18n("OK"));
-// bbox->insert(closebtn);
-// connect(closebtn, SIGNAL(clicked()), SLOT(closebutton()));
-// QPushButton *cancel = new QPushButton( bbox, i18n("Cancel"));
-// bbox->insert(cancel);
-// connect(cancel, SIGNAL(clicked()),
-// this, SLOT(reject()));
-// bbox->layout();
-// l->addWidget(bbox);
-
-// setFixedSize(sizeHint());
//load info from gpppdata
@@ -133,5 +118,5 @@ void PPPdArguments::defaultsbutton() {
-void PPPdArguments::closebutton() {
+void PPPdArguments::accept() {
QStringList arglist;
for(uint i=0; i < arguments->count(); i++)
@@ -139,5 +124,5 @@ void PPPdArguments::closebutton() {
_pppdata->setpppdArgument(arglist);
- done(0);
+ QDialog::accept();
}
diff --git a/noncore/settings/networksettings/ppp/pppdargs.h b/noncore/settings/networksettings/ppp/pppdargs.h
index 75f0c9d..065b03c 100644
--- a/noncore/settings/networksettings/ppp/pppdargs.h
+++ b/noncore/settings/networksettings/ppp/pppdargs.h
@@ -46,5 +46,5 @@ private slots:
void removebutton();
void defaultsbutton();
- void closebutton();
+ virtual void accept();
void textChanged(const QString &);
void itemSelected(int);