-rw-r--r-- | libopie2/opieui/odialog.cpp | 16 | ||||
-rw-r--r-- | libopie2/opieui/odialog.h | 10 | ||||
-rw-r--r-- | libopie2/opieui/oimageeffect.cpp | 41 | ||||
-rw-r--r-- | libopie2/opieui/olistview.cpp | 20 | ||||
-rw-r--r-- | libopie2/opieui/opieui.pro | 22 | ||||
-rw-r--r-- | libopie2/opieui/oseparator.cpp | 12 | ||||
-rw-r--r-- | libopie2/opieui/oversatileview.cpp | 25 |
7 files changed, 75 insertions, 71 deletions
diff --git a/libopie2/opieui/odialog.cpp b/libopie2/opieui/odialog.cpp index 00a7a7e..4d269d4 100644 --- a/libopie2/opieui/odialog.cpp +++ b/libopie2/opieui/odialog.cpp @@ -1,6 +1,5 @@ /* This file is part of the Opie Project - - Copyright (C) 2003 Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de> + Copyright (C) 2003 Michael 'Mickey' Lauer <mickey@Vanille.de> =. .=l. @@ -32,15 +31,18 @@ #include <opie2/odialog.h> -int ODialog::mMarginSize = 5; // 11 like in KDialog is probably too much for PDA -int ODialog::mSpacingSize = 2; // 6 like in KDialog is probably too much for PDA +#warning Make Margin and Spacing device dependend and configurable! + +int ODialog::mMarginSize = 5; +int ODialog::mSpacingSize = 2; ODialog::ODialog(QWidget *parent, const char *name, bool modal, WFlags f) - : QDialog(parent, name, modal, f) + :QDialog(parent, name, modal, f) { + // d = new ODialogPrivate(); } int ODialog::marginHint() { - return( mMarginSize ); + return( mMarginSize ); } @@ -48,5 +50,5 @@ int ODialog::marginHint() int ODialog::spacingHint() { - return( mSpacingSize ); + return( mSpacingSize ); } diff --git a/libopie2/opieui/odialog.h b/libopie2/opieui/odialog.h index 4116ed7..ceff612 100644 --- a/libopie2/opieui/odialog.h +++ b/libopie2/opieui/odialog.h @@ -1,6 +1,5 @@ /* This file is part of the Opie Project - - (C) 2003 Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de> + (C) 2003 Michael 'Mickey' Lauer <mickey@Vanille.de> =. .=l. @@ -50,7 +49,10 @@ class QLayoutItem; * @ref marginHint() above the separator as well. * - * @author Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de> + * @author Michael 'Mickey' Lauer <mickey@Vanille.de> */ + // lets fix up Qt instead! Size does matter. -zecke + // while that may be true, reducing maintainance effort for the future does also matter - + // and I believe that maintaining a patch against QtE is more work than our classes -mml class ODialog : public QDialog @@ -84,5 +86,5 @@ class ODialog : public QDialog class ODialogPrivate; - ODialogPrivate *d; // d pointer always needed! -zecke + ODialogPrivate *d; }; diff --git a/libopie2/opieui/oimageeffect.cpp b/libopie2/opieui/oimageeffect.cpp index 01e7c6f..9a58bb9 100644 --- a/libopie2/opieui/oimageeffect.cpp +++ b/libopie2/opieui/oimageeffect.cpp @@ -35,5 +35,6 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include <stdlib.h> -#include "oimageeffect.h" +#include <opie2/oimageeffect.h> +#include <opie2/odebug.h> #define MaxRGB 255L @@ -64,5 +65,5 @@ QImage OImageEffect::gradient(const QSize &size, const QColor &ca, if (size.width() == 0 || size.height() == 0) { - qDebug( "WARNING: OImageEffect::gradient: invalid image" ); + odebug << "WARNING: OImageEffect::gradient: invalid image" << oendl; return image; } @@ -350,5 +351,5 @@ QImage OImageEffect::unbalancedGradient(const QSize &size, const QColor &ca, if (size.width() == 0 || size.height() == 0) { - qDebug( "WARNING: OImageEffect::unbalancedGradient : invalid image" ); + odebug << "WARNING: OImageEffect::unbalancedGradient : invalid image" << oendl; return image; } @@ -569,5 +570,5 @@ QImage& OImageEffect::intensity(QImage &image, float percent) { if (image.width() == 0 || image.height() == 0) { - qDebug( "WARNING: OImageEffect::intensity : invalid image" ); + odebug << "WARNING: OImageEffect::intensity : invalid image" << oendl; return image; } @@ -634,5 +635,5 @@ QImage& OImageEffect::channelIntensity(QImage &image, float percent, { if (image.width() == 0 || image.height() == 0) { - qDebug( "WARNING: OImageEffect::channelIntensity : invalid image" ); + odebug << "WARNING: OImageEffect::channelIntensity : invalid image" << oendl; return image; } @@ -724,5 +725,5 @@ QImage& OImageEffect::modulate(QImage &image, QImage &modImage, bool reverse, if (image.width() == 0 || image.height() == 0 || modImage.width() == 0 || modImage.height() == 0) { - qDebug( "WARNING: OImageEffect::modulate : invalid image" ); + odebug << "WARNING: OImageEffect::modulate : invalid image" << oendl; return image; } @@ -853,5 +854,5 @@ QImage& OImageEffect::blend(const QColor& clr, QImage& dst, float opacity) if (opacity < 0.0 || opacity > 1.0) { - qDebug( "WARNING: OImageEffect::blend : invalid opacity. Range [0, 1] "); + odebug << "WARNING: OImageEffect::blend : invalid opacity. Range [0, 1] " << oendl; return dst; } @@ -896,10 +897,10 @@ QImage& OImageEffect::blend(QImage& src, QImage& dst, float opacity) if (src.width() != dst.width() || src.height() != dst.height()) { - qDebug( "WARNING: OImageEffect::blend : src and destination images are not the same size" ); + odebug << "WARNING: OImageEffect::blend : src and destination images are not the same size" << oendl; return dst; } if (opacity < 0.0 || opacity > 1.0) { - qDebug( "WARNING: OImageEffect::blend : invalid opacity. Range [0, 1]" ); + odebug << "WARNING: OImageEffect::blend : invalid opacity. Range [0, 1]" << oendl; return dst; } @@ -941,5 +942,5 @@ QImage& OImageEffect::blend(QImage &image, float initial_intensity, { if (image.width() == 0 || image.height() == 0 || image.depth()!=32 ) { - qDebug( "WARNING: OImageEffect::blend : invalid image" ); + odebug << "WARNING: OImageEffect::blend : invalid image" << oendl; return image; } @@ -1134,5 +1135,5 @@ QImage& OImageEffect::blend(QImage &image, float initial_intensity, } } - else qDebug( "OImageEffect::blend effect not implemented" ); + else odebug << "OImageEffect::blend effect not implemented" << oendl; return image; } @@ -1164,5 +1165,5 @@ QImage& OImageEffect::blend(QImage &image1, QImage &image2, image2.width() == 0 || image2.height() == 0 || blendImage.width() == 0 || blendImage.height() == 0) { - qDebug( "OImageEffect::blend effect invalid image" ); + odebug << "OImageEffect::blend effect invalid image" << oendl; return image1; } @@ -1262,5 +1263,5 @@ QImage& OImageEffect::hash(QImage &image, Lighting lite, unsigned int spacing) { if (image.width() == 0 || image.height() == 0) { - qDebug( "OImageEffect::hash effect invalid image" ); + odebug << "OImageEffect::hash effect invalid image" << oendl; return image; } @@ -1770,5 +1771,5 @@ bool OImageEffect::blend( ) { - qDebug( "OImageEffect::blend : Sizes not correct" ); + odebug << "OImageEffect::blend : Sizes not correct" << oendl; return false; } @@ -1987,5 +1988,5 @@ void OImageEffect::normalize(QImage &img) normalize_map = (unsigned int *)malloc((MaxRGB+1)*sizeof(unsigned int)); if(!normalize_map || !histogram){ - qWarning("Unable to allocate normalize histogram and map"); + owarn << "Unable to allocate normalize histogram and map" << oendl; free(normalize_map); free(histogram); @@ -2103,5 +2104,5 @@ void OImageEffect::equalize(QImage &img) if(!histogram || !map || !equalize_map){ - qWarning("Unable to allocate equalize histogram and maps"); + owarn << "Unable to allocate equalize histogram and maps" << oendl; free(histogram); free(map); @@ -2188,5 +2189,5 @@ QImage OImageEffect::sample(QImage &src, int w, int h) y_offset = (double *)malloc(h*sizeof(double)); if(!x_offset || !y_offset){ - qWarning("Unable to allocate pixels buffer"); + owarn << "Unable to allocate pixels buffer" << oendl; free(x_offset); free(y_offset); @@ -2206,5 +2207,5 @@ QImage OImageEffect::sample(QImage &src, int w, int h) pixels = (unsigned int *)malloc(src.width()*sizeof(unsigned int)); if(!pixels){ - qWarning("Unable to allocate pixels buffer"); + owarn << "Unable to allocate pixels buffer" << oendl; free(pixels); free(x_offset); @@ -2234,5 +2235,5 @@ QImage OImageEffect::sample(QImage &src, int w, int h) pixels = (unsigned char *)malloc(src.width()*sizeof(unsigned char)); if(!pixels){ - qWarning("Unable to allocate pixels buffer"); + owarn << "Unable to allocate pixels buffer" << oendl; free(pixels); free(x_offset); @@ -3073,5 +3074,5 @@ QImage OImageEffect::oilPaint(QImage &src, int radius) // TODO 8bpp src! if(src.depth() < 32){ - qWarning("Oil Paint source image < 32bpp. Convert before using!"); + owarn << "Oil Paint source image < 32bpp. Convert before using!" << oendl; return(src); } diff --git a/libopie2/opieui/olistview.cpp b/libopie2/opieui/olistview.cpp index ec503dd..38f3fe2 100644 --- a/libopie2/opieui/olistview.cpp +++ b/libopie2/opieui/olistview.cpp @@ -1,6 +1,5 @@ /* This file is part of the Opie Project - - =. (C) 2003 Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de> + =. (C) 2003 Michael 'Mickey' Lauer <mickey@Vanille.de> .=l. .>+-= @@ -38,4 +37,5 @@ /* OPIE */ +#include <opie2/odebug.h> #include <opie2/olistview.h> @@ -143,5 +143,5 @@ void OListView::serializeTo( QDataStream& s ) const { #warning Caution... the binary format is still under construction... - qDebug( "storing OListView..." ); + odebug << "storing OListView..." << oendl; // store number of columns and the labels @@ -168,5 +168,5 @@ void OListView::serializeTo( QDataStream& s ) const } - qDebug( "OListview stored." ); + odebug << "OListview stored." << oendl; } @@ -174,5 +174,5 @@ void OListView::serializeFrom( QDataStream& s ) { #warning Caution... the binary format is still under construction... - qDebug( "loading OListView..." ); + odebug << "loading OListView..." << oendl; int cols; @@ -200,5 +200,5 @@ void OListView::serializeFrom( QDataStream& s ) } - qDebug( "OListView loaded." ); + odebug << "OListView loaded." << oendl; } @@ -378,5 +378,5 @@ void OListViewItem::serializeTo( QDataStream& s ) const { #warning Caution... the binary format is still under construction... - qDebug( "storing OListViewItem..." ); + odebug << "storing OListViewItem..." << oendl; // store item text @@ -404,5 +404,5 @@ void OListViewItem::serializeTo( QDataStream& s ) const } - qDebug( "OListviewItem stored." ); + odebug << "OListviewItem stored." << oendl; } @@ -411,5 +411,5 @@ void OListViewItem::serializeFrom( QDataStream& s ) { #warning Caution... the binary format is still under construction... - qDebug( "loading OListViewItem..." ); + odebug << "loading OListViewItem..." << oendl; for ( int i = 0; i < listView()->columns(); ++i ) @@ -431,5 +431,5 @@ void OListViewItem::serializeFrom( QDataStream& s ) } - qDebug( "OListViewItem loaded." ); + odebug << "OListViewItem loaded." << oendl; } diff --git a/libopie2/opieui/opieui.pro b/libopie2/opieui/opieui.pro index b455602..61f9bbb 100644 --- a/libopie2/opieui/opieui.pro +++ b/libopie2/opieui/opieui.pro @@ -11,7 +11,8 @@ HEADERS = olistview.h \ oversatileviewitem.h \ odialog.h \ - omessagebox.h \ - oresource.h \ - oseparator.h + omessagebox.h \ + oresource.h \ + otaskbarapplet.h \ + oseparator.h SOURCES = olistview.cpp \ @@ -24,26 +25,23 @@ SOURCES = olistview.cpp \ oversatileviewitem.cpp \ odialog.cpp \ - oresource.cpp \ - oseparator.cpp + oresource.cpp \ + otaskbarapplet.cpp \ + oseparator.cpp INTERFACES = TARGET = opieui2 VERSION = 1.8.2 + INCLUDEPATH += $(OPIEDIR)/include DEPENDPATH += $(OPIEDIR)/include -LIBS += -lopiecore2 -MOC_DIR = moc -OBJECTS_DIR = obj +LIBS += -lopiecore2 !contains( platform, x11 ) { include ( $(OPIEDIR)/include.pro ) - HEADERS += otaskbarapplet.h - SOURCES += otaskbarapplet.cpp } contains( platform, x11 ) { - LIBS += -L$(OPIEDIR)/lib -Wl,-rpath,$(OPIEDIR)/lib - message( Warning: NO otaskbarapplet ATM ) + LIBS += -L$(OPIEDIR)/lib -Wl,-rpath,$(OPIEDIR)/lib } diff --git a/libopie2/opieui/oseparator.cpp b/libopie2/opieui/oseparator.cpp index 85181dc..98d42c7 100644 --- a/libopie2/opieui/oseparator.cpp +++ b/libopie2/opieui/oseparator.cpp @@ -1,5 +1,4 @@ /* This file is part of the Opie Project - Copyright (C) 2003 Michael 'Mickey' Lauer <mickey@tm.informatik.uni-frankfurt.de> Copyright (C) 1997 Michael Roth <mroth@wirlweb.de> @@ -31,12 +30,13 @@ */ -/* QT */ - -#include <qstyle.h> - /* OPIE */ +#include <opie2/odebug.h> #include <opie2/oseparator.h> +/* QT */ + +#include <qstyle.h> + OSeparator::OSeparator(QWidget* parent, const char* name, WFlags f) : QFrame(parent, name, f) @@ -70,5 +70,5 @@ void OSeparator::setOrientation(int orientation) default: - qWarning( "OSeparator::setOrientation(): invalid orientation, using default orientation HLine" ); + owarn << "OSeparator::setOrientation(): invalid orientation, using default orientation HLine" << oendl; case Horizontal: diff --git a/libopie2/opieui/oversatileview.cpp b/libopie2/opieui/oversatileview.cpp index 6808539..65fe3d8 100644 --- a/libopie2/opieui/oversatileview.cpp +++ b/libopie2/opieui/oversatileview.cpp @@ -29,4 +29,11 @@ */ +/* OPIE */ + +#include <opie2/odebug.h> +#include <opie2/oversatileview.h> +#include <opie2/oversatileviewitem.h> +#include <opie2/olistview.h> + /* QT */ @@ -45,10 +52,4 @@ #include <qwidgetstack.h> -/* OPIE */ - -#include <opie2/oversatileview.h> -#include <opie2/oversatileviewitem.h> -#include <opie2/olistview.h> - /* XPM */ static const char * view_icon_xpm[] = { @@ -290,5 +291,5 @@ void OVersatileView::setDefaultPixmaps( int mode, QPixmap& leaf, QPixmap& opened else { - qDebug( "OVersatileView::setDefaultPixmaps(): invalid mode" ); + odebug << "OVersatileView::setDefaultPixmaps(): invalid mode" << oendl; } } @@ -318,5 +319,5 @@ void OVersatileView::setViewMode( int mode ) else { - qDebug( "OVersatileView::setViewMode(): invalid mode" ); + odebug << "OVersatileView::setViewMode(): invalid mode" << oendl; } } @@ -344,5 +345,5 @@ bool OVersatileView::isValidViewMode( int mode ) const if ( _viewmode != mode ) { - qDebug( "OVersatileView::isValidViewMode(): Requested operation not valid in current mode." ); + odebug << "OVersatileView::isValidViewMode(): Requested operation not valid in current mode." << oendl; return true; } @@ -352,5 +353,5 @@ bool OVersatileView::isValidViewMode( int mode ) const if ( _viewmode != mode ) { - qDebug( "OVersatileView::isValidViewMode(): Requested operation not valid in current mode." ); + odebug << "OVersatileView::isValidViewMode(): Requested operation not valid in current mode." << oendl; return false; } @@ -358,5 +359,5 @@ bool OVersatileView::isValidViewMode( int mode ) const default: { - qWarning( "OVersatileView::isValidViewMode(): Inconsistent object state!" ); + owarn << "OVersatileView::isValidViewMode(): Inconsistent object state!" << oendl; return true; } @@ -449,5 +450,5 @@ void OVersatileView::onItem( QIconViewItem * item ) void OVersatileView::expanded( QListViewItem *item ) // QListView { - //qDebug( "OVersatileView::expanded(): opening tree..." ); + //odebug << "OVersatileView::expanded(): opening tree..." << oendl; if ( !_treeopened.isNull() ) item->setPixmap( 0, _treeopened ); |