summaryrefslogtreecommitdiff
Unidiff
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--libopie/pim/opimaccesstemplate.h2
-rw-r--r--libopie/pim/orecordlist.h5
-rw-r--r--libopie/pim/otodoaccesssql.cpp31
-rw-r--r--libopie/pim/otodoaccesssql.h3
-rw-r--r--libopie2/opiepim/backend/otodoaccesssql.cpp31
-rw-r--r--libopie2/opiepim/backend/otodoaccesssql.h3
-rw-r--r--libopie2/opiepim/core/opimaccesstemplate.h2
-rw-r--r--libopie2/opiepim/orecordlist.h5
8 files changed, 58 insertions, 24 deletions
diff --git a/libopie/pim/opimaccesstemplate.h b/libopie/pim/opimaccesstemplate.h
index 92d7192..a0d8f63 100644
--- a/libopie/pim/opimaccesstemplate.h
+++ b/libopie/pim/opimaccesstemplate.h
@@ -163,54 +163,52 @@ OPimAccessTemplate<T>::List OPimAccessTemplate<T>::allRecords()const {
163template <class T> 163template <class T>
164OPimAccessTemplate<T>::List 164OPimAccessTemplate<T>::List
165OPimAccessTemplate<T>::queryByExample( const T& t, int sortOrder ) { 165OPimAccessTemplate<T>::queryByExample( const T& t, int sortOrder ) {
166 QArray<int> ints = m_backEnd->queryByExample( t, sortOrder ); 166 QArray<int> ints = m_backEnd->queryByExample( t, sortOrder );
167 167
168 List lis(ints, this ); 168 List lis(ints, this );
169 return lis; 169 return lis;
170} 170}
171template <class T> 171template <class T>
172T OPimAccessTemplate<T>::find( int uid ) const{ 172T OPimAccessTemplate<T>::find( int uid ) const{
173 T t = m_backEnd->find( uid ); 173 T t = m_backEnd->find( uid );
174 cache( t ); 174 cache( t );
175 return t; 175 return t;
176} 176}
177template <class T> 177template <class T>
178T OPimAccessTemplate<T>::find( int uid, const QArray<int>& ar, 178T OPimAccessTemplate<T>::find( int uid, const QArray<int>& ar,
179 uint current, CacheDirection dir )const { 179 uint current, CacheDirection dir )const {
180 /* 180 /*
181 * better do T.isEmpty() 181 * better do T.isEmpty()
182 * after a find this way we would 182 * after a find this way we would
183 * avoid two finds in QCache... 183 * avoid two finds in QCache...
184 */ 184 */
185 // qWarning("find it now %d", uid ); 185 // qWarning("find it now %d", uid );
186 if (m_cache.contains( uid ) ) { 186 if (m_cache.contains( uid ) ) {
187 qWarning("m cache contains %d", uid);
188 return m_cache.find( uid ); 187 return m_cache.find( uid );
189 } 188 }
190 189
191 T t = m_backEnd->find( uid, ar, current, dir ); 190 T t = m_backEnd->find( uid, ar, current, dir );
192 qWarning("found it and cache it now %d", uid);
193 cache( t ); 191 cache( t );
194 return t; 192 return t;
195} 193}
196template <class T> 194template <class T>
197void OPimAccessTemplate<T>::clear() { 195void OPimAccessTemplate<T>::clear() {
198 invalidateCache(); 196 invalidateCache();
199 m_backEnd->clear(); 197 m_backEnd->clear();
200} 198}
201template <class T> 199template <class T>
202bool OPimAccessTemplate<T>::add( const T& t ) { 200bool OPimAccessTemplate<T>::add( const T& t ) {
203 cache( t ); 201 cache( t );
204 return m_backEnd->add( t ); 202 return m_backEnd->add( t );
205} 203}
206template <class T> 204template <class T>
207bool OPimAccessTemplate<T>::remove( const T& t ) { 205bool OPimAccessTemplate<T>::remove( const T& t ) {
208 return remove( t.uid() ); 206 return remove( t.uid() );
209} 207}
210template <class T> 208template <class T>
211bool OPimAccessTemplate<T>::remove( int uid ) { 209bool OPimAccessTemplate<T>::remove( int uid ) {
212 m_cache.remove( uid ); 210 m_cache.remove( uid );
213 return m_backEnd->remove( uid ); 211 return m_backEnd->remove( uid );
214} 212}
215template <class T> 213template <class T>
216bool OPimAccessTemplate<T>::replace( const T& t ) { 214bool OPimAccessTemplate<T>::replace( const T& t ) {
diff --git a/libopie/pim/orecordlist.h b/libopie/pim/orecordlist.h
index 08f5c85..5404910 100644
--- a/libopie/pim/orecordlist.h
+++ b/libopie/pim/orecordlist.h
@@ -88,48 +88,49 @@ public:
88 * c'tor 88 * c'tor
89 */ 89 */
90 ORecordList () { 90 ORecordList () {
91 } 91 }
92 ORecordList( const QArray<int>& ids, 92 ORecordList( const QArray<int>& ids,
93 const Base* ); 93 const Base* );
94 ~ORecordList(); 94 ~ORecordList();
95 95
96 /** 96 /**
97 * the first iterator 97 * the first iterator
98 */ 98 */
99 Iterator begin(); 99 Iterator begin();
100 100
101 /** 101 /**
102 * the end 102 * the end
103 */ 103 */
104 Iterator end(); 104 Iterator end();
105 105
106 /** 106 /**
107 * the number of items in the list 107 * the number of items in the list
108 */ 108 */
109 uint count()const; 109 uint count()const;
110 110
111 T operator[]( uint i ); 111 T operator[]( uint i );
112 int uidAt(uint i );
112 // FIXME implemenent remove 113 // FIXME implemenent remove
113 /* 114 /*
114 ConstIterator begin()const; 115 ConstIterator begin()const;
115 ConstIterator end()const; 116 ConstIterator end()const;
116 */ 117 */
117private: 118private:
118 QArray<int> m_ids; 119 QArray<int> m_ids;
119 const Base* m_acc; 120 const Base* m_acc;
120}; 121};
121 122
122/* ok now implement it */ 123/* ok now implement it */
123template <class T> 124template <class T>
124ORecordListIterator<T>::ORecordListIterator() { 125ORecordListIterator<T>::ORecordListIterator() {
125 m_current = 0; 126 m_current = 0;
126 m_temp = 0l; 127 m_temp = 0l;
127 m_end = true; 128 m_end = true;
128 m_record = T(); 129 m_record = T();
129 /* forward */ 130 /* forward */
130 m_direction = TRUE; 131 m_direction = TRUE;
131} 132}
132template <class T> 133template <class T>
133ORecordListIterator<T>::~ORecordListIterator() { 134ORecordListIterator<T>::~ORecordListIterator() {
134/* nothing to delete */ 135/* nothing to delete */
135} 136}
@@ -241,25 +242,29 @@ ORecordList<T>::~ORecordList() {
241/* nothing to do here */ 242/* nothing to do here */
242} 243}
243template <class T> 244template <class T>
244ORecordList<T>::Iterator ORecordList<T>::begin() { 245ORecordList<T>::Iterator ORecordList<T>::begin() {
245 Iterator it( m_ids, m_acc ); 246 Iterator it( m_ids, m_acc );
246 return it; 247 return it;
247} 248}
248template <class T> 249template <class T>
249ORecordList<T>::Iterator ORecordList<T>::end() { 250ORecordList<T>::Iterator ORecordList<T>::end() {
250 Iterator it( m_ids, m_acc ); 251 Iterator it( m_ids, m_acc );
251 it.m_end = true; 252 it.m_end = true;
252 it.m_current = m_ids.count(); 253 it.m_current = m_ids.count();
253 254
254 return it; 255 return it;
255} 256}
256template <class T> 257template <class T>
257uint ORecordList<T>::count()const { 258uint ORecordList<T>::count()const {
258return m_ids.count(); 259return m_ids.count();
259} 260}
260template <class T> 261template <class T>
261T ORecordList<T>::operator[]( uint i ) { 262T ORecordList<T>::operator[]( uint i ) {
262 /* forward */ 263 /* forward */
263 return m_acc->find( m_ids[i], m_ids, i ); 264 return m_acc->find( m_ids[i], m_ids, i );
264} 265}
266template <class T>
267int ORecordList<T>::uidAt( uint i ) {
268 return m_ids[i];
269}
265#endif 270#endif
diff --git a/libopie/pim/otodoaccesssql.cpp b/libopie/pim/otodoaccesssql.cpp
index a059dab..ea8b3c9 100644
--- a/libopie/pim/otodoaccesssql.cpp
+++ b/libopie/pim/otodoaccesssql.cpp
@@ -220,176 +220,181 @@ namespace {
220 EffQuery::EffQuery( const QDate& start, const QDate& end, bool inc ) 220 EffQuery::EffQuery( const QDate& start, const QDate& end, bool inc )
221 : OSQLQuery(), m_start( start ), m_end( end ),m_inc(inc) {} 221 : OSQLQuery(), m_start( start ), m_end( end ),m_inc(inc) {}
222 EffQuery::~EffQuery() {} 222 EffQuery::~EffQuery() {}
223 QString EffQuery::query()const { 223 QString EffQuery::query()const {
224 return m_inc ? with() : out(); 224 return m_inc ? with() : out();
225 } 225 }
226 QString EffQuery::with()const { 226 QString EffQuery::with()const {
227 QString str; 227 QString str;
228 str = QString("select uid from todolist where ( DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6' ) OR DueDate = '0-0-0' ") 228 str = QString("select uid from todolist where ( DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6' ) OR DueDate = '0-0-0' ")
229 .arg( m_start.year() ).arg( m_start.month() ).arg( m_start.day() ) 229 .arg( m_start.year() ).arg( m_start.month() ).arg( m_start.day() )
230 .arg( m_end .year() ).arg( m_end .month() ).arg( m_end .day() ); 230 .arg( m_end .year() ).arg( m_end .month() ).arg( m_end .day() );
231 return str; 231 return str;
232 } 232 }
233 QString EffQuery::out()const { 233 QString EffQuery::out()const {
234 QString str; 234 QString str;
235 str = QString("select uid from todolist where DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6'") 235 str = QString("select uid from todolist where DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6'")
236 .arg(m_start.year() ).arg(m_start.month() ).arg( m_start.day() ) 236 .arg(m_start.year() ).arg(m_start.month() ).arg( m_start.day() )
237 .arg(m_end. year() ).arg(m_end. month() ).arg(m_end.day() ); 237 .arg(m_end. year() ).arg(m_end. month() ).arg(m_end.day() );
238 238
239 return str; 239 return str;
240 } 240 }
241}; 241};
242 242
243OTodoAccessBackendSQL::OTodoAccessBackendSQL( const QString& file ) 243OTodoAccessBackendSQL::OTodoAccessBackendSQL( const QString& file )
244 : OTodoAccessBackend(), m_dict(15) 244 : OTodoAccessBackend(), m_dict(15), m_dirty(true)
245{ 245{
246 QString fi = file; 246 QString fi = file;
247 if ( fi.isEmpty() ) 247 if ( fi.isEmpty() )
248 fi = Global::applicationFileName( "todolist", "todolist.db" ); 248 fi = Global::applicationFileName( "todolist", "todolist.db" );
249 OSQLManager man; 249 OSQLManager man;
250 m_driver = man.standard(); 250 m_driver = man.standard();
251 m_driver->setUrl(fi); 251 m_driver->setUrl(fi);
252 fillDict(); 252 fillDict();
253} 253}
254 254
255OTodoAccessBackendSQL::~OTodoAccessBackendSQL(){ 255OTodoAccessBackendSQL::~OTodoAccessBackendSQL(){
256} 256}
257bool OTodoAccessBackendSQL::load(){ 257bool OTodoAccessBackendSQL::load(){
258 if (!m_driver->open() ) 258 if (!m_driver->open() )
259 return false; 259 return false;
260 260
261 CreateQuery creat; 261 CreateQuery creat;
262 OSQLResult res = m_driver->query(&creat ); 262 OSQLResult res = m_driver->query(&creat );
263 263
264 update(); 264 m_dirty = true;
265 qWarning("loaded %d", m_uids.count() );
266 return true; 265 return true;
267} 266}
268bool OTodoAccessBackendSQL::reload(){ 267bool OTodoAccessBackendSQL::reload(){
269 return load(); 268 return load();
270} 269}
271 270
272bool OTodoAccessBackendSQL::save(){ 271bool OTodoAccessBackendSQL::save(){
273 return m_driver->close(); 272 return m_driver->close();
274} 273}
275QArray<int> OTodoAccessBackendSQL::allRecords()const { 274QArray<int> OTodoAccessBackendSQL::allRecords()const {
275 if (m_dirty )
276 update();
277
276 return m_uids; 278 return m_uids;
277} 279}
278QArray<int> OTodoAccessBackendSQL::queryByExample( const OTodo& , int ){ 280QArray<int> OTodoAccessBackendSQL::queryByExample( const OTodo& , int ){
279 QArray<int> ints(0); 281 QArray<int> ints(0);
280 return ints; 282 return ints;
281} 283}
282OTodo OTodoAccessBackendSQL::find(int uid ) const{ 284OTodo OTodoAccessBackendSQL::find(int uid ) const{
283 FindQuery query( uid ); 285 FindQuery query( uid );
284 return todo( m_driver->query(&query) ); 286 return todo( m_driver->query(&query) );
285 287
286} 288}
287OTodo OTodoAccessBackendSQL::find( int uid, const QArray<int>& ints, 289OTodo OTodoAccessBackendSQL::find( int uid, const QArray<int>& ints,
288 uint cur, Frontend::CacheDirection dir ) const{ 290 uint cur, Frontend::CacheDirection dir ) const{
289 qWarning("searching for %d", uid ); 291 qWarning("searching for %d", uid );
290 QArray<int> search( 8 ); 292 QArray<int> search( 8 );
291 uint size =0; 293 uint size =0;
292 OTodo to; 294 OTodo to;
293 295
294 // we try to cache 8 items 296 // we try to cache 8 items
295 switch( dir ) { 297 switch( dir ) {
296 /* forward */ 298 /* forward */
297 case 0: 299 case 0:
298 for (uint i = cur; i < ints.count() && size < 8; i++ ) { 300 for (uint i = cur; i < ints.count() && size < 8; i++ ) {
299 qWarning("size %d %d", size, ints[i] ); 301 qWarning("size %d %d", size, ints[i] );
300 search[size] = ints[i]; 302 search[size] = ints[i];
301 size++; 303 size++;
302 } 304 }
303 break; 305 break;
304 /* reverse */ 306 /* reverse */
305 case 1: 307 case 1:
306 for (uint i = cur; i >= 0 && size < 8; i-- ) { 308 for (uint i = cur; i != 0 && size < 8; i-- ) {
307 search[size] = ints[i]; 309 search[size] = ints[i];
308 size++; 310 size++;
309 } 311 }
310 break; 312 break;
311 } 313 }
312 search.resize( size ); 314 search.resize( size );
313 FindQuery query( search ); 315 FindQuery query( search );
314 OSQLResult res = m_driver->query( &query ); 316 OSQLResult res = m_driver->query( &query );
315 if ( res.state() != OSQLResult::Success ) 317 if ( res.state() != OSQLResult::Success )
316 return to; 318 return to;
317 319
318 return todo( res ); 320 return todo( res );
319} 321}
320void OTodoAccessBackendSQL::clear() { 322void OTodoAccessBackendSQL::clear() {
321 ClearQuery cle; 323 ClearQuery cle;
322 OSQLResult res = m_driver->query( &cle ); 324 OSQLResult res = m_driver->query( &cle );
323 CreateQuery qu; 325 CreateQuery qu;
324 res = m_driver->query(&qu); 326 res = m_driver->query(&qu);
325} 327}
326bool OTodoAccessBackendSQL::add( const OTodo& t) { 328bool OTodoAccessBackendSQL::add( const OTodo& t) {
327 InsertQuery ins( t ); 329 InsertQuery ins( t );
328 OSQLResult res = m_driver->query( &ins ); 330 OSQLResult res = m_driver->query( &ins );
329 331
330 if ( res.state() == OSQLResult::Failure ) 332 if ( res.state() == OSQLResult::Failure )
331 return false; 333 return false;
332 int c = m_uids.count(); 334 int c = m_uids.count();
333 m_uids.resize( c+1 ); 335 m_uids.resize( c+1 );
334 m_uids[c] = t.uid(); 336 m_uids[c] = t.uid();
335 337
336 return true; 338 return true;
337} 339}
338bool OTodoAccessBackendSQL::remove( int uid ) { 340bool OTodoAccessBackendSQL::remove( int uid ) {
339 RemoveQuery rem( uid ); 341 RemoveQuery rem( uid );
340 OSQLResult res = m_driver->query(&rem ); 342 OSQLResult res = m_driver->query(&rem );
341 343
342 if ( res.state() == OSQLResult::Failure ) 344 if ( res.state() == OSQLResult::Failure )
343 return false; 345 return false;
344 346
345 update(); 347 m_dirty = true;
346 return true; 348 return true;
347} 349}
348/* 350/*
349 * FIXME better set query 351 * FIXME better set query
350 * but we need the cache for that 352 * but we need the cache for that
351 * now we remove 353 * now we remove
352 */ 354 */
353bool OTodoAccessBackendSQL::replace( const OTodo& t) { 355bool OTodoAccessBackendSQL::replace( const OTodo& t) {
354 remove( t.uid() ); 356 remove( t.uid() );
355 return add(t); 357 bool b= add(t);
358 m_dirty = false; // we changed some stuff but the UID stayed the same
359 return b;
356} 360}
357QArray<int> OTodoAccessBackendSQL::overDue() { 361QArray<int> OTodoAccessBackendSQL::overDue() {
358 OverDueQuery qu; 362 OverDueQuery qu;
359 return uids( m_driver->query(&qu ) ); 363 return uids( m_driver->query(&qu ) );
360} 364}
361QArray<int> OTodoAccessBackendSQL::effectiveToDos( const QDate& s, 365QArray<int> OTodoAccessBackendSQL::effectiveToDos( const QDate& s,
362 const QDate& t, 366 const QDate& t,
363 bool u) { 367 bool u) {
364 EffQuery ef(s, t, u ); 368 EffQuery ef(s, t, u );
365 return uids (m_driver->query(&ef) ); 369 return uids (m_driver->query(&ef) );
366} 370}
367/* 371/*
368 * 372 *
369 */ 373 */
370QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder, 374QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder,
371 int sortFilter, int cat ) { 375 int sortFilter, int cat ) {
376 qWarning("sorted %d, %d", asc, sortOrder );
372 QString query; 377 QString query;
373 query = "select uid from todolist WHERE "; 378 query = "select uid from todolist WHERE ";
374 379
375 /* 380 /*
376 * Sort Filter stuff 381 * Sort Filter stuff
377 * not that straight forward 382 * not that straight forward
378 * 383 *
379 */ 384 */
380 /* Category */ 385 /* Category */
381 if ( sortFilter & 1 ) { 386 if ( sortFilter & 1 ) {
382 QString str; 387 QString str;
383 if (cat != 0 ) str = QString::number( cat ); 388 if (cat != 0 ) str = QString::number( cat );
384 query += " categories like '%" +str+"%' AND"; 389 query += " categories like '%" +str+"%' AND";
385 } 390 }
386 /* Show only overdue */ 391 /* Show only overdue */
387 if ( sortFilter & 2 ) { 392 if ( sortFilter & 2 ) {
388 QDate date = QDate::currentDate(); 393 QDate date = QDate::currentDate();
389 QString due; 394 QString due;
390 QString base; 395 QString base;
391 base = QString("DueDate <= '%1-%2-%3' AND completed = 0").arg( date.year() ).arg( date.month() ).arg( date.day() ); 396 base = QString("DueDate <= '%1-%2-%3' AND completed = 0").arg( date.year() ).arg( date.month() ).arg( date.day() );
392 query += " " + base + " AND"; 397 query += " " + base + " AND";
393 } 398 }
394 /* not show completed */ 399 /* not show completed */
395 if ( sortFilter & 4 ) { 400 if ( sortFilter & 4 ) {
@@ -400,50 +405,53 @@ QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder,
400 /* srtip the end */ 405 /* srtip the end */
401 query = query.remove( query.length()-3, 3 ); 406 query = query.remove( query.length()-3, 3 );
402 407
403 408
404 /* 409 /*
405 * sort order stuff 410 * sort order stuff
406 * quite straight forward 411 * quite straight forward
407 */ 412 */
408 query += "ORDER BY "; 413 query += "ORDER BY ";
409 switch( sortOrder ) { 414 switch( sortOrder ) {
410 /* completed */ 415 /* completed */
411 case 0: 416 case 0:
412 query += "completed"; 417 query += "completed";
413 break; 418 break;
414 case 1: 419 case 1:
415 query += "priority"; 420 query += "priority";
416 break; 421 break;
417 case 2: 422 case 2:
418 query += "description"; 423 query += "description";
419 break; 424 break;
420 case 3: 425 case 3:
421 query += "DueDate"; 426 query += "DueDate";
422 break; 427 break;
423 } 428 }
424 if ( !asc ) 429
430 if ( !asc ) {
431 qWarning("not ascending!");
425 query += " DESC"; 432 query += " DESC";
433 }
426 434
427 qWarning( query ); 435 qWarning( query );
428 OSQLRawQuery raw(query ); 436 OSQLRawQuery raw(query );
429 return uids( m_driver->query(&raw) ); 437 return uids( m_driver->query(&raw) );
430} 438}
431bool OTodoAccessBackendSQL::date( QDate& da, const QString& str ) const{ 439bool OTodoAccessBackendSQL::date( QDate& da, const QString& str ) const{
432 if ( str == "0-0-0" ) 440 if ( str == "0-0-0" )
433 return false; 441 return false;
434 else{ 442 else{
435 int day, year, month; 443 int day, year, month;
436 QStringList list = QStringList::split("-", str ); 444 QStringList list = QStringList::split("-", str );
437 year = list[0].toInt(); 445 year = list[0].toInt();
438 month = list[1].toInt(); 446 month = list[1].toInt();
439 day = list[2].toInt(); 447 day = list[2].toInt();
440 da.setYMD( year, month, day ); 448 da.setYMD( year, month, day );
441 return true; 449 return true;
442 } 450 }
443} 451}
444OTodo OTodoAccessBackendSQL::todo( const OSQLResult& res) const{ 452OTodo OTodoAccessBackendSQL::todo( const OSQLResult& res) const{
445 if ( res.state() == OSQLResult::Failure ) { 453 if ( res.state() == OSQLResult::Failure ) {
446 OTodo to; 454 OTodo to;
447 return to; 455 return to;
448 } 456 }
449 457
@@ -480,47 +488,52 @@ OTodo OTodoAccessBackendSQL::todo( int uid )const {
480 * update the dict 488 * update the dict
481 */ 489 */
482void OTodoAccessBackendSQL::fillDict() { 490void OTodoAccessBackendSQL::fillDict() {
483 /* initialize dict */ 491 /* initialize dict */
484 /* 492 /*
485 * UPDATE dict if you change anything!!! 493 * UPDATE dict if you change anything!!!
486 */ 494 */
487 m_dict.setAutoDelete( TRUE ); 495 m_dict.setAutoDelete( TRUE );
488 m_dict.insert("Categories" , new int(OTodo::Category) ); 496 m_dict.insert("Categories" , new int(OTodo::Category) );
489 m_dict.insert("Uid" , new int(OTodo::Uid) ); 497 m_dict.insert("Uid" , new int(OTodo::Uid) );
490 m_dict.insert("HasDate" , new int(OTodo::HasDate) ); 498 m_dict.insert("HasDate" , new int(OTodo::HasDate) );
491 m_dict.insert("Completed" , new int(OTodo::Completed) ); 499 m_dict.insert("Completed" , new int(OTodo::Completed) );
492 m_dict.insert("Description" , new int(OTodo::Description) ); 500 m_dict.insert("Description" , new int(OTodo::Description) );
493 m_dict.insert("Summary" , new int(OTodo::Summary) ); 501 m_dict.insert("Summary" , new int(OTodo::Summary) );
494 m_dict.insert("Priority" , new int(OTodo::Priority) ); 502 m_dict.insert("Priority" , new int(OTodo::Priority) );
495 m_dict.insert("DateDay" , new int(OTodo::DateDay) ); 503 m_dict.insert("DateDay" , new int(OTodo::DateDay) );
496 m_dict.insert("DateMonth" , new int(OTodo::DateMonth) ); 504 m_dict.insert("DateMonth" , new int(OTodo::DateMonth) );
497 m_dict.insert("DateYear" , new int(OTodo::DateYear) ); 505 m_dict.insert("DateYear" , new int(OTodo::DateYear) );
498 m_dict.insert("Progress" , new int(OTodo::Progress) ); 506 m_dict.insert("Progress" , new int(OTodo::Progress) );
499 m_dict.insert("Completed", new int(OTodo::Completed) ); 507 m_dict.insert("Completed", new int(OTodo::Completed) );
500 m_dict.insert("CrossReference", new int(OTodo::CrossReference) ); 508 m_dict.insert("CrossReference", new int(OTodo::CrossReference) );
501 m_dict.insert("HasAlarmDateTime",new int(OTodo::HasAlarmDateTime) ); 509 m_dict.insert("HasAlarmDateTime",new int(OTodo::HasAlarmDateTime) );
502 m_dict.insert("AlarmDateTime", new int(OTodo::AlarmDateTime) ); 510 m_dict.insert("AlarmDateTime", new int(OTodo::AlarmDateTime) );
503} 511}
504void OTodoAccessBackendSQL::update() { 512/*
513 * need to be const so let's fool the
514 * compiler :(
515 */
516void OTodoAccessBackendSQL::update()const {
517 ((OTodoAccessBackendSQL*)this)->m_dirty = false;
505 LoadQuery lo; 518 LoadQuery lo;
506 OSQLResult res = m_driver->query(&lo); 519 OSQLResult res = m_driver->query(&lo);
507 if ( res.state() != OSQLResult::Success ) 520 if ( res.state() != OSQLResult::Success )
508 return; 521 return;
509 522
510 m_uids = uids( res ); 523 ((OTodoAccessBackendSQL*)this)->m_uids = uids( res );
511} 524}
512QArray<int> OTodoAccessBackendSQL::uids( const OSQLResult& res) const{ 525QArray<int> OTodoAccessBackendSQL::uids( const OSQLResult& res) const{
513 526
514 OSQLResultItem::ValueList list = res.results(); 527 OSQLResultItem::ValueList list = res.results();
515 OSQLResultItem::ValueList::Iterator it; 528 OSQLResultItem::ValueList::Iterator it;
516 QArray<int> ints(list.count() ); 529 QArray<int> ints(list.count() );
517 qWarning(" count = %d", list.count() ); 530 qWarning(" count = %d", list.count() );
518 531
519 int i = 0; 532 int i = 0;
520 for (it = list.begin(); it != list.end(); ++it ) { 533 for (it = list.begin(); it != list.end(); ++it ) {
521 ints[i] = (*it).data("uid").toInt(); 534 ints[i] = (*it).data("uid").toInt();
522 i++; 535 i++;
523 } 536 }
524 return ints; 537 return ints;
525} 538}
526 539
diff --git a/libopie/pim/otodoaccesssql.h b/libopie/pim/otodoaccesssql.h
index c1aa2ed..0f6dd2c 100644
--- a/libopie/pim/otodoaccesssql.h
+++ b/libopie/pim/otodoaccesssql.h
@@ -11,39 +11,40 @@ class OSQLResultItem;
11class OTodoAccessBackendSQL : public OTodoAccessBackend { 11class OTodoAccessBackendSQL : public OTodoAccessBackend {
12public: 12public:
13 OTodoAccessBackendSQL( const QString& file ); 13 OTodoAccessBackendSQL( const QString& file );
14 ~OTodoAccessBackendSQL(); 14 ~OTodoAccessBackendSQL();
15 15
16 bool load(); 16 bool load();
17 bool reload(); 17 bool reload();
18 bool save(); 18 bool save();
19 QArray<int> allRecords()const; 19 QArray<int> allRecords()const;
20 20
21 QArray<int> queryByExample( const OTodo& t, int sort ); 21 QArray<int> queryByExample( const OTodo& t, int sort );
22 OTodo find(int uid)const; 22 OTodo find(int uid)const;
23 OTodo find(int uid, const QArray<int>&, uint cur, Frontend::CacheDirection )const; 23 OTodo find(int uid, const QArray<int>&, uint cur, Frontend::CacheDirection )const;
24 void clear(); 24 void clear();
25 bool add( const OTodo& t ); 25 bool add( const OTodo& t );
26 bool remove( int uid ); 26 bool remove( int uid );
27 bool replace( const OTodo& t ); 27 bool replace( const OTodo& t );
28 28
29 QArray<int> overDue(); 29 QArray<int> overDue();
30 QArray<int> effectiveToDos( const QDate& start, 30 QArray<int> effectiveToDos( const QDate& start,
31 const QDate& end, bool includeNoDates ); 31 const QDate& end, bool includeNoDates );
32 QArray<int> sorted(bool asc, int sortOrder, int sortFilter, int cat ); 32 QArray<int> sorted(bool asc, int sortOrder, int sortFilter, int cat );
33 33
34private: 34private:
35 void update(); 35 void update()const;
36 void fillDict(); 36 void fillDict();
37 inline bool date( QDate& date, const QString& )const; 37 inline bool date( QDate& date, const QString& )const;
38 inline OTodo todo( const OSQLResult& )const; 38 inline OTodo todo( const OSQLResult& )const;
39 inline OTodo todo( OSQLResultItem& )const; 39 inline OTodo todo( OSQLResultItem& )const;
40 inline QArray<int> uids( const OSQLResult& )const; 40 inline QArray<int> uids( const OSQLResult& )const;
41 OTodo todo( int uid )const; 41 OTodo todo( int uid )const;
42 42
43 QAsciiDict<int> m_dict; 43 QAsciiDict<int> m_dict;
44 OSQLDriver* m_driver; 44 OSQLDriver* m_driver;
45 QArray<int> m_uids; 45 QArray<int> m_uids;
46 bool m_dirty : 1;
46}; 47};
47 48
48 49
49#endif 50#endif
diff --git a/libopie2/opiepim/backend/otodoaccesssql.cpp b/libopie2/opiepim/backend/otodoaccesssql.cpp
index a059dab..ea8b3c9 100644
--- a/libopie2/opiepim/backend/otodoaccesssql.cpp
+++ b/libopie2/opiepim/backend/otodoaccesssql.cpp
@@ -220,176 +220,181 @@ namespace {
220 EffQuery::EffQuery( const QDate& start, const QDate& end, bool inc ) 220 EffQuery::EffQuery( const QDate& start, const QDate& end, bool inc )
221 : OSQLQuery(), m_start( start ), m_end( end ),m_inc(inc) {} 221 : OSQLQuery(), m_start( start ), m_end( end ),m_inc(inc) {}
222 EffQuery::~EffQuery() {} 222 EffQuery::~EffQuery() {}
223 QString EffQuery::query()const { 223 QString EffQuery::query()const {
224 return m_inc ? with() : out(); 224 return m_inc ? with() : out();
225 } 225 }
226 QString EffQuery::with()const { 226 QString EffQuery::with()const {
227 QString str; 227 QString str;
228 str = QString("select uid from todolist where ( DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6' ) OR DueDate = '0-0-0' ") 228 str = QString("select uid from todolist where ( DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6' ) OR DueDate = '0-0-0' ")
229 .arg( m_start.year() ).arg( m_start.month() ).arg( m_start.day() ) 229 .arg( m_start.year() ).arg( m_start.month() ).arg( m_start.day() )
230 .arg( m_end .year() ).arg( m_end .month() ).arg( m_end .day() ); 230 .arg( m_end .year() ).arg( m_end .month() ).arg( m_end .day() );
231 return str; 231 return str;
232 } 232 }
233 QString EffQuery::out()const { 233 QString EffQuery::out()const {
234 QString str; 234 QString str;
235 str = QString("select uid from todolist where DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6'") 235 str = QString("select uid from todolist where DueDate >= '%1-%2-%3' AND DueDate <= '%4-%5-%6'")
236 .arg(m_start.year() ).arg(m_start.month() ).arg( m_start.day() ) 236 .arg(m_start.year() ).arg(m_start.month() ).arg( m_start.day() )
237 .arg(m_end. year() ).arg(m_end. month() ).arg(m_end.day() ); 237 .arg(m_end. year() ).arg(m_end. month() ).arg(m_end.day() );
238 238
239 return str; 239 return str;
240 } 240 }
241}; 241};
242 242
243OTodoAccessBackendSQL::OTodoAccessBackendSQL( const QString& file ) 243OTodoAccessBackendSQL::OTodoAccessBackendSQL( const QString& file )
244 : OTodoAccessBackend(), m_dict(15) 244 : OTodoAccessBackend(), m_dict(15), m_dirty(true)
245{ 245{
246 QString fi = file; 246 QString fi = file;
247 if ( fi.isEmpty() ) 247 if ( fi.isEmpty() )
248 fi = Global::applicationFileName( "todolist", "todolist.db" ); 248 fi = Global::applicationFileName( "todolist", "todolist.db" );
249 OSQLManager man; 249 OSQLManager man;
250 m_driver = man.standard(); 250 m_driver = man.standard();
251 m_driver->setUrl(fi); 251 m_driver->setUrl(fi);
252 fillDict(); 252 fillDict();
253} 253}
254 254
255OTodoAccessBackendSQL::~OTodoAccessBackendSQL(){ 255OTodoAccessBackendSQL::~OTodoAccessBackendSQL(){
256} 256}
257bool OTodoAccessBackendSQL::load(){ 257bool OTodoAccessBackendSQL::load(){
258 if (!m_driver->open() ) 258 if (!m_driver->open() )
259 return false; 259 return false;
260 260
261 CreateQuery creat; 261 CreateQuery creat;
262 OSQLResult res = m_driver->query(&creat ); 262 OSQLResult res = m_driver->query(&creat );
263 263
264 update(); 264 m_dirty = true;
265 qWarning("loaded %d", m_uids.count() );
266 return true; 265 return true;
267} 266}
268bool OTodoAccessBackendSQL::reload(){ 267bool OTodoAccessBackendSQL::reload(){
269 return load(); 268 return load();
270} 269}
271 270
272bool OTodoAccessBackendSQL::save(){ 271bool OTodoAccessBackendSQL::save(){
273 return m_driver->close(); 272 return m_driver->close();
274} 273}
275QArray<int> OTodoAccessBackendSQL::allRecords()const { 274QArray<int> OTodoAccessBackendSQL::allRecords()const {
275 if (m_dirty )
276 update();
277
276 return m_uids; 278 return m_uids;
277} 279}
278QArray<int> OTodoAccessBackendSQL::queryByExample( const OTodo& , int ){ 280QArray<int> OTodoAccessBackendSQL::queryByExample( const OTodo& , int ){
279 QArray<int> ints(0); 281 QArray<int> ints(0);
280 return ints; 282 return ints;
281} 283}
282OTodo OTodoAccessBackendSQL::find(int uid ) const{ 284OTodo OTodoAccessBackendSQL::find(int uid ) const{
283 FindQuery query( uid ); 285 FindQuery query( uid );
284 return todo( m_driver->query(&query) ); 286 return todo( m_driver->query(&query) );
285 287
286} 288}
287OTodo OTodoAccessBackendSQL::find( int uid, const QArray<int>& ints, 289OTodo OTodoAccessBackendSQL::find( int uid, const QArray<int>& ints,
288 uint cur, Frontend::CacheDirection dir ) const{ 290 uint cur, Frontend::CacheDirection dir ) const{
289 qWarning("searching for %d", uid ); 291 qWarning("searching for %d", uid );
290 QArray<int> search( 8 ); 292 QArray<int> search( 8 );
291 uint size =0; 293 uint size =0;
292 OTodo to; 294 OTodo to;
293 295
294 // we try to cache 8 items 296 // we try to cache 8 items
295 switch( dir ) { 297 switch( dir ) {
296 /* forward */ 298 /* forward */
297 case 0: 299 case 0:
298 for (uint i = cur; i < ints.count() && size < 8; i++ ) { 300 for (uint i = cur; i < ints.count() && size < 8; i++ ) {
299 qWarning("size %d %d", size, ints[i] ); 301 qWarning("size %d %d", size, ints[i] );
300 search[size] = ints[i]; 302 search[size] = ints[i];
301 size++; 303 size++;
302 } 304 }
303 break; 305 break;
304 /* reverse */ 306 /* reverse */
305 case 1: 307 case 1:
306 for (uint i = cur; i >= 0 && size < 8; i-- ) { 308 for (uint i = cur; i != 0 && size < 8; i-- ) {
307 search[size] = ints[i]; 309 search[size] = ints[i];
308 size++; 310 size++;
309 } 311 }
310 break; 312 break;
311 } 313 }
312 search.resize( size ); 314 search.resize( size );
313 FindQuery query( search ); 315 FindQuery query( search );
314 OSQLResult res = m_driver->query( &query ); 316 OSQLResult res = m_driver->query( &query );
315 if ( res.state() != OSQLResult::Success ) 317 if ( res.state() != OSQLResult::Success )
316 return to; 318 return to;
317 319
318 return todo( res ); 320 return todo( res );
319} 321}
320void OTodoAccessBackendSQL::clear() { 322void OTodoAccessBackendSQL::clear() {
321 ClearQuery cle; 323 ClearQuery cle;
322 OSQLResult res = m_driver->query( &cle ); 324 OSQLResult res = m_driver->query( &cle );
323 CreateQuery qu; 325 CreateQuery qu;
324 res = m_driver->query(&qu); 326 res = m_driver->query(&qu);
325} 327}
326bool OTodoAccessBackendSQL::add( const OTodo& t) { 328bool OTodoAccessBackendSQL::add( const OTodo& t) {
327 InsertQuery ins( t ); 329 InsertQuery ins( t );
328 OSQLResult res = m_driver->query( &ins ); 330 OSQLResult res = m_driver->query( &ins );
329 331
330 if ( res.state() == OSQLResult::Failure ) 332 if ( res.state() == OSQLResult::Failure )
331 return false; 333 return false;
332 int c = m_uids.count(); 334 int c = m_uids.count();
333 m_uids.resize( c+1 ); 335 m_uids.resize( c+1 );
334 m_uids[c] = t.uid(); 336 m_uids[c] = t.uid();
335 337
336 return true; 338 return true;
337} 339}
338bool OTodoAccessBackendSQL::remove( int uid ) { 340bool OTodoAccessBackendSQL::remove( int uid ) {
339 RemoveQuery rem( uid ); 341 RemoveQuery rem( uid );
340 OSQLResult res = m_driver->query(&rem ); 342 OSQLResult res = m_driver->query(&rem );
341 343
342 if ( res.state() == OSQLResult::Failure ) 344 if ( res.state() == OSQLResult::Failure )
343 return false; 345 return false;
344 346
345 update(); 347 m_dirty = true;
346 return true; 348 return true;
347} 349}
348/* 350/*
349 * FIXME better set query 351 * FIXME better set query
350 * but we need the cache for that 352 * but we need the cache for that
351 * now we remove 353 * now we remove
352 */ 354 */
353bool OTodoAccessBackendSQL::replace( const OTodo& t) { 355bool OTodoAccessBackendSQL::replace( const OTodo& t) {
354 remove( t.uid() ); 356 remove( t.uid() );
355 return add(t); 357 bool b= add(t);
358 m_dirty = false; // we changed some stuff but the UID stayed the same
359 return b;
356} 360}
357QArray<int> OTodoAccessBackendSQL::overDue() { 361QArray<int> OTodoAccessBackendSQL::overDue() {
358 OverDueQuery qu; 362 OverDueQuery qu;
359 return uids( m_driver->query(&qu ) ); 363 return uids( m_driver->query(&qu ) );
360} 364}
361QArray<int> OTodoAccessBackendSQL::effectiveToDos( const QDate& s, 365QArray<int> OTodoAccessBackendSQL::effectiveToDos( const QDate& s,
362 const QDate& t, 366 const QDate& t,
363 bool u) { 367 bool u) {
364 EffQuery ef(s, t, u ); 368 EffQuery ef(s, t, u );
365 return uids (m_driver->query(&ef) ); 369 return uids (m_driver->query(&ef) );
366} 370}
367/* 371/*
368 * 372 *
369 */ 373 */
370QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder, 374QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder,
371 int sortFilter, int cat ) { 375 int sortFilter, int cat ) {
376 qWarning("sorted %d, %d", asc, sortOrder );
372 QString query; 377 QString query;
373 query = "select uid from todolist WHERE "; 378 query = "select uid from todolist WHERE ";
374 379
375 /* 380 /*
376 * Sort Filter stuff 381 * Sort Filter stuff
377 * not that straight forward 382 * not that straight forward
378 * 383 *
379 */ 384 */
380 /* Category */ 385 /* Category */
381 if ( sortFilter & 1 ) { 386 if ( sortFilter & 1 ) {
382 QString str; 387 QString str;
383 if (cat != 0 ) str = QString::number( cat ); 388 if (cat != 0 ) str = QString::number( cat );
384 query += " categories like '%" +str+"%' AND"; 389 query += " categories like '%" +str+"%' AND";
385 } 390 }
386 /* Show only overdue */ 391 /* Show only overdue */
387 if ( sortFilter & 2 ) { 392 if ( sortFilter & 2 ) {
388 QDate date = QDate::currentDate(); 393 QDate date = QDate::currentDate();
389 QString due; 394 QString due;
390 QString base; 395 QString base;
391 base = QString("DueDate <= '%1-%2-%3' AND completed = 0").arg( date.year() ).arg( date.month() ).arg( date.day() ); 396 base = QString("DueDate <= '%1-%2-%3' AND completed = 0").arg( date.year() ).arg( date.month() ).arg( date.day() );
392 query += " " + base + " AND"; 397 query += " " + base + " AND";
393 } 398 }
394 /* not show completed */ 399 /* not show completed */
395 if ( sortFilter & 4 ) { 400 if ( sortFilter & 4 ) {
@@ -400,50 +405,53 @@ QArray<int> OTodoAccessBackendSQL::sorted( bool asc, int sortOrder,
400 /* srtip the end */ 405 /* srtip the end */
401 query = query.remove( query.length()-3, 3 ); 406 query = query.remove( query.length()-3, 3 );
402 407
403 408
404 /* 409 /*
405 * sort order stuff 410 * sort order stuff
406 * quite straight forward 411 * quite straight forward
407 */ 412 */
408 query += "ORDER BY "; 413 query += "ORDER BY ";
409 switch( sortOrder ) { 414 switch( sortOrder ) {
410 /* completed */ 415 /* completed */
411 case 0: 416 case 0:
412 query += "completed"; 417 query += "completed";
413 break; 418 break;
414 case 1: 419 case 1:
415 query += "priority"; 420 query += "priority";
416 break; 421 break;
417 case 2: 422 case 2:
418 query += "description"; 423 query += "description";
419 break; 424 break;
420 case 3: 425 case 3:
421 query += "DueDate"; 426 query += "DueDate";
422 break; 427 break;
423 } 428 }
424 if ( !asc ) 429
430 if ( !asc ) {
431 qWarning("not ascending!");
425 query += " DESC"; 432 query += " DESC";
433 }
426 434
427 qWarning( query ); 435 qWarning( query );
428 OSQLRawQuery raw(query ); 436 OSQLRawQuery raw(query );
429 return uids( m_driver->query(&raw) ); 437 return uids( m_driver->query(&raw) );
430} 438}
431bool OTodoAccessBackendSQL::date( QDate& da, const QString& str ) const{ 439bool OTodoAccessBackendSQL::date( QDate& da, const QString& str ) const{
432 if ( str == "0-0-0" ) 440 if ( str == "0-0-0" )
433 return false; 441 return false;
434 else{ 442 else{
435 int day, year, month; 443 int day, year, month;
436 QStringList list = QStringList::split("-", str ); 444 QStringList list = QStringList::split("-", str );
437 year = list[0].toInt(); 445 year = list[0].toInt();
438 month = list[1].toInt(); 446 month = list[1].toInt();
439 day = list[2].toInt(); 447 day = list[2].toInt();
440 da.setYMD( year, month, day ); 448 da.setYMD( year, month, day );
441 return true; 449 return true;
442 } 450 }
443} 451}
444OTodo OTodoAccessBackendSQL::todo( const OSQLResult& res) const{ 452OTodo OTodoAccessBackendSQL::todo( const OSQLResult& res) const{
445 if ( res.state() == OSQLResult::Failure ) { 453 if ( res.state() == OSQLResult::Failure ) {
446 OTodo to; 454 OTodo to;
447 return to; 455 return to;
448 } 456 }
449 457
@@ -480,47 +488,52 @@ OTodo OTodoAccessBackendSQL::todo( int uid )const {
480 * update the dict 488 * update the dict
481 */ 489 */
482void OTodoAccessBackendSQL::fillDict() { 490void OTodoAccessBackendSQL::fillDict() {
483 /* initialize dict */ 491 /* initialize dict */
484 /* 492 /*
485 * UPDATE dict if you change anything!!! 493 * UPDATE dict if you change anything!!!
486 */ 494 */
487 m_dict.setAutoDelete( TRUE ); 495 m_dict.setAutoDelete( TRUE );
488 m_dict.insert("Categories" , new int(OTodo::Category) ); 496 m_dict.insert("Categories" , new int(OTodo::Category) );
489 m_dict.insert("Uid" , new int(OTodo::Uid) ); 497 m_dict.insert("Uid" , new int(OTodo::Uid) );
490 m_dict.insert("HasDate" , new int(OTodo::HasDate) ); 498 m_dict.insert("HasDate" , new int(OTodo::HasDate) );
491 m_dict.insert("Completed" , new int(OTodo::Completed) ); 499 m_dict.insert("Completed" , new int(OTodo::Completed) );
492 m_dict.insert("Description" , new int(OTodo::Description) ); 500 m_dict.insert("Description" , new int(OTodo::Description) );
493 m_dict.insert("Summary" , new int(OTodo::Summary) ); 501 m_dict.insert("Summary" , new int(OTodo::Summary) );
494 m_dict.insert("Priority" , new int(OTodo::Priority) ); 502 m_dict.insert("Priority" , new int(OTodo::Priority) );
495 m_dict.insert("DateDay" , new int(OTodo::DateDay) ); 503 m_dict.insert("DateDay" , new int(OTodo::DateDay) );
496 m_dict.insert("DateMonth" , new int(OTodo::DateMonth) ); 504 m_dict.insert("DateMonth" , new int(OTodo::DateMonth) );
497 m_dict.insert("DateYear" , new int(OTodo::DateYear) ); 505 m_dict.insert("DateYear" , new int(OTodo::DateYear) );
498 m_dict.insert("Progress" , new int(OTodo::Progress) ); 506 m_dict.insert("Progress" , new int(OTodo::Progress) );
499 m_dict.insert("Completed", new int(OTodo::Completed) ); 507 m_dict.insert("Completed", new int(OTodo::Completed) );
500 m_dict.insert("CrossReference", new int(OTodo::CrossReference) ); 508 m_dict.insert("CrossReference", new int(OTodo::CrossReference) );
501 m_dict.insert("HasAlarmDateTime",new int(OTodo::HasAlarmDateTime) ); 509 m_dict.insert("HasAlarmDateTime",new int(OTodo::HasAlarmDateTime) );
502 m_dict.insert("AlarmDateTime", new int(OTodo::AlarmDateTime) ); 510 m_dict.insert("AlarmDateTime", new int(OTodo::AlarmDateTime) );
503} 511}
504void OTodoAccessBackendSQL::update() { 512/*
513 * need to be const so let's fool the
514 * compiler :(
515 */
516void OTodoAccessBackendSQL::update()const {
517 ((OTodoAccessBackendSQL*)this)->m_dirty = false;
505 LoadQuery lo; 518 LoadQuery lo;
506 OSQLResult res = m_driver->query(&lo); 519 OSQLResult res = m_driver->query(&lo);
507 if ( res.state() != OSQLResult::Success ) 520 if ( res.state() != OSQLResult::Success )
508 return; 521 return;
509 522
510 m_uids = uids( res ); 523 ((OTodoAccessBackendSQL*)this)->m_uids = uids( res );
511} 524}
512QArray<int> OTodoAccessBackendSQL::uids( const OSQLResult& res) const{ 525QArray<int> OTodoAccessBackendSQL::uids( const OSQLResult& res) const{
513 526
514 OSQLResultItem::ValueList list = res.results(); 527 OSQLResultItem::ValueList list = res.results();
515 OSQLResultItem::ValueList::Iterator it; 528 OSQLResultItem::ValueList::Iterator it;
516 QArray<int> ints(list.count() ); 529 QArray<int> ints(list.count() );
517 qWarning(" count = %d", list.count() ); 530 qWarning(" count = %d", list.count() );
518 531
519 int i = 0; 532 int i = 0;
520 for (it = list.begin(); it != list.end(); ++it ) { 533 for (it = list.begin(); it != list.end(); ++it ) {
521 ints[i] = (*it).data("uid").toInt(); 534 ints[i] = (*it).data("uid").toInt();
522 i++; 535 i++;
523 } 536 }
524 return ints; 537 return ints;
525} 538}
526 539
diff --git a/libopie2/opiepim/backend/otodoaccesssql.h b/libopie2/opiepim/backend/otodoaccesssql.h
index c1aa2ed..0f6dd2c 100644
--- a/libopie2/opiepim/backend/otodoaccesssql.h
+++ b/libopie2/opiepim/backend/otodoaccesssql.h
@@ -11,39 +11,40 @@ class OSQLResultItem;
11class OTodoAccessBackendSQL : public OTodoAccessBackend { 11class OTodoAccessBackendSQL : public OTodoAccessBackend {
12public: 12public:
13 OTodoAccessBackendSQL( const QString& file ); 13 OTodoAccessBackendSQL( const QString& file );
14 ~OTodoAccessBackendSQL(); 14 ~OTodoAccessBackendSQL();
15 15
16 bool load(); 16 bool load();
17 bool reload(); 17 bool reload();
18 bool save(); 18 bool save();
19 QArray<int> allRecords()const; 19 QArray<int> allRecords()const;
20 20
21 QArray<int> queryByExample( const OTodo& t, int sort ); 21 QArray<int> queryByExample( const OTodo& t, int sort );
22 OTodo find(int uid)const; 22 OTodo find(int uid)const;
23 OTodo find(int uid, const QArray<int>&, uint cur, Frontend::CacheDirection )const; 23 OTodo find(int uid, const QArray<int>&, uint cur, Frontend::CacheDirection )const;
24 void clear(); 24 void clear();
25 bool add( const OTodo& t ); 25 bool add( const OTodo& t );
26 bool remove( int uid ); 26 bool remove( int uid );
27 bool replace( const OTodo& t ); 27 bool replace( const OTodo& t );
28 28
29 QArray<int> overDue(); 29 QArray<int> overDue();
30 QArray<int> effectiveToDos( const QDate& start, 30 QArray<int> effectiveToDos( const QDate& start,
31 const QDate& end, bool includeNoDates ); 31 const QDate& end, bool includeNoDates );
32 QArray<int> sorted(bool asc, int sortOrder, int sortFilter, int cat ); 32 QArray<int> sorted(bool asc, int sortOrder, int sortFilter, int cat );
33 33
34private: 34private:
35 void update(); 35 void update()const;
36 void fillDict(); 36 void fillDict();
37 inline bool date( QDate& date, const QString& )const; 37 inline bool date( QDate& date, const QString& )const;
38 inline OTodo todo( const OSQLResult& )const; 38 inline OTodo todo( const OSQLResult& )const;
39 inline OTodo todo( OSQLResultItem& )const; 39 inline OTodo todo( OSQLResultItem& )const;
40 inline QArray<int> uids( const OSQLResult& )const; 40 inline QArray<int> uids( const OSQLResult& )const;
41 OTodo todo( int uid )const; 41 OTodo todo( int uid )const;
42 42
43 QAsciiDict<int> m_dict; 43 QAsciiDict<int> m_dict;
44 OSQLDriver* m_driver; 44 OSQLDriver* m_driver;
45 QArray<int> m_uids; 45 QArray<int> m_uids;
46 bool m_dirty : 1;
46}; 47};
47 48
48 49
49#endif 50#endif
diff --git a/libopie2/opiepim/core/opimaccesstemplate.h b/libopie2/opiepim/core/opimaccesstemplate.h
index 92d7192..a0d8f63 100644
--- a/libopie2/opiepim/core/opimaccesstemplate.h
+++ b/libopie2/opiepim/core/opimaccesstemplate.h
@@ -163,54 +163,52 @@ OPimAccessTemplate<T>::List OPimAccessTemplate<T>::allRecords()const {
163template <class T> 163template <class T>
164OPimAccessTemplate<T>::List 164OPimAccessTemplate<T>::List
165OPimAccessTemplate<T>::queryByExample( const T& t, int sortOrder ) { 165OPimAccessTemplate<T>::queryByExample( const T& t, int sortOrder ) {
166 QArray<int> ints = m_backEnd->queryByExample( t, sortOrder ); 166 QArray<int> ints = m_backEnd->queryByExample( t, sortOrder );
167 167
168 List lis(ints, this ); 168 List lis(ints, this );
169 return lis; 169 return lis;
170} 170}
171template <class T> 171template <class T>
172T OPimAccessTemplate<T>::find( int uid ) const{ 172T OPimAccessTemplate<T>::find( int uid ) const{
173 T t = m_backEnd->find( uid ); 173 T t = m_backEnd->find( uid );
174 cache( t ); 174 cache( t );
175 return t; 175 return t;
176} 176}
177template <class T> 177template <class T>
178T OPimAccessTemplate<T>::find( int uid, const QArray<int>& ar, 178T OPimAccessTemplate<T>::find( int uid, const QArray<int>& ar,
179 uint current, CacheDirection dir )const { 179 uint current, CacheDirection dir )const {
180 /* 180 /*
181 * better do T.isEmpty() 181 * better do T.isEmpty()
182 * after a find this way we would 182 * after a find this way we would
183 * avoid two finds in QCache... 183 * avoid two finds in QCache...
184 */ 184 */
185 // qWarning("find it now %d", uid ); 185 // qWarning("find it now %d", uid );
186 if (m_cache.contains( uid ) ) { 186 if (m_cache.contains( uid ) ) {
187 qWarning("m cache contains %d", uid);
188 return m_cache.find( uid ); 187 return m_cache.find( uid );
189 } 188 }
190 189
191 T t = m_backEnd->find( uid, ar, current, dir ); 190 T t = m_backEnd->find( uid, ar, current, dir );
192 qWarning("found it and cache it now %d", uid);
193 cache( t ); 191 cache( t );
194 return t; 192 return t;
195} 193}
196template <class T> 194template <class T>
197void OPimAccessTemplate<T>::clear() { 195void OPimAccessTemplate<T>::clear() {
198 invalidateCache(); 196 invalidateCache();
199 m_backEnd->clear(); 197 m_backEnd->clear();
200} 198}
201template <class T> 199template <class T>
202bool OPimAccessTemplate<T>::add( const T& t ) { 200bool OPimAccessTemplate<T>::add( const T& t ) {
203 cache( t ); 201 cache( t );
204 return m_backEnd->add( t ); 202 return m_backEnd->add( t );
205} 203}
206template <class T> 204template <class T>
207bool OPimAccessTemplate<T>::remove( const T& t ) { 205bool OPimAccessTemplate<T>::remove( const T& t ) {
208 return remove( t.uid() ); 206 return remove( t.uid() );
209} 207}
210template <class T> 208template <class T>
211bool OPimAccessTemplate<T>::remove( int uid ) { 209bool OPimAccessTemplate<T>::remove( int uid ) {
212 m_cache.remove( uid ); 210 m_cache.remove( uid );
213 return m_backEnd->remove( uid ); 211 return m_backEnd->remove( uid );
214} 212}
215template <class T> 213template <class T>
216bool OPimAccessTemplate<T>::replace( const T& t ) { 214bool OPimAccessTemplate<T>::replace( const T& t ) {
diff --git a/libopie2/opiepim/orecordlist.h b/libopie2/opiepim/orecordlist.h
index 08f5c85..5404910 100644
--- a/libopie2/opiepim/orecordlist.h
+++ b/libopie2/opiepim/orecordlist.h
@@ -88,48 +88,49 @@ public:
88 * c'tor 88 * c'tor
89 */ 89 */
90 ORecordList () { 90 ORecordList () {
91 } 91 }
92 ORecordList( const QArray<int>& ids, 92 ORecordList( const QArray<int>& ids,
93 const Base* ); 93 const Base* );
94 ~ORecordList(); 94 ~ORecordList();
95 95
96 /** 96 /**
97 * the first iterator 97 * the first iterator
98 */ 98 */
99 Iterator begin(); 99 Iterator begin();
100 100
101 /** 101 /**
102 * the end 102 * the end
103 */ 103 */
104 Iterator end(); 104 Iterator end();
105 105
106 /** 106 /**
107 * the number of items in the list 107 * the number of items in the list
108 */ 108 */
109 uint count()const; 109 uint count()const;
110 110
111 T operator[]( uint i ); 111 T operator[]( uint i );
112 int uidAt(uint i );
112 // FIXME implemenent remove 113 // FIXME implemenent remove
113 /* 114 /*
114 ConstIterator begin()const; 115 ConstIterator begin()const;
115 ConstIterator end()const; 116 ConstIterator end()const;
116 */ 117 */
117private: 118private:
118 QArray<int> m_ids; 119 QArray<int> m_ids;
119 const Base* m_acc; 120 const Base* m_acc;
120}; 121};
121 122
122/* ok now implement it */ 123/* ok now implement it */
123template <class T> 124template <class T>
124ORecordListIterator<T>::ORecordListIterator() { 125ORecordListIterator<T>::ORecordListIterator() {
125 m_current = 0; 126 m_current = 0;
126 m_temp = 0l; 127 m_temp = 0l;
127 m_end = true; 128 m_end = true;
128 m_record = T(); 129 m_record = T();
129 /* forward */ 130 /* forward */
130 m_direction = TRUE; 131 m_direction = TRUE;
131} 132}
132template <class T> 133template <class T>
133ORecordListIterator<T>::~ORecordListIterator() { 134ORecordListIterator<T>::~ORecordListIterator() {
134/* nothing to delete */ 135/* nothing to delete */
135} 136}
@@ -241,25 +242,29 @@ ORecordList<T>::~ORecordList() {
241/* nothing to do here */ 242/* nothing to do here */
242} 243}
243template <class T> 244template <class T>
244ORecordList<T>::Iterator ORecordList<T>::begin() { 245ORecordList<T>::Iterator ORecordList<T>::begin() {
245 Iterator it( m_ids, m_acc ); 246 Iterator it( m_ids, m_acc );
246 return it; 247 return it;
247} 248}
248template <class T> 249template <class T>
249ORecordList<T>::Iterator ORecordList<T>::end() { 250ORecordList<T>::Iterator ORecordList<T>::end() {
250 Iterator it( m_ids, m_acc ); 251 Iterator it( m_ids, m_acc );
251 it.m_end = true; 252 it.m_end = true;
252 it.m_current = m_ids.count(); 253 it.m_current = m_ids.count();
253 254
254 return it; 255 return it;
255} 256}
256template <class T> 257template <class T>
257uint ORecordList<T>::count()const { 258uint ORecordList<T>::count()const {
258return m_ids.count(); 259return m_ids.count();
259} 260}
260template <class T> 261template <class T>
261T ORecordList<T>::operator[]( uint i ) { 262T ORecordList<T>::operator[]( uint i ) {
262 /* forward */ 263 /* forward */
263 return m_acc->find( m_ids[i], m_ids, i ); 264 return m_acc->find( m_ids[i], m_ids, i );
264} 265}
266template <class T>
267int ORecordList<T>::uidAt( uint i ) {
268 return m_ids[i];
269}
265#endif 270#endif