summaryrefslogtreecommitdiff
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--core/pim/addressbook/TODO4
-rw-r--r--core/pim/addressbook/ablabel.cpp34
-rw-r--r--core/pim/addressbook/version.h2
3 files changed, 27 insertions, 13 deletions
diff --git a/core/pim/addressbook/TODO b/core/pim/addressbook/TODO
index 106747e..da9b9c2 100644
--- a/core/pim/addressbook/TODO
+++ b/core/pim/addressbook/TODO
@@ -13,8 +13,6 @@ Feature requests:
13- Beaming of multiple contacts (current list/ by search or by category) 13- Beaming of multiple contacts (current list/ by search or by category)
14- Configure the letter-picker: lastname/fullname search 14- Configure the letter-picker: lastname/fullname search
15- User center of the joypad to switch back from card to listview ! 15- User center of the joypad to switch back from card to listview !
16- Cursor-UP/Down: Should additionally scroll cardview if it is too large
17 (behaviour should be selectable by configuration)
18 16
19Known Bugs: 17Known Bugs:
20----------- 18-----------
@@ -114,3 +112,5 @@ Fixed/Ready:
114 If on second tab: The combo chooser is on the top left of the screen ! :( 112 If on second tab: The combo chooser is on the top left of the screen ! :(
115- Default Email-Button: Sometimes not hiding the textfields completely 113- Default Email-Button: Sometimes not hiding the textfields completely
116- Fix handling of 3 Firstnames 114- Fix handling of 3 Firstnames
115- Cursor-UP/Down: Should additionally scroll cardview if it is too large
116 (behaviour should be selectable by configuration)
diff --git a/core/pim/addressbook/ablabel.cpp b/core/pim/addressbook/ablabel.cpp
index 80b57ae..6d8de91 100644
--- a/core/pim/addressbook/ablabel.cpp
+++ b/core/pim/addressbook/ablabel.cpp
@@ -90,6 +90,7 @@ void AbLabel::sync()
90 90
91void AbLabel::keyPressEvent( QKeyEvent *e ) 91void AbLabel::keyPressEvent( QKeyEvent *e )
92{ 92{
93
93 // Commonly handled keys 94 // Commonly handled keys
94 if ( !m_empty ){ 95 if ( !m_empty ){
95 switch( e->key() ) { 96 switch( e->key() ) {
@@ -103,20 +104,33 @@ void AbLabel::keyPressEvent( QKeyEvent *e )
103 break; 104 break;
104 case Qt::Key_Up: 105 case Qt::Key_Up:
105 qWarning( "UP.."); 106 qWarning( "UP..");
106 --m_itCurContact; 107 if ( ( visibleHeight() < contentsHeight() ) &&
107 if ( *m_itCurContact != OContact() ) 108 ( verticalScrollBar()->value() > verticalScrollBar()->minValue() ) )
108 sync(); 109 scrollBy( 0, -(visibleHeight()-20) );
109 else 110 else {
110 m_itCurContact = m_viewList.end(); 111 --m_itCurContact;
112 if ( *m_itCurContact != OContact() )
113 sync();
114 else
115 m_itCurContact = m_viewList.end();
116 }
111 117
112 break; 118 break;
113 case Qt::Key_Down: 119 case Qt::Key_Down:
114 qWarning( "DOWN.."); 120 qWarning( "DOWN..");
115 ++m_itCurContact; 121 // qWarning( "visible: %d, content: %d",visibleHeight(),contentsHeight());
116 if ( *m_itCurContact != OContact() ) 122 // qWarning( "value: %d; barMaxValue: %d", verticalScrollBar()->value()
117 sync(); 123 // , verticalScrollBar()->maxValue() );
118 else 124 if ( ( visibleHeight() < contentsHeight() ) &&
119 m_itCurContact = m_viewList.begin(); 125 ( verticalScrollBar()->value() < verticalScrollBar()->maxValue() ) )
126 scrollBy( 0, visibleHeight()-20 );
127 else {
128 ++m_itCurContact;
129 if ( *m_itCurContact != OContact() )
130 sync();
131 else
132 m_itCurContact = m_viewList.begin();
133 }
120 break; 134 break;
121 case Qt::Key_Return: // fall through 135 case Qt::Key_Return: // fall through
122 case Qt::Key_Space: // fall through 136 case Qt::Key_Space: // fall through
diff --git a/core/pim/addressbook/version.h b/core/pim/addressbook/version.h
index 0f12bd7..999ce67 100644
--- a/core/pim/addressbook/version.h
+++ b/core/pim/addressbook/version.h
@@ -3,7 +3,7 @@
3 3
4#define MAINVERSION "0" 4#define MAINVERSION "0"
5#define SUBVERSION "9" 5#define SUBVERSION "9"
6#define PATCHVERSION "1" 6#define PATCHVERSION "2"
7 7
8#define APPNAME "OPIE_ADDRESSBOOK" 8#define APPNAME "OPIE_ADDRESSBOOK"
9 9