1 files changed, 51 insertions, 13 deletions

diff --git a/core/multimedia/opieplayer/libmad/layer12.c b/core/multimedia/opieplayer/libmad/layer12.c
index d291174..512b6a5 100644
--- a/core/multimedia/opieplayer/libmad/layer12.c
+++ b/core/multimedia/opieplayer/libmad/layer12.c
@@ -1,15 +1,15 @@
 /*
  * libmad - MPEG audio decoder library
- * Copyright (C) 2000-2001 Robert Leslie
+ * Copyright (C) 2000-2004 Underbit Technologies, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
@@ -33,25 +33,25 @@
 
 # include "fixed.h"
 # include "bit.h"
 # include "stream.h"
 # include "frame.h"
 # include "layer12.h"
 
 /*
  * scalefactor table
  * used in both Layer I and Layer II decoding
  */
 static
-mad_fixed_t const sf_table[63] = {
+mad_fixed_t const sf_table[64] = {
 # include "sf_table.dat"
 };
 
 /* --- Layer I ------------------------------------------------------------- */
 
 /* linear scaling table */
 static
 mad_fixed_t const linear_table[14] = {
   MAD_F(0x15555555),  /* 2^2  / (2^2  - 1) == 1.33333333333333 */
   MAD_F(0x12492492),  /* 2^3  / (2^3  - 1) == 1.14285714285714 */
   MAD_F(0x11111111),  /* 2^4  / (2^4  - 1) == 1.06666666666667 */
   MAD_F(0x10842108),  /* 2^5  / (2^5  - 1) == 1.03225806451613 */
@@ -154,28 +154,35 @@ int mad_layer_I(struct mad_stream *stream, struct mad_frame *frame)
 
     allocation[0][sb] =
     allocation[1][sb] = nb ? nb + 1 : 0;
   }
 
   /* decode scalefactors */
 
   for (sb = 0; sb < 32; ++sb) {
     for (ch = 0; ch < nch; ++ch) {
       if (allocation[ch][sb]) {
         scalefactor[ch][sb] = mad_bit_read(&stream->ptr, 6);
 
+# if defined(OPT_STRICT)
+        /*
+         * Scalefactor index 63 does not appear in Table B.1 of
+         * ISO/IEC 11172-3. Nonetheless, other implementations accept it,
+         * so we only reject it if OPT_STRICT is defined.
+         */
         if (scalefactor[ch][sb] == 63) {
           stream->error = MAD_ERROR_BADSCALEFACTOR;
           return -1;
         }
+# endif
       }
     }
   }
 
   /* decode samples */
 
   for (s = 0; s < 12; ++s) {
     for (sb = 0; sb < bound; ++sb) {
       for (ch = 0; ch < nch; ++ch) {
         nb = allocation[ch][sb];
         frame->sbsample[ch][s][sb] = nb ?
           mad_f_mul(I_sample(&stream->ptr, nb),
@@ -325,38 +332,62 @@ int mad_layer_II(struct mad_stream *stream, struct mad_frame *frame)
 {
   struct mad_header *header = &frame->header;
   struct mad_bitptr start;
   unsigned int index, sblimit, nbal, nch, bound, gr, ch, s, sb;
   unsigned char const *offsets;
   unsigned char allocation[2][32], scfsi[2][32], scalefactor[2][32][3];
   mad_fixed_t samples[3];
 
   nch = MAD_NCHANNELS(header);
 
   if (header->flags & MAD_FLAG_LSF_EXT)
     index = 4;
+  else if (header->flags & MAD_FLAG_FREEFORMAT)
+    goto freeformat;
   else {
-    switch (nch == 2 ? header->bitrate / 2 : header->bitrate) {
-    case 32000:
-    case 48000:
-      index = (header->samplerate == 32000) ? 3 : 2;
-      break;
+    unsigned long bitrate_per_channel;
+
+    bitrate_per_channel = header->bitrate;
+    if (nch == 2) {
+      bitrate_per_channel /= 2;
+
+# if defined(OPT_STRICT)
+      /*
+       * ISO/IEC 11172-3 allows only single channel mode for 32, 48, 56, and
+       * 80 kbps bitrates in Layer II, but some encoders ignore this
+       * restriction. We enforce it if OPT_STRICT is defined.
+       */
+      if (bitrate_per_channel <= 28000 || bitrate_per_channel == 40000) {
+        stream->error = MAD_ERROR_BADMODE;
+        return -1;
+      }
+# endif
+    }
+    else {  /* nch == 1 */
+      if (bitrate_per_channel > 192000) {
+        /*
+         * ISO/IEC 11172-3 does not allow single channel mode for 224, 256,
+         * 320, or 384 kbps bitrates in Layer II.
+         */
+        stream->error = MAD_ERROR_BADMODE;
+        return -1;
+      }
+    }
 
-    case 56000:
-    case 64000:
-    case 80000:
+    if (bitrate_per_channel <= 48000)
+      index = (header->samplerate == 32000) ? 3 : 2;
+    else if (bitrate_per_channel <= 80000)
       index = 0;
-      break;
-
-    default:
+    else {
+    freeformat:
       index = (header->samplerate == 48000) ? 0 : 1;
     }
   }
 
   sblimit = sbquant_table[index].sblimit;
   offsets = sbquant_table[index].offsets;
 
   bound = 32;
   if (header->mode == MAD_MODE_JOINT_STEREO) {
     header->flags |= MAD_FLAG_I_STEREO;
     bound = 4 + header->mode_extension * 4;
   }
@@ -422,30 +453,37 @@ int mad_layer_II(struct mad_stream *stream, struct mad_frame *frame)
         case 0:
           scalefactor[ch][sb][1] = mad_bit_read(&stream->ptr, 6);
           /* fall through */
 
         case 1:
         case 3:
           scalefactor[ch][sb][2] = mad_bit_read(&stream->ptr, 6);
         }
 
         if (scfsi[ch][sb] & 1)
           scalefactor[ch][sb][1] = scalefactor[ch][sb][scfsi[ch][sb] - 1];
 
+# if defined(OPT_STRICT)
+        /*
+         * Scalefactor index 63 does not appear in Table B.1 of
+         * ISO/IEC 11172-3. Nonetheless, other implementations accept it,
+         * so we only reject it if OPT_STRICT is defined.
+         */
         if (scalefactor[ch][sb][0] == 63 ||
             scalefactor[ch][sb][1] == 63 ||
             scalefactor[ch][sb][2] == 63) {
           stream->error = MAD_ERROR_BADSCALEFACTOR;
           return -1;
         }
+# endif
       }
     }
   }
 
   /* decode samples */
 
   for (gr = 0; gr < 12; ++gr) {
     for (sb = 0; sb < bound; ++sb) {
       for (ch = 0; ch < nch; ++ch) {
         if ((index = allocation[ch][sb])) {
           index = offset_table[bitalloc_table[offsets[sb]].offset][index - 1];