| -rw-r--r-- | libopie2/opiecore/oapplication.cpp | 2 | ||||
| -rw-r--r-- | libopie2/opiecore/oapplication.h | 6 | ||||
| -rw-r--r-- | libopie2/opiecore/oglobal.h | 3 | ||||
| -rw-r--r-- | libopie2/opiecore/oglobalsettings.h | 5 |
4 files changed, 13 insertions, 3 deletions
diff --git a/libopie2/opiecore/oapplication.cpp b/libopie2/opiecore/oapplication.cpp index d3e04ba..ce26420 100644 --- a/libopie2/opiecore/oapplication.cpp +++ b/libopie2/opiecore/oapplication.cpp @@ -112,5 +112,5 @@ void OApplication::showMainWidget( QWidget* widget, bool nomax ) -void OApplication::setTitle( QString title ) const +void OApplication::setTitle( const QString& title ) const { if ( mainWidget() ) diff --git a/libopie2/opiecore/oapplication.h b/libopie2/opiecore/oapplication.h index 4d25202..8326847 100644 --- a/libopie2/opiecore/oapplication.h +++ b/libopie2/opiecore/oapplication.h @@ -34,4 +34,7 @@ #define oApp OApplication::oApplication() +// the below stuff will fail with moc because moc does not pre process headers +// This will make usage of signal and slots hard inside QPEApplication -zecke + #ifdef QWS #include <qpe/qpeapplication.h> @@ -47,4 +50,5 @@ class OConfig; class OApplication: public OApplicationBaseClass { +// Q_OBJECT would fail -zecke public: @@ -115,5 +119,5 @@ class OApplication: public OApplicationBaseClass * @param title the title. If not given, resets caption to appname */ - virtual void setTitle( QString title = QString::null ) const; + virtual void setTitle( const QString& title = QString::null ) const; //virtual void setTitle() const; diff --git a/libopie2/opiecore/oglobal.h b/libopie2/opiecore/oglobal.h index 8345c6a..34f211e 100644 --- a/libopie2/opiecore/oglobal.h +++ b/libopie2/opiecore/oglobal.h @@ -38,9 +38,10 @@ static OConfig globalconfig = OConfig( "global" ); //FIXME: Is it wise or even necessary to inherit OGlobal from Global? +// once we totally skip libqpe it should ideally swallow Global -zecke class OGlobal : public Global { public: - + // do we want to put that into OApplication as in KApplication -zecke static OConfig* config(); }; diff --git a/libopie2/opiecore/oglobalsettings.h b/libopie2/opiecore/oglobalsettings.h index 6481251..d3f357e 100644 --- a/libopie2/opiecore/oglobalsettings.h +++ b/libopie2/opiecore/oglobalsettings.h @@ -48,4 +48,5 @@ //FIXME: before public usage... lack of time to do it at once - so it will //FIXME: happen step-by-step. ML. +// we should not habe too much configure options!!!!!! -zecke /** @@ -100,4 +101,5 @@ class OGlobalSettings */ + // we do not support DND at the momemt -zecke static int dndEventDelay(); @@ -115,4 +117,5 @@ class OGlobalSettings * Returns whether tear-off handles are inserted in OPopupMenus. **/ + // would clutter the small screen -zecke static bool insertTearOffHandle(); @@ -252,4 +255,5 @@ class OGlobalSettings * The path to the desktop directory of the current user. */ + // below handled by Global stuff and QPEApplication static QString desktopPath() { initStatic(); return *s_desktopPath; } @@ -262,4 +266,5 @@ class OGlobalSettings * The path to the trash directory of the current user. */ + // we do not have that concept -zecke static QString trashPath() { initStatic(); return *s_trashPath; } |