| -rw-r--r-- | libopie2/opiecore/oapplication.cpp | 2 | ||||
| -rw-r--r-- | libopie2/opiecore/oapplication.h | 6 | ||||
| -rw-r--r-- | libopie2/opiecore/oglobal.h | 3 | ||||
| -rw-r--r-- | libopie2/opiecore/oglobalsettings.h | 5 |
4 files changed, 13 insertions, 3 deletions
diff --git a/libopie2/opiecore/oapplication.cpp b/libopie2/opiecore/oapplication.cpp index d3e04ba..ce26420 100644 --- a/libopie2/opiecore/oapplication.cpp +++ b/libopie2/opiecore/oapplication.cpp @@ -110,9 +110,9 @@ void OApplication::showMainWidget( QWidget* widget, bool nomax ) widget->setCaption( _appname ); } -void OApplication::setTitle( QString title ) const +void OApplication::setTitle( const QString& title ) const { if ( mainWidget() ) { if ( !title.isNull() ) diff --git a/libopie2/opiecore/oapplication.h b/libopie2/opiecore/oapplication.h index 4d25202..8326847 100644 --- a/libopie2/opiecore/oapplication.h +++ b/libopie2/opiecore/oapplication.h @@ -32,8 +32,11 @@ #define OAPPLICATION_H #define oApp OApplication::oApplication() +// the below stuff will fail with moc because moc does not pre process headers +// This will make usage of signal and slots hard inside QPEApplication -zecke + #ifdef QWS #include <qpe/qpeapplication.h> #define OApplicationBaseClass QPEApplication #else @@ -45,8 +48,9 @@ class OApplicationPrivate; class OConfig; class OApplication: public OApplicationBaseClass { +// Q_OBJECT would fail -zecke public: /** * Constructor. Parses command-line arguments and sets the window caption. @@ -113,9 +117,9 @@ class OApplication: public OApplicationBaseClass * to the application name given in the constructor. * * @param title the title. If not given, resets caption to appname */ - virtual void setTitle( QString title = QString::null ) const; + virtual void setTitle( const QString& title = QString::null ) const; //virtual void setTitle() const; protected: void init(); diff --git a/libopie2/opiecore/oglobal.h b/libopie2/opiecore/oglobal.h index 8345c6a..34f211e 100644 --- a/libopie2/opiecore/oglobal.h +++ b/libopie2/opiecore/oglobal.h @@ -36,13 +36,14 @@ static OConfig globalconfig = OConfig( "global" ); //FIXME: Is it wise or even necessary to inherit OGlobal from Global? +// once we totally skip libqpe it should ideally swallow Global -zecke class OGlobal : public Global { public: - + // do we want to put that into OApplication as in KApplication -zecke static OConfig* config(); }; #endif // OGLOBAL_H diff --git a/libopie2/opiecore/oglobalsettings.h b/libopie2/opiecore/oglobalsettings.h index 6481251..d3f357e 100644 --- a/libopie2/opiecore/oglobalsettings.h +++ b/libopie2/opiecore/oglobalsettings.h @@ -46,8 +46,9 @@ //FIXME: There's still a whole lot of stuff in here which has to be revised //FIXME: before public usage... lack of time to do it at once - so it will //FIXME: happen step-by-step. ML. +// we should not habe too much configure options!!!!!! -zecke /** * Access the OPIE global configuration settings. * @@ -98,8 +99,9 @@ class OGlobalSettings * </pre> * */ + // we do not support DND at the momemt -zecke static int dndEventDelay(); /** * Returns whether OPIE runs in single (default) or double click @@ -113,8 +115,9 @@ class OGlobalSettings /** * Returns whether tear-off handles are inserted in OPopupMenus. **/ + // would clutter the small screen -zecke static bool insertTearOffHandle(); /** * @return the OPIE setting for "change cursor over icon" @@ -250,8 +253,9 @@ class OGlobalSettings /** * The path to the desktop directory of the current user. */ + // below handled by Global stuff and QPEApplication static QString desktopPath() { initStatic(); return *s_desktopPath; } /** * The path to the autostart directory of the current user. @@ -260,8 +264,9 @@ class OGlobalSettings /** * The path to the trash directory of the current user. */ + // we do not have that concept -zecke static QString trashPath() { initStatic(); return *s_trashPath; } /** * The path where documents are stored of the current user. |