14 files changed, 51 insertions, 19 deletions

diff --git a/libopie2/opiecore/oapplication.cpp b/libopie2/opiecore/oapplication.cpp
index d3e04ba..ce26420 100644
--- a/libopie2/opiecore/oapplication.cpp
+++ b/libopie2/opiecore/oapplication.cpp
@@ -113,3 +113,3 @@ void OApplication::showMainWidget( QWidget* widget, bool nomax )
 
-void OApplication::setTitle( QString title ) const
+void OApplication::setTitle( const QString& title ) const
 {
diff --git a/libopie2/opiecore/oapplication.h b/libopie2/opiecore/oapplication.h
index 4d25202..8326847 100644
--- a/libopie2/opiecore/oapplication.h
+++ b/libopie2/opiecore/oapplication.h
@@ -35,2 +35,5 @@
 
+// the below stuff will fail with moc because moc does not pre process headers
+// This will make usage of signal and slots hard inside QPEApplication -zecke
+
 #ifdef QWS
@@ -48,2 +51,3 @@ class OApplication: public OApplicationBaseClass
 {
+// Q_OBJECT would fail -zecke 
   public:
@@ -116,3 +120,3 @@ class OApplication: public OApplicationBaseClass
     */
-    virtual void setTitle( QString title = QString::null ) const;
+    virtual void setTitle( const QString& title = QString::null ) const;
     //virtual void setTitle() const;
diff --git a/libopie2/opiecore/oglobal.h b/libopie2/opiecore/oglobal.h
index 8345c6a..34f211e 100644
--- a/libopie2/opiecore/oglobal.h
+++ b/libopie2/opiecore/oglobal.h
@@ -39,2 +39,3 @@ static OConfig globalconfig = OConfig( "global" );
 //FIXME: Is it wise or even necessary to inherit OGlobal from Global?
+// once we totally skip libqpe it should ideally swallow Global -zecke
 
@@ -43,3 +44,3 @@ class OGlobal : public Global
   public:
-  
+    // do we want to put that into OApplication as in KApplication -zecke
     static OConfig* config();
diff --git a/libopie2/opiecore/oglobalsettings.h b/libopie2/opiecore/oglobalsettings.h
index 6481251..d3f357e 100644
--- a/libopie2/opiecore/oglobalsettings.h
+++ b/libopie2/opiecore/oglobalsettings.h
@@ -49,2 +49,3 @@
 //FIXME: happen step-by-step. ML.
+// we should not habe too much configure options!!!!!! -zecke
 
@@ -101,2 +102,3 @@ class OGlobalSettings
 
+    // we do not support DND at the momemt -zecke
     static int dndEventDelay();
@@ -116,2 +118,3 @@ class OGlobalSettings
      **/
+    // would clutter the small screen -zecke
     static bool insertTearOffHandle();
@@ -253,2 +256,3 @@ class OGlobalSettings
      */
+     // below handled by Global stuff and QPEApplication
     static QString desktopPath() { initStatic(); return *s_desktopPath; }
@@ -261,4 +265,5 @@ class OGlobalSettings
     /**
-     * The path to the trash directory of the current user.
+     * The path to the trash directory of the current user.    
      */
+     // we do not have that concept -zecke
     static QString trashPath() { initStatic(); return *s_trashPath; }
diff --git a/libopie2/opienet/omanufacturerdb.h b/libopie2/opienet/omanufacturerdb.h
index 5e66c37..cb0b6c8 100644
--- a/libopie2/opienet/omanufacturerdb.h
+++ b/libopie2/opienet/omanufacturerdb.h
@@ -23,2 +23,3 @@ class OManufacturerDB
   public:
+    //FIXME make us consistent -zecke I use self(), sandman inst() you use instance() so we need to chose one!
     static OManufacturerDB* instance();
diff --git a/libopie2/opienet/onetutils.h b/libopie2/opienet/onetutils.h
index bedea63..9611518 100644
--- a/libopie2/opienet/onetutils.h
+++ b/libopie2/opienet/onetutils.h
@@ -52,2 +52,3 @@ class OMacAddress
   public:
+    // QString c'tor? -zecke
     OMacAddress( unsigned char* );
@@ -61,2 +62,3 @@ class OMacAddress
 
+    // no c'tor but this one why not make it a c'tor. it could also replace the others or is this the problem?
     static OMacAddress fromString( const QString& );
@@ -104,2 +106,3 @@ class OPrivateIOCTL : public QObject
 
+    // FIXME return int? as ::ioctl does? -zecke
     void invoke() const;
diff --git a/libopie2/opienet/onetwork.cpp b/libopie2/opienet/onetwork.cpp
index 73b543b..f0094c7 100644
--- a/libopie2/opienet/onetwork.cpp
+++ b/libopie2/opienet/onetwork.cpp
@@ -110,3 +110,3 @@ void ONetwork::synchronize()
 
-ONetworkInterface* ONetwork::interface( QString iface ) const
+ONetworkInterface* ONetwork::interface( const QString& iface ) const
 {
diff --git a/libopie2/opienet/onetwork.h b/libopie2/opienet/onetwork.h
index d2cc25d..db8e702 100644
--- a/libopie2/opienet/onetwork.h
+++ b/libopie2/opienet/onetwork.h
@@ -100,2 +100,3 @@ class ONetwork : public QObject
      */
+     // FIXME QString? -zecke
     bool isWirelessInterface( const char* interface ) const;
@@ -105,3 +106,4 @@ class ONetwork : public QObject
      */
-    ONetworkInterface* interface( QString interface ) const;
+     // FIXME: const QString& is prefered over QString!!! -zecke
+    ONetworkInterface* interface( const QString& interface ) const;
 
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h
index 99631ba..6bf7416 100644
--- a/libopie2/opienet/opcap.h
+++ b/libopie2/opienet/opcap.h
@@ -70,3 +70,3 @@ class QSocketNotifier;
  *======================================================================================*/
-
+// FIXME how many OPackets do we've at a time? QObject seams to be a big for that usage
 class OPacket : public QObject
@@ -97,2 +97,3 @@ class OPacket : public QObject
 
+//FIXME same critic as above -zecke
 class OEthernetPacket : public QObject
@@ -117,3 +118,3 @@ class OEthernetPacket : public QObject
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanPacket : public QObject
@@ -147,3 +148,3 @@ class OWaveLanPacket : public QObject
  *======================================================================================*/
-
+//FIXME same as above -zecke
 class OWaveLanManagementPacket : public QObject
@@ -176,3 +177,3 @@ class OWaveLanManagementPacket : public QObject
  *======================================================================================*/
-
+//FIXME is QObject necessary? -zecke
 class OWaveLanManagementSSID : public QObject
@@ -194,3 +195,3 @@ class OWaveLanManagementSSID : public QObject
  *======================================================================================*/
-
+// FIXME same as above -zecke
 class OWaveLanManagementRates : public QObject
@@ -211,2 +212,3 @@ class OWaveLanManagementRates : public QObject
 
+//FIXME same....
 class OWaveLanManagementCF : public QObject
@@ -227,2 +229,3 @@ class OWaveLanManagementCF : public QObject
 
+//FIXME same
 class OWaveLanManagementFH : public QObject
@@ -242,3 +245,3 @@ class OWaveLanManagementFH : public QObject
  *======================================================================================*/
-
+//FIXME same
 class OWaveLanManagementDS : public QObject
@@ -261,2 +264,3 @@ class OWaveLanManagementDS : public QObject
 
+//FIXME guess what?
 class OWaveLanManagementTim : public QObject
@@ -277,2 +281,3 @@ class OWaveLanManagementTim : public QObject
 
+//FIXME same as above ( Qobject )
 class OWaveLanManagementIBSS : public QObject
@@ -293,2 +298,3 @@ class OWaveLanManagementIBSS : public QObject
 
+// Qobject do we need that??
 class OWaveLanManagementChallenge : public QObject
@@ -308,3 +314,3 @@ class OWaveLanManagementChallenge : public QObject
  *======================================================================================*/
-
+// Qobject?
 class OWaveLanDataPacket : public QObject
@@ -324,3 +330,3 @@ class OWaveLanDataPacket : public QObject
  *======================================================================================*/
-
+// Qobject needed?
 class OWaveLanControlPacket : public QObject
@@ -341,2 +347,3 @@ class OWaveLanControlPacket : public QObject
 
+// QObject needed?
 class OLLCPacket : public QObject
@@ -350,2 +357,3 @@ class OLLCPacket : public QObject
   private:
+  //FIXME how to get that header?
     const struct ieee_802_11_802_2_header* _header;
@@ -357,2 +365,3 @@ class OLLCPacket : public QObject
 
+// Qobject as baseclass?
 class OIPPacket : public QObject
@@ -383,3 +392,3 @@ class OIPPacket : public QObject
  *======================================================================================*/
-
+// QObject?
 class OUDPPacket : public QObject
@@ -403,2 +412,3 @@ class OUDPPacket : public QObject
 
+// Qobect needed?
 class OTCPPacket : public QObject
diff --git a/libopie2/opieui/odialog.h b/libopie2/opieui/odialog.h
index 7947dfb..4116ed7 100644
--- a/libopie2/opieui/odialog.h
+++ b/libopie2/opieui/odialog.h
@@ -53,2 +53,3 @@ class QLayoutItem;
  */
+ // lets fix up Qt instead! Size does matter. -zecke
 
@@ -83,4 +84,4 @@ class ODialog : public QDialog
 
-    //class ODialogPrivate;
-    //ODialogPrivate *d;
+    class ODialogPrivate;
+    ODialogPrivate *d; // d pointer always needed! -zecke
 
diff --git a/libopie2/opieui/oimageeffect.h b/libopie2/opieui/oimageeffect.h
index 313ea50..fb4d22d 100644
--- a/libopie2/opieui/oimageeffect.h
+++ b/libopie2/opieui/oimageeffect.h
@@ -2,2 +2,3 @@
 //FIXME: Maybe not on SL5xxx, but surely on C700 :))
+//FIXME: I think we don#t need that -zecke
 
diff --git a/libopie2/opieui/olistview.h b/libopie2/opieui/olistview.h
index bafc67c..b62e278 100644
--- a/libopie2/opieui/olistview.h
+++ b/libopie2/opieui/olistview.h
@@ -121,3 +121,3 @@ class OListViewItem;
 
-    #ifndef QT_NO_DATASTREAM
+#ifndef QT_NO_DATASTREAM
    /**
@@ -133,3 +133,3 @@ class OListViewItem;
     virtual void serializeFrom( QDataStream& s );
-    #endif
+#endif
 
diff --git a/libopie2/opieui/opopupmenu.h b/libopie2/opieui/opopupmenu.h
index 94f05f4..54e4301 100644
--- a/libopie2/opieui/opopupmenu.h
+++ b/libopie2/opieui/opopupmenu.h
@@ -1 +1,4 @@
+//FIXME what is ODE? ODE Desktop Environemt? -zecke
+//FIXME do we need titles? space is limited that is only eyecandy? -zecke
+//FIXME keyboard navigation is also not that popular on a PDA might be with a keyboard (tuxphone) -zecke
 /* This file is part of the ODE libraries
diff --git a/libopie2/qt3/opiecore/opair.h b/libopie2/qt3/opiecore/opair.h
index 26f617d..a151127 100644
--- a/libopie2/qt3/opiecore/opair.h
+++ b/libopie2/qt3/opiecore/opair.h
@@ -2,2 +2,3 @@
 //FIXME: remove and use qpair.h as soon as we're on Qt3
+// name file qpair -zecke