2 files changed, 109 insertions, 164 deletions

diff --git a/libopie2/opiecore/oprocess.cpp b/libopie2/opiecore/oprocess.cpp
index fb51bf9..f1a5f3b 100644
--- a/libopie2/opiecore/oprocess.cpp
+++ b/libopie2/opiecore/oprocess.cpp
@@ -1,101 +1,80 @@
 /*
- 
-   $Id$
- 
-   This file is part of the KDE libraries
-   Copyright (C) 1997 Christian Czezatke (e9025461@student.tuwien.ac.at)
- 
-   This library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Library General Public
-   License as published by the Free Software Foundation; either
-   version 2 of the License, or (at your option) any later version.
- 
-   This library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Library General Public License for more details.
- 
-   You should have received a copy of the GNU Library General Public License
-   along with this library; see the file COPYING.LIB.  If not, write to
-   the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+                            This file is part of the Opie Project
+                            Copyright (C) 2002-2004 Holger Freyther <zecke@handhelds.org>
+                            and The Opie Team <opie-devel@handhelds.org>
+             =.             Based on KProcess (C) 1997 Christian Czezatke (e9025461@student.tuwien.ac.at)
+           .=l.
+          .>+-=
+_;:,     .>    :=|.         This program is free software; you can
+.> <`_,   >  .   <=          redistribute it and/or  modify it under
+:`=1 )Y*s>-.--   :           the terms of the GNU Library General Public
+.="- .-=="i,     .._         License as published by the Free Software
+- .   .-<_>     .<>         Foundation; either version 2 of the License,
+    ._= =}       :          or (at your option) any later version.
+   .%`+i>       _;_.
+   .i_,=:_.      -<s.       This program is distributed in the hope that
+    +  .  -:.       =       it will be useful,  but WITHOUT ANY WARRANTY;
+   : ..    .:,     . . .    without even the implied warranty of
+   =_        +     =;=|`    MERCHANTABILITY or FITNESS FOR A
+ _.=:.       :    :=>`:     PARTICULAR PURPOSE. See the GNU
+..}^=.=       =       ;      Library General Public License for more
+++=   -.     .`     .:       details.
+:     =  ...= . :.=-
+-.   .:....=;==+<;          You should have received a copy of the GNU
+ -_. . .   )=.  =           Library General Public License along with
+   --        :-=`           this library; see the file COPYING.LIB.
+                            If not, write to the Free Software Foundation,
+                            Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.
- 
 */
 
-
-//
-//  KPROCESS -- A class for handling child processes in KDE without
-//  having to take care of Un*x specific implementation details
-//
-//  version 0.3.1, Jan 8th 1998
-//
-//  (C) Christian Czezatke
-//  e9025461@student.tuwien.ac.at
-//
-// Changes:
-//
-// March 2nd, 1998: Changed parameter list for KShellProcess:
-//   Arguments are now placed in a single string so that
-//   <shell> -c <commandstring> is passed to the shell
-//   to make the use of "operator<<" consistent with KProcess
-//
-//
-//  Ported by Holger Freyther
-//   <zekce> Harlekin: oprocess and say it was ported to Qt by the Opie developers an Qt 2
-
-
-
-#include "oprocess.h"
-#define _MAY_INCLUDE_KPROCESSCONTROLLER_
 #include "oprocctrl.h"
 
-//#include <config.h>
+/* OPIE */
+#include <opie2/oprocess.h>
+
+/* QT */
 
+#include <qapplication.h>
 #include <qfile.h>
-#include <qsocketnotifier.h>
+#include <qmap.h>
 #include <qregexp.h>
+#include <qsocketnotifier.h>
 
-#include <sys/time.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <sys/socket.h>
-
+/* STD */
 #include <errno.h>
 #include <fcntl.h>
+#include <pwd.h>
 #include <stdlib.h>
 #include <signal.h>
 #include <stdio.h>
 #include <string.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/socket.h>
 #include <unistd.h>
 #ifdef HAVE_SYS_SELECT_H
 #include <sys/select.h>
 #endif
 #ifdef HAVE_INITGROUPS
 #include <grp.h>
 #endif
-#include <pwd.h>
-
-#include <qapplication.h>
-#include <qmap.h>
-//#include <kdebug.h>
-
-/////////////////////////////
-// public member functions //
-/////////////////////////////
 
 class OProcessPrivate
 {
 public:
-    OProcessPrivate() : useShell(false) { }
+    OProcessPrivate() : useShell( false )
+    { }
 
     bool useShell;
     QMap<QString,QString> env;
     QString wd;
     QCString shell;
 };
 
 
 OProcess::OProcess(QObject *parent, const char *name)
         : QObject(parent, name)
 {
     init ( );
@@ -134,67 +113,61 @@ void OProcess::init ( )
     if (0 == OProcessController::theOProcessController)
     {
         (void) new OProcessController();
         CHECK_PTR(OProcessController::theOProcessController);
     }
 
     OProcessController::theOProcessController->addOProcess(this);
     out[0] = out[1] = -1;
     in[0] = in[1] = -1;
     err[0] = err[1] = -1;
 }
 
-void
-OProcess::setEnvironment(const QString &name, const QString &value)
+void OProcess::setEnvironment( const QString &name, const QString &value )
 {
     if (!d)
         d = new OProcessPrivate;
     d->env.insert(name, value);
 }
 
-void
-OProcess::setWorkingDirectory(const QString &dir)
+void OProcess::setWorkingDirectory( const QString &dir )
 {
     if (!d)
         d = new OProcessPrivate;
     d->wd = dir;
 }
 
-void
-OProcess::setupEnvironment()
+void OProcess::setupEnvironment()
 {
     if (d)
     {
         QMap<QString,QString>::Iterator it;
         for(it = d->env.begin(); it != d->env.end(); ++it)
             setenv(QFile::encodeName(it.key()).data(),
                    QFile::encodeName(it.data()).data(), 1);
         if (!d->wd.isEmpty())
             chdir(QFile::encodeName(d->wd).data());
     }
 }
 
-void
-OProcess::setRunPrivileged(bool keepPrivileges)
+void OProcess::setRunPrivileged( bool keepPrivileges )
 {
     keepPrivs = keepPrivileges;
 }
 
-bool
-OProcess::runPrivileged() const
+bool OProcess::runPrivileged() const
 {
     return keepPrivs;
 }
 
-
 OProcess::~OProcess()
 {
     // destroying the OProcess instance sends a SIGKILL to the
     // child process (if it is running) after removing it from the
     // list of valid processes (if the process is not started as
     // "DontCare")
 
     OProcessController::theOProcessController->removeOProcess(this);
     // this must happen before we kill the child
     // TODO: block the signal while removing the current process from the process list
 
     if (runs && (run_mode != DontCare))
@@ -215,27 +188,29 @@ void OProcess::detach()
 
     runs = false;
     pid_ = 0;
 
     // Clean up open fd's and socket notifiers.
     closeStdin();
     closeStdout();
     closeStderr();
 }
 
 bool OProcess::setExecutable(const QString& proc)
 {
-    if (runs) return false;
+    if ( runs )
+        return false;
 
-    if (proc.isEmpty())  return false;
+    if ( proc.isEmpty() )
+        return false;
 
     if (!arguments.isEmpty())
         arguments.remove(arguments.begin());
     arguments.prepend(QFile::encodeName(proc));
 
     return true;
 }
 
 OProcess &OProcess::operator<<(const QStringList& args)
 {
     QStringList::ConstIterator it = args.begin();
     for ( ; it != args.end() ; ++it )
@@ -307,24 +282,25 @@ bool OProcess::start(RunMode runmode, Communication comm)
             arglist[i] = arguments[i].data();
         arglist[n]= 0;
     }
 
     if (!setupCommunication(comm))
         qWarning( "Could not setup Communication!");
 
     // We do this in the parent because if we do it in the child process
     // gdb gets confused when the application runs from gdb.
     uid_t uid = getuid();
     gid_t gid = getgid();
 #ifdef HAVE_INITGROUPS
+
     struct passwd *pw = getpwuid(uid);
 #endif
 
     int fd[2];
     if (0 > pipe(fd))
     {
         fd[0] = fd[1] = 0; // Pipe failed.. continue
     }
 
     runs = true;
 
     QApplication::flushX();
@@ -332,27 +308,29 @@ bool OProcess::start(RunMode runmode, Communication comm)
     // WABA: Note that we use fork() and not vfork() because
     // vfork() has unclear semantics and is not standardized.
     pid_ = fork();
 
     if (0 == pid_)
     {
         if (fd[0])
             close(fd[0]);
         if (!runPrivileged())
         {
             setgid(gid);
 #if defined( HAVE_INITGROUPS)
+
             if(pw)
                 initgroups(pw->pw_name, pw->pw_gid);
 #endif
+
             setuid(uid);
         }
         // The child process
         if(!commSetupDoneC())
             qWarning( "Could not finish comm setup in child!" );
 
         setupEnvironment();
 
         // Matthias
         if (run_mode == DontCare)
             setpgid(0,0);
         // restore default SIGPIPE handler (Harri)
@@ -382,25 +360,26 @@ bool OProcess::start(RunMode runmode, Communication comm)
         return false;
     }
     else
     {
         if (fd[1])
             close(fd[1]);
         // the parent continues here
 
         // Discard any data for stdin that might still be there
         input_data = 0;
 
         // Check whether client could be started.
-        if (fd[0]) for(;;)
+        if ( fd[ 0 ] )
+            for ( ;; )
             {
                 char resultByte;
                 int n = ::read(fd[0], &resultByte, 1);
                 if (n == 1)
                 {
                     // Error
                     runs = false;
                     close(fd[0]);
                     free(arglist);
                     pid_ = 0;
                     return false;
                 }
@@ -439,56 +418,46 @@ bool OProcess::start(RunMode runmode, Communication comm)
 
 
 bool OProcess::kill(int signo)
 {
     bool rv=false;
 
     if (0 != pid_)
         rv= (-1 != ::kill(pid_, signo));
     // probably store errno somewhere...
     return rv;
 }
 
-
-
 bool OProcess::isRunning() const
 {
     return runs;
 }
 
-
-
 pid_t OProcess::pid() const
 {
     return pid_;
 }
 
-
-
 bool OProcess::normalExit() const
 {
     int _status = status;
     return (pid_ != 0) && (!runs) && (WIFEXITED((_status)));
 }
 
-
-
 int OProcess::exitStatus() const
 {
     int _status = status;
     return WEXITSTATUS((_status));
 }
 
-
-
 bool OProcess::writeStdin(const char *buffer, int buflen)
 {
     bool rv;
 
     // if there is still data pending, writing new data
     // to stdout is not allowed (since it could also confuse
     // kprocess...
     if (0 != input_data)
         return false;
 
     if (runs && (communication & Stdin))
     {
@@ -574,161 +543,137 @@ bool OProcess::closeStderr()
     {
         communication = static_cast<Communication>(communication & ~Stderr);
         delete errnot;
         errnot = 0;
         close(err[0]);
         rv = true;
     }
     else
         rv = false;
     return rv;
 }
 
-
-/////////////////////////////
-// protected slots         //
-/////////////////////////////
-
-
-
 void OProcess::slotChildOutput(int fdno)
 {
     if (!childOutput(fdno))
         closeStdout();
 }
 
-
 void OProcess::slotChildError(int fdno)
 {
     if (!childError(fdno))
         closeStderr();
 }
 
-
 void OProcess::slotSendData(int)
 {
     if (input_sent == input_total)
     {
         innot->setEnabled(false);
         input_data = 0;
         emit wroteStdin(this);
     }
     else
         input_sent += ::write(in[1], input_data+input_sent, input_total-input_sent);
 }
 
-
-
-//////////////////////////////
-// private member functions //
-//////////////////////////////
-
-
-
 void OProcess::processHasExited(int state)
 {
     if (runs)
     {
         runs = false;
         status = state;
 
         commClose(); // cleanup communication sockets
 
         // also emit a signal if the process was run Blocking
         if (DontCare != run_mode)
         {
             emit processExited(this);
         }
     }
 }
 
-
-
 int OProcess::childOutput(int fdno)
 {
     if (communication & NoRead)
     {
         int len = -1;
         emit receivedStdout(fdno, len);
         errno = 0; // Make sure errno doesn't read "EAGAIN"
         return len;
     }
     else
     {
         char buffer[1024];
         int len;
 
         len = ::read(fdno, buffer, 1024);
 
         if ( 0 < len)
         {
             emit receivedStdout(this, buffer, len);
         }
         return len;
     }
 }
 
-
-
 int OProcess::childError(int fdno)
 {
     char buffer[1024];
     int len;
 
     len = ::read(fdno, buffer, 1024);
 
     if ( 0 < len)
         emit receivedStderr(this, buffer, len);
     return len;
 }
 
-
-
 int OProcess::setupCommunication(Communication comm)
 {
     int ok;
 
     communication = comm;
 
     ok = 1;
     if (comm & Stdin)
         ok &= socketpair(AF_UNIX, SOCK_STREAM, 0, in) >= 0;
 
     if (comm & Stdout)
         ok &= socketpair(AF_UNIX, SOCK_STREAM, 0, out) >= 0;
 
     if (comm & Stderr)
         ok &= socketpair(AF_UNIX, SOCK_STREAM, 0, err) >= 0;
 
     return ok;
 }
 
-
-
 int OProcess::commSetupDoneP()
 {
     int ok = 1;
 
     if (communication != NoCommunication)
     {
         if (communication & Stdin)
             close(in[0]);
         if (communication & Stdout)
             close(out[1]);
         if (communication & Stderr)
             close(err[1]);
 
         // Don't create socket notifiers and set the sockets non-blocking if
         // blocking is requested.
-        if (run_mode == Block) return ok;
+        if ( run_mode == Block )
+            return ok;
 
         if (communication & Stdin)
         {
             //        ok &= (-1 != fcntl(in[1], F_SETFL, O_NONBLOCK));
             innot =  new QSocketNotifier(in[1], QSocketNotifier::Write, this);
             CHECK_PTR(innot);
             innot->setEnabled(false); // will be enabled when data has to be sent
             QObject::connect(innot, SIGNAL(activated(int)),
                              this, SLOT(slotSendData(int)));
         }
 
         if (communication & Stdout)
@@ -745,26 +690,24 @@ int OProcess::commSetupDoneP()
         if (communication & Stderr)
         {
             //        ok &= (-1 != fcntl(err[0], F_SETFL, O_NONBLOCK));
             errnot = new QSocketNotifier(err[0], QSocketNotifier::Read, this );
             CHECK_PTR(errnot);
             QObject::connect(errnot, SIGNAL(activated(int)),
                              this, SLOT(slotChildError(int)));
         }
     }
     return ok;
 }
 
-
-
 int OProcess::commSetupDoneC()
 {
     int ok = 1;
     struct linger so;
     memset(&so, 0, sizeof(so));
 
     if (communication & Stdin)
         close(in[1]);
     if (communication & Stdout)
         close(out[0]);
     if (communication & Stderr)
         close(err[0]);
@@ -793,26 +736,24 @@ int OProcess::commSetupDoneC()
         ok &= dup2(err[1], STDERR_FILENO) != -1;
         ok &= !setsockopt(err[1], SOL_SOCKET, SO_LINGER, reinterpret_cast<char *>(&so), sizeof(so));
     }
     else
     {
         int null_fd = open( "/dev/null", O_WRONLY );
         ok &= dup2( null_fd, STDERR_FILENO ) != -1;
         close( null_fd );
     }
     return ok;
 }
 
-
-
 void OProcess::commClose()
 {
     if (NoCommunication != communication)
     {
         bool b_in = (communication & Stdin);
         bool b_out = (communication & Stdout);
         bool b_err = (communication & Stderr);
         if (b_in)
             delete innot;
 
         if (b_out || b_err)
         {
@@ -856,38 +797,41 @@ void OProcess::commClose()
                 timeout.tv_sec = 0;
                 timeout.tv_usec = 0;
                 struct timeval *p_timeout = runs ? 0 : &timeout;
 
                 FD_ZERO(&rfds);
                 if (b_out)
                     FD_SET(out[0], &rfds);
 
                 if (b_err)
                     FD_SET(err[0], &rfds);
 
                 fds_ready = select(max_fd+1, &rfds, 0, 0, p_timeout);
-                if (fds_ready <= 0) break;
+                if ( fds_ready <= 0 )
+                    break;
 
                 if (b_out && FD_ISSET(out[0], &rfds))
                 {
                     int ret = 1;
-                    while (ret > 0) ret = childOutput(out[0]);
+                    while ( ret > 0 )
+                        ret = childOutput( out[ 0 ] );
                     if ((ret == -1 && errno != EAGAIN) || ret == 0)
                         b_out = false;
                 }
 
                 if (b_err && FD_ISSET(err[0], &rfds))
                 {
                     int ret = 1;
-                    while (ret > 0) ret = childError(err[0]);
+                    while ( ret > 0 )
+                        ret = childError( err[ 0 ] );
                     if ((ret == -1 && errno != EAGAIN) || ret == 0)
                         b_err = false;
                 }
             }
         }
 
         if (b_in)
         {
             communication = (Communication) (communication & ~Stdin);
             close(in[1]);
         }
         if (b_out)
@@ -929,42 +873,43 @@ QCString OProcess::searchShell()
     if (!isExecutable(tmpShell))
     {
         tmpShell = "/bin/sh";
     }
 
     return tmpShell;
 }
 
 bool OProcess::isExecutable(const QCString &filename)
 {
     struct stat fileinfo;
 
-    if (filename.isEmpty()) return false;
+    if ( filename.isEmpty() )
+        return false;
 
     // CC: we've got a valid filename, now let's see whether we can execute that file
 
-    if (-1 == stat(filename.data(), &fileinfo)) return false;
+    if ( -1 == stat( filename.data(), &fileinfo ) )
+        return false;
     // CC: return false if the file does not exist
 
     // CC: anyway, we cannot execute directories, block/character devices, fifos or sockets
     if ( (S_ISDIR(fileinfo.st_mode))  ||
             (S_ISCHR(fileinfo.st_mode))  ||
             (S_ISBLK(fileinfo.st_mode))  ||
 #ifdef S_ISSOCK
             // CC: SYSVR4 systems don't have that macro
             (S_ISSOCK(fileinfo.st_mode)) ||
 #endif
             (S_ISFIFO(fileinfo.st_mode)) ||
             (S_ISDIR(fileinfo.st_mode)) )
     {
         return false;
     }
 
     // CC: now check for permission to execute the file
-    if (access(filename.data(), X_OK) != 0) return false;
+    if ( access( filename.data(), X_OK ) != 0 )
+        return false;
 
     // CC: we've passed all the tests...
     return true;
 }
 
-
-
diff --git a/libopie2/opiecore/oprocess.h b/libopie2/opiecore/oprocess.h
index 8dd19b5..352485b 100644
--- a/libopie2/opiecore/oprocess.h
+++ b/libopie2/opiecore/oprocess.h
@@ -1,51 +1,55 @@
-/* This file is part of the KDE libraries
-    Copyright (C) 1997 Christian Czezakte (e9025461@student.tuwien.ac.at)
- 
-    This library is free software; you can redistribute it and/or
-    modify it under the terms of the GNU Library General Public
-    License as published by the Free Software Foundation; either
-    version 2 of the License, or (at your option) any later version.
- 
-    This library is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-    Library General Public License for more details.
- 
-    You should have received a copy of the GNU Library General Public License
-    along with this library; see the file COPYING.LIB.  If not, write to
-    the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+/*
+                            This file is part of the Opie Project
+                            Copyright (C) 2003-2004 Holger Freyther <zecke@handhelds.org>
+                            Copyright (C) The Opie Team <opie-devel@handhelds.org>
+             =.             Based on KProcess (C) 1997 Christian Czezatke (e9025461@student.tuwien.ac.at)
+           .=l.
+          .>+-=
+_;:,     .>    :=|.         This program is free software; you can
+.> <`_,   >  .   <=         redistribute it and/or  modify it under
+:`=1 )Y*s>-.--   :          the terms of the GNU Library General Public
+.="- .-=="i,     .._        License as published by the Free Software
+- .   .-<_>     .<>         Foundation; either version 2 of the License,
+    ._= =}       :          or (at your option) any later version.
+   .%`+i>       _;_.
+   .i_,=:_.      -<s.       This program is distributed in the hope that
+    +  .  -:.       =       it will be useful,  but WITHOUT ANY WARRANTY;
+   : ..    .:,     . . .    without even the implied warranty of
+   =_        +     =;=|`    MERCHANTABILITY or FITNESS FOR A
+ _.=:.       :    :=>`:     PARTICULAR PURPOSE. See the GNU
+..}^=.=       =       ;     Library General Public License for more
+++=   -.     .`     .:      details.
+:     =  ...= . :.=-
+-.   .:....=;==+<;          You should have received a copy of the GNU
+ -_. . .   )=.  =           Library General Public License along with
+   --        :-=`           this library; see the file COPYING.LIB.
+                            If not, write to the Free Software Foundation,
+                            Inc., 59 Temple Place - Suite 330,
     Boston, MA 02111-1307, USA.
 */
-//
-//  KPROCESS -- A class for handling child processes in KDE without
-//  having to take care of Un*x specific implementation details
-//
-//  version 0.3.1, Jan 8th 1998
-//
-//  (C) Christian Czezatke
-//  e9025461@student.tuwien.ac.at
-//  Ported by Holger Freyther to the Open Palmtop Integrated Environment
-//
 
-#ifndef __kprocess_h__
-#define __kprocess_h__
+#ifndef OPROCESS_H
+#define OPROCESS_H
+
+/* QT */
+#include <qcstring.h>
+#include <qobject.h>
+#include <qvaluelist.h>
 
+/* STD */
 #include <sys/types.h> // for pid_t
 #include <sys/wait.h>
 #include <signal.h>
 #include <unistd.h>
-#include <qvaluelist.h>
-#include <qcstring.h>
-#include <qobject.h>
 
 class QSocketNotifier;
 class OProcessPrivate;
 
 /**
  * Child process invocation, monitoring and control.
  *
  * @sect General usage and features
  *
  *This class allows a KDE and OPIE application to start child processes without having
  *to worry about UN*X signal handling issues and zombie process reaping.
  *
@@ -132,25 +136,25 @@ class OProcessPrivate;
  *
  *@li void @ref receivedStdout(OProcess  *proc, char  *buffer, int  buflen);
  *@li  void @ref receivedStderr(OProcess  *proc, char  *buffer, int  buflen);
  *@li  -- Indicates that new data has arrived from either the
  *child process's stdout or stderr.
  *
  *@li  void @ref wroteStdin(OProcess  *proc);
  *@li  -- Indicates that all data that has been sent to the child process
  *by a prior call to @ref writeStdin() has actually been transmitted to the
  *client .
  *
  *@author Christian Czezakte e9025461@student.tuwien.ac.at
- *
+ *@author Holger Freyther (Opie Port)
  *
  **/
 class OProcess : public QObject
 {
     Q_OBJECT
 
 public:
 
     /**
      * Modes in which the communication channel can be opened.
      *
      * If communication for more than one channel is required,
@@ -386,25 +390,28 @@ public:
      * This causes the stderr file descriptor of the child process to be
      * closed.
      *
      * @return @p false if no communication to the process's stderr
      *  had been specified in the call to @ref start().
     */
     bool closeStderr();
 
     /**
      * Lets you see what your arguments are for debugging.
      */
 
-    const QValueList<QCString> &args() { return arguments; }
+    const QValueList<QCString> &args()
+    {
+        return arguments;
+    }
 
     /**
      * Controls whether the started process should drop any
      * setuid/segid privileges or whether it should keep them
      *
      * The default is @p false : drop privileges
      */
     void setRunPrivileged(bool keepPrivileges);
 
     /**
      * Returns whether the started process will drop any
      * setuid/segid privileges or whether it will keep them
@@ -445,26 +452,24 @@ public:
      */
     static QString quote(const QString &arg);
 
     /**
      * Detaches OProcess from child process. All communication is closed.
      * No exit notification is emitted any more for the child process.
      * Deleting the OProcess will no longer kill the child process.
      * Note that the current process remains the parent process of the
      * child process.
      */
     void detach();
 
-
-
 signals:
 
     /**
      * Emitted after the process has terminated when
      * the process was run in the @p NotifyOnExit  (==default option to
      * @ref start()) or the @ref Block mode.
      **/
     void processExited(OProcess *proc);
 
 
     /**
      * Emitted, when output from the child process has
@@ -513,25 +518,24 @@ signals:
      * You should copy the information contained in @p buffer to your private
      * data structures before returning from this slot.
     */
     void receivedStderr(OProcess *proc, char *buffer, int buflen);
 
     /**
      * Emitted after all the data that has been
      * specified by a prior call to @ref writeStdin() has actually been
      * written to the child process.
      **/
     void wroteStdin(OProcess *proc);
 
-
 protected slots:
 
     /**
      * This slot gets activated when data from the child's stdout arrives.
      * It usually calls "childOutput"
      */
     void slotChildOutput(int fdno);
 
     /**
      * This slot gets activated when data from the child's stderr arrives.
      * It usually calls "childError"
      */
@@ -700,25 +704,24 @@ protected:
     // information about the data that has to be sent to the child:
 
     const char *input_data;  // the buffer holding the data
     int input_sent;    // # of bytes already transmitted
     int input_total;   // total length of input_data
 
     /**
      * @ref OProcessController is a friend of OProcess because it has to have
      * access to various data members.
      */
     friend class OProcessController;
 
-
 private:
     /**
      * Searches for a valid shell.
      * Here is the algorithm used for finding an executable shell:
      *
      *    @li Try the executable pointed to by the "SHELL" environment
      *    variable with white spaces stripped off
      *
      *    @li If your process runs with uid != euid or gid != egid, a shell
      *    not listed in /etc/shells will not used.
      *
      *    @li If no valid shell could be found, "/bin/sh" is used as a last resort.
@@ -728,20 +731,17 @@ private:
     /**
      * Used by @ref searchShell in order to find out whether the shell found
      * is actually executable at all.
      */
     bool isExecutable(const QCString &filename);
 
     // Disallow assignment and copy-construction
     OProcess( const OProcess& );
     OProcess& operator= ( const OProcess& );
 
 private:
     void init ( );
-
     OProcessPrivate *d;
 };
 
-
-
 #endif