8 files changed, 55 insertions, 130 deletions

diff --git a/noncore/multimedia/opieplayer2/lib.cpp b/noncore/multimedia/opieplayer2/lib.cpp
index 248221b..8afb318 100644
--- a/noncore/multimedia/opieplayer2/lib.cpp
+++ b/noncore/multimedia/opieplayer2/lib.cpp
@@ -127,27 +127,19 @@ void Lib::initialize()
 
     // allocate oss for sound
     // and fb for framebuffer
     m_audioOutput = xine_open_audio_driver( m_xine,  "oss", NULL );
     m_videoOutput = ::init_video_out_plugin( m_xine, NULL, xine_display_frame, this );
 
-
-//xine_open_video_driver( m_xine,  NULL,  XINE_VISUAL_TYPE_FB,  NULL);
-
-
-//    null_display_handler( m_videoOutput, xine_display_frame, this );
-
     m_stream = xine_stream_new (m_xine,  m_audioOutput,  m_videoOutput );
 
-    if (m_wid != 0 ) {
-        printf( "!0\n" );
+    if (m_wid != 0 )
         setWidget( m_wid );
-    }
 
-    m_queue = xine_event_new_queue (m_stream);
 
+    m_queue = xine_event_new_queue (m_stream);
     xine_event_create_listener_thread (m_queue, xine_event_handler, this);
 
     ::null_preload_decoders( m_stream );
 
     m_duringInitialization = false;
 }
@@ -156,18 +148,16 @@ Lib::~Lib() {
     assert( isRunning() == false );
     assert( m_initialized );
 
 //    free( m_config );
 
     xine_close( m_stream );
-
     xine_event_dispose_queue( m_queue );
-
     xine_dispose( m_stream );
-
     xine_exit( m_xine );
+
     /* FIXME either free or delete but valgrind bitches against both */
     //free( m_videoOutput );
     //delete m_audioOutput;
 }
 
 void Lib::resize ( const QSize &s ) {
@@ -196,32 +186,24 @@ int Lib::subVersion() {
      xine_get_version ( &major, &minor, &sub );
      return sub;
 }
 
 int Lib::play( const QString& fileName, int startPos, int start_time ) {
     assert( m_initialized );
-    // FIXME actually a hack imho. Should not be needed to dispose the whole stream
-    // but without we get wrong media length reads from libxine for the second media
-    //xine_dispose ( m_stream );
 
     QString str = fileName.stripWhiteSpace();
 
-    //m_stream = xine_stream_new (m_xine,  m_audioOutput,  m_videoOutput );
-    //m_queue = xine_event_new_queue (m_stream);
-    //xine_event_create_listener_thread (m_queue, xine_event_handler, this);
 
-     if ( !xine_open( m_stream, str.utf8().data() ) ) {
-        return 0;
+    if ( !xine_open( m_stream, str.utf8().data() ) ) {
+         return 0;
     }
     return xine_play( m_stream, startPos, start_time);
 }
 
 void Lib::stop() {
     assert( m_initialized );
-
-    odebug << "<<<<<<<< STOP IN LIB TRIGGERED >>>>>>>" << oendl;
     xine_stop( m_stream );
 }
 
 void Lib::pause( bool toggle ) {
     assert( m_initialized );
 
@@ -255,18 +237,18 @@ int Lib::currentPosition() const {
 }
 
 int Lib::currentTime() const {
     assert( m_initialized );
 
     int pos, time, length;
-    xine_get_pos_length( m_stream, &pos, &time, &length );
-    if ( time > 0 )  {
+    pos = time = length = 0;
+
+    if ( xine_get_pos_length( m_stream, &pos, &time, &length ) )
         return time/1000;
-    } else {
+    else
         return 0;
-    }
 }
 
 int Lib::length() const {
       assert( m_initialized );
 
       int pos, time, length;
@@ -297,14 +279,12 @@ bool Lib::isSeekable() const {
     return xine_get_stream_info( m_stream, XINE_STREAM_INFO_SEEKABLE );
 }
 
 void Lib::seekTo( int time ) {
     assert( m_initialized );
 
-    //xine_trick_mode ( m_stream, XINE_TRICK_MODE_SEEK_TO_TIME, time ); NOT IMPLEMENTED YET IN XINE :_(
-    // since its now milliseconds we need *1000
     xine_play( m_stream, 0, time*1000 );
 }
 
 
 Frame Lib::currentFrame() const {
     assert( m_initialized );
@@ -422,13 +402,12 @@ void Lib::xine_display_frame( void* user_data, uint8_t *frame,
 }
 
 void Lib::drawFrame( uint8_t* frame,  int width,  int height,  int bytes ) {
     assert( m_initialized );
 
     if ( !m_video ) {
-        owarn << "not showing video now" << oendl;
         return;
     }
 
     assert( m_wid );
 
     m_wid-> setVideoFrame ( frame, width, height, bytes );
diff --git a/noncore/multimedia/opieplayer2/mediaplayer.cpp b/noncore/multimedia/opieplayer2/mediaplayer.cpp
index e6afbd8..b8023ca 100644
--- a/noncore/multimedia/opieplayer2/mediaplayer.cpp
+++ b/noncore/multimedia/opieplayer2/mediaplayer.cpp
@@ -2,12 +2,13 @@
 #include "audiowidget.h"
 #include "videowidget.h"
 #include "volumecontrol.h"
 
 /* OPIE */
 #include <opie2/odebug.h>
+#include <opie2/odevice.h>
 #include <qpe/qpeapplication.h>
 #include <qpe/config.h>
 
 /* QT */
 #include <qfileinfo.h>
 
@@ -31,16 +32,12 @@ MediaPlayer::MediaPlayer( PlayListWidget &_playList, MediaPlayerState &_mediaPla
 
     qApp->processEvents();
     //    QPEApplication::grabKeyboard(); // EVIL
     connect( qApp,SIGNAL( aboutToQuit()),SLOT( cleanUp()) );
 
     connect( &mediaPlayerState, SIGNAL( playingToggled(bool) ), this, SLOT( setPlaying(bool) ) );
-
-// What is pauseCheck good for? (Simon)
-//    connect( &mediaPlayerState, SIGNAL( pausedToggled(bool) ),  this, SLOT( pauseCheck(bool) ) );
-
     connect( &mediaPlayerState, SIGNAL( next() ), this, SLOT( next() ) );
     connect( &mediaPlayerState, SIGNAL( prev() ), this, SLOT( prev() ) );
     connect( &mediaPlayerState, SIGNAL( blankToggled(bool) ), this, SLOT ( blank(bool) ) );
 
     volControl = new VolumeControl;
     Config cfg( "OpiePlayer" );
@@ -151,13 +148,13 @@ void MediaPlayer::next() {
                 play();
             }
         } else {
             mediaPlayerState.setList();
         }
     } else { //if playing from file list, let's just stop
-        odebug << "<<<<<<<<<<<<<<<<<stop for filelists" << oendl; 
+        odebug << "<<<<<<<<<<<<<<<<<stop for filelists" << oendl;
         mediaPlayerState.setPlaying(false);
         mediaPlayerState.setDisplayType( MediaPlayerState::MediaSelection );
         if(l) mediaPlayerState.setLooping(l);
         if(r) mediaPlayerState.setShuffled(r);
     }
     qApp->processEvents();
@@ -278,48 +275,13 @@ void MediaPlayer::timerEvent( QTimerEvent * ) {
         }
     }
 }
 
 
 void MediaPlayer::blank( bool b ) {
-#ifdef QT_QWS_DEVFS
-    fd=open("/dev/fb/0",O_RDWR);
-#else
-    fd=open("/dev/fb0",O_RDWR);
-#endif
-#ifdef QT_QWS_SL5XXX
-    fl= open( "/dev/fl", O_RDWR );
-#endif
-    if (fd != -1) {
-        if ( b ) {
-            odebug << "do blanking" << oendl; 
-#ifdef QT_QWS_SL5XXX
-            ioctl( fd, FBIOBLANK, 1 );
-            if(fl !=-1) {
-                ioctl( fl, 2 );
-                ::close(fl);
-            }
-#else
-            ioctl( fd, FBIOBLANK, 3 );
-#endif
-            isBlanked = TRUE;
-        } else {
-            odebug << "do unblanking" << oendl; 
-            ioctl( fd, FBIOBLANK, 0);
-#ifdef QT_QWS_SL5XXX
-            if(fl != -1) {
-                ioctl( fl, 1);
-                ::close(fl);
-            }
-#endif
-            isBlanked = FALSE;
-        }
-        close( fd );
-    } else {
-        odebug << "<< /dev/fb0 could not be opened  >>" << oendl; 
-    }
+    Opie::Core::ODevice::inst()->setDisplayStatus( b );
 }
 
 void MediaPlayer::keyReleaseEvent( QKeyEvent *e) {
     switch ( e->key() ) {
 ////////////////////////////// Zaurus keys
       case Key_Home:
@@ -328,29 +290,27 @@ void MediaPlayer::keyReleaseEvent( QKeyEvent *e) {
           break;
       case Key_F10: //contacts
           break;
       case Key_F11: //menu
           break;
       case Key_F12: //home
-          odebug << "Blank here" << oendl; 
+          odebug << "Blank here" << oendl;
 //          mediaPlayerState->toggleBlank();
           break;
       case Key_F13: //mail
-          odebug << "Blank here" << oendl; 
+          odebug << "Blank here" << oendl;
           //  mediaPlayerState->toggleBlank();
           break;
     }
 }
 
 void MediaPlayer::cleanUp() {// this happens on closing
      Config cfg( "OpiePlayer" );
      mediaPlayerState.writeConfig( cfg );
      playList.writeDefaultPlaylist( );
 
-//     QPEApplication::grabKeyboard();
-//     QPEApplication::ungrabKeyboard();
 }
 
 void MediaPlayer::recreateAudioAndVideoWidgets() const
 {
     delete m_skinLoader;
 
diff --git a/noncore/multimedia/opieplayer2/mediawidget.cpp b/noncore/multimedia/opieplayer2/mediawidget.cpp
index 563ccf5..880b295 100644
--- a/noncore/multimedia/opieplayer2/mediawidget.cpp
+++ b/noncore/multimedia/opieplayer2/mediawidget.cpp
@@ -45,17 +45,16 @@ MediaWidget::~MediaWidget()
 void MediaWidget::setupButtons( const SkinButtonInfo *skinInfo, uint buttonCount,
                                 const Skin &skin )
 {
     buttonMask = skin.buttonMask( skinInfo, buttonCount );
 
     buttons.clear();
-    buttons.reserve( buttonCount );
 
     for ( uint i = 0; i < buttonCount; ++i ) {
         Button button = setupButton( skinInfo[ i ], skin );
-        buttons.push_back( button );
+        buttons.append( button );
     }
 }
 
 MediaWidget::Button MediaWidget::setupButton( const SkinButtonInfo &buttonInfo, const Skin &skin )
 {
     Button button;
@@ -84,35 +83,29 @@ void MediaWidget::loadSkin( const SkinButtonInfo *skinInfo, uint buttonCount, co
 
 void MediaWidget::closeEvent( QCloseEvent * )
 {
     mediaPlayerState.setList();
 }
 
-void MediaWidget::paintEvent( QPaintEvent *pe )
+void MediaWidget::paintEvent( QPaintEvent * )
 {
     QPainter p( this );
 
-    if ( mediaPlayerState.isFullscreen() ) {
-        // Clear the background
-        p.setBrush( QBrush( Qt::black ) );
-        return;
-    }
-
     QPixmap buffer( size() );
     QPainter bufferedPainter( &buffer );
     bufferedPainter.drawTiledPixmap( rect(), backgroundPixmap, QPoint( 0, 0 ) );
     paintAllButtons( bufferedPainter );
     p.drawPixmap( 0, 0, buffer );
 }
 
 void MediaWidget::resizeEvent( QResizeEvent *e )
 {
     QPixmap pixUp = combineImageWithBackground( buttonUpImage, backgroundPixmap, upperLeftOfButtonMask );
     QPixmap pixDn = combineImageWithBackground( buttonDownImage, backgroundPixmap, upperLeftOfButtonMask );
 
-    for ( ButtonVector::iterator it = buttons.begin(); it != buttons.end(); ++it ) {
+    for ( ButtonVector::Iterator it = buttons.begin(); it != buttons.end(); ++it ) {
         Button &button = *it;
 
         if ( button.mask.isNull() )
             continue;
         button.pixUp = addMaskToPixmap( pixUp, button.mask );
         button.pixDown = addMaskToPixmap( pixDn, button.mask );
@@ -126,14 +119,14 @@ MediaWidget::Button *MediaWidget::buttonAt( const QPoint &position )
     if ( position.x() <= 0 || position.y() <= 0 ||
          position.x() >= buttonMask.width() ||
          position.y() >= buttonMask.height() )
         return 0;
 
     int pixelIdx = buttonMask.pixelIndex( position.x(), position.y() );
-    for ( ButtonVector::iterator it = buttons.begin(); it != buttons.end(); ++it )
-        if ( it->command + 1 == pixelIdx )
+    for ( ButtonVector::Iterator it = buttons.begin(); it != buttons.end(); ++it )
+        if ( (*it).command + 1 == pixelIdx )
             return &( *it );
 
     return 0;
 }
 
 void MediaWidget::mousePressEvent( QMouseEvent *event )
@@ -190,21 +183,21 @@ void MediaWidget::handleCommand( Command command, bool buttonDown )
         default: assert( false );
     }
 }
 
 bool MediaWidget::isOverButton( const QPoint &position, int buttonId ) const
 {
-    return ( position.x() > 0 && position.y() > 0 && 
-             position.x() < buttonMask.width() && 
-             position.y() < buttonMask.height() && 
+    return ( position.x() > 0 && position.y() > 0 &&
+             position.x() < buttonMask.width() &&
+             position.y() < buttonMask.height() &&
              buttonMask.pixelIndex( position.x(), position.y() ) == buttonId + 1 );
 }
 
 void MediaWidget::paintAllButtons( QPainter &p )
 {
-    for ( ButtonVector::const_iterator it = buttons.begin();
+    for ( ButtonVector::ConstIterator it = buttons.begin();
           it != buttons.end(); ++it )
         paintButton( p, *it );
 }
 
 void MediaWidget::paintButton( const Button &button )
 {
@@ -219,14 +212,14 @@ void MediaWidget::paintButton( QPainter &p, const Button &button )
     else
         p.drawPixmap( upperLeftOfButtonMask, button.pixUp );
 }
 
 void MediaWidget::setToggleButton( Command command, bool down )
 {
-    for ( ButtonVector::iterator it = buttons.begin(); it != buttons.end(); ++it )
-        if ( it->command == command ) {
+    for ( ButtonVector::Iterator it = buttons.begin(); it != buttons.end(); ++it )
+        if ( (*it).command == command ) {
             setToggleButton( *it, down );
             return;
         }
 }
 
 void MediaWidget::setToggleButton( Button &button, bool down )
diff --git a/noncore/multimedia/opieplayer2/mediawidget.h b/noncore/multimedia/opieplayer2/mediawidget.h
index 8c3a467..d885150 100644
--- a/noncore/multimedia/opieplayer2/mediawidget.h
+++ b/noncore/multimedia/opieplayer2/mediawidget.h
@@ -26,15 +26,12 @@
 #include <qwidget.h>
 #include <qmap.h>
 
 #include "mediaplayerstate.h"
 #include "playlistwidget.h"
 
-#include <vector>
-#include <memory>
-
 class Skin;
 
 class MediaWidget : public QWidget
 {
     Q_OBJECT
 public:
@@ -51,13 +48,13 @@ public:
         bool isDown : 1;
 
         QBitmap mask;
         QPixmap pixUp;
         QPixmap pixDown;
     };
-    typedef std::vector<Button> ButtonVector;
+    typedef QValueList<Button> ButtonVector;
 
     struct SkinButtonInfo
     {
         Command command;
         const char *fileName;
         ButtonType type;
diff --git a/noncore/multimedia/opieplayer2/playlistwidget.cpp b/noncore/multimedia/opieplayer2/playlistwidget.cpp
index 36f77be..d73f0cd 100644
--- a/noncore/multimedia/opieplayer2/playlistwidget.cpp
+++ b/noncore/multimedia/opieplayer2/playlistwidget.cpp
@@ -181,18 +181,16 @@ void PlayListWidget::writeDefaultPlaylist() {
 
     Config config( "OpiePlayer" );
     config.setGroup( "PlayList" );
     QString filename=QPEApplication::documentDir() + "/default.m3u";
     QString currentString = config.readEntry( "CurrentPlaylist", filename);
     if( currentString == filename) {
-      Om3u *m3uList;
-      //    odebug << "<<<<<<<<<<<<<default>>>>>>>>>>>>>>>>>>>" << oendl; 
+        Om3u *m3uList;
       if( d->selectedFiles->first() ) {
         m3uList = new Om3u(filename, IO_ReadWrite | IO_Truncate);
         do {
-          //        odebug << d->selectedFiles->current()->file() << oendl; 
           m3uList->add( d->selectedFiles->current()->file() );
         }
         while ( d->selectedFiles->next() );
 
         m3uList->write();
         m3uList->close();
@@ -205,13 +203,12 @@ void PlayListWidget::writeDefaultPlaylist() {
 void PlayListWidget::addToSelection( const DocLnk& lnk ) {
     d->setDocumentUsed = FALSE;
     if( QFileInfo( lnk.file() ).exists() ||
         lnk.file().left(4) == "http" ) {
         d->selectedFiles->addToSelection( lnk );
     }
-//          writeCurrentM3u();
 }
 
 
 void PlayListWidget::clearList() {
     while ( first() ) {
         d->selectedFiles->removeSelected();
@@ -325,20 +322,20 @@ void PlayListWidget::addAllVideoToList() {
     writeCurrentM3u();
     d->selectedFiles->first();
 }
 
 
 void PlayListWidget::setDocument( const QString& _fileref ) {
-  //    odebug << "<<<<<<<<set document>>>>>>>>>> "+fileref << oendl; 
+  //    odebug << "<<<<<<<<set document>>>>>>>>>> "+fileref << oendl;
     QString fileref  = _fileref;
     fromSetDocument = TRUE;
-    
+
     DocLnk lnk(_fileref);
     if(lnk.isValid())
         fileref = lnk.file();
-    
+
     QFileInfo fileInfo(fileref);
 
     if ( !fileInfo.exists() ) {
         QMessageBox::warning( this, tr( "Invalid File" ),
                                tr( "There was a problem in getting the file." ) );
         return;
@@ -407,13 +404,13 @@ bool PlayListWidget::prev() {
         return TRUE;
     }
 }
 
 
 bool PlayListWidget::next() {
-//odebug << "<<<<<<<<<<<<next()" << oendl; 
+//odebug << "<<<<<<<<<<<<next()" << oendl;
     if ( mediaPlayerState->isShuffled() ) {
         return prev();
     } else {
         if ( !d->selectedFiles->next() ) {
             if ( mediaPlayerState->isLooping() ) {
                 return d->selectedFiles->first();
@@ -618,13 +615,13 @@ void PlayListWidget::openURL() {
     QString filename, name;
     InputDialog *fileDlg;
     fileDlg = new InputDialog(this,tr("Add  URL"),TRUE, 0);
     fileDlg->exec();
     if( fileDlg->result() == 1 ) {
         filename = fileDlg->text();
-        odebug << "Selected filename is " + filename << oendl; 
+        odebug << "Selected filename is " + filename << oendl;
         //            Om3u *m3uList;
             DocLnk lnk;
             Config cfg( "OpiePlayer" );
             cfg.setGroup("PlayList");
 
         if(filename.left(4) == "http") {
@@ -694,13 +691,13 @@ void PlayListWidget::openFile() {
         str=str.right(str.length()-1);
     }
     cfg.writeEntry( "LastDirectory" ,QFileInfo( str ).dirPath() );
 
     if( !str.isEmpty() ) {
 
-        odebug << "Selected filename is " + str << oendl; 
+        odebug << "Selected filename is " + str << oendl;
         filename = str;
         DocLnk lnk;
 
         if( filename.right( 3) == "m3u" ||  filename.right(3) == "pls" ) {
             readListFromFile( filename );
         } else {
@@ -712,26 +709,26 @@ void PlayListWidget::openFile() {
         }
     }
 }
 
 
 void PlayListWidget::readListFromFile( const QString &filename ) {
-    odebug << "read list filename " + filename << oendl; 
+    odebug << "read list filename " + filename << oendl;
     QFileInfo fi(filename);
     Om3u *m3uList;
     QString s, name;
     m3uList = new Om3u( filename, IO_ReadOnly );
     if(fi.extension(false).find("m3u",0,false) != -1 )
         m3uList->readM3u();
     else if(fi.extension(false).find("pls",0,false) != -1 )
         m3uList->readPls();
 
     DocLnk lnk;
     for ( QStringList::ConstIterator it = m3uList->begin(); it != m3uList->end(); ++it ) {
         s = *it;
-        //        odebug << s << oendl; 
+        //        odebug << s << oendl;
         if(s.left(4)=="http") {
           lnk.setName( s ); //sets file name
           lnk.setIcon("opieplayer2/musicfile");
           lnk.setFile( s ); //sets file name
 
         }  else { //is file
@@ -759,27 +756,27 @@ void PlayListWidget::readListFromFile( const QString &filename ) {
     setCaption(tr("OpiePlayer: ")+ QFileInfo(filename).baseName());
 
 }
 
 //  writes current playlist to current m3u file */
  void PlayListWidget::writeCurrentM3u() {
-   odebug << "writing to current m3u" << oendl; 
+   odebug << "writing to current m3u" << oendl;
    Config cfg( "OpiePlayer" );
    cfg.setGroup("PlayList");
    QString currentPlaylist = cfg.readEntry("CurrentPlaylist","default");
 
    Om3u *m3uList;
    m3uList = new Om3u( currentPlaylist, IO_ReadWrite | IO_Truncate );
    if( d->selectedFiles->first()) {
 
        do {
-           //      odebug << "add writeCurrentM3u " +d->selectedFiles->current()->file() << oendl; 
+           //      odebug << "add writeCurrentM3u " +d->selectedFiles->current()->file() << oendl;
            m3uList->add( d->selectedFiles->current()->file() );
        }
        while ( d->selectedFiles->next() );
-       //    odebug << "<<<<<<<<<<<<>>>>>>>>>>>>>>>>>" << oendl; 
+       //    odebug << "<<<<<<<<<<<<>>>>>>>>>>>>>>>>>" << oendl;
        m3uList->write();
       m3uList->close();
    }
    delete m3uList;
 
  }
@@ -818,13 +815,13 @@ void PlayListWidget::writem3u() {
     QString name, filename, list;
     Om3u *m3uList;
 
     if( !str.isEmpty() ) {
         name = str;
         //       name = fileDlg->text();
-//        odebug << filename << oendl; 
+//        odebug << filename << oendl;
         if( name.find("/",0,true) != -1) {// assume they specify a file path
             filename = name;
             name = name.right(name.length()- name.findRev("/",-1,true) - 1 );
         }
         else //otherwise dump it somewhere noticable
             filename = QPEApplication::documentDir() + "/" + name;
@@ -836,33 +833,33 @@ void PlayListWidget::writem3u() {
             m3uList = new Om3u( filename, IO_ReadWrite | IO_Truncate);
 
             do {
             m3uList->add( d->selectedFiles->current()->file());
           }
           while ( d->selectedFiles->next() );
-          //    odebug << list << oendl; 
+          //    odebug << list << oendl;
           m3uList->write();
           m3uList->close();
           delete m3uList;
 
           //delete fileDlg;
 
           DocLnk lnk;
           lnk.setFile( filename);
           lnk.setIcon("opieplayer2/playlist2");
           lnk.setName( name); //sets file name
 
-          // odebug << filename << oendl; 
+          // odebug << filename << oendl;
           Config config( "OpiePlayer" );
           config.setGroup( "PlayList" );
 
           config.writeEntry("CurrentPlaylist",filename);
           currentPlayList=filename;
 
           if(!lnk.writeLink()) {
-            odebug << "Writing doclink did not work" << oendl; 
+            odebug << "Writing doclink did not work" << oendl;
           }
 
           setCaption(tr("OpiePlayer: ") + name);
         }
     }
 }
@@ -890,13 +887,13 @@ void PlayListWidget::keyReleaseEvent( QKeyEvent *e ) {
     addSelected();
     break;
   case Key_R: //remove from playlist
     removeSelected();
     break;
     //       case Key_P: //play
-    //           odebug << "Play" << oendl; 
+    //           odebug << "Play" << oendl;
     //           playSelected();
     //           break;
   case Key_Space:
     //          playSelected(); puh
     break;
   case Key_1:
@@ -920,13 +917,13 @@ void PlayListWidget::keyReleaseEvent( QKeyEvent *e ) {
       //        d->selectedFiles->last();
       break;
   }
 }
 
 void PlayListWidget::pmViewActivated(int index) {
-//  odebug << "" << index << "" << oendl; 
+//  odebug << "" << index << "" << oendl;
     switch(index) {
     case -16:
     {
         mediaPlayerState->toggleFullscreen();
         bool b=mediaPlayerState->isFullscreen();
         pmView->setItemChecked( index, b);
@@ -950,13 +947,13 @@ void PlayListWidget::populateSkinsMenu() {
     skinsDir.setSorting(QDir::Name );
     const QFileInfoList *skinslist = skinsDir.entryInfoList();
     QFileInfoListIterator it( *skinslist );
     QFileInfo *fi;
     while ( ( fi = it.current() ) ) {
         skinName =  fi->fileName();
-//        odebug << fi->fileName() << oendl; 
+//        odebug << fi->fileName() << oendl;
         if( skinName != "." &&  skinName != ".." && skinName !="CVS" )  {
             item = skinsMenu->insertItem( fi->fileName() ) ;
         }
         if( skinName == "default" ) {
             defaultSkinIndex = item;
         }
@@ -1006,13 +1003,13 @@ PlayListWidget::Entry PlayListWidget::currentEntry() const
 QString PlayListWidget::currentFileListPathName() const {
     return currentFileListView->currentItem()->text( 3 );
 }
 
 
 void PlayListWidget::qcopReceive(const QCString &msg, const QByteArray &data) {
-   odebug << "qcop message "+msg << oendl; 
+   odebug << "qcop message "+msg << oendl;
    QDataStream stream ( data, IO_ReadOnly );
    if ( msg == "play()" ) { //plays current selection
       btnPlay( true);
    } else if ( msg == "stop()" ) {
       mediaPlayerState->setPlaying( false);
    } else if ( msg == "togglePause()" ) {
diff --git a/noncore/multimedia/opieplayer2/playlistwidgetgui.cpp b/noncore/multimedia/opieplayer2/playlistwidgetgui.cpp
index 922f9d7..c3c1282 100644
--- a/noncore/multimedia/opieplayer2/playlistwidgetgui.cpp
+++ b/noncore/multimedia/opieplayer2/playlistwidgetgui.cpp
@@ -180,13 +180,12 @@ void PlayListWidgetGui::setView( char view )  {
     else
         hide();
 }
 
 
 void PlayListWidgetGui::setActiveWindow()  {
-    //  odebug << "SETTING active window" << oendl; 
     // When we get raised we need to ensure that it switches views
     MediaPlayerState::DisplayType origDisplayType = mediaPlayerState->displayType();
     mediaPlayerState->setDisplayType( MediaPlayerState::MediaSelection ); // invalidate
     mediaPlayerState->setDisplayType( origDisplayType ); // now switch back
 }
 
diff --git a/noncore/multimedia/opieplayer2/videowidget.cpp b/noncore/multimedia/opieplayer2/videowidget.cpp
index 0625376..2b44701 100644
--- a/noncore/multimedia/opieplayer2/videowidget.cpp
+++ b/noncore/multimedia/opieplayer2/videowidget.cpp
@@ -142,12 +142,13 @@ void VideoWidget::setDisplayType( MediaPlayerState::DisplayType displayType )
         return;
     }
 
     // Effectively blank the view next time we show it so it looks nicer
     scaledWidth = 0;
     scaledHeight = 0;
+    videoFrame->hide();
     hide();
 }
 
 void VideoWidget::loadSkin()
 {
     loadDefaultSkin( guiInfo() );
@@ -191,23 +192,23 @@ void VideoWidget::backToNormal() {
      mediaPlayerState.setFullscreen( FALSE );
      makeVisible();
      setToggleButton( FullScreen, false );
 }
 
 void VideoWidget::makeVisible() {
+    videoFrame->show();
     if ( mediaPlayerState.isFullscreen() ) {
         showFullScreen();
         resize( qApp->desktop()->size() );
         videoFrame-> setGeometry ( 0, 0, width ( ), height ( ));
 
         slider->hide();
         disconnect( &mediaPlayerState, SIGNAL( positionChanged(long) ),this, SLOT( setPosition(long) ) );
         disconnect( &mediaPlayerState, SIGNAL( positionUpdated(long) ),this, SLOT( setPosition(long) ) );
         disconnect( slider, SIGNAL( sliderPressed() ), this, SLOT( sliderPressed() ) );
         disconnect( slider, SIGNAL( sliderReleased() ), this, SLOT( sliderReleased() ) );
-
     } else {
         showNormal();
         showMaximized();
         QWidget *d = QApplication::desktop();
         int w = d->width();
         int h = d->height();
diff --git a/noncore/multimedia/opieplayer2/xinecontrol.cpp b/noncore/multimedia/opieplayer2/xinecontrol.cpp
index 9f944d7..e1816c8 100644
--- a/noncore/multimedia/opieplayer2/xinecontrol.cpp
+++ b/noncore/multimedia/opieplayer2/xinecontrol.cpp
@@ -78,13 +78,13 @@ void XineControl::init()
     connect( xineVideoWidget, SIGNAL( videoResized(const QSize&) ), this, SLOT( videoResized(const QSize&) ) );
 
     disabledSuspendScreenSaver = FALSE;
 }
 
 XineControl::~XineControl() {
-#if defined(Q_WS_QWS) && !defined(QT_NO_COP)
+#if !defined(QT_NO_COP)
     if ( disabledSuspendScreenSaver ) {
         disabledSuspendScreenSaver = FALSE;
         // Re-enable the suspend mode
         QCopEnvelope( "QPE/System", "setScreenSaverMode(int)" ) << QPEApplication::Enable;
     }
 #endif
@@ -94,31 +94,29 @@ XineControl::~XineControl() {
 void XineControl::play( const QString& fileName ) {
 
     hasVideoChannel = FALSE;
     hasAudioChannel = FALSE;
     m_fileName = fileName;
 
-    odebug << "<<FILENAME: " + fileName  + ">>>>" << oendl; 
+    odebug << "<<FILENAME: " + fileName  + ">>>>" << oendl;
 
     if ( !libXine->play( fileName, 0, 0 ) ) {
         QMessageBox::warning( 0l , tr( "Failure" ), getErrorCode() );
         // toggle stop so the the play button is reset
         mediaPlayerState.setPlaying( false );
         return;
     }
     mediaPlayerState.setPlaying( true );
 
     MediaPlayerState::DisplayType displayType;
     if ( !libXine->hasVideo() ) {
         displayType = MediaPlayerState::Audio;
-        odebug << "HAS AUDIO" << oendl; 
         libXine->setShowVideo( false );
         hasAudioChannel = TRUE;
     } else {
         displayType = MediaPlayerState::Video;
-        odebug << "HAS VIDEO" << oendl; 
         libXine->setShowVideo( true );
         hasVideoChannel = TRUE;
     }
     // determine if slider is shown
     mediaPlayerState.setIsSeekable( libXine->isSeekable() );
 
@@ -147,13 +145,13 @@ void XineControl::setGamma( int value ) {
 }
 
 void XineControl::stop( bool isSet ) {
     if ( !isSet ) {
         libXine->stop();
 
-#if defined(Q_WS_QWS) && !defined(QT_NO_COP)
+#if !defined(QT_NO_COP)
         if ( disabledSuspendScreenSaver ) {
             disabledSuspendScreenSaver = FALSE;
             // Re-enable the suspend mode
             QCopEnvelope( "QPE/System", "setScreenSaverMode(int)" ) << QPEApplication::Enable;
         }
 #endif
@@ -173,13 +171,12 @@ void XineControl::pause( bool isSet) {
  * get current time in playback
  */
 long XineControl::currentTime() {
     // todo: jede sekunde überprüfen
     m_currentTime = libXine->currentTime();
     return m_currentTime;
-    QTimer::singleShot( 1000, this, SLOT( currentTime() ) );
 }
 
 /**
  * Set the length of the media file
  */
 void  XineControl::length() {
@@ -244,22 +241,24 @@ QString XineControl::getMetaInfo() {
 }
 
 QString XineControl::getErrorCode() {
 
     int errorCode = libXine->error();
 
-    odebug << QString("ERRORCODE: %1 ").arg(errorCode) << oendl; 
+    odebug << QString("ERRORCODE: %1 ").arg(errorCode) << oendl;
 
     if ( errorCode == 1 ) {
         return tr( "No input plugin found for this media type" );
     } else if ( errorCode == 2 ) {
-         return tr( "No demux plugin found for this media type" );
+        return tr( "No demux plugin found for this media type" );
     } else if ( errorCode == 3 ) {
         return tr( "Demuxing failed for this media type" );
     } else if ( errorCode == 4 ) {
         return tr( "Malformed MRL" );
+    } else if ( errorCode == 5 ) {
+        return tr( "Input failed" );
     } else {
         return tr( "Some other error" );
     }
 }
 
 /**