1 files changed, 39 insertions, 60 deletions

diff --git a/noncore/settings/appearance2/appearance.cpp b/noncore/settings/appearance2/appearance.cpp
index 52c7125..cf3069e 100644
--- a/noncore/settings/appearance2/appearance.cpp
+++ b/noncore/settings/appearance2/appearance.cpp
@@ -66,212 +66,174 @@
 #include <qvgroupbox.h>
 #include <qwidget.h>
 
 #include "stylelistitem.h"
 #include "decolistitem.h"
 #include "fontlistitem.h"
 #include "colorlistitem.h"
 
 #include "sample.h"
 
 
 static int findItemCB ( QComboBox *box, const QString &str )
 {
 	for ( int i = 0; i < box-> count ( ); i++ ) {
 		if ( box-> text ( i ) == str )
 			return i;
 	}
 	return -1;
 }
 
 class DefaultWindowDecoration : public WindowDecorationInterface
 {
 public:
     DefaultWindowDecoration() : ref(0) {}
     QString name() const {
 	return "Default";
     }
     QPixmap icon() const {
 	return QPixmap();
     }
     QRESULT queryInterface( const QUuid &uuid, QUnknownInterface **iface ) {
 	*iface = 0;
 	if ( uuid == IID_QUnknown )
 	    *iface = this;
 	else if ( uuid == IID_WindowDecoration )
 	    *iface = this;
 
 	if ( *iface )
 	    (*iface)->addRef();
 	return QS_OK;
     }
     Q_REFCOUNT
 
 private:
 	ulong ref;
 };
 
 
-struct {
-	QColorGroup::ColorRole role;
-	const char *key;
-	const char *def;
-} colorLUT [] = {
-	{ QColorGroup::Base,            "Base",            "#FFFFFF" },
-	{ QColorGroup::Background,      "Background",      "#E5E1D5" },
-	{ QColorGroup::Button,          "Button",          "#D6CDBB" },
-	{ QColorGroup::ButtonText,      "ButtonText",      "#000000" },
-	{ QColorGroup::Highlight,       "Highlight",       "#800000" },
-	{ QColorGroup::HighlightedText, "HighlightedText", "#FFFFFF" },
-	{ QColorGroup::Text,            "Text",            "#000000" },
-	
-	{ QColorGroup::NColorRoles,     0,                 0         }
-};
-
 
 void Appearance::loadStyles ( QListBox *list )
 {
 #if QT_VERSION >= 300
     list->insertStringList(QStyleFactory::styles());
 #else
     list->insertItem( new StyleListItem ( "Windows", new QWindowsStyle ( )));
     list->insertItem( new StyleListItem ( "Light", new LightStyle ( )));
 #ifndef QT_NO_STYLE_MOTIF
     list->insertItem( new StyleListItem ( "Motif", new QMotifStyle ( )));
 #endif
 #ifndef QT_NO_STYLE_MOTIFPLUS
     list->insertItem( new StyleListItem ( "MotifPlus", new QMotifPlusStyle ( )));
 #endif
 #ifndef QT_NO_STYLE_PLATINUM
     list->insertItem( new StyleListItem ( "Platinum", new QPlatinumStyle ( )));
 #endif
 #endif
     list->insertItem( new StyleListItem ( "QPE", new QPEStyle ( )));
 
 #if QT_VERSION < 300
 	{
 		QString path = QPEApplication::qpeDir() + "/plugins/styles/";
 		QStringList sl = QDir ( path, "lib*.so" ). entryList ( );
 
 		for ( QStringList::Iterator it = sl. begin ( ); it != sl. end ( ); ++it ) {
 			QLibrary *lib = new QLibrary ( path + "/" + *it );
 			StyleInterface *iface;
 
 			if ( lib-> queryInterface ( IID_Style, (QUnknownInterface **) &iface ) == QS_OK )
 				list-> insertItem ( new StyleListItem ( lib, iface ));
 			else
 				delete lib;
 		}
 	}
 
 #endif
 }
 
 void Appearance::loadDecos ( QListBox *list )
 {
     list-> insertItem ( new DecoListItem ( tr( "Default" )));
 
 	{
 		QString path = QPEApplication::qpeDir() + "/plugins/decorations/";
 		QStringList sl = QDir ( path, "lib*.so" ). entryList ( );
 
 		for ( QStringList::Iterator it = sl. begin ( ); it != sl. end ( ); ++it ) {
 			QLibrary *lib = new QLibrary ( path + "/" + *it );
 			WindowDecorationInterface *iface;
 
 			if ( lib-> queryInterface ( IID_WindowDecoration, (QUnknownInterface **) &iface ) == QS_OK )
 				list-> insertItem ( new DecoListItem ( lib, iface ));
 			else
 				delete lib;
 		}
 	}
 }
 
-static QPalette readColorPalette ( Config &config )
-{
-	QColor bgcolor( config. readEntry( "Background", "#E5E1D5" ) );
-	QColor btncolor( config. readEntry( "Button", "#D6CDBB" ) );
-	QPalette pal( btncolor, bgcolor );
-	
-	QString color = config. readEntry( "Highlight", "#800000" );
-	pal.setColor( QColorGroup::Highlight, QColor(color) );
-	color = config. readEntry( "HighlightedText", "#FFFFFF" );
-	pal.setColor( QColorGroup::HighlightedText, QColor(color) );
-	color = config. readEntry( "Text", "#000000" );
-	pal.setColor( QColorGroup::Text, QColor(color) );
-	color = config. readEntry( "ButtonText", "#000000" );
-	pal.setColor( QPalette::Active, QColorGroup::ButtonText, QColor(color) );
-	color = config. readEntry( "Base", "#FFFFFF" );
-	pal.setColor( QColorGroup::Base, QColor(color) );
-                                                    
-	pal.setColor( QPalette::Disabled, QColorGroup::Text, pal.color(QPalette::Active, QColorGroup::Background).dark() );
-		
-	return pal;
-}                                                                  		
-		
 void Appearance::loadColors ( QListBox *list )
 {
     list-> clear ( );
     {
     	Config config ( "qpe" );
 		config. setGroup ( "Appearance" );
     
-		list-> insertItem ( new ColorListItem ( tr( "Current scheme" ), readColorPalette ( config )));
+		list-> insertItem ( new ColorListItem ( tr( "Current scheme" ), config ));
 	}
 
 	QString path = QPEApplication::qpeDir ( ) + "/etc/colors/";
     QStringList sl = QDir ( path ). entryList ( "*.scheme" );
 	
 	for ( QStringList::Iterator it = sl. begin ( ); it != sl. end ( ); ++it ) {
 		QString name = (*it). left ((*it). find ( ".scheme" ));
 		Config config ( path + *it, Config::File );
 		config. setGroup ( "Colors" );
 		
-		list-> insertItem ( new ColorListItem ( name, readColorPalette ( config )));
+		list-> insertItem ( new ColorListItem ( name, config ));
 	}
 }
 
 void Appearance::loadFonts ( QListBox *list )
 {
 	FontDatabase fd;
 	QStringList f = fd. families ( );
 	
 	for ( QStringList::ConstIterator it = f. begin ( ); it != f. end ( ); ++it )
 		list-> insertItem ( new FontListItem ( *it, fd. styles ( *it ), fd. pointSizes ( *it )));
 }
 
 
 QWidget *Appearance::createStyleTab ( QWidget *parent )
 {
 	Config config ( "qpe" );
 	config. setGroup ( "Appearance" );
 
     QWidget* tab = new QWidget( parent, "StyleTab" );
     QVBoxLayout* vertLayout = new QVBoxLayout( tab, 4, 4 );
 
     m_style_list = new QListBox( tab, "m_style_list" );
     vertLayout->addWidget( m_style_list );
 
     m_style_settings = new QPushButton ( tr( "Settings..." ), tab );
     connect ( m_style_settings, SIGNAL( clicked ( )), this, SLOT( styleSettingsClicked ( )));
     vertLayout-> addWidget ( m_style_settings );
 
 	loadStyles ( m_style_list );
 
     QString s = config. readEntry ( "Style", "Light" );
     m_style_list-> setCurrentItem ( m_style_list-> findItem ( s ));
     m_original_style = m_style_list-> currentItem ( );
     styleClicked ( m_original_style );
 
     connect( m_style_list, SIGNAL( highlighted( int ) ), this, SLOT( styleClicked( int ) ) );
 
 	return tab;
 }
 
 QWidget *Appearance::createDecoTab ( QWidget *parent )
 {
 	Config config ( "qpe" );
 	config. setGroup ( "Appearance" );
 
     QWidget* tab = new QWidget( parent, "DecoTab" );
     QVBoxLayout* vertLayout = new QVBoxLayout( tab, 4, 4 );
 
@@ -439,106 +401,105 @@ Appearance::Appearance( QWidget* parent,  const char* name, WFlags )
 	
     OTabWidget* tw = new OTabWidget ( this, "tabwidget", OTabWidget::Global, OTabWidget::Bottom );
 	QWidget *styletab;
 	
  	tw-> addTab ( styletab = createStyleTab ( tw ), "appearance/styletabicon.png", tr( "Style" ));
     tw-> addTab ( createFontTab ( tw ), "appearance/fonttabicon.png", tr( "Font" ));
     tw-> addTab ( createColorTab ( tw ), "appearance/colorstabicon.png", tr( "Colors" ) );
     tw-> addTab ( createDecoTab ( tw ), "appearance/styletabicon.png", tr( "Windows" ) );
     tw-> addTab ( createGuiTab ( tw ), "appearance/backgroundtabicon.png", tr( "Gui" ) );
 
 	top-> addWidget ( tw, 10 );	
 	top-> addWidget ( m_sample, 1 );
 
     tw-> setCurrentTab ( styletab );
 }
 
 Appearance::~Appearance()
 {
 }
 
 void Appearance::accept ( )
 {
     Config config("qpe");
     config.setGroup( "Appearance" );
 
 	int newstyle = m_style_list-> currentItem ( );
 	int newtabstyle = ( m_tabstyle_list-> currentItem ( ) & 0xff ) | \
 	                  ( m_tabstyle_top-> isChecked ( ) ? 0x000 : 0x100 );
 	int newfontfamily = m_font_family_list-> currentItem ( );
 	int newfontstyle = m_font_style_list-> currentItem ( );
 	int newfontsize = m_font_size_list-> currentItem ( );
 
 
     if ( m_style_changed ) { 
 	    StyleListItem *item = (StyleListItem *) m_style_list-> item ( newstyle );
 	    if ( item )
             config.writeEntry( "Style", item-> key ( ));
 	}
 	if ( newtabstyle != m_original_tabstyle ) {
 		config. writeEntry ( "TabStyle", newtabstyle );
 	}
 
     if ( m_font_changed ) {
         config.writeEntry( "FontFamily", m_font_family_list-> text ( newfontfamily ));
         config.writeEntry( "FontStyle", m_font_style_list-> text ( newfontstyle ));
         config.writeEntry( "FontSize", m_font_size_list-> text ( newfontsize ));
     }
 
-/*
-    if ( schemeChanged )
-    {
-        int i;
-        for ( i = 0; i < MAX_CONTROL; i++ )
+
+    if ( m_color_changed )
         {
-            config.writeEntry( controlList[i], controlColor[i] );
-        }
+    	ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
+ 
+ 		if ( item )   
+			item-> save ( config );
     }
-*/
+    
 	config. write ( ); // need to flush the config info first
 	Global::applyStyle ( );
 
 	if ( QMessageBox::warning ( this, tr( "Restart" ), tr( "Do you want to restart Opie now?" ),  tr( "Yes" ), tr( "No" ), 0, 0, 1 ) == 0 ) {
 		QCopEnvelope e( "QPE/System", "restart()" );
 	}
 	
 	QDialog::accept ( );
 }
 
 void Appearance::done ( int r )
 {
 	QDialog::done ( r );
 	close ( );
 }
 
 
 void Appearance::styleClicked ( int index )
 {
     StyleListItem *sli = (StyleListItem *) m_style_list-> item ( index );
 	m_style_settings-> setEnabled ( sli ? sli-> hasSettings ( ) : false );
 	
 	if ( m_sample && sli && sli-> style ( ))
 		m_sample-> setStyle2 ( sli-> style ( ));
 		
 	m_style_changed |= ( index != m_original_style );
 }
 
 void Appearance::styleSettingsClicked ( )
 {
 	StyleListItem *item = (StyleListItem *) m_style_list-> item ( m_style_list-> currentItem ( ));
 
 	if ( item && item-> hasSettings ( )) {
 		QDialog *d = new QDialog ( this, "SETTINGS-DLG", true );
 		QVBoxLayout *vbox = new QVBoxLayout ( d, 4, 0 );
 
 		QWidget *w = item-> settings ( d );
 
 		if ( w ) {
 			vbox-> addWidget ( w );
 
 			d-> setCaption ( w-> caption ( ));
 
 		   	d-> showMaximized ( );
 			bool accepted = ( d-> exec ( ) == QDialog::Accepted );
 
 			if ( item-> setSettings ( accepted ))
 				m_style_changed = true;
@@ -607,123 +568,141 @@ void Appearance::fontFamilyClicked ( int index )
 
 void Appearance::fontStyleClicked ( int index )
 {
 	changeText ( );
 	
 	m_font_changed |= ( index != m_original_fontstyle );	
 }
 
 void Appearance::fontSizeClicked ( int index )
 {
 	changeText ( );
 
 	m_font_changed |= ( index != m_original_fontsize );
 }
 
 void Appearance::changeText ( )
 {
     int ffa = m_font_family_list-> currentItem ( );
     int fst = m_font_style_list-> currentItem ( ); 
     int fsi = m_font_size_list-> currentItem ( );
     
     FontListItem *fli = (FontListItem *) m_font_family_list-> item ( ffa );
     
     if ( fli ) {
     	FontDatabase fdb;
     
 		m_sample-> setFont ( fdb. font ( fli-> family ( ), \
 		                     fst >= 0 ? fli-> styles ( ) [fst] : QString::null, \
 		                     fsi >= 0 ? fli-> sizes ( ) [fsi] : 10, \
 		                     fdb. charSets ( fli-> family ( )) [0] ));
 	}
 }
 
 void Appearance::colorClicked ( int index )
 {
 	ColorListItem *item = (ColorListItem *) m_color_list-> item ( index );
 
 	if ( item )
 		m_sample-> setPalette ( item-> palette ( ));
 
 	m_color_changed |= ( item-> palette ( ) != qApp-> palette ( ));
 }
 
 
 void Appearance::editSchemeClicked ( )
 {
 	ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
-/*
-    EditScheme* editdlg = new EditScheme( this, "editScheme", TRUE, 0,
-                                         9, controlLabel, controlColor );
+	int cnt = 0;
+	QString controlLabel [QColorGroup::NColorRoles];
+	QString controlColor [QColorGroup::NColorRoles];
+	
+	for ( QColorGroup::ColorRole role = (QColorGroup::ColorRole) 0; role != QColorGroup::NColorRoles; ((int) role )++ ) {
+		QColor col = item-> color ( role );
+		
+		if ( col. isValid ( )) {
+			controlLabel [cnt] = item-> label ( role );
+			controlColor [cnt] = col. name ( );
+		
+			cnt++;
+		}
+	}
+
+    EditScheme* editdlg = new EditScheme( this, "editScheme", true, 0,  cnt, controlLabel, controlColor );
     editdlg->showMaximized();
-    if ( editdlg->exec() == QDialog::Accepted )
-    {
-        int i;
-        for ( i = 0; i < MAX_CONTROL; i++ )
-        {
-            controlColor[i] = editdlg->colorList[i];
+    if ( editdlg-> exec ( ) == QDialog::Accepted ) {
+    	ColorListItem *citem = (ColorListItem *) m_color_list-> item ( 0 );
+		cnt = 0;
+		    
+		for ( QColorGroup::ColorRole role = (QColorGroup::ColorRole) 0; role != QColorGroup::NColorRoles; ((int) role )++ ) {
+			if ( item-> color ( role ). isValid ( )) {
+        		citem-> setColor ( role, QColor ( controlColor [cnt] ));	
+        		cnt++;
+        	}
         }
+        
+        m_color_list-> setCurrentItem ( 0 );
+        colorClicked ( 0 );
+        
         m_color_changed = true;
     }
     delete editdlg;
-    */
 }
 
 
 void Appearance::saveSchemeClicked()
 {
 	ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
 	if ( !item )
 		return;
 
 	QDialog *d = new QDialog ( this, 0, true );
 	d-> setCaption ( tr( "Save Scheme" ));
 	QLineEdit *ed = new QLineEdit ( this );
 	( new QVBoxLayout ( d, 4, 4 ))-> addWidget ( ed );
 
     if ( d-> exec ( ) == QDialog::Accepted ) {
         QString schemename = ed-> text ( );
         QFile file ( QPEApplication::qpeDir() + "/etc/colors/" + schemename + ".scheme" );
         if ( !file. exists ( ))
         { 
         	QPalette p = item-> palette ( );
         
             Config config ( file.name(), Config::File );
             config.setGroup( "Colors" );
 
-            for ( int i = 0; colorLUT [i]. role != QColorGroup::NColorRoles; i++ ) 
-                config.writeEntry ( colorLUT [i]. key, p. color ( QPalette::Active, colorLUT [i]. role ). name ( ));
+			item-> save ( config );
                 
             config. write ( ); // need to flush the config info first
 		    loadColors ( m_color_list );
         }
         else
         {
 	        QMessageBox::information ( this, tr( "Save scheme" ), tr( "Scheme does already exist." ));
         }
     }
     delete d;
 }
 
 void Appearance::deleteSchemeClicked()
 {
 	ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
 	if ( !item )
 		return;
 
     if ( m_color_list-> currentItem ( ) > 0 )
     {
         if ( QMessageBox::warning ( this, tr( "Delete scheme" ), tr( "Do you really want to delete\n" ) + item-> text ( ) + "?",
                 tr( "Yes" ), tr( "No" ), 0, 0, 1 ) == 0 ) {
 			QFile::remove ( QPEApplication::qpeDir ( ) + "/etc/colors/" + item-> text ( ) + ".scheme" );
 			loadColors ( m_color_list );
         }
     }
     else
     {
         QMessageBox::information( this, tr( "Delete scheme" ), tr( "Unable to delete current scheme." ));
     }
 }