1 files changed, 185 insertions, 108 deletions

diff --git a/noncore/settings/networksettings/ppp/general.cpp b/noncore/settings/networksettings/ppp/general.cpp
index f735e49..5540946 100644
--- a/noncore/settings/networksettings/ppp/general.cpp
+++ b/noncore/settings/networksettings/ppp/general.cpp
@@ -35,42 +35,61 @@
 #include <qslider.h>
 #include <qspinbox.h>
 #include <qwhatsthis.h>
-
+#include <qpe/config.h>
 // #include <qgroupbox.h>
 
+
 #include "general.h"
 #include "interfaceppp.h"
 //#include "miniterm.h"
 #include "modeminfo.h"
 #include "modemcmds.h"
-#include "devices.h"
+//#include "devices.h"
 #include "pppdata.h"
 //#include <klocale.h>
-#define i18n QObject::tr
 
 
 
-ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name )
-    : QWidget(parent, name), _ifaceppp(ifppp)
+
+ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name )
+    : QWidget(parent, name), _pppdata(pd)
 {
   int k;
 
   QGridLayout *tl = new QGridLayout(this, 8, 2, 0 );//, KDialog::spacingHint());
 
   QLabel *label1;
-  label1 = new QLabel(i18n("Modem de&vice:"), this);
+
+  label1 = new QLabel(tr("Modem &name:"), this);
   tl->addWidget(label1, 0, 0);
 
+  modemname = new QLineEdit(this, "modemName");
+  modemname->setText( _pppdata->devname() );
+  label1->setBuddy(modemname);
+  tl->addWidget(modemname, 0, 1);
+
+  label1 = new QLabel(tr("Modem de&vice:"), this);
+  tl->addWidget(label1, 1, 0);
+
   modemdevice = new QComboBox(false, this);
+  modemdevice->setEditable( true );
+  modemdevice->setDuplicatesEnabled ( false );
+  modemdevice->setInsertionPolicy( QComboBox::AtTop );
   label1->setBuddy(modemdevice);
 
-  for(k = 0; devices[k]; k++)
-    modemdevice->insertItem(devices[k]);
+  Config cfg("NetworkSetupPPP");
+  cfg.setGroup("Devices_General");
+  QStringList devs = cfg.readListEntry("devices",',');
+  if (devs.isEmpty()) devs << "/dev/modem" << "/dev/ircomm0" << "/dev/ttyS0";
+  modemdevice->insertStringList( devs );
+  tl->addWidget(modemdevice, 1, 1);
+
+//   connect(modemdevice, SIGNAL(activated(int)),
+        //   SLOT(setmodemdc(int)));
+//   connect(modemdevice, SIGNAL(textChanged( const QString & ) ),
+//           SLOT( setmodemdc( const QString &) ) );
 
-  tl->addWidget(modemdevice, 0, 1);
-  connect(modemdevice, SIGNAL(activated(int)),
-          SLOT(setmodemdc(int)));
-  QString tmp = i18n("This specifies the serial port your modem is attached \n"
+  QString tmp = tr("This specifies the serial port your modem is attached \n"
                      "to. On Linux/x86, typically this is either /dev/ttyS0 \n"
                      "(COM1 under DOS) or /dev/ttyS1 (COM2 under DOS).\n"
                      "\n"
@@ -82,19 +101,19 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
   QWhatsThis::add(modemdevice,tmp);
 
 
-  label1 = new QLabel(i18n("&Flow control:"), this);
-  tl->addWidget(label1, 1, 0);
+  label1 = new QLabel(tr("&Flow control:"), this);
+  tl->addWidget(label1, 2, 0);
 
   flowcontrol = new QComboBox(false, this);
   label1->setBuddy(flowcontrol);
-  flowcontrol->insertItem(i18n("Hardware [CRTSCTS]"));
-  flowcontrol->insertItem(i18n("Software [XON/XOFF]"));
-  flowcontrol->insertItem(i18n("None"));
-  tl->addWidget(flowcontrol, 1, 1);
-  connect(flowcontrol, SIGNAL(activated(int)),
-          SLOT(setflowcontrol(int)));
-
-  tmp = i18n("<p>Specifies how the serial port and modem\n"
+  flowcontrol->insertItem(tr("Hardware [CRTSCTS]"));
+  flowcontrol->insertItem(tr("Software [XON/XOFF]"));
+  flowcontrol->insertItem(tr("None"));
+  tl->addWidget(flowcontrol, 2, 1);
+//   connect(flowcontrol, SIGNAL(activated(int)),
+        //   SLOT(setflowcontrol(int)));
+
+  tmp = tr("<p>Specifies how the serial port and modem\n"
              "communicate. You should not change this unless\n"
              "you know what you are doing.\n"
              "\n"
@@ -103,17 +122,17 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
   QWhatsThis::add(label1,tmp);
   QWhatsThis::add(flowcontrol,tmp);
 
-  QLabel *labelenter = new QLabel(i18n("&Line termination:"), this);
-  tl->addWidget(labelenter, 2, 0);
+  QLabel *labelenter = new QLabel(tr("&Line termination:"), this);
+  tl->addWidget(labelenter, 3, 0);
 
   enter = new QComboBox(false, this);
   labelenter->setBuddy(enter);
   enter->insertItem("CR");
   enter->insertItem("LF");
   enter->insertItem("CR/LF");
-  tl->addWidget(enter, 2, 1);
-  connect(enter, SIGNAL(activated(int)), SLOT(setenter(int)));
-  tmp = i18n("<p>Specifies how AT commands are sent to your\n"
+  tl->addWidget(enter, 3, 1);
+//  connect(enter, SIGNAL(activated(int)), SLOT(setenter(int)));
+  tmp = tr("<p>Specifies how AT commands are sent to your\n"
              "modem. Most modems will work fine with the\n"
              "default <i>CR/LF</i>. If your modem does not react\n"
              "to the init string, you should try different\n"
@@ -124,8 +143,8 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
   QWhatsThis::add(labelenter,tmp);
   QWhatsThis::add(enter, tmp);
 
-  QLabel *baud_label = new QLabel(i18n("Co&nnection speed:"), this);
-  tl->addWidget(baud_label, 3, 0);
+  QLabel *baud_label = new QLabel(tr("Co&nnection speed:"), this);
+  tl->addWidget(baud_label, 4, 0);
   baud_c = new QComboBox(this);
   baud_label->setBuddy(baud_c);
 
@@ -157,11 +176,11 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
     baud_c->insertItem(baudrates[k]);
 
   baud_c->setCurrentItem(3);
-  connect(baud_c, SIGNAL(activated(int)),
-          this, SLOT(speed_selection(int)));
-  tl->addWidget(baud_c, 3, 1);
+//   connect(baud_c, SIGNAL(activated(int)),
+        //   this, SLOT(speed_selection(int)));
+  tl->addWidget(baud_c, 4, 1);
 
-  tmp = i18n("Specifies the speed your modem and the serial\n"
+  tmp = tr("Specifies the speed your modem and the serial\n"
              "port talk to each other. You should begin with\n"
              "the default of 38400 bits/sec. If everything\n"
              "works you can try to increase this value, but to\n"
@@ -172,22 +191,22 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
   QWhatsThis::add(baud_c,tmp);
 
   for(int i=0; i <= enter->count()-1; i++) {
-    if(_ifaceppp->data()->enter() == enter->text(i))
+    if(_pppdata->enter() == enter->text(i))
       enter->setCurrentItem(i);
   }
 
-  tl->addRowSpacing(4, 10);
+  tl->addRowSpacing(5, 10);
 
   //Modem Lock File
-  modemlockfile = new QCheckBox(i18n("&Use lock file"), this);
+  modemlockfile = new QCheckBox(tr("&Use lock file"), this);
 
-  modemlockfile->setChecked(_ifaceppp->data()->modemLockFile());
-  connect(modemlockfile, SIGNAL(toggled(bool)),
-          SLOT(modemlockfilechanged(bool)));
-  tl->addMultiCellWidget(modemlockfile, 5, 5, 0, 1);
+  modemlockfile->setChecked(_pppdata->modemLockFile());
+//   connect(modemlockfile, SIGNAL(toggled(bool)),
+//           SLOT(modemlockfilechanged(bool)));
+  tl->addMultiCellWidget(modemlockfile, 6, 6, 0, 1);
   //  l12->addStretch(1);
   QWhatsThis::add(modemlockfile,
-                  i18n("<p>To prevent other programs from accessing the\n"
+                  tr("<p>To prevent other programs from accessing the\n"
                        "modem while a connection is established, a\n"
                        "file can be created to indicate that the modem\n"
                        "is in use. On Linux an example file would be\n"
@@ -202,89 +221,139 @@ ModemWidget::ModemWidget( InterfacePPP *ifppp, QWidget *parent, const char *name
   QLabel *timeoutlabel = new QLabel( tr("Modem timeout:") ,this, "timeout" );
   modemtimeout = new QSpinBox( 1, 120, 1, this, "modemTimeout" );
 //   modemtimeout = new KIntNumInput(_pppdata->modemTimeout(), this);
-//   modemtimeout->setLabel(i18n("Modem &timeout:"));
+//   modemtimeout->setLabel(tr("Modem &timeout:"));
 //  modemtimeout->setRange(1, 120, 1);
-  modemtimeout->setSuffix(i18n(" sec"));
-  modemtimeout->setValue( _ifaceppp->data()->modemTimeout() );
-  connect(modemtimeout, SIGNAL(valueChanged(int)),
-          SLOT(modemtimeoutchanged(int)));
+  modemtimeout->setSuffix(tr(" sec"));
+  modemtimeout->setValue( _pppdata->modemTimeout() );
+//   connect(modemtimeout, SIGNAL(valueChanged(int)),
+        //   SLOT(modemtimeoutchanged(int)));
   timeoutLayout->addWidget(timeoutlabel);
   timeoutLayout->addWidget(modemtimeout);
-  tl->addMultiCellLayout(timeoutLayout, 6, 6, 0, 1);
+  tl->addMultiCellLayout(timeoutLayout, 7, 7, 0, 1);
 
   QWhatsThis::add(modemtimeout,
-                  i18n("This specifies how long <i>kppp</i> waits for a\n"
+                  tr("This specifies how long <i>kppp</i> waits for a\n"
                        "<i>CONNECT</i> response from your modem. The\n"
                        "recommended value is 30 seconds."));
 
   //set stuff from gpppdata
   for(int i=0; i <= enter->count()-1; i++) {
-    if(_ifaceppp->data()->enter() == enter->text(i))
+    if(_pppdata->enter() == enter->text(i))
       enter->setCurrentItem(i);
   }
 
   for(int i=0; i <= modemdevice->count()-1; i++) {
-    if(_ifaceppp->data()->modemDevice() == modemdevice->text(i))
+    if(_pppdata->modemDevice() == modemdevice->text(i))
       modemdevice->setCurrentItem(i);
   }
 
   for(int i=0; i <= flowcontrol->count()-1; i++) {
-    if(_ifaceppp->data()->flowcontrol() == flowcontrol->text(i))
+    if(_pppdata->flowcontrol() == flowcontrol->text(i))
       flowcontrol->setCurrentItem(i);
   }
 
   //set the modem speed
   for(int i=0; i < baud_c->count(); i++)
-    if(baud_c->text(i) == _ifaceppp->data()->speed())
+    if(baud_c->text(i) == _pppdata->speed())
       baud_c->setCurrentItem(i);
 
-  tl->setRowStretch(7, 1);
+  tl->setRowStretch(1, 1);
 }
 
+ModemWidget::~ModemWidget()
+{
+    QStringList devs;
 
-void ModemWidget::speed_selection(int) {
-  _ifaceppp->data()->setSpeed(baud_c->text(baud_c->currentItem()));
-}
+    for (int i=0;i<modemdevice->count();i++)
+    {
+        QString s = modemdevice->text(i);
+        s.simplifyWhiteSpace();
+        if (! s.isEmpty() ) devs << s;
+    }
 
 
-void ModemWidget::setenter(int ) {
-  _ifaceppp->data()->setEnter(enter->text(enter->currentItem()));
-}
+    QString edited = modemdevice->currentText();
+    if ( !( edited ).isEmpty() )  {
+        edited.simplifyWhiteSpace();
+        if ( devs.contains( edited ) == 0 )  {
+            devs << edited;
+        }
+        _pppdata->setModemDevice( edited );
+    }
+
 
+    Config cfg("NetworkSetupPPP");
+    cfg.setGroup("Devices_General");
+    cfg.writeEntry("devices",devs,',');
 
-void ModemWidget::setmodemdc(int i) {
-  _ifaceppp->data()->setModemDevice(modemdevice->text(i));
 }
 
+// void ModemWidget::speed_selection(int) {
+//   _pppdata->setSpeed(baud_c->text(baud_c->currentItem()));
+// }
 
-void ModemWidget::setflowcontrol(int i) {
-  _ifaceppp->data()->setFlowcontrol(flowcontrol->text(i));
-}
 
+// void ModemWidget::setenter(int ) {
+//   _pppdata->setEnter(enter->text(enter->currentItem()));
+// }
 
-void ModemWidget::modemlockfilechanged(bool set) {
-  _ifaceppp->data()->setModemLockFile(set);
-}
 
+// void ModemWidget::setmodemdc(int i) {
+//   _pppdata->setModemDevice(modemdevice->text(i));
+// }
 
-void ModemWidget::modemtimeoutchanged(int n) {
-  _ifaceppp->data()->setModemTimeout(n);
-}
+// void ModemWidget::setmodemdc( const QString &string )  {
+//     _pppdata->setModemDevice( string );
+// }
+
+// void ModemWidget::setflowcontrol(int i) {
+//   _pppdata->setFlowcontrol(flowcontrol->text(i));
+// }
 
 
-ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
+// void ModemWidget::modemlockfilechanged(bool set) {
+//   _pppdata->setModemLockFile(set);
+// }
+
+
+// void ModemWidget::modemtimeoutchanged(int n) {
+//   _pppdata->setModemTimeout(n);
+// }
+
+
+
+bool ModemWidget::save()
+{
+    //first check to make sure that the device name is unique!
+    if(modemname->text().isEmpty() ||
+       !_pppdata->isUniqueDevname(modemname->text()))
+        return false;
+
+    qDebug("ModemWidget::save saving modem1 data");
+    _pppdata->setDevname( modemname->text() );
+    _pppdata->setModemDevice( modemdevice->currentText() );
+    _pppdata->setFlowcontrol(flowcontrol->currentText());
+    _pppdata->setFlowcontrol(flowcontrol->currentText());
+    _pppdata->setSpeed(baud_c->currentText());
+    _pppdata->setModemLockFile( modemlockfile->isChecked());
+    _pppdata->setModemTimeout( modemtimeout->value() );
+    return true;
+
+}
+
+ModemWidget2::ModemWidget2( PPPData *pd, InterfacePPP *ip, QWidget *parent,
                             const char *name)
-    : QWidget(parent, name), _ifaceppp(ifp)
+    : QWidget(parent, name), _pppdata(pd), _ifaceppp(ip)
 {
     QVBoxLayout *l1 = new QVBoxLayout(this, 0 );//, KDialog::spacingHint());
 
 
-  waitfordt = new QCheckBox(i18n("&Wait for dial tone before dialing"), this);
-  waitfordt->setChecked(_ifaceppp->data()->waitForDialTone());
-  connect(waitfordt, SIGNAL(toggled(bool)), SLOT(waitfordtchanged(bool)));
+  waitfordt = new QCheckBox(tr("&Wait for dial tone before dialing"), this);
+  waitfordt->setChecked(_pppdata->waitForDialTone());
+//  connect(waitfordt, SIGNAL(toggled(bool)), SLOT(waitfordtchanged(bool)));
   l1->addWidget(waitfordt);
   QWhatsThis::add(waitfordt,
-                  i18n("<p>Normally the modem waits for a dial tone\n"
+                  tr("<p>Normally the modem waits for a dial tone\n"
                        "from your phone line, indicating that it can\n"
                        "start to dial a number. If your modem does not\n"
                        "recognize this sound, or your local phone system\n"
@@ -296,16 +365,16 @@ ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
   QLabel *waitLabel = new QLabel( tr("Busy wait:"), this, "busyWait" );
   busywait = new QSpinBox( 0, 300, 5, this, "busyWait" );
 //   busywait = new KIntNumInput(_pppdata->busyWait(), this);
-//   busywait->setLabel(i18n("B&usy wait:"));
+//   busywait->setLabel(tr("B&usy wait:"));
 //   busywait->setRange(0, 300, 5, true);
-   busywait->setSuffix(i18n(" sec"));
-  connect(busywait, SIGNAL(valueChanged(int)), SLOT(busywaitchanged(int)));
+   busywait->setSuffix(tr(" sec"));
+//  connect(busywait, SIGNAL(valueChanged(int)), SLOT(busywaitchanged(int)));
   waitLayout->addWidget(waitLabel);
   waitLayout->addWidget(busywait);
   l1->addLayout( waitLayout );
 
   QWhatsThis::add(busywait,
-                  i18n("Specifies the number of seconds to wait before\n"
+                  tr("Specifies the number of seconds to wait before\n"
                        "redial if all dialed numbers are busy. This is\n"
                        "necessary because some modems get stuck if the\n"
                        "same number is busy too often.\n"
@@ -318,9 +387,9 @@ ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
   QHBoxLayout *hbl = new QHBoxLayout;
   hbl->setSpacing(2);//KDialog::spacingHint());
 
-  QLabel *volumeLabel = new QLabel(i18n("Modem &volume:"), this);
+  QLabel *volumeLabel = new QLabel(tr("Modem &volume:"), this);
   hbl->addWidget(volumeLabel);
-  volume = new QSlider(0, 2, 1, _ifaceppp->data()->volume(),
+  volume = new QSlider(0, 2, 1, _pppdata->volume(),
                        QSlider::Horizontal, this);
   volumeLabel->setBuddy(volume);
   volume->setTickmarks(QSlider::Below);
@@ -328,9 +397,9 @@ ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
 
   l1->addLayout(hbl);
 
-  connect(volume, SIGNAL(valueChanged(int)),
-          this, SLOT(volumeChanged(int)));
-  QString tmp = i18n("Most modems have a speaker which makes\n"
+//   connect(volume, SIGNAL(valueChanged(int)),
+        //   this, SLOT(volumeChanged(int)));
+  QString tmp = tr("Most modems have a speaker which makes\n"
              "a lot of noise when dialing. Here you can\n"
              "either turn this completely off or select a\n"
              "lower volume.\n"
@@ -344,38 +413,38 @@ ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
   l1->addSpacing(20);
 
 #if 0
-  chkbox1 = new QCheckBox(i18n("Modem asserts CD line"), this);
-  chkbox1->setChecked(_ifaceppp->data()->UseCDLine());
+  chkbox1 = new QCheckBox(tr("Modem asserts CD line"), this);
+  chkbox1->setChecked(_pppdata->UseCDLine());
   connect(chkbox1,SIGNAL(toggled(bool)),
           this,SLOT(use_cdline_toggled(bool)));
   l12->addWidget(chkbox1);
   l12->addStretch(1);
   l1->addStretch(1);
   QWhatsThis::add(chkbox1,
-                  i18n("This controls how <i>kppp</i> detects that the modem\n"
+                  tr("This controls how <i>kppp</i> detects that the modem\n"
                        "is not responding. Unless you are having\n"
                        "problems with this, do not modify this setting.\n"
                        "\n"
                        "<b>Default</b>: Off"));
 #endif
 
-  modemcmds = new QPushButton(i18n("Mod&em Commands..."), this);
+  modemcmds = new QPushButton(tr("Mod&em Commands..."), this);
   QWhatsThis::add(modemcmds,
-                  i18n("Allows you to change the AT command for\n"
+                  tr("Allows you to change the AT command for\n"
                        "your modem."));
 
-  modeminfo_button = new QPushButton(i18n("&Query Modem..."), this);
+  modeminfo_button = new QPushButton(tr("&Query Modem..."), this);
   QWhatsThis::add(modeminfo_button,
-                  i18n("Most modems support the ATI command set to\n"
+                  tr("Most modems support the ATI command set to\n"
                        "find out vendor and revision of your modem.\n"
                        "\n"
                        "Press this button to query your modem for\n"
                        "this information. It can be useful to help\n"
                        "you setup the modem"));
 
-//   terminal_button = new QPushButton(i18n("&Terminal..."), this);
+//   terminal_button = new QPushButton(tr("&Terminal..."), this);
 //   QWhatsThis::add(terminal_button,
-        //        i18n("Opens the built-in terminal program. You\n"
+        //        tr("Opens the built-in terminal program. You\n"
         //             "can use this if you want to play around\n"
         //             "with your modem's AT command set"));
 
@@ -402,7 +471,7 @@ ModemWidget2::ModemWidget2( InterfacePPP* ifp, QWidget *parent,
 
 
 void ModemWidget2::modemcmdsbutton() {
-  ModemCommands mc(_ifaceppp->data(), this);
+  ModemCommands mc(_ifaceppp->data(), this, "commands" , true, Qt::WStyle_ContextHelp);
   mc.showMaximized();
   mc.exec();
 }
@@ -420,22 +489,30 @@ void ModemWidget2::query_modem() {
 // }
 
 
-#if 0
-void ModemWidget2::use_cdline_toggled(bool on) {
-    _ifaceppp->data()->setUseCDLine(on);
-}
-#endif
+// #if 0
+// void ModemWidget2::use_cdline_toggled(bool on) {
+//     _pppdata->setUseCDLine(on);
+// }
+// #endif
 
-void ModemWidget2::waitfordtchanged(bool b) {
-  _ifaceppp->data()->setWaitForDialTone((int)b);
-}
+// void ModemWidget2::waitfordtchanged(bool b) {
+//   _pppdata->setWaitForDialTone((int)b);
+// }
 
-void ModemWidget2::busywaitchanged(int n) {
-  _ifaceppp->data()->setbusyWait(n);
-}
+// void ModemWidget2::busywaitchanged(int n) {
+//   _pppdata->setbusyWait(n);
+// }
 
 
-void ModemWidget2::volumeChanged(int v) {
-  _ifaceppp->data()->setVolume(v);
+// void ModemWidget2::volumeChanged(int v) {
+//   _pppdata->setVolume(v);
+// }
+
+bool ModemWidget2::save()
+{
+    _pppdata->setWaitForDialTone(waitfordt->isChecked());
+    _pppdata->setbusyWait(busywait->value());
+    _pppdata->setVolume(volume->value());
+    return true;
 }