1 files changed, 236 insertions, 227 deletions

diff --git a/noncore/settings/networksettings/ppp/kpppwidget.cpp b/noncore/settings/networksettings/ppp/kpppwidget.cpp
index f8a8dc3..289e9f5 100644
--- a/noncore/settings/networksettings/ppp/kpppwidget.cpp
+++ b/noncore/settings/networksettings/ppp/kpppwidget.cpp
@@ -34,12 +34,13 @@
 #include <qlabel.h>
 #include <qpushbutton.h>
 #include <qregexp.h>
 #include <qtabwidget.h>
 #include <qdialog.h>
 #include <qwhatsthis.h>
+#include <qcheckbox.h>
 
 // #include <kaboutdata.h>
 // #include <kapplication.h>
 #include <qbuttongroup.h>
 //#include <kcmdlineargs.h>
 //#include <kconfig.h>
@@ -67,203 +68,211 @@
 //#include "ppplog.h"
 //#include "opener.h"
 //#include "requester.h"
 //#include "pppstats.h"
 #include "pppdata.h"
 #include "general.h"
+#include "interface.h"
 
 #define execute_command system
 
 KPPPWidget *p_kppp = 0;
 
-KPPPWidget::KPPPWidget( QWidget *parent, const char *name, bool modal, WFlags fl )
-  : QDialog(parent, name, modal, fl)
-//  , acct(0)
-//  , m_bCmdlAccount (false)
+KPPPWidget::KPPPWidget(PPPData*pd, Interface *i, QWidget *parent, const char *name, bool modal, WFlags fl )
+    : QDialog(parent, name, modal, fl), _pppdata(pd)
 {
 //  tabWindow = 0;
   p_kppp = this;
   // before doing anything else, run a few tests
+    if (!_pppdata->setModemDevice( i->getInterfaceName() ))
+        _pppdata->setModemDevice("/dev/modem");
+    qDebug("PPPConfigWidget::PPPConfigWidget");
+    qDebug(" interface->getHardwareName >%s<", i->getHardwareName().latin1());
+    if (!_pppdata->setAccount( i->getHardwareName() ))
+        _pppdata->setAccount( 0 );
+
+    qDebug(" _pppdata->accname >%s<",_pppdata->accname().latin1());
+    qDebug(" _pppdata->currentAccountID() >%i<",_pppdata->currentAccountID());
 
   int result = runTests();
   if(result == TEST_CRITICAL)
     exit(4);
 
 //   installEventFilter(this);
 
-//   QVBoxLayout *tl = new QVBoxLayout(this, 10, 10);
-
-//   QGridLayout *l1 = new QGridLayout(3, 4);
-//   tl->addLayout(l1);
-//   l1->addColSpacing(0, 10);
-//   l1->addColSpacing(3, 10);
-//   l1->setColStretch(1, 3);
-//   l1->setColStretch(2, 4);
-
-//   label1 = new QLabel(i18n("C&onnect to: "), this);
-//   l1->addWidget(label1, 0, 1);
-
-//   connectto_c = new QComboBox(false, this);
-//   label1->setBuddy(connectto_c);
-
-//   connect(connectto_c, SIGNAL(activated(int)),
-        //   SLOT(newdefaultaccount(int)));
-//   l1->addWidget(connectto_c, 0, 2);
-
-//   ID_Label = new QLabel(i18n("&Login ID:"), this);
-//   l1->addWidget(ID_Label, 1, 1);
-
-//   // the entry line for usernames
-//   ID_Edit = new QLineEdit(this);
-//   ID_Label->setBuddy(ID_Edit);
-//   l1->addWidget(ID_Edit, 1, 2);
-//   connect(ID_Edit, SIGNAL(returnPressed()),
-        //   this, SLOT(enterPressedInID()));
-//   QString tmp = i18n("<p>Type in the username that you got from your\n"
-        //           "ISP. This is especially important for PAP\n"
-        //           "and CHAP. You may omit this when you use\n"
-        //           "terminal-based or script-based authentication.\n"
-        //           "\n"
-        //           "<b>Important</b>: case is important here:\n"
-        //           "<i>myusername</i> is not the same as <i>MyUserName</i>!");
-
-//   QWhatsThis::add(ID_Label,tmp);
-//   QWhatsThis::add(ID_Edit,tmp);
-
-//   PW_Label = new QLabel(i18n("&Password:"), this);
-//   l1->addWidget(PW_Label, 2, 1);
-
-//   PW_Edit= new QLineEdit(this);
-//   PW_Label->setBuddy(PW_Edit);
-//   PW_Edit->setEchoMode(QLineEdit::Password);
-//   l1->addWidget(PW_Edit, 2, 2);
-//   connect(PW_Edit, SIGNAL(returnPressed()),
-        //   this, SLOT(enterPressedInPW()));
-
-//   tmp = i18n("<p>Type in the password that you got from your\n"
-        //      "ISP. This is especially important for PAP\n"
-        //      "and CHAP. You may omit this when you use\n"
-        //      "terminal-based or script-based authentication.\n"
-        //      "\n"
-        //      "<b>Important</b>: case is important here:\n"
-        //      "<i>mypassword</i> is not the same as <i>MyPassword</i>!");
-
-//   QWhatsThis::add(PW_Label,tmp);
-//   QWhatsThis::add(PW_Edit,tmp);
-
-//    QHBoxLayout *l3 = new QHBoxLayout;
-//    tl->addSpacing(5);
-//    tl->addLayout(l3);
-//    tl->addSpacing(5);
-//    l3->addSpacing(10);
-//    log = new QCheckBox(i18n("Show lo&g window"), this);
-//    connect(log, SIGNAL(toggled(bool)),
-        //     this, SLOT(log_window_toggled(bool)));
-//    log->setChecked(PPPData::data()->get_show_log_window());
-//    l3->addWidget(log);
-
-//    QWhatsThis::add(log,
-        //        i18n("<p>This controls whether a log window is shown.\n"
-        //             "A log window shows the communication between\n"
-        //             "<i>kppp</i> and your modem. This will help you\n"
-        //             "in tracking down problems.\n"
-        //             "\n"
-        //             "Turn it off if <i>kppp</i> routinely connects without\n"
-        //             "problems"));
-
-// //  fline = new QSeparator( KSeparator::HLine, this);
-// //  tl->addWidget(fline);
-
-//   QHBoxLayout *l2 = new QHBoxLayout(this);
-//   tl->addLayout(l2);
-
-//  int minw = 0;
-//   quit_b = new QPushButton(i18n("&Quit"), this);
-//   // quit_b-> setGuiItem (KGuiItem(i18n("&Quit"), "exit" ) );
-//   connect( quit_b, SIGNAL(clicked()), SLOT(quitbutton()));
-//   if(quit_b->sizeHint().width() > minw)
-//       minw = quit_b->sizeHint().width();
-
-//   setup_b = new QPushButton(i18n("&Setup..."), this);
-// //  setup_b->setGuiItem (KGuiItem(i18n("&Setup...")) );
-//   connect( setup_b, SIGNAL(clicked()), SLOT(expandbutton()));
-//   if(setup_b->sizeHint().width() > minw)
-//       minw = setup_b->sizeHint().width();
-
-
-
-//   if(PPPData::data()->access() != KConfig::ReadWrite)
-//     setup_b->setEnabled(false);
+  QVBoxLayout *tl = new QVBoxLayout(this, 10, 10);
+
+  QGridLayout *l1 = new QGridLayout(3, 4);
+  tl->addLayout(l1);
+  l1->addColSpacing(0, 10);
+  l1->addColSpacing(3, 10);
+  l1->setColStretch(1, 3);
+  l1->setColStretch(2, 4);
+
+  label1 = new QLabel(i18n("C&onnect to: "), this);
+  l1->addWidget(label1, 0, 1);
+
+  connectto_c = new QComboBox(false, this);
+  label1->setBuddy(connectto_c);
+
+  connect(connectto_c, SIGNAL(activated(int)),
+          SLOT(newdefaultaccount(int)));
+  l1->addWidget(connectto_c, 0, 2);
+
+  ID_Label = new QLabel(i18n("&Login ID:"), this);
+  l1->addWidget(ID_Label, 1, 1);
+
+  // the entry line for usernames
+  ID_Edit = new QLineEdit(this);
+  ID_Label->setBuddy(ID_Edit);
+  l1->addWidget(ID_Edit, 1, 2);
+  connect(ID_Edit, SIGNAL(returnPressed()),
+          this, SLOT(enterPressedInID()));
+  QString tmp = i18n("<p>Type in the username that you got from your\n"
+                     "ISP. This is especially important for PAP\n"
+                     "and CHAP. You may omit this when you use\n"
+                     "terminal-based or script-based authentication.\n"
+                     "\n"
+                     "<b>Important</b>: case is important here:\n"
+                     "<i>myusername</i> is not the same as <i>MyUserName</i>!");
+
+  QWhatsThis::add(ID_Label,tmp);
+  QWhatsThis::add(ID_Edit,tmp);
+
+  PW_Label = new QLabel(i18n("&Password:"), this);
+  l1->addWidget(PW_Label, 2, 1);
+
+  PW_Edit= new QLineEdit(this);
+  PW_Label->setBuddy(PW_Edit);
+  PW_Edit->setEchoMode(QLineEdit::Password);
+  l1->addWidget(PW_Edit, 2, 2);
+  connect(PW_Edit, SIGNAL(returnPressed()),
+          this, SLOT(enterPressedInPW()));
+
+  tmp = i18n("<p>Type in the password that you got from your\n"
+             "ISP. This is especially important for PAP\n"
+             "and CHAP. You may omit this when you use\n"
+             "terminal-based or script-based authentication.\n"
+             "\n"
+             "<b>Important</b>: case is important here:\n"
+             "<i>mypassword</i> is not the same as <i>MyPassword</i>!");
+
+  QWhatsThis::add(PW_Label,tmp);
+  QWhatsThis::add(PW_Edit,tmp);
+
+   QHBoxLayout *l3 = new QHBoxLayout;
+   tl->addSpacing(5);
+   tl->addLayout(l3);
+   tl->addSpacing(5);
+   l3->addSpacing(10);
+   log = new QCheckBox(i18n("Show lo&g window"), this);
+   connect(log, SIGNAL(toggled(bool)),
+            this, SLOT(log_window_toggled(bool)));
+   log->setChecked(_pppdata->get_show_log_window());
+   l3->addWidget(log);
+
+   QWhatsThis::add(log,
+                  i18n("<p>This controls whether a log window is shown.\n"
+                       "A log window shows the communication between\n"
+                       "<i>kppp</i> and your modem. This will help you\n"
+                       "in tracking down problems.\n"
+                       "\n"
+                       "Turn it off if <i>kppp</i> routinely connects without\n"
+                       "problems"));
+
+//  fline = new QSeparator( KSeparator::HLine, this);
+//  tl->addWidget(fline);
+
+  QHBoxLayout *l2 = new QHBoxLayout(this);
+  tl->addLayout(l2);
+
+ int minw = 0;
+  quit_b = new QPushButton(i18n("&Quit"), this);
+  // quit_b-> setGuiItem (KGuiItem(i18n("&Quit"), "exit" ) );
+  connect( quit_b, SIGNAL(clicked()), SLOT(quitbutton()));
+  if(quit_b->sizeHint().width() > minw)
+      minw = quit_b->sizeHint().width();
+
+  setup_b = new QPushButton(i18n("&Setup..."), this);
+// setup_b->setGuiItem (KGuiItem(i18n("&Setup...")) );
+  connect( setup_b, SIGNAL(clicked()), SLOT(expandbutton()));
+  if(setup_b->sizeHint().width() > minw)
+      minw = setup_b->sizeHint().width();
+
+
+
+//  if(_pppdata->access() != KConfig::ReadWrite)
+  //  setup_b->setEnabled(false);
 
 //   help_b = new QPushButton(i18n("&Help"), this);
 //   connect( help_b, SIGNAL(clicked()), SLOT(helpbutton()));
 
 //   KHelpMenu *helpMenu = new KHelpMenu(this, KGlobal::instance()->aboutData(), true);
 //   help_b->setPopup((QPopupMenu*)helpMenu->menu());
 //   help_b->setGuiItem (KGuiItem(i18n("&Help"), "help" ) );
 
 //    if(help_b->sizeHint().width() > minw)
 //        minw = help_b->sizeHint().width();
 
-//   connect_b = new QPushButton(i18n("&Connect"), this);
-//   connect_b->setDefault(true);
-//   connect_b->setFocus();
-//   connect(connect_b, SIGNAL(clicked()), SLOT(beginConnect()));
-//    if(connect_b->sizeHint().width() > minw)
-//        minw = connect_b->sizeHint().width();
+  connect_b = new QPushButton(i18n("&Connect"), this);
+  connect_b->setDefault(true);
+  connect_b->setFocus();
+  connect(connect_b, SIGNAL(clicked()), SLOT(beginConnect()));
+   if(connect_b->sizeHint().width() > minw)
+       minw = connect_b->sizeHint().width();
 
-//   quit_b->setFixedWidth(minw);
-//   setup_b->setFixedWidth(minw);
-// //  help_b->setFixedWidth(help_b->sizeHint().width());
-//   connect_b->setFixedWidth(minw);
+  quit_b->setFixedWidth(minw);
+  setup_b->setFixedWidth(minw);
+// help_b->setFixedWidth(help_b->sizeHint().width());
+  connect_b->setFixedWidth(minw);
 
-//   l2->addWidget(quit_b);
-//   l2->addWidget(setup_b);
-// //  l2->addWidget(help_b);
-//   l2->addSpacing(20);
-//   l2->addWidget(connect_b);
+  l2->addWidget(quit_b);
+  l2->addWidget(setup_b);
+// l2->addWidget(help_b);
+  l2->addSpacing(20);
+  l2->addWidget(connect_b);
 
   setFixedSize(sizeHint());
 
-  (void)new Modem;
+  (void)new Modem(_pppdata);
 
   // we also connect cmld_start to the beginConnect so that I can run
   // the dialer through a command line argument
   connect(this,SIGNAL(cmdl_start()),this,SLOT(beginConnect()));
 
 //  stats = new PPPStats;
 
   // KWin::setIcons(winId(), kapp->icon(), kapp->miniIcon());
 
   // constructor of con_win reads position from config file
-//  con_win = new ConWindow(0, "conw", this);
+  con_win = new ConWindow(_pppdata, 0, "conw", this);
   // KWin::setIcons(con_win->winId(), kapp->icon(), kapp->miniIcon());
 
 //  statdlg = new PPPStatsDlg(0, "stats", this, stats);
 //  statdlg->hide();
 
   // load up the accounts combo box
 
 //  resetaccounts();
-//  con = new ConnectWidget(0, "con");
+  con = new ConnectWidget(_pppdata, 0, "con");
   //KWin::setIcons(con->winId(), kapp->icon(), kapp->miniIcon() );
-//  connect(this, SIGNAL(begin_connect()),con, SLOT(preinit()));
+ connect(this, SIGNAL(begin_connect()),con, SLOT(preinit()));
   // Is this the best we can do here?  it's not right.
 //   QRect desk = QApplication::desktop()->screenGeometry(
 //                QApplication::desktop()->screenNumber(topLevelWidget()));
 //   con->setGeometry(desk.center().x()-175, desk.center().y()-55, 350,110);
 
   // connect the ConnectWidgets various signals
-// //   connect(con, SIGNAL(startAccounting()),
-        // //   this, SLOT(startAccounting()));
-// //   connect(con, SIGNAL(stopAccounting()),
-        // //   this, SLOT(stopAccounting()));
-//   connect(qApp, SIGNAL(saveYourself()),
-        //   this, SLOT(saveMyself()));
-//   connect(qApp, SIGNAL(shutDown()),
-        //   this, SLOT(shutDown()));
+  connect(con, SIGNAL(startAccounting()),
+          this, SLOT(startAccounting()));
+  connect(con, SIGNAL(stopAccounting()),
+          this, SLOT(stopAccounting()));
+  connect(qApp, SIGNAL(saveYourself()),
+          this, SLOT(saveMyself()));
+  connect(qApp, SIGNAL(shutDown()),
+          this, SLOT(shutDown()));
 
 
 //   KCmdLineArgs *args = KCmdLineArgs::parsedArgs();
 
 //   m_strCmdlAccount = args->getOption("c");
 //   m_bQuitOnDisconnect = args->isSet("q");
@@ -271,13 +280,13 @@ KPPPWidget::KPPPWidget( QWidget *parent, const char *name, bool modal, WFlags fl
 //   if(!m_strCmdlAccount.isEmpty()) {
 //     m_bCmdlAccount = true;
 //     kdDebug(5002) << "cmdl_account: " << m_bCmdlAccount << endl;
 //   }
 
 //   if(m_bCmdlAccount){
-//     bool result = PPPData::data()->setAccount(m_strCmdlAccount);
+//     bool result = _pppdata->setAccount(m_strCmdlAccount);
 //     if (!result){
 //       QString string;
 //       string = i18n("No such Account:\n%1").arg(m_strCmdlAccount);
 //       KMessageBox::error(this, string);
 //       m_bCmdlAccount = false;
 //       this->show();
@@ -343,62 +352,62 @@ void KPPPWidget::enterPressedInID() {
 void KPPPWidget::enterPressedInPW() {
   connect_b->setFocus();
 }
 
 // triggered by the session manager
 void KPPPWidget::saveMyself() {
-    PPPData::data()->save();
+    _pppdata->save();
 }
 
 void KPPPWidget::shutDown() {
     interruptConnection();
     saveMyself();
 }
 
 void KPPPWidget::log_window_toggled(bool on) {
-  PPPData::data()->set_show_log_window(on);
+  _pppdata->set_show_log_window(on);
 }
 
 
 
 
 // void KPPPWidget::resetaccounts() {
 //   connectto_c->clear();
 
-//   int count = PPPData::data()->count();
+//   int count = _pppdata->count();
 
 //   // enable/disable controls
 //   connectto_c->setEnabled(count > 0);
 //   connect_b->setEnabled(count > 0);
 //   log->setEnabled(count > 0);
 //   ID_Edit->setEnabled(count > 0);
 //   PW_Edit->setEnabled(count > 0);
 
 //   //load the accounts
 //   for(int i=0; i < count; i++) {
-//     PPPData::data()->setAccountbyIndex(i);
-//      connectto_c->insertItem(PPPData::data()->accname());
+//     _pppdata->setAccountbyIndex(i);
+//      connectto_c->insertItem(_pppdata->accname());
 //   }
 
 //   //set the default account
-//   if(!PPPData::data()->defaultAccount().isEmpty()) {
+//   if(!_pppdata->defaultAccount().isEmpty()) {
 //     for(int i=0; i < count; i++)
-//        if(PPPData::data()->defaultAccount() == connectto_c->text(i)) {
+//        if(_pppdata->defaultAccount() == connectto_c->text(i)) {
         //  connectto_c->setCurrentItem(i);
-        // PPPData::data()->setAccountbyIndex(i);
+        // _pppdata->setAccountbyIndex(i);
 
-        // ID_Edit->setText(PPPData::data()->storedUsername());
-        // PW_Edit->setText(PPPData::data()->storedPassword());
+        // ID_Edit->setText(_pppdata->storedUsername());
+        // PW_Edit->setText(_pppdata->storedPassword());
 //     }
 //   }
 //   else
 //     if(count > 0) {
-//        PPPData::data()->setDefaultAccount(connectto_c->text(0));
-//         PPPData::data()->save();
-        // ID_Edit->setText(PPPData::data()->storedUsername());
-        // PW_Edit->setText(PPPData::data()->storedPassword());
+//        _pppdata->setDefaultAccount(connectto_c->text(0));
+//         _pppdata->save();
+        // ID_Edit->setText(_pppdata->storedUsername());
+        // PW_Edit->setText(_pppdata->storedPassword());
 //     }
 
 //   connect(ID_Edit, SIGNAL(textChanged(const QString &)),
         //    this, SLOT(usernameChanged(const QString &)));
 
 //   connect(PW_Edit, SIGNAL(textChanged(const QString &)),
@@ -410,69 +419,72 @@ void KPPPWidget::log_window_toggled(bool on) {
 //       PW_Edit->setFocus();
 // }
 
 
 void KPPPWidget::interruptConnection() {
   // interrupt dial up
-//   if (con->isVisible())
-//     emit con->cancelbutton();
+//
+
+    if (con->isVisible())
+     emit con->cancelbutton();
 
   // disconnect if online
-  if (PPPData::data()->pppdRunning())
+  if (_pppdata->pppdRunning())
     emit disconnect();
 }
 
 
 void KPPPWidget::sigPPPDDied() {
     qDebug( "Received a SIGUSR1" );
 
     // if we are not connected pppdpid is -1 so have have to check for that
     // in the followin line to make sure that we don't raise a false alarm
     // such as would be the case when the log file viewer exits.
-    if(PPPData::data()->pppdRunning() || PPPData::data()->pppdError()) {
+    if(_pppdata->pppdRunning() || _pppdata->pppdError()) {
         qDebug( "It was pppd that died" );
 
         // when we killpppd() on Cancel in ConnectWidget
         // we set pppid to -1 so we won't
         // enter this block
 
         // just to be sure
 
         Modem::modem->removeSecret(AUTH_PAP);
         Modem::modem->removeSecret(AUTH_CHAP);
 
-        PPPData::data()->setpppdRunning(false);
+        _pppdata->setpppdRunning(false);
 
         qDebug( "Executing command on disconnect since pppd has died." );
         QApplication::flushX();
-        execute_command(PPPData::data()->command_on_disconnect());
+        execute_command(_pppdata->command_on_disconnect());
 
 //      stopAccounting();
 
-//        con_win->stopClock();
+        con_win->stopClock();
 //       DockWidget::dock_widget->stop_stats();
 //       DockWidget::dock_widget->hide();
 
-        if(!PPPData::data()->pppdError())
-            PPPData::data()->setpppdError(E_PPPD_DIED);
+        if(!_pppdata->pppdError())
+            _pppdata->setpppdError(E_PPPD_DIED);
         removedns();
         Modem::modem->unlockdevice();
-        //      con->pppdDied();
+        //
+        con->pppdDied();
 
-        if(!PPPData::data()->automatic_redial()) {
+        if(!_pppdata->automatic_redial()) {
             quit_b->setFocus();
             show();
-//            con_win->stopClock();
+            con_win->stopClock();
         //stopAccounting();
-//            con_win->hide();
-//            con->hide();
+            con_win->hide();
+            con->hide();
 
-            PPPData::data()->setpppdRunning(false);
+            _pppdata->setpppdRunning(false);
             // // not in a signal handler !!!  KNotifyClient::beep();
             QString msg;
-            if (PPPData::data()->pppdError() == E_IF_TIMEOUT)
+            if (_pppdata->pppdError() == E_IF_TIMEOUT)
                 msg = i18n("Timeout expired while waiting for the PPP interface "
                            "to come up!");
             else {
                 msg = i18n("<p>The pppd daemon died unexpectedly!</p>");
                 Modem::modem->pppdExitStatus();
                         if (Modem::modem->lastStatus != 99) {// more recent pppds only
@@ -487,28 +499,28 @@ void KPPPWidget::sigPPPDDied() {
         // if(QMessageBox::warning(0, msg, i18n("Error"), i18n("&OK"), i18n("&Details...")) == QMessageBox::No)
         // //  PPPL_ShowLog();
 //       } else { /* reconnect on disconnect */
             if (false){
                 qDebug( "Trying to reconnect... " );
 
-                if(PPPData::data()->authMethod() == AUTH_PAP ||
-                   PPPData::data()->authMethod() == AUTH_CHAP ||
-                   PPPData::data()->authMethod() == AUTH_PAPCHAP)
-                    Modem::modem->setSecret(PPPData::data()->authMethod(),
-                                            encodeWord(PPPData::data()->storedUsername()),
-                                            encodeWord(PPPData::data()->password()));
+                if(_pppdata->authMethod() == AUTH_PAP ||
+                   _pppdata->authMethod() == AUTH_CHAP ||
+                   _pppdata->authMethod() == AUTH_PAPCHAP)
+                    Modem::modem->setSecret(_pppdata->authMethod(),
+                                            encodeWord(_pppdata->storedUsername()),
+                                            encodeWord(_pppdata->password()));
 
-//                con_win->hide();
-                //               con_win->stopClock();
+                con_win->hide();
+                               con_win->stopClock();
         //stopAccounting();
-                PPPData::data()->setpppdRunning(false);
+                _pppdata->setpppdRunning(false);
                         // not in a signal handler !!!KNotifyClient::beep();
                 emit cmdl_start();
             }
         }
-        PPPData::data()->setpppdError(0);
+        _pppdata->setpppdError(0);
     }
 }
 
 // void KPPPWidget::sigChld() {
 //   qDebug( "sigchld()" );
 //   //  pid_t id = wait(0L);
@@ -523,29 +535,29 @@ void KPPPWidget::sigPPPDDied() {
 //     exit(1);
 //     //  }
 // }
 
 
 void KPPPWidget::newdefaultaccount(int i) {
-  PPPData::data()->setDefaultAccount(connectto_c->text(i));
-  PPPData::data()->save();
-  ID_Edit->setText(PPPData::data()->storedUsername());
-  PW_Edit->setText(PPPData::data()->storedPassword());
+  _pppdata->setDefaultAccount(connectto_c->text(i));
+  _pppdata->save();
+  ID_Edit->setText(_pppdata->storedUsername());
+  PW_Edit->setText(_pppdata->storedPassword());
 }
 
 
 
 
 void KPPPWidget::beginConnect() {
   // make sure to connect to the account that is selected in the combo box
   // (exeption: an account given by a command line argument)
  //  if(!m_bCmdlAccount) {
-//     PPPData::data()->setAccount(connectto_c->currentText());
-//     PPPData::data()->setPassword(PW_Edit->text());
+//     _pppdata->setAccount(connectto_c->currentText());
+//     _pppdata->setPassword(PW_Edit->text());
 //   } else {
-    PPPData::data()->setPassword(PPPData::data()->storedPassword());
+    _pppdata->setPassword(_pppdata->storedPassword());
 //  }
 
   QFileInfo info(pppdPath());
 
   if(!info.exists()){
     QMessageBox::warning(this, "error", i18n("Cannot find the PPP daemon!\n"
@@ -557,114 +569,111 @@ void KPPPWidget::beginConnect() {
   if(!info.isExecutable()){
 
     QString string;
     string = i18n("kppp cannot execute:\n %1\n"
                    "Please make sure that you have given kppp "
                    "setuid permission and that "
-                   "pppd is executable.").arg(PPPData::data()->pppdPath());
+                   "pppd is executable.").arg(_pppdata->pppdPath());
     KMessageBox::error(this, string);
     return;
 
   }
 #endif
 
-  QFileInfo info2(PPPData::data()->modemDevice());
+  QFileInfo info2(_pppdata->modemDevice());
 
   if(!info2.exists()){
     QString string;
     string = i18n("kppp can not find:\n %1\nPlease make sure you have setup "
                    "your modem device properly "
                    "and/or adjust the location of the modem device on "
                    "the modem tab of "
-                   "the setup dialog.").arg(PPPData::data()->modemDevice());
+                   "the setup dialog.").arg(_pppdata->modemDevice());
     QMessageBox::warning(this, "error", string);
     return;
   }
 
   // if this is a PAP or CHAP account, ensure that username is
   // supplied
-  if(PPPData::data()->authMethod() == AUTH_PAP ||
-     PPPData::data()->authMethod() == AUTH_CHAP ||
-     PPPData::data()->authMethod() == AUTH_PAPCHAP ) {
+  if(_pppdata->authMethod() == AUTH_PAP ||
+     _pppdata->authMethod() == AUTH_CHAP ||
+     _pppdata->authMethod() == AUTH_PAPCHAP ) {
     if(ID_Edit->text().isEmpty()) {
         QMessageBox::warning(this,"error",
-                           i18n(
-                           "You have selected the authentication "
-                           "method PAP or CHAP. This requires that you "
-                           "supply a username and a password!"));
-      return;
+                           i18n("You have selected the authentication method PAP or CHAP. This requires that you supply a username and a password!"));
+// FIXME:      return;
     } else {
-      if(!Modem::modem->setSecret(PPPData::data()->authMethod(),
-                                   encodeWord(PPPData::data()->storedUsername()),
-                                   encodeWord(PPPData::data()->password()))) {
+      if(!Modem::modem->setSecret(_pppdata->authMethod(),
+                                   encodeWord(_pppdata->storedUsername()),
+                                   encodeWord(_pppdata->password()))) {
         QString s;
         s = i18n("Cannot create PAP/CHAP authentication\n"
                                      "file \"%1\"").arg(PAP_AUTH_FILE);
         QMessageBox::warning(this, "error", s);
         return;
       }
     }
   }
 
-  if (PPPData::data()->phonenumber().isEmpty()) {
+  if (_pppdata->phonenumber().isEmpty()) {
     QString s = i18n("You must specify a telephone number!");
     QMessageBox::warning(this, "error", s);
     return;
   }
 
   this->hide();
 
-  QString tit = i18n("Connecting to: %1").arg(PPPData::data()->accname());
+  QString tit = i18n("Connecting to: %1").arg(_pppdata->accname());
 //   con->setCaption(tit);
 
 //   con->show();
 
 
   emit begin_connect();
 }
 
 
 void KPPPWidget::disconnect() {
-  if (!PPPData::data()->command_before_disconnect().isEmpty()) {
-//     con_win->hide();
-//     con->show();
-//     con->setCaption(i18n("Disconnecting..."));
-//     con->setMsg(i18n("Executing command before disconnection."));
+  if (!_pppdata->command_before_disconnect().isEmpty()) {
+     con_win->hide();
+     con->show();
+     con->setCaption(i18n("Disconnecting..."));
+     con->setMsg(i18n("Executing command before disconnection."));
 
     qApp->processEvents();
     QApplication::flushX();
 //    pid_t id =
-        execute_command(PPPData::data()->command_before_disconnect());
+        execute_command(_pppdata->command_before_disconnect());
 //    int i, status;
 
 //     do {
 //       kapp->processEvents();
 //       i = waitpid(id, &status, WNOHANG);
 //       usleep(500000);
 //     } while (i == 0 && errno == 0);
 
-//    con->hide();
+    con->hide();
   }
 
   qApp->processEvents();
 
 //  statdlg->stop_stats();
   Modem::modem->killPPPDaemon();
 
   QApplication::flushX();
-  execute_command(PPPData::data()->command_on_disconnect());
+  execute_command(_pppdata->command_on_disconnect());
 
   Modem::modem->removeSecret(AUTH_PAP);
   Modem::modem->removeSecret(AUTH_CHAP);
 
   removedns();
   Modem::modem->unlockdevice();
 
-//  con_win->stopClock();
+  con_win->stopClock();
 //  p_kppp->stopAccounting();
-//  con_win->hide();
+  con_win->hide();
 
 //   DockWidget::dock_widget->stop_stats();
 //   DockWidget::dock_widget->hide();
 
 //   if(m_bQuitOnDisconnect)
 //     kapp->exit(0);
@@ -678,28 +687,28 @@ void KPPPWidget::disconnect() {
 // void KPPPWidget::helpbutton() {
 //   kapp->invokeHelp();
 // }
 
 
 void KPPPWidget::quitbutton() {
-  if(PPPData::data()->pppdRunning()) {
+  if(_pppdata->pppdRunning()) {
     int ok = QMessageBox::warning(this,
                             i18n("Exiting kPPP will close your PPP Session."),
                             i18n("Quit kPPP?"));
     if(ok == QMessageBox::Yes) {
       Modem::modem->killPPPDaemon();
       QApplication::flushX();
-      execute_command(PPPData::data()->command_on_disconnect());
+      execute_command(_pppdata->command_on_disconnect());
       removedns();
       Modem::modem->unlockdevice();
     }
   } else {
-    if (!PPPData::data()->accname().isEmpty() && !PPPData::data()->storePassword())
-      PPPData::data()->setStoredPassword("");
+    if (!_pppdata->accname().isEmpty() && !_pppdata->storePassword())
+      _pppdata->setStoredPassword("");
   }
-  PPPData::data()->save();
+  _pppdata->save();
   qApp->quit();
 }
 
 
 // void KPPPWidget::rulesetLoadError() {
 //   QMessageBox::warning(this,"error", ruleset_load_errmsg);
@@ -707,31 +716,31 @@ void KPPPWidget::quitbutton() {
 
 
 // void KPPPWidget::startAccounting() {
 //   // volume accounting
 //   stats->totalbytes = 0;
 
-//   kdDebug() << "AcctEnabled: " << PPPData::data()->AcctEnabled() << endl;
+//   kdDebug() << "AcctEnabled: " << _pppdata->AcctEnabled() << endl;
 
 //   // load the ruleset
-//   if(!PPPData::data()->AcctEnabled())
+//   if(!_pppdata->AcctEnabled())
 //     return;
 
-//   QString d = AccountingBase::getAccountingFile(PPPData::data()->accountingFile());
+//   QString d = AccountingBase::getAccountingFile(_pppdata->accountingFile());
 //   //  if(::access(d.data(), X_OK) != 0)
 //     acct = new Accounting(this, stats);
 //     //  else
 //     //    acct = new ExecutableAccounting(this);
 
 //   // connect to the accounting object
 //   connect(acct, SIGNAL(changed(QString, QString)),
         //   con_win, SLOT(slotAccounting(QString, QString)));
 
-// //   if(!acct->loadRuleSet(PPPData::data()->accountingFile())) {
+// //   if(!acct->loadRuleSet(_pppdata->accountingFile())) {
 // //     QString s= i18n("Can not load the accounting "
-        // //               "ruleset \"%1\"!").arg(PPPData::data()->accountingFile());
+        // //               "ruleset \"%1\"!").arg(_pppdata->accountingFile());
 
 //     // starting the messagebox with a timer will prevent us
 //     // from blocking the calling function ConnectWidget::timerEvent
 //     ruleset_load_errmsg = s;
 //     QTimer::singleShot(0, this, SLOT(rulesetLoadError()));
 //     return;
@@ -740,15 +749,15 @@ void KPPPWidget::quitbutton() {
 // //    acct->slotStart();
 // }
 
 // void KPPPWidget::stopAccounting() {
 //   // store volume accounting
 // //   if(stats->totalbytes != 0)
-// //     PPPData::data()->setTotalBytes(stats->totalbytes);
+// //     _pppdata->setTotalBytes(stats->totalbytes);
 
-//   if(!PPPData::data()->AcctEnabled())
+//   if(!_pppdata->AcctEnabled())
 //     return;
 
 // //   if(acct != 0) {
 // //     acct->slotStop();
 // //     delete acct;
 // //     acct = 0;
@@ -763,22 +772,22 @@ void KPPPWidget::quitbutton() {
 //   }
 // }
 
 
 void KPPPWidget::usernameChanged(const QString &) {
   // store username for later use
-  PPPData::data()->setStoredUsername(ID_Edit->text());
+  _pppdata->setStoredUsername(ID_Edit->text());
 }
 
 
 void KPPPWidget::passwordChanged(const QString &) {
     // store the password if so requested
-  if(PPPData::data()->storePassword())
-    PPPData::data()->setStoredPassword(PW_Edit->text());
+  if(_pppdata->storePassword())
+    _pppdata->setStoredPassword(PW_Edit->text());
   else
-    PPPData::data()->setStoredPassword("");
+    _pppdata->setStoredPassword("");
 }
 
 
 void KPPPWidget::setPW_Edit(const QString &pw) {
   PW_Edit->setText(pw);
 }
@@ -812,13 +821,13 @@ QString KPPPWidget::encodeWord(const QString &s) {
 void KPPPWidget::showNews() {
 #ifdef KPPP_SHOW_NEWS
   /*
    * Introduce the QuickHelp feature to new users of this version
    */
   #define QUICKHELP_HINT "Hint_QuickHelp"
-  if(PPPData::data()->readNumConfig(GENERAL_GRP, QUICKHELP_HINT, 0) == 0) {
+  if(_pppdata->readNumConfig(GENERAL_GRP, QUICKHELP_HINT, 0) == 0) {
     QDialog dlg(0, 0, true);
     dlg.setCaption(i18n("Recent Changes in KPPP"));
 
     QVBoxLayout *tl = new QVBoxLayout(&dlg, 10, 10);
     QHBoxLayout *l1 = new QHBoxLayout(10);
     QVBoxLayout *l2 = new QVBoxLayout(10);
@@ -864,14 +873,14 @@ void KPPPWidget::showNews() {
 
     QWhatsThis::add(cb,tmp);
     QWhatsThis::add(l, tmp);
 
     dlg.exec();
     if(cb->isChecked()) {
-      PPPData::data()->writeConfig(GENERAL_GRP, QUICKHELP_HINT, 1);
-      PPPData::data()->save();
+      _pppdata->writeConfig(GENERAL_GRP, QUICKHELP_HINT, 1);
+      _pppdata->save();
     }
   }
 #endif
 }