1 files changed, 121 insertions, 67 deletions

diff --git a/noncore/settings/networksettings2/editconnection.cpp b/noncore/settings/networksettings2/editconnection.cpp
index 77826d1..3f8a53f 100644
--- a/noncore/settings/networksettings2/editconnection.cpp
+++ b/noncore/settings/networksettings2/editconnection.cpp
@@ -1,12 +1,13 @@
+#include <opie2/odebug.h>
 #include <qlistview.h>
 #include <qwidgetstack.h>
 #include <qframe.h>
 #include <qcombobox.h>
 #include <qtabwidget.h>
 #include <qmessagebox.h>
 #include <qpushbutton.h>
 #include <qlineedit.h>
 #include <qheader.h>
 #include <qpainter.h>
 #include <qcheckbox.h>
 #include <qlabel.h>
@@ -22,24 +23,31 @@
 //
 
 class MyQCheckListItem : public QCheckListItem
 {
 public:
     MyQCheckListItem( QListView *parent, const QString & S, Type T ) :
       QCheckListItem( parent, S, T ) { }
     MyQCheckListItem( QCheckListItem *parent, const QString & S, Type T ) :
       QCheckListItem( parent, S, T ) { }
     MyQCheckListItem( QListViewItem *parent, const QString & S, Type T ) :
       QCheckListItem( parent, S, T ) { }
 
+    MyQCheckListItem( QListView *parent, const QString & S ) :
+      QCheckListItem( parent, S, QCheckListItem::Controller ) { }
+    MyQCheckListItem( QCheckListItem *parent, const QString & S ) :
+      QCheckListItem( parent, S, QCheckListItem::Controller ) { }
+    MyQCheckListItem( QListViewItem *parent, const QString & S ) :
+      QCheckListItem( parent, S, QCheckListItem::Controller ) { }
+
     virtual void paintCell( QPainter *p, const QColorGroup &cg,
                             int column, int width, int alignment );
 
 };
 
 void MyQCheckListItem::paintCell( QPainter *p, const QColorGroup &cg,
                                  int column, int width, int alignment )
 {
     QColorGroup _cg( cg );
     QColor c = _cg.text();
     if ( ! isSelectable() )
         _cg.setColor( QColorGroup::Text, Qt::lightGray );
@@ -107,66 +115,88 @@ NodeCollection * EditConnection::getTmpCollection( void ) {
       for( QListIterator<ANetNodeInstance> it(TmpCollection);
            it.current();
            ++it ) {
         if( it.current()->isNew() ) {
           delete it.current();
         }
       }
       TmpCollection.clear();
 
       // update content
       QListViewItem * it = Nodes_LV->firstChild();
       ANetNode * NN;
-      // start iter
+
+      // start iter (if there is a collection)
+      /*
+
+          a node collection is sorted from the toplevel
+          node to the deepest node
+
+      */
       ANetNodeInstance * NNI = 
         (SelectedNodes) ? SelectedNodes->first() : 0 ;
 
       TmpCollection.setModified( 0 );
 
+      // the listview always starts with the toplevel 
+      // hierarchy.  This is always a controller item
       while ( it ) {
         NN = (*Mapping)[it];
         if( NN == 0 ) {
-          // child is controller -> has sub radio
-          // check if one radio is selected
+          // this item is a controller -> 
+          // has radio items as children -> 
+          // find selected one 
           it = it->firstChild();
           while( it ) {
             if( ((QCheckListItem *)it)->isOn() ) {
               // this radio is selected -> go deeper
-              if( SelectedNodes == 0 || 
-                  NNI == 0 ||
-                  it->text(0) != NNI->nodeClass()->name() ) {
-                // new item not in previous collection
-                ANetNodeInstance * NNI = (*Mapping)[it]->createInstance();
-                NNI->initialize();
-                // this node type not in collection
-                TmpCollection.append( NNI );
-                // master collection changed because new item in it
-                TmpCollection.setModified( 1 );
-                // no more valid items in old list
-                NNI = 0;
-              } else {
-                // already in list -> copy pointer
-                TmpCollection.append( NNI );
-                NNI = SelectedNodes->next();
-              }
-              it = it->firstChild();
-              // do not bother to check other items
               break;
             }
             it = it->nextSibling();
           }
+
+          if( ! it ) {
+            owarn  << "Radio not selected" << oendl;
+            TmpIsValid = 0;
+            return 0;
+          }
+
+          // it now contains selected radio
+          NN = (*Mapping)[it];
+        }
+
+        // NN here contains the netnode of the
+        // current item -> this node needs to
+        // be stored in the collection
+        if( NNI == 0 ||
+            it->text(0) != NNI->nodeClass()->name() ) {
+          // new item not in previous collection
+          ANetNodeInstance * NNI = NN->createInstance();
+          NNI->initialize();
+          // this node type not in collection
+          TmpCollection.append( NNI );
+          // master collection changed because new item in it
+          TmpCollection.setModified( 1 );
+          // no more valid items in old list
+          NNI = 0;
         } else {
-          // check children
-          it = it->firstChild();
+          // already in list -> copy pointer
+          TmpCollection.append( NNI );
+          NNI = SelectedNodes->next();
         }
+
+        // go deeper to next level
+        // this level is can be a new controller
+        // or an item
+        it = it->firstChild();
       }
 
       TmpIsValid = 1;
       return &(TmpCollection);
 }
 
 // pass a connection NodeCollection to be edited
 void EditConnection::setConnection( NodeCollection * NC ) {
       ANetNodeInstance * NNI;
       ANetNode * NN;
 
       SelectedNodes = NC;
@@ -178,58 +208,78 @@ void EditConnection::setConnection( NodeCollection * NC ) {
 
       // valid colledction
       Tab_TB->setTabEnabled( Setup_FRM, FALSE );
       Setup_FRM->setEnabled( FALSE );
 
       // select items in collection
       QListViewItem * it = Nodes_LV->firstChild();
       bool Found;
 
       TmpIsValid = 0;
 
       while ( it ) {
-        // listitem corresponds to netnode 
         NN = (*Mapping)[it];
         if( NN == 0 ) {
-          // child is controller -> has sub radio
-          QString Ctr = it->text(0);
-          // check if one radio is selected
+          // this item is a controller -> 
+          // has radio items as children -> 
+          // find selected one 
           it = it->firstChild();
           Found = 0;
           while( it ) {
             if( NNI && it->text(0) == NNI->nodeClass()->name() ) {
               // this radio is part of the collection
               ((QCheckListItem *)it)->setOn( 1 );
               updateGUI( it, NNI->nodeClass() );
               // check its children
               Found = 1;
               it = it->firstChild();
               NNI = SelectedNodes->next();
               // do not bother to check other items
               break;
             }
             it = it->nextSibling();
           }
+
           if( ! Found ) {
             // this means that this level is NOT present in collection
             // probably INCOMPATIBEL collection OR Missing plugin
             QMessageBox::warning(
                 0, 
                 tr( "Error presentig Connection" ),
                 tr( "<p>Old connection or missing plugin \"<i>%1</i>\"</p>" ).
-                    arg(Ctr) );
+                    arg(NNI->nodeClass()->name()) );
             return;
           }
+
+          // it now contains selected radio
+          NN = (*Mapping)[it];
         } else {
-          // automatic item -> check children
+          // automatic selection 
+          if( NNI == 0 ||  it->text(0) != NNI->nodeClass()->name() ) {
+            // should exist and be the same
+            if( NNI ) {
+              QMessageBox::warning(
+                  0, 
+                  tr( "Error presentig Connection" ),
+                  tr( "<p>Old connection or missing plugin \"<i>%1</i>\"</p>" ).
+                      arg(NNI->nodeClass()->name()) );
+            } else {
+              QMessageBox::warning(
+                  0, 
+                  tr( "Error presentig Connection" ),
+                  tr( "<p>Missing connection\"<i>%1</i>\"</p>" ).
+                      arg(it->text(0)) );
+            }
+            return;
+          }
           it = it->firstChild();
         }
       }
 }
 
 // get result of editing (either new OR updated collection
 NodeCollection * EditConnection::connection( void ) {
 
       if( SelectedNodes == 0 ) {
         // new collection 
         SelectedNodes = new NodeCollection;
       }
@@ -260,55 +310,57 @@ void EditConnection::buildFullTree( void ) {
     ANetNode * NN;
 
     // toplevel item
     MyQCheckListItem * TheTop = new MyQCheckListItem( 
         Nodes_LV, 
         NSResources->netNode2Name("fullsetup"),
         QCheckListItem::Controller );
     TheTop->setOpen( TRUE );
     Description_LBL->setText( 
           NSResources->netNode2Description( "fullsetup" ) );
     Nodes_LV->setSelected( TheTop, TRUE );
 
-    // find all Nodes that care toplevel nodes -> ie provide
+    // find all Nodes that are toplevel nodes -> ie provide
     // TCP/IP Connection
     for( QDictIterator<NetNode_t> Iter(NSResources->netNodes());
          Iter.current();
          ++Iter ) {
 
       NN = Iter.current()->NetNode;
 
       if( ! NN->isToplevel() ) {
         continue;
       }
 
       MyQCheckListItem * it = new MyQCheckListItem( TheTop, 
           NN->name(), 
           QCheckListItem::RadioButton );
-      it->setPixmap( 0, NSResources->getPixmap( "Devices/commprofile" ) );
+      it->setPixmap( 0, 
+                     NSResources->getPixmap( NN->pixmapName() )
+                   );
       // remember that this node maps to this listitem
       Mapping->insert( it, NN );
       buildSubTree( it, NN );
     }
 }
 
 // Build device tree -> help function 
 void EditConnection::buildSubTree( QListViewItem * it, ANetNode *NN ) {
     ANetNode::NetNodeList & NNL = NN->alternatives();
 
     if( NNL.size() > 1 ) {
       // this node has alternatives -> needs radio buttons
       it = new MyQCheckListItem( 
         it, 
-        NSResources->netNode2Name(NNL[0]->provides()),
+        NSResources->netNode2Name(NN->needs()[0]),
         QCheckListItem::Controller );
       it->setSelectable( FALSE );
     }
 
     for ( unsigned int i=0; i < NNL.size(); i++ ) {
       QListViewItem * CI;
       if( NNL.size() > 1 ) {
         // generate radio buttons
         CI = new MyQCheckListItem( 
                 (QCheckListItem *)it, 
                 NNL[i]->name(), QCheckListItem::RadioButton );
         // remember that this node maps to this listitem
@@ -378,28 +430,29 @@ void EditConnection::SLOT_SelectNode( QListViewItem * it ) {
     if( it == 0 || it->depth() == 0 ) {
       Description_LBL->setText( 
           NSResources->netNode2Description( "fullsetup" ) );
       // topevel or no selection
       return;
     }
 
     // store conversion from lvitem to node
     NN = (*Mapping)[ it ];
 
     if( ! NN ) {
       // intermediate node
-      NN = (*Mapping)[ it->firstChild() ];
+      NN = (*Mapping)[ it->parent() ];
       if( NN ) {
         // figure out type of this node -> produce mesage
-        Description_LBL->setText( NSResources->netNode2Description(NN->provides()) );
+        Description_LBL->setText( NSResources->netNode2Description(
+                                  NN->needs()[0]) );
       } else {
         Description_LBL->setText( "" );
       }
       return;
     }
 
     Description_LBL->setText( NN->nodeDescription() );
 
     if( ! it->isSelectable() ) {
       return;
     }
 
@@ -530,48 +583,49 @@ void EditConnection::enablePath( QListViewItem * it, bool pha ) {
       } else {
         // controller node
         it->setSelectable( TRUE );
         it->setOpen( TRUE );
         enablePath( it->firstChild(), pha );
       }
       it = it->nextSibling();
     }
 }
 
 // do we have a complete configuration (all needs are provided for ?)
 bool EditConnection::haveCompleteConfig( QListViewItem * it ) {
-    if( it == 0 || ((QCheckListItem *)it)->isOn() ) {
-      // check children
-      it = (it) ? it->firstChild() : Nodes_LV->firstChild() ;
-      while ( it ) {
-        if( ((QCheckListItem *)it)->type() == 
-            QCheckListItem::Controller ) {
-          // child is controller -> has sub radio
-          // check if one radio is selected
-          it = it->firstChild();
-          while( it ) {
-            if( ((QCheckListItem *)it)->isOn() ) {
-              // this radio is selected -> go deeper
-              it = it->firstChild();
-              if( ! it ) {
-                // was deepest level
-                return 1;
-              }
-              // do not bother to check other items
-              break;
-            }
-            it = it->nextSibling();
-          }
-          if( ! it ) {
-            // no radio selected
-            return 0;
+
+    // check if all below this level is selected
+    it = ( it ) ?it : Nodes_LV->firstChild();
+    ANetNode *NN;
+    bool Found;
+
+    while ( it ) {
+      NN = (*Mapping)[it];
+      if( NN == 0 ) {
+        // this item is a controller -> 
+        // has radio items as children -> 
+        // find selected one 
+        it = it->firstChild();
+        Found = 0;
+        while( it ) {
+          if( ((QCheckListItem *)it)->isOn() ) {
+            Found = 1;
+            // go deeper
+            it = it->firstChild();
+            break;
           }
-        } else {
-          // check children
-          it = it->firstChild();
+          it = it->nextSibling();
         }
+
+        if( ! Found ) {
+          return 0; // no not complete -> a radio should have been chkd
+        }
+
+        // it now contains selected radio
+        NN = (*Mapping)[it];
+      } else {
+        // automatic selection 
+        it = it->firstChild();
       }
-      // deepest level -> all is still OK
-      return 1;
-    } // was not ON
-    return 0;
+    }
+    return 1;
 }