1 files changed, 16 insertions, 17 deletions

diff --git a/noncore/settings/networksettings2/network/networkrun.cpp b/noncore/settings/networksettings2/network/networkrun.cpp
index c17aa7f..2c93d9d 100644
--- a/noncore/settings/networksettings2/network/networkrun.cpp
+++ b/noncore/settings/networksettings2/network/networkrun.cpp
@@ -24,12 +24,15 @@ QString NetworkRun::setMyState( NodeCollection * NC, Action_t A, bool ) {
 
+    if( ! II ) {
+      Log(( "no interface assigned." ));
+      return QString();
+    }
+
+    QStringList SL;
+
     if( A == Up ) {
       // we can bring UP if lower level is available
-      QStringList SL;
-      SL << "ifup"
-         << QString().sprintf( "%s=%s-c%d-allowed",
-                        II->Name.latin1(), II->Name.latin1(),
-                        nodeCollection()->number() );
-      if( ! NSResources->system().runAsRoot( SL ) ) {
-        return QString("Cannot call %1").arg(SL.join(" "));
-      }
+      SL << "ifup";
+    } else if( A == Down ) {
+      SL << "ifdown";
+    } else {
       return QString();
@@ -37,7 +40,6 @@ QString NetworkRun::setMyState( NodeCollection * NC, Action_t A, bool ) {
 
-    if( A == Down ) {
-      QStringList SL;
-      if( II ) {
-        SL << "ifdown"
-           << II->Name.latin1();
+    SL << QString().sprintf( "%s=%s-c%d-allowed",
+                        II->Name.latin1(), II->Name.latin1(),
+                        nodeCollection()->number() );
+
         if( !  NSResources->system().runAsRoot( SL ) ) {
@@ -45,6 +47,3 @@ QString NetworkRun::setMyState( NodeCollection * NC, Action_t A, bool ) {
         }
-      } else {
-        Log(( "no interface assigned." ));
-      }
-    } 
+
     return QString();