1 files changed, 6 insertions, 3 deletions

diff --git a/noncore/settings/usermanager/userdialog.cpp b/noncore/settings/usermanager/userdialog.cpp
index 3654639..75a96a6 100644
--- a/noncore/settings/usermanager/userdialog.cpp
+++ b/noncore/settings/usermanager/userdialog.cpp
@@ -149,195 +149,198 @@ void UserDialog::setupTab1()
     if(vm==VIEWMODE_NEW)
     {
         vlayout1->addSpacing(5);
         vlayout1->addWidget(skelLabel);
     }
     // Second column, data
     vlayout2->addWidget(loginLineEdit);
     vlayout2->addSpacing(5);
     vlayout2->addWidget(uidLineEdit);
     vlayout2->addSpacing(5);
     vlayout2->addWidget(gecosLineEdit);
     vlayout2->addSpacing(5);
     vlayout2->addWidget(passwordLineEdit);
     vlayout2->addSpacing(5);
     vlayout2->addWidget(shellComboBox);
     vlayout2->addSpacing(5);
     vlayout2->addWidget(groupComboBox);
     if(vm==VIEWMODE_NEW)
     {
         vlayout2->addSpacing(5);
         vlayout2->addWidget(skelCheckBox);
     }
     hlayout->addLayout(vlayout1);
     hlayout->addLayout(vlayout2);
 
     myTabWidget->addTab(tabpage,"User Info");
 }
 
 /**
  *  Creates the second tab containing additional groups for the user.
  *
  */
 void UserDialog::setupTab2()
 {
     QWidget *tabpage = new QWidget(myTabWidget,"page2");
     QVBoxLayout *layout = new QVBoxLayout(tabpage);
     layout->setMargin(5);
 
     // Additional groups
     groupsListView=new QListView(tabpage,"groups");
     groupsListView->addColumn("Additional groups");
     groupsListView->setColumnWidthMode(0,QListView::Maximum);
     groupsListView->setMultiSelection(false);
     groupsListView->setAllColumnsShowFocus(false);
 
     layout->addSpacing(5);
     // Grouplist
     layout->addWidget(groupsListView);
 
     myTabWidget->addTab(tabpage,"User Groups");
 }
 
 /**
  * Static function that creates the userinfo dialog.
  * The user will be prompted to add a user.
  *
  * @param uid This is a suggested available UID.
  * @param gid This is a suggested available GID.
  *
  * @return <code>true</code> if the user was successfully added, otherwise <code>false</code>.
  *
  */
 bool UserDialog::addUser(int uid, int gid)
 {
     QCheckListItem *temp;
     QFile ozTest;
     int oz=false;
     if(ODevice::inst()->system()==System_OpenZaurus) oz=true;
     // viewmode is a workaround for a bug in qte-2.3.4 that gives bus error on manipulating adduserDialog's widgets here.
     UserDialog *adduserDialog=new UserDialog(VIEWMODE_NEW);
     adduserDialog->setCaption(tr("Add User"));
     adduserDialog->userID=uid;    // Set next available UID as default uid.
     adduserDialog->groupID=gid;    // Set next available GID as default gid.
     // Insert default group into groupComboBox
     adduserDialog->groupComboBox->insertItem("<create new group>",0);
     adduserDialog->uidLineEdit->setText(QString::number(uid));
     // If we're running on OZ, add new users to some default groups.
     if(oz)
     {
         QListViewItemIterator iter( adduserDialog->groupsListView );
         for ( ; iter.current(); ++iter )
         {
             temp=(QCheckListItem*)iter.current();
             if (temp->text()=="video") temp->setOn(true);
             if (temp->text()=="audio") temp->setOn(true);
             if (temp->text()=="time") temp->setOn(true);
             if (temp->text()=="power") temp->setOn(true);
             if (temp->text()=="input") temp->setOn(true);
             if (temp->text()=="sharp") temp->setOn(true);
             if (temp->text()=="tty") temp->setOn(true);
         }
     }
     // Show the dialog!
     if(!(adduserDialog->exec())) return false;
     if((adduserDialog->groupComboBox->currentItem()!=0))
     {
-        accounts->findGroup(adduserDialog->groupComboBox->currentText());
-        adduserDialog->groupID=accounts->gr_gid;
-        owarn << QString::number(accounts->gr_gid) << oendl; 
+        // making the call findGroup() puts the group info in the accounts gr_gid
+        if (accounts->findGroup(adduserDialog->groupComboBox->currentText()))
+        {
+            adduserDialog->groupID=accounts->gr_gid;
+            owarn << QString::number(accounts->gr_gid) << oendl;
+        }
     }
     if(!(accounts->addUser(adduserDialog->loginLineEdit->text(), adduserDialog->passwordLineEdit->text(),
                            adduserDialog->uidLineEdit->text().toInt(), adduserDialog->groupID, adduserDialog->gecosLineEdit->text(),
                            QString("/home/")+adduserDialog->loginLineEdit->text() , adduserDialog->shellComboBox->currentText())))
     {
         QMessageBox::information(0,"Ooops!","Something went wrong!\nUnable to add user.");
         return false;
     }
 
     // Add User to additional groups.
     QListViewItemIterator it( adduserDialog->groupsListView );
     for ( ; it.current(); ++it )
     {
         temp=(QCheckListItem*)it.current();
         if (temp->isOn() )
             accounts->addGroupMember(it.current()->text(0),adduserDialog->loginLineEdit->text());
     }
     // Copy image to pics/users/
     if(!(adduserDialog->userImage.isNull()))
     {
         QDir d;
         if(!(d.exists(QPEApplication::qpeDir() + "pics/users")))
         {
             d.mkdir(QPEApplication::qpeDir() + "pics/users");
         }
         QString filename= QPEApplication::qpeDir()+"pics/users/"+accounts->pw_name+".png";
         //        adduserDialog->userImage=adduserDialog->userImage.smoothScale(48,48);
         adduserDialog->userImage.save(filename,"PNG");
     }
 
     // Should we copy the skeleton homedirectory /etc/skel to the user's homedirectory?
     accounts->findUser(adduserDialog->loginLineEdit->text());
     if(adduserDialog->skelCheckBox->isChecked())
     {
         QString command_cp;
         QString command_chown;
         command_cp.sprintf("cp -a /etc/skel/* %s/",accounts->pw_dir.latin1());
         system(command_cp);
 
         command_cp.sprintf("cp -a /etc/skel/.[!.]* %s/",accounts->pw_dir.latin1());    // Bug in busybox, ".*" includes parent directory, does this work as a workaround?
         system(command_cp);
 
         command_chown.sprintf("chown -R %d:%d %s",accounts->pw_uid,accounts->pw_gid,accounts->pw_dir.latin1());
         system(command_chown);
     }
 
     return true;
 }
 
 /**
  * Deletes the user account.
  *
  * @param username User to be deleted.
  *
  * @return <code>true</code> if the user was successfully deleted, otherwise <code>false</code>.
  *
  */
 bool UserDialog::delUser(const char *username)
 {
     if((accounts->findUser(username)))
     {    // Does that user exist?
         if(!(accounts->delUser(username)))
         {    // Delete the user.
             QMessageBox::information(0,"Ooops!","Something went wrong\nUnable to delete user: "+QString(username)+".");
         }
     }
     else
     {
         QMessageBox::information(0,"Invalid Username","That username ("+QString(username)+")does not exist.");
         return false;
     }
     return true;
 }
 
 /**
  * This displays a confirmation dialog wether a user should be deleted or not.
  *  (And also deletes the account)
  *
  * @param username User to be deleted.
  *
  * @return <code>true</code> if the user was successfully deleted, otherwise <code>false</code>.
  *
  */
 bool UserDialog::editUser(const char *username)
 {
     int invalid_group=0;
     // viewmode is a workaround for a bug in qte-2.3.4 that gives bus error on manipulating edituserDialog's widgets here.
     UserDialog *edituserDialog=new UserDialog(VIEWMODE_EDIT);    // Create Dialog
     edituserDialog->setCaption(tr("Edit User"));
     accounts->findUser(username);    // Locate user in database and fill variables in 'accounts' object.
     if(!(accounts->findGroup(accounts->pw_gid)))
     {    // Locate the user's primary group, and fill group variables in 'accounts' object.
         invalid_group=1;
     }
     // Fill widgets with userinfo.
     edituserDialog->loginLineEdit->setText(accounts->pw_name);